[Lldb-commits] [lldb] e0219f2 - [lldb] Overwrite existing LLVM_ENABLE_EXPORTED_SYMBOLS_IN_EXECUTABLES

2024-04-09 Thread Cyndy Ishida via lldb-commits
Author: Cyndy Ishida Date: 2024-04-09T19:35:55-07:00 New Revision: e0219f2d53686135b7363450b44877342a960e71 URL: https://github.com/llvm/llvm-project/commit/e0219f2d53686135b7363450b44877342a960e71 DIFF: https://github.com/llvm/llvm-project/commit/e0219f2d53686135b7363450b44877342a960e71.diff

[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

2024-04-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > No particular reason apart from it being scoped, which I thought we might > prefer for new enums. But there's no reason it couldn't be an old-school enum If that's the case I think consistency is more important. Mind putting up a PR?

[Lldb-commits] [lldb] Fix error in unrecognized register name handling for "SBFrame.register" (PR #88047)

2024-04-09 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Looks good. https://github.com/llvm/llvm-project/pull/88047 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangUserExpression][NFCI] Pass the most specific ExecutionContextScope possible into ClangExpressionParser (PR #87657)

2024-04-09 Thread Michael Buch via lldb-commits
@@ -669,15 +670,8 @@ bool ClangUserExpression::Parse(DiagnosticManager _manager, // Parse the expression // - Process *process = exe_ctx.GetProcessPtr(); - ExecutionContextScope *exe_scope = process; - - if (!exe_scope) -exe_scope = exe_ctx.GetTargetPtr(); - -

[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

2024-04-09 Thread Michael Buch via lldb-commits
Michael137 wrote: > @Michael137 I'm a little late to the party but I just noticed that > `ChildCacheState` is the only `enum class` in `lldb-enumerations.h`. Is that > intentional? Is there a reason this cannot be a old-school enum like > everything else in that file? I don't feel super

[Lldb-commits] [lldb] [lldb][libc++] Adds local_t clock data formatters. (PR #88178)

2024-04-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Mark de Wever (mordante) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/88178.diff 5 Files Affected: - (modified) lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp (+23) - (modified)

[Lldb-commits] [lldb] [lldb][libc++] Adds local_t clock data formatters. (PR #88178)

2024-04-09 Thread Mark de Wever via lldb-commits
https://github.com/mordante created https://github.com/llvm/llvm-project/pull/88178 None >From 656ee030e38be24732dd78f96204ce12fe40e788 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Tue, 19 Mar 2024 20:31:41 +0100 Subject: [PATCH] [lldb][libc++] Adds local_t clock data formatters. ---

[Lldb-commits] [lldb] Fix error in unrecognized register name handling for "SBFrame.register" (PR #88047)

2024-04-09 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/88047 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix dead lock in TypeCategoryMap.cpp (PR #87540)

2024-04-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/87540 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix dead lock in TypeCategoryMap.cpp (PR #87540)

2024-04-09 Thread Vincent Belliard via lldb-commits
@@ -25,19 +25,25 @@ TypeCategoryMap::TypeCategoryMap(IFormatChangeListener *lst) } void TypeCategoryMap::Add(KeyType name, const TypeCategoryImplSP ) { - std::lock_guard guard(m_map_mutex); - m_map[name] = entry; + { +std::lock_guard guard(m_map_mutex); +

[Lldb-commits] [lldb] [lldb] fix dead lock in TypeCategoryMap.cpp (PR #87540)

2024-04-09 Thread Vincent Belliard via lldb-commits
https://github.com/v-bulle updated https://github.com/llvm/llvm-project/pull/87540 >From 5234f6873d894dd80b2c1fef40fd18e4b722a2c9 Mon Sep 17 00:00:00 2001 From: Vincent Belliard Date: Wed, 3 Apr 2024 11:31:06 -0700 Subject: [PATCH 1/3] [lldb] fix dead lock in TypeCategoryMap.cpp