https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/147990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/147990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/functionalities/disassembler-variables/TestRichDisassembler.py
@@ -81,6 +81,39 @@ class StructuredDataImpl {
void SetObjectSP(const StructuredData::ObjectSP &obj) { m_data_sp = obj; }
+ void SetValueForKey(const char *key,
+ const StructuredData::ObjectSP &value) const {
+if (m_data_sp) {
+ auto dict = m_
@@ -428,50 +653,60 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::shrink_to_fi
}
}
-template
+template class
_Layout>
template
-_LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::emplace_front(_Args&&... __args) {
- if (__begi
@@ -78,23 +336,18 @@ public:
__split_buffer,
void>;
- pointer __first_;
- pointer __begin_;
- pointer __end_;
- _LIBCPP_COMPRESSED_PAIR(pointer, __cap_, allocator_type, __alloc_);
-
__split_buffer(const __split_buffer&)
@@ -428,50 +653,60 @@ _LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::shrink_to_fi
}
}
-template
+template class
_Layout>
template
-_LIBCPP_CONSTEXPR_SINCE_CXX20 void __split_buffer<_Tp,
_Allocator>::emplace_front(_Args&&... __args) {
- if (__begi
@@ -45,13 +47,129 @@ _LIBCPP_PUSH_MACROS
_LIBCPP_BEGIN_NAMESPACE_STD
-// __split_buffer allocates a contiguous chunk of memory and stores objects in
the range [__begin_, __end_).
-// It has uninitialized memory in the ranges [__first_, __begin_) and
[__end_, __cap_). That
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/154433
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-08-19T16:00:31-07:00
New Revision: 7cd61793edbb4e6dbc0fb92e5d6d85cabfa62b40
URL:
https://github.com/llvm/llvm-project/commit/7cd61793edbb4e6dbc0fb92e5d6d85cabfa62b40
DIFF:
https://github.com/llvm/llvm-project/commit/7cd61793edbb4e6dbc0fb92e5d6d85cabfa62b40.d
https://github.com/adrian-prantl approved this pull request.
nice!
https://github.com/llvm/llvm-project/pull/154433
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cmtice wrote:
Thank you for confirming this fixed the previous test failure
(TestDataFormatterObjCNSContainer.py)
https://github.com/llvm/llvm-project/pull/154269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
slydiman wrote:
Please fix the issue or revert ASAP to make buildbots green.
https://github.com/llvm/llvm-project/pull/149493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
eronnen wrote:
> I haven't looked at the code yet, but based on the video, I'm assuming this
> happens "on demand", right? A user has to interact with the module view to
> request the symbols?
Yes, the user has to click on "Show Module Symbols" from the context menu of
the module tree or thro
@@ -594,6 +594,20 @@ class CancelRequestHandler : public
RequestHandler> {
+public:
+ using RequestHandler::RequestHandler;
+ static llvm::StringLiteral GetCommand() { return "moduleSymbols"; }
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/1
kuilpd wrote:
@labath
I have the next PR standing by, is this one ready for merging?
https://github.com/llvm/llvm-project/pull/152308
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/154202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-08-19T10:49:23-07:00
New Revision: 4cecbeed4f4558df9cd221afaaa38e2281d133a2
URL:
https://github.com/llvm/llvm-project/commit/4cecbeed4f4558df9cd221afaaa38e2281d133a2
DIFF:
https://github.com/llvm/llvm-project/commit/4cecbeed4f4558df9cd221afaaa38e2281d133a2.d
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/154366
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
charles-zablit wrote:
The `lldb-api` tests on the Swift Windows CI fail when the Python we use to
build is not the same as the one installed on the system, as can be seen on
[this
run](https://ci-external.swift.org/job/swift-PR-windows/44473/consoleText).
https://github.com/llvm/llvm-project/
JDevlieghere wrote:
I haven't looked at the code yet, but based on the video, I'm assuming this
happens "on demand", right? A user has to interact with the module view to
request the symbols?
https://github.com/llvm/llvm-project/pull/153836
___
lldb
ashgti wrote:
> Missing unit test for `CompletionItem`
Done, added unit tests to cover the new JSON types.
https://github.com/llvm/llvm-project/pull/153317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/153317
>From 3db3a7184eb7d729c37f7dc02f826c77df8c65e9 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 12 Aug 2025 16:23:18 -0700
Subject: [PATCH 1/4] [lldb-dap] Migrating 'completions' to structured types.
This
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
Just to double check, can you run `npm package && code --install-extension
out/lldb-dap.vsix` to make sure the css/js files are bundled correctly.
Otherwise, LGTM with the last few comments.
https://github.com/llvm/llvm-project/pull/153836
@@ -39,6 +45,9 @@ export class DebugSessionTracker
private modulesChanged = new vscode.EventEmitter<
vscode.DebugSession | undefined
>();
+ private sessionGotCapabilities =
ashgti wrote:
Sounds good to me
https://github.com/llvm/llvm-project/pull/153
anutosh491 wrote:
Thanks @rastogishubham . I've reapplied the patch !
https://github.com/llvm/llvm-project/pull/154339
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -146,6 +164,10 @@ export class DebugSessionTracker
this.logger.info(
`Session "${session.name}" exited with code ${exitCode}`,
);
+
+ this.sessionExited.fire(session);
+} else if (isEvent(message, "capabilities")) {
+ this.sessionGotCapabili
@@ -594,6 +594,20 @@ class CancelRequestHandler : public
RequestHandler> {
+public:
+ using RequestHandler::RequestHandler;
+ static llvm::StringLiteral GetCommand() { return "moduleSymbols"; }
ashgti wrote:
+1
https://github.com/llvm/llvm-project/pull/153836
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/153121
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: John Harrison
Date: 2025-08-19T08:46:25-07:00
New Revision: 538bd83b37149fa928fff838d452fa68e5854e1c
URL:
https://github.com/llvm/llvm-project/commit/538bd83b37149fa928fff838d452fa68e5854e1c
DIFF:
https://github.com/llvm/llvm-project/commit/538bd83b37149fa928fff838d452fa68e5854e1c.diff
https://github.com/anutosh491 updated
https://github.com/llvm/llvm-project/pull/154339
>From 009f13dae8f41a28beb59f2c75692a962886d708 Mon Sep 17 00:00:00 2001
From: anutosh491
Date: Tue, 19 Aug 2025 19:25:33 +0530
Subject: [PATCH 1/2] Fix failing test in TestClangREPL
---
lldb/test/API/repl/c
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazu Hirata (kazutakahirata)
Changes
This patch replaces SmallSet with SmallPtrSet. Note
that SmallSet.h "redirects" SmallSet to SmallPtrSet for pointer
element types:
template
class S
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/154366
This patch replaces SmallSet with SmallPtrSet. Note
that SmallSet.h "redirects" SmallSet to SmallPtrSet for pointer
element types:
template
class SmallSet : public SmallPtrSet {};
We only have 10 i
https://github.com/anutosh491 updated
https://github.com/llvm/llvm-project/pull/154339
>From 009f13dae8f41a28beb59f2c75692a962886d708 Mon Sep 17 00:00:00 2001
From: anutosh491
Date: Tue, 19 Aug 2025 19:25:33 +0530
Subject: [PATCH] Fix failing test in TestClangREPL
---
lldb/test/API/repl/clang
rastogishubham wrote:
Hi @anutosh491 just referencing my comment
https://github.com/llvm/llvm-project/pull/153560#issuecomment-3201252830
Greendragon must always be green, to make sure we catch any issues that break
the tests, I reverted the change in
https://github.com/llvm/llvm-project/pull
anutosh491 wrote:
Hey @rastogishubham ,
I have provided a PR fixing the test in the comment above !
https://github.com/llvm/llvm-project/pull/153560
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
rastogishubham wrote:
Hi, this change broke greendragon
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/31613/changes#00ffd8b8aa4e8cd3a2fee654d55995918886e874
TEST 'lldb-api :: repl/clang/TestClangREPL.py' FAILED
/Users/ec2-user/jen
Author: Shubham Sandeep Rastogi
Date: 2025-08-19T08:34:29-07:00
New Revision: 5abad32538d4aa6fa9a418d9dfe74d2fd275efd7
URL:
https://github.com/llvm/llvm-project/commit/5abad32538d4aa6fa9a418d9dfe74d2fd275efd7
DIFF:
https://github.com/llvm/llvm-project/commit/5abad32538d4aa6fa9a418d9dfe74d2fd275
@@ -594,6 +594,20 @@ class CancelRequestHandler : public
RequestHandler> {
+public:
+ using RequestHandler::RequestHandler;
+ static llvm::StringLiteral GetCommand() { return "moduleSymbols"; }
walter-erquinigo wrote:
Good suggestion. I've been trying to use t
walter-erquinigo wrote:
This lgtm, please get a final approval from @ashgti
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cmtice wrote:
> > Hopefully
>
> Does that mean you didn't check if it fixes it? I think we should understand
> how the test passed without this PR before including that.
I do not have the right machines, etc. to test it. I have asked some friends at
Apple to test it for me, but have not heard
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -324,6 +324,8 @@ class LLDB_API SBTarget {
lldb::SBModule FindModule(const lldb::SBFileSpec &file_spec);
+ lldb::SBModule FindModule(const lldb::SBModuleSpec &module_spec);
walter-erquinigo wrote:
I think I didn't explain myself clearly. I just wanted
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/153984
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2025-08-19T08:29:25-07:00
New Revision: 6e3c7b8244e9067721ccd0d786755f2ae9c96a87
URL:
https://github.com/llvm/llvm-project/commit/6e3c7b8244e9067721ccd0d786755f2ae9c96a87
DIFF:
https://github.com/llvm/llvm-project/commit/6e3c7b8244e9067721ccd0d786755f2ae9c96a87.diff
LOG:
https://github.com/labath approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/153121
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
The following buildbots are broken after this patch
[lldb-x86_64-win](https://lab.llvm.org/buildbot/#/builders/211/builds/1439)
[lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197/builds/8177)
Please take a look and fix.
https://github.com/llvm/llvm-project/pull
labath wrote:
> Hopefully
Does that mean you didn't check if it fixes it? I think we should understand
how the test passed without this PR before including that.
https://github.com/llvm/llvm-project/pull/154269
___
lldb-commits mailing list
lldb-comm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Anutosh Bhat (anutosh491)
Changes
Addressing
https://github.com/llvm/llvm-project/pull/153560?notification_referrer_id=NT_kwDOBTBQx7QxODIyMDYwOTQ1ODo4NzA1MjQ4Nw#issuecomment-3199157830
The test runs as expected now
```
anutosh491@Anutoshs
https://github.com/anutosh491 created
https://github.com/llvm/llvm-project/pull/154339
Addressing
https://github.com/llvm/llvm-project/pull/153560?notification_referrer_id=NT_kwDOBTBQx7QxODIyMDYwOTQ1ODo4NzA1MjQ4Nw#issuecomment-3199157830
The test runs as expected now
```
anutosh491@Anutoshs-M
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/149493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Charles Zablit
Date: 2025-08-19T14:52:29+01:00
New Revision: f55dc0824ebcf546b1d34a5102021c15101e4d3b
URL:
https://github.com/llvm/llvm-project/commit/f55dc0824ebcf546b1d34a5102021c15101e4d3b
DIFF:
https://github.com/llvm/llvm-project/commit/f55dc0824ebcf546b1d34a5102021c15101e4d3b.diff
anutosh491 wrote:
Hi,
I have been trying to figure the above error out. I'm on macos and I was trying
to build and run the tests locally.
So I build lldb like this
```
cmake -G Ninja \
-S llvm-project/llvm \
-B ~/build/lldb \
-C "$(pwd)/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cm
tgs-sc wrote:
@Michael137, is it OK?
https://github.com/llvm/llvm-project/pull/154123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -248,6 +248,8 @@ enum class IterationAction {
Stop,
};
+enum class TracePCType { Returns, ReturnsNoZerothFrame, Calls };
Michael137 wrote:
Can we add some doxygen comments here to explain each of these cases?
https://github.com/llvm/llvm-project/pull/15
@@ -176,10 +170,23 @@ HistoryThreads
MemoryHistoryASan::GetHistoryThreads(lldb::addr_t address) {
options.SetAutoApplyFixIts(false);
options.SetLanguage(eLanguageTypeObjC_plus_plus);
- if (auto m = GetPreferredAsanModule(process_sp->GetTarget())) {
-SymbolContextList
@@ -594,6 +594,20 @@ class CancelRequestHandler : public
RequestHandler> {
+public:
+ using RequestHandler::RequestHandler;
+ static llvm::StringLiteral GetCommand() { return "moduleSymbols"; }
da-viper wrote:
I think we could put the command behind some kind
@@ -0,0 +1,37 @@
+"""
+Test lldb-dap moduleSymbols request
+"""
+
+import lldbdap_testcase
+
+
+class TestDAP_moduleSymbols(lldbdap_testcase.DAPTestCaseBase):
+def test_moduleSymbols(self):
+"""
+Test that the stack frame without a module still has assembly sou
@@ -146,6 +164,10 @@ export class DebugSessionTracker
this.logger.info(
`Session "${session.name}" exited with code ${exitCode}`,
);
+
+ this.sessionExited.fire(session);
+} else if (isEvent(message, "capabilities")) {
+ this.sessionGotCapabili
@@ -39,6 +45,9 @@ export class DebugSessionTracker
private modulesChanged = new vscode.EventEmitter<
vscode.DebugSession | undefined
>();
+ private sessionGotCapabilities =
eronnen wrote:
changed to `sessionReceivedCapabilities` is it ok?
And I don't
@@ -0,0 +1,89 @@
+//===-- ModuleSymbolsRequestHandler.cpp -===//
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.
@@ -46,6 +46,10 @@ ConfigurationDoneRequestHandler::Run(const
ConfigurationDoneArguments &) const {
// may have different capabilities than the final target.
SendTargetBasedCapabilities(dap);
+ /// Send custom capabilities to the client.
+ /// This is consumed by the ll
@@ -85,6 +85,12 @@ class LLDB_API SBSymbol {
SymbolType GetType();
+ /// Get the ID of this symbol, usually the original symbol table index. .
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/153836
nikic wrote:
Ping
https://github.com/llvm/llvm-project/pull/152481
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
65 matches
Mail list logo
