[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Sam Elliott via lldb-commits
lenary wrote: How does this work now that LLDB doesn't stop on the first unknown instruction? I thought it now printed `` for that and kept going, but maybe that's not right? https://github.com/llvm/llvm-project/pull/164413 ___ lldb-commits mailing l

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

2025-10-22 Thread Walter Erquinigo via lldb-commits
@@ -622,6 +623,30 @@ class Target : public std::enable_shared_from_this, /// requirements. llvm::Error SetLabel(llvm::StringRef label); + /// Get the target session name for this target. + /// + /// Provides a meaningful name for IDEs or tools to display for dynamic

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

2025-10-22 Thread Walter Erquinigo via lldb-commits
@@ -1289,13 +1293,108 @@ protocol::Capabilities DAP::GetCustomCapabilities() { } void DAP::StartEventThread() { - event_thread = std::thread(&DAP::EventThread, this); + // Get event thread for this debugger (creates it if it doesn't exist). + event_thread_sp = DAPSessionMan

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

2025-10-22 Thread Walter Erquinigo via lldb-commits
@@ -295,4 +307,267 @@ void SendMemoryEvent(DAP &dap, lldb::SBValue variable) { dap.Send(protocol::Event{"memory", std::move(body)}); } +// Note: EventThread() is architecturally different from the other functions in walter-erquinigo wrote: thanks for this c

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

2025-10-22 Thread Walter Erquinigo via lldb-commits
@@ -0,0 +1,142 @@ +//===-- DAPSessionManager.cpp --*- C++ -*-===// walter-erquinigo wrote: new files should use a simple ``` //===--===// ``` no need to repeat t

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

2025-10-22 Thread Janet Yang via lldb-commits
@@ -1289,13 +1293,92 @@ protocol::Capabilities DAP::GetCustomCapabilities() { } void DAP::StartEventThread() { - event_thread = std::thread(&DAP::EventThread, this); + // Get event thread for this debugger (creates it if it doesn't exist). + event_thread_sp = DAPSessionMana

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add multi-session support with shared debugger instances (PR #163653)

2025-10-22 Thread Janet Yang via lldb-commits
@@ -1390,104 +1481,151 @@ void DAP::EventThread() { // Only report a stopped event if the process was not // automatically restarted. if (!lldb::SBProcess::GetRestartedFromEvent(event)) { - SendStdOutStdErr(*this, process); -

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

2025-10-22 Thread Piyush Jaiswal via lldb-commits
https://github.com/piyushjaiswal98 updated https://github.com/llvm/llvm-project/pull/164739 >From e04bbb2579b91a08a99fd208739a17313de969ab Mon Sep 17 00:00:00 2001 From: Piyush Jaiswal Date: Wed, 22 Oct 2025 17:37:29 -0700 Subject: [PATCH] Refactor Breakpoint event notification --- lldb/inclu

[Lldb-commits] [lldb] Refactor LLDB Breakpoint Event Notifications to centralize and eliminate code duplication (PR #164739)

2025-10-22 Thread Piyush Jaiswal via lldb-commits
https://github.com/piyushjaiswal98 created https://github.com/llvm/llvm-project/pull/164739 ### Summary This PR refactors breakpoint event notification in LLDB to centralize and eliminate code duplication. It creates a unified method in the `Target` class for sending breakpoint change events.

[Lldb-commits] [lldb] Enable LLDB to load large dSYM files. (PR #164471)

2025-10-22 Thread Jason Molenda via lldb-commits
@@ -1697,6 +1701,14 @@ void ObjectFileMachO::ProcessSegmentCommand( // isn't stored in the abstracted Sections. m_mach_sections.push_back(sect64); +// Make sure we can load dSYM files whose __DWARF sections exceed the 4GB +// barrier. llvm::MachO::section_64 ha

[Lldb-commits] [lldb] [llvm] [lldb][DeclVendor] Remove ClangDeclVendor (PR #164380)

2025-10-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64le-linux-multistage` running on `ppc64le-clang-multistage-test` while building `lldb,llvm` at step 11 "ninja check 2". Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/13267 Here

[Lldb-commits] [lldb] update lldb-server platform help parsing (PR #162730)

2025-10-22 Thread Chad Smith via lldb-commits
cs01 wrote: > You could use the CI here to check it. Try enabling the platform mode tests > and see what happens. I removed the `# UNSUPPORTED: system-windows` line at the top and pushed. Is that all I have to do, or do I have to somehow enable platform mode tests manually? And aren't there m

[Lldb-commits] [lldb] [lldb][test] When an external stdlib is specified do not link to the system stdlib (PR #164462)

2025-10-22 Thread Michael Buch via lldb-commits
@@ -386,6 +386,11 @@ ifeq (,$(filter 1, $(USE_LIBSTDCPP) $(USE_LIBCPP) $(USE_SYSTEM_STDLIB))) ifneq "$(LIBCPP_INCLUDE_TARGET_DIR)" "" CXXFLAGS += -cxx-isystem $(LIBCPP_INCLUDE_TARGET_DIR) endif + + # If `-nostdlib++` is not passed, clang will link to the sy

[Lldb-commits] [lldb] update lldb-server platform help parsing (PR #162730)

2025-10-22 Thread Chad Smith via lldb-commits
@@ -0,0 +1,41 @@ +# UNSUPPORTED: system-windows + +RUN: %platformserver --help 2>&1 | FileCheck %s +RUN: %platformserver -h 2>&1 | FileCheck %s +RUN: %lldb-server p --help 2>&1 | FileCheck %s +RUN: %lldb-server p -h 2>&1 | FileCheck %s +RUN: %lldb-server platform --help 2>&1 | Fil

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Don't silently inherit the VFS from `FileManager` (PR #164323)

2025-10-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross` running on `suse-gary-m68k-cross` while building `clang-tools-extra,clang,lldb` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/17897 Here

[Lldb-commits] [lldb] 866879f - [clang] Don't silently inherit the VFS from `FileManager` (#164323)

2025-10-22 Thread via lldb-commits
Author: Jan Svoboda Date: 2025-10-22T10:15:12-07:00 New Revision: 866879f80342b857a8b911c804189c43ac4fc334 URL: https://github.com/llvm/llvm-project/commit/866879f80342b857a8b911c804189c43ac4fc334 DIFF: https://github.com/llvm/llvm-project/commit/866879f80342b857a8b911c804189c43ac4fc334.diff L

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Don't silently inherit the VFS from `FileManager` (PR #164323)

2025-10-22 Thread Jan Svoboda via lldb-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/164323 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix mutex acquisition order for modules event. (PR #163821)

2025-10-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/163821 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f67880a - [lldb-dap] Fix mutex acquisition order for modules event. (#163821)

2025-10-22 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-10-22T17:37:59+01:00 New Revision: f67880ae3d23981c733383126267dd8e841d1ea9 URL: https://github.com/llvm/llvm-project/commit/f67880ae3d23981c733383126267dd8e841d1ea9 DIFF: https://github.com/llvm/llvm-project/commit/f67880ae3d23981c733383126267dd8e841d1ea9.diff L

[Lldb-commits] [lldb] [lldb] Introduce internal stop hooks (PR #164506)

2025-10-22 Thread via lldb-commits
jimingham wrote: That is the reason for introducing this concept. Note that stop hooks are orthogonal to breakpoints, in that breakpoints allow you to react to the program running certain code, whereas stop hooks allow you to react to stop reasons in a pluggable manner. So this allows a plug

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Don't silently inherit the VFS from `FileManager` (PR #164323)

2025-10-22 Thread Jan Svoboda via lldb-commits
jansvoboda11 wrote: Good catch! There is [one place](https://github.com/llvm/llvm-project/blob/main/clang/tools/driver/cc1_main.cpp#L316-L325) in particular that made me not reset the VFS. I could call `setVirtualFileSystem()` there again, but I really wanted to have just one place where we c

[Lldb-commits] [lldb] [lldb] Implement Process::ReadMemoryRanges (PR #163651)

2025-10-22 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > The unit tests are failing on Arm 32-bit, I'll figure it out. thank you! https://github.com/llvm/llvm-project/pull/163651 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [openmp] [polly] Python-related cleanups (PR #163566)

2025-10-22 Thread Louis Dionne via lldb-commits
ldionne wrote: > Do you mean one PR with a commit per subproject, or a PR per subproject? One PR per subproject. These monolithic patches tend not to make progress. If you make a PR just for libc++, for example, we'll be able to quickly take a look and merge it. https://github.com/llvm/llvm-p

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Don't silently inherit the VFS from `FileManager` (PR #164323)

2025-10-22 Thread Qiongsi Wu via lldb-commits
https://github.com/qiongsiwu approved this pull request. Thanks! LGTM. There are two places where we reset file manager but do not reset the VFS. Could you help me confirm that these are OK? I think they are because these are already in frontend actions and I assume we intend to preserve the

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for exceptioninfo (PR #164318)

2025-10-22 Thread Michael Buch via lldb-commits
Michael137 wrote: > It has been reverted, It seems to be something specific to how > `GetDescription` works on arm, will test it in a container. Note, the failure is on our x86_64 bot: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/16126/execution/node/111/log/ https://githu

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for exceptioninfo (PR #164318)

2025-10-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: Does feel like an alignment assumption, which is weird for what looks like a high level change. It passed on AArch64 Linux https://lab.llvm.org/buildbot/#/builders/59/builds/26153. ``` UNSUPPORTED: lldb-api :: tools/lldb-dap/exception/objc/TestDAP_exception_objc.py (1218

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for exceptioninfo (PR #164318)

2025-10-22 Thread Ebuka Ezike via lldb-commits
da-viper wrote: It has been reverted, It seems to be something specific to how `GetDescription` works on arm, will test it in a container. https://github.com/llvm/llvm-project/pull/164318 ___ lldb-commits mailing list [email protected] http

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Timur Golubovich via lldb-commits
@@ -157,7 +157,9 @@ static lldb::offset_t DumpInstructions(const DataExtractor &DE, Stream *s, exe_scope->CalculateExecutionContext(exe_ctx); disassembler_sp->GetInstructionList().Dump( s, show_address, show_bytes, show_control_flow_kind, &exe_ctx);

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for exceptioninfo (PR #164318)

2025-10-22 Thread Michael Buch via lldb-commits
Michael137 wrote: Also failing on x86_64 macOS: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/16126/execution/node/111/log/ ``` 12:58:04 Failed Tests (3): 12:58:04lldb-api :: tools/lldb-dap/exception/TestDAP_exception.py 12:58:04lldb-api :: tools/lldb-dap/exception/cp

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Timur Golubovich via lldb-commits
@@ -5,5 +5,8 @@ int main(int argc, const char *argv[]) { double my_double = 1234.5678; int my_ints[] = {2, 4, 6, 8, 10, 12, 14, 16, 18, 20, 22}; uint64_t my_uint64s[] = {0, 1, 2, 3, 4, 5, 6, 7}; + // assume that 0x is invalid instruction in RISC-V and AArch64 +

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Timur Golubovich via lldb-commits
@@ -41,6 +41,20 @@ def test_memory_read_c_string(self): " Consider increasing the maximum read length.", ) +@skipIf(archs=no_match("^(riscv|aarch64).*")) +def test_riscv_decode_failure(self): +"""Test the 'memory read' command with instructi

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Timur Golubovich via lldb-commits
@@ -41,6 +41,20 @@ def test_memory_read_c_string(self): " Consider increasing the maximum read length.", ) +@skipIf(archs=no_match("^(riscv|aarch64).*")) +def test_riscv_decode_failure(self): tgs-sc wrote: Addressed https://github

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Timur Golubovich via lldb-commits
@@ -41,6 +41,20 @@ def test_memory_read_c_string(self): " Consider increasing the maximum read length.", ) +@skipIf(archs=no_match("^(riscv|aarch64).*")) +def test_riscv_decode_failure(self): +"""Test the 'memory read' command with instructi

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for exceptioninfo (PR #164318)

2025-10-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: The important part of the Arm 32-bit failure: ``` = END = FAIL: LLDB (/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_stopped_description (TestDAP_exception.TestDAP_exception) ===

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Timur Golubovich via lldb-commits
https://github.com/tgs-sc updated https://github.com/llvm/llvm-project/pull/164413 >From e923a77a146296c441e86a8f9ca87f372058b48a Mon Sep 17 00:00:00 2001 From: Timur Golubovich Date: Fri, 17 Oct 2025 12:12:29 + Subject: [PATCH] [lldb] Added a warning in case of instruction decode failure

[Lldb-commits] [lldb] Revert "[lldb-dap] Use protocol types for exceptioninfo" (PR #164631)

2025-10-22 Thread Walter Lee via lldb-commits
https://github.com/googlewalt auto_merge_enabled https://github.com/llvm/llvm-project/pull/164631 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb-dap] Use protocol types for exceptioninfo" (PR #164631)

2025-10-22 Thread via lldb-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Developer Policy](https://llvm.org/docs/DeveloperPol

[Lldb-commits] [lldb] Revert "[lldb-dap] Use protocol types for exceptioninfo" (PR #164631)

2025-10-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Lee (googlewalt) Changes Reverts llvm/llvm-project#164318 2 failures from LLVM Buildbot. --- Patch is 20.33 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/164631.diff 11 Files Affected

[Lldb-commits] [lldb] Revert "[lldb-dap] Use protocol types for exceptioninfo" (PR #164631)

2025-10-22 Thread Benjamin Kramer via lldb-commits
https://github.com/d0k approved this pull request. https://github.com/llvm/llvm-project/pull/164631 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] When an external stdlib is specified do not link to the system stdlib (PR #164462)

2025-10-22 Thread Michael Buch via lldb-commits
@@ -386,6 +386,11 @@ ifeq (,$(filter 1, $(USE_LIBSTDCPP) $(USE_LIBCPP) $(USE_SYSTEM_STDLIB))) ifneq "$(LIBCPP_INCLUDE_TARGET_DIR)" "" CXXFLAGS += -cxx-isystem $(LIBCPP_INCLUDE_TARGET_DIR) endif + + # If `-nostdlib++` is not passed, clang will link to the sy

[Lldb-commits] [lldb] Revert "[lldb-dap] Use protocol types for exceptioninfo" (PR #164631)

2025-10-22 Thread Walter Lee via lldb-commits
https://github.com/googlewalt created https://github.com/llvm/llvm-project/pull/164631 Reverts llvm/llvm-project#164318 2 failures from LLVM Buildbot. >From 35f38d717d99ecdc2368dc5d495e822fcf124c73 Mon Sep 17 00:00:00 2001 From: Walter Lee <[email protected]> Date: W

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Timur Golubovich via lldb-commits
@@ -0,0 +1,32 @@ +""" +Test the 'memory read' command when decoding instruction failures. +""" tgs-sc wrote: I checked on riscv, it works (still fails). Enabled this test also for AArch64. https://github.com/llvm/llvm-project/pull/164413

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Timur Golubovich via lldb-commits
https://github.com/tgs-sc updated https://github.com/llvm/llvm-project/pull/164413 >From aab9c5f56e15b65fc2a9c6b27d4dde75b6fe0a5a Mon Sep 17 00:00:00 2001 From: Timur Golubovich Date: Fri, 17 Oct 2025 12:12:29 + Subject: [PATCH] [lldb] Added a warning in case of instruction decode failure

[Lldb-commits] [lldb] [lldb] Implement ProcessGDBRemote support for ReadMemoryRanges (PR #164311)

2025-10-22 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/164311 Unicorn! · GitHub body { background-color: #f1f1f1; margin: 0; font-family: "Helvetica Neue", Helvetica, Arial, sans-serif; } .container { margin:

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread David Spickett via lldb-commits
@@ -0,0 +1,32 @@ +""" +Test the 'memory read' command when decoding instruction failures. +""" DavidSpickett wrote: Got the expected error with: ``` diff --git a/lldb/test/API/riscv/decode-failure/TestDecodeFailure.py b/lldb/test/API/riscv/decode-failure/TestDec

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Timur Golubovich via lldb-commits
https://github.com/tgs-sc updated https://github.com/llvm/llvm-project/pull/164413 >From 8a8e09540d0031969b7582e10d596430ce10ac8d Mon Sep 17 00:00:00 2001 From: Timur Golubovich Date: Fri, 17 Oct 2025 12:12:29 + Subject: [PATCH] [lldb] Added a warning in case of instruction decode failure

[Lldb-commits] [lldb] [docs][lldb] update the Windows tools instructions (PR #164491)

2025-10-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: Looks fine to me, but I defer to Omair to approve if anyone from Linaro is going to. (you don't have to wait for us though) https://github.com/llvm/llvm-project/pull/164491 ___ lldb-commits mailing list [email protected]

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Timur Golubovich via lldb-commits
@@ -0,0 +1,32 @@ +""" +Test the 'memory read' command when decoding instruction failures. +""" tgs-sc wrote: Yes, you are right, currently this warning only triggers if target specific disasm won't change the size of consumed bytes. In RISC-V it happens only if

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for exceptioninfo (PR #164318)

2025-10-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/22154 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/164413 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread David Spickett via lldb-commits
@@ -0,0 +1,32 @@ +""" +Test the 'memory read' command when decoding instruction failures. +""" DavidSpickett wrote: The same encoding is invalid on AArch64 too but I don't get the error you're adding, I get: ``` AssertionError: Ran command: "memory read --format

[Lldb-commits] [lldb] [lldb-dap] Fix mutex acquisition order for modules event. (PR #163821)

2025-10-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/163821 >From fd2f356f24b3876ce4f25cbbe97eadb2aa433a01 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Thu, 16 Oct 2025 17:40:21 +0100 Subject: [PATCH] [lldb-dap] Fix mutex acquisition order for modules event. The mo

[Lldb-commits] [lldb] [lldb][test] When an external stdlib is specified do not link to the system stdlib (PR #164462)

2025-10-22 Thread Ebuka Ezike via lldb-commits
@@ -386,6 +386,11 @@ ifeq (,$(filter 1, $(USE_LIBSTDCPP) $(USE_LIBCPP) $(USE_SYSTEM_STDLIB))) ifneq "$(LIBCPP_INCLUDE_TARGET_DIR)" "" CXXFLAGS += -cxx-isystem $(LIBCPP_INCLUDE_TARGET_DIR) endif + + # If `-nostdlib++` is not passed, clang will link to the sy

[Lldb-commits] [lldb] [lldb] Introduce internal stop hooks (PR #164506)

2025-10-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: I have used stop hooks as a user but never had to deal with their implementation. So my first question here is "but why?". The strongest point here seems to be: > Combining these 3 concepts we can model "internal > stop hooks" which serve the same function as > LLDB's inter

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread David Spickett via lldb-commits
@@ -0,0 +1,32 @@ +""" +Test the 'memory read' command when decoding instruction failures. +""" DavidSpickett wrote: Yeah that's the perfect spot for it. I'll checkout your PR and figure out an encoding for you. https://github.com/llvm/llvm-project/pull/164413 _

[Lldb-commits] [lldb] [lldb] Fix StdUnorderedMapSynthProvider for GCC (PR #164251)

2025-10-22 Thread Sergei Druzhkov via lldb-commits
DrSergei wrote: > > Oh, yeah, GCC doesn't produce DW_TAG_template_type_parameter for unnamed > > template type parameters - yeah, it'd be a valid size optimization for them > > (relying on the uniqueness/identity of the DW_AT_name, I guess, for any > > type equivalence checking) - anything tha

[Lldb-commits] [lldb] b8062f8 - [lldb-dap] Use protocol types for exceptioninfo (#164318)

2025-10-22 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-10-22T12:44:42+01:00 New Revision: b8062f85dd3612f2b5c0c5cfc14bdc5c0eae641f URL: https://github.com/llvm/llvm-project/commit/b8062f85dd3612f2b5c0c5cfc14bdc5c0eae641f DIFF: https://github.com/llvm/llvm-project/commit/b8062f85dd3612f2b5c0c5cfc14bdc5c0eae641f.diff L

[Lldb-commits] [lldb] [lldb] Fix StdUnorderedMapSynthProvider for GCC (PR #164251)

2025-10-22 Thread Michael Buch via lldb-commits
Michael137 wrote: > Oh, yeah, GCC doesn't produce DW_TAG_template_type_parameter for unnamed > template type parameters - yeah, it'd be a valid size optimization for them > (relying on the uniqueness/identity of the DW_AT_name, I guess, for any type > equivalence checking) - anything that can

[Lldb-commits] [lldb] [lldb-dap] Fix mutex acquisition order for modules event. (PR #163821)

2025-10-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/163821 >From b1ae0f72c8ba40c93dec9c421c1da772d295e7a2 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Thu, 16 Oct 2025 17:40:21 +0100 Subject: [PATCH] [lldb-dap] Fix mutex acquisition order for modules event. The mo

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for exceptioninfo (PR #164318)

2025-10-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/164318 >From c879be8e419a03b4a3694afaa17e73907d701aee Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 15 Oct 2025 16:11:57 +0100 Subject: [PATCH 1/5] [lldb-dap] use protocol types for exceptionInfo --- .../Han

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Timur Golubovich via lldb-commits
@@ -0,0 +1,32 @@ +""" +Test the 'memory read' command when decoding instruction failures. +""" tgs-sc wrote: > I suggest moving this test to a more generic place and only running it on > risc-v for the time being. I can add an AArch64 encoding to it. I wil be g

[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

2025-10-22 Thread Timur Golubovich via lldb-commits
@@ -157,7 +157,9 @@ static lldb::offset_t DumpInstructions(const DataExtractor &DE, Stream *s, exe_scope->CalculateExecutionContext(exe_ctx); disassembler_sp->GetInstructionList().Dump( s, show_address, show_bytes, show_control_flow_kind, &exe_ctx);

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for exceptioninfo (PR #164318)

2025-10-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/164318 >From c879be8e419a03b4a3694afaa17e73907d701aee Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 15 Oct 2025 16:11:57 +0100 Subject: [PATCH 1/4] [lldb-dap] use protocol types for exceptionInfo --- .../Han

[Lldb-commits] [lldb] 0d20f3f - [lldb][test] Fix address type in ReadMemoryRanges test

2025-10-22 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-10-22T10:21:36Z New Revision: 0d20f3fa1fee43bc50883fbc988171cc0eb5a8e3 URL: https://github.com/llvm/llvm-project/commit/0d20f3fa1fee43bc50883fbc988171cc0eb5a8e3 DIFF: https://github.com/llvm/llvm-project/commit/0d20f3fa1fee43bc50883fbc988171cc0eb5a8e3.diff LOG

[Lldb-commits] [lldb] [lldb] Deploy Python DLL on Windows (PR #137467)

2025-10-22 Thread via lldb-commits
Nerixyz wrote: Closing this in favor of #151617 - see https://discourse.llvm.org/t/a-minimal-python-install-for-lldb/88658 for more context. This PR was incomplete in that it didn't include a standard library. Since #162509, LLDB will print a proper error that it can't find Python. The curren

[Lldb-commits] [lldb] [lldb] Deploy Python DLL on Windows (PR #137467)

2025-10-22 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/137467 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add a warning if `dirname` is not in the PATH (PR #164494)

2025-10-22 Thread via lldb-commits
https://github.com/Nerixyz approved this pull request. Wrong button, but LGTM https://github.com/llvm/llvm-project/pull/164494 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add a warning if `dirname` is not in the PATH (PR #164494)

2025-10-22 Thread via lldb-commits
https://github.com/Nerixyz commented: LGTM https://github.com/llvm/llvm-project/pull/164494 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [docs][lldb] update the Windows tools instructions (PR #164491)

2025-10-22 Thread via lldb-commits
Nerixyz wrote: Ah, didn't see that, thanks! https://github.com/llvm/llvm-project/pull/164491 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [docs][lldb] update the Windows tools instructions (PR #164491)

2025-10-22 Thread via lldb-commits
@@ -95,37 +95,29 @@ commands below. Windows *** -* Visual Studio 2019. -* The latest Windows SDK. -* The Active Template Library (ATL). -* `GnuWin32 `_ for CoreUtils and Make. -* `Python 3 `_. Ma

[Lldb-commits] [lldb] [lldb][test] Fix TestEmptyFuncThreadStepOut.py (PR #161788)

2025-10-22 Thread David Spickett via lldb-commits
@@ -2,6 +2,7 @@ void done() {} DavidSpickett wrote: Oh yeah true. Adding more code to the body would just make it clearer once you realised what had happened, not help you figure that out. https://github.com/llvm/llvm-project/pull/161788 __