[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82b3e28e836d: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead… (authored by abhina.sreeskantharajan). Repository:

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2670552 , @yroux wrote: > Hi, > > Sorry I'm bit lost in the various patches proposed to fix the issue > introduced by https://reviews.llvm.org/D97785 > My understanding is that this is missing one to

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2666341 , @aganea wrote: > In D99426#2666141 , > @abhina.sreeskantharajan wrote: > >> In D99426#2665361 , @aganea wrote:

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. Is there any more feedback on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https://reviews.llvm.org/D99426 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334941. abhina.sreeskantharajan retitled this revision from "[Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text" to "[SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text".

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2665361 , @aganea wrote: > I am still concerned by the fact that this patch doesn't fix the issue > mentionned in https://reviews.llvm.org/D96363#2650460 > Was the intention to fix that issue? Will the

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334792. abhina.sreeskantharajan added a comment. Update comment in FileSystem.h for OF_TextWithCRLF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https://reviews.llvm.org/D99426

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2664841 , @MaskRay wrote: > /// The file should be opened in text mode on platforms like z/OS that make > /// this distinction. > OF_Text = 1, > F_Text = 1, // For compatibility > > /// The

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. @MaskRay is there still any confusion about the problem this patch is trying to solve and concerns about the renaming? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334220. abhina.sreeskantharajan added a comment. Specified z/OS in FileSystem.h comments, added an assertion in Window's Path.inc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/include/llvm/Support/FileSystem.h:757 + /// OF_TextWithCRLF = OF_Text | OF_CRLF + OF_TextWithCRLF = 3, + amccarth wrote: > Nit: If it

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added inline comments. Comment at: llvm/lib/Support/Windows/Path.inc:1086 - if (Flags & OF_Text) + if (Flags & OF_CRLF) CrtOpenFlags |= _O_TEXT; amccarth wrote: > I assume it would be weird to set `OF_CRLF` without also setting

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334110. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Set OF_Text for llvm/tools/dsymutil/DwarfLinkerForBinary.cpp instead of OF_TextWithCRLF. This was also another file I recently

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2656582 , @MaskRay wrote: > In D99426#2656217 , @rnk wrote: > >> In D99426#2653725 , @MaskRay wrote: >> >>> This touches a

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 333965. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. mention OF_CRLF is Windows-only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 333960. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Rebase + I updated the comments in FileSystem.h to be a bit more descriptive. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2653949 , @MaskRay wrote: > In D99426#2653869 , > @abhina.sreeskantharajan wrote: > >> In D99426#2653725 , @MaskRay

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2653725 , @MaskRay wrote: > This touches a lot of files. I am a bit worried that it would not be easy for > a contributor to know OF_TextWithCRLF is needed to make SystemZ happy. > >> On SystemZ we need

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc83cd8feef7e: [NFC] Reordering parameters in getFile and getFileOrSTDIN (authored by abhina.sreeskantharajan). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/lib/Support/MemoryBuffer.cpp:275 + return getFileAux( + Filename, /*MapSize=*/-1, 0, /*IsText=*/false, + /*RequiresNullTerminator=*/false,

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, wenlei, okura, kuter, cmtice, martong, steven_wu, gbedwell, hiraditya, qcolombet, MatzeB. Herald added a reviewer: bollu. Herald added a reviewer: JDevlieghere. Herald added a reviewer: andreadb. Herald added a

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 333266. abhina.sreeskantharajan added a comment. Rebase and fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99182/new/ https://reviews.llvm.org/D99182 Files:

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/include/llvm/Support/MemoryBuffer.h:78-80 /// if successful, otherwise returning null. If FileSize is specified, this /// means that the client knows

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332720. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. After going through all the function usages, I realized FileSize is not used anywhere. I can remove this parameter. Repository:

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332946. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. I've removed FileSize from getFileAux and WritableMemoryBuffer::getFile as well. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332644. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Herald added a subscriber: JDevlieghere. Move FileSize to the end because it is never used. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, thopre, rupprecht, steven_wu, hiraditya, arichardson, emaste. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. abhina.sreeskantharajan requested review of this revision. Herald added