Re: [Lldb-commits] [PATCH] D15834: Handle hardcoded breakpoints on Windows (e.g., int3 or __debugbreak())

amccarth added a comment. In http://reviews.llvm.org/D15834#318623, @labath wrote: > Linux tests the same functionality in TestBuiltinTrap.py. Would it make sense > to merge these two tests, given that the only difference is which compiler > intrinsic is used to generate the int3 trap? Yes,

[Lldb-commits] [PATCH] D15834: Handle hardcoded breakpoints on Windows (e.g., int3 or __debugbreak())

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. No hurry on the review. This can go in next year. :-) This required a little rejiggering of ProcessWindowsLive::RefreshStateAfterStop in order to treat an unexpected breakpoint opcode

[Lldb-commits] [lldb] r256283 - Allow test decorators to use lists (and not_in(list)) for arches

Author: amccarth Date: Tue Dec 22 15:01:21 2015 New Revision: 256283 URL: http://llvm.org/viewvc/llvm-project?rev=256283=rev Log: Allow test decorators to use lists (and not_in(list)) for arches Differential Revision: https://mail.google.com/mail/u/0/?zx=w4areffgjbgg#inbox/151cb6afe6169bb0

[Lldb-commits] [PATCH] D15723: Allow test decorators to use lists (and not_in(list)) for arches

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. Tweaks check_list_or_lambda to handle a partial match into a list of strings, and updates the decorators to use check_list_or_lambda for architectures. In addition to making things

[Lldb-commits] [lldb] r256251 - Improve error handling for `frame select` command when there are too many arguments.

Author: amccarth Date: Tue Dec 22 10:50:28 2015 New Revision: 256251 URL: http://llvm.org/viewvc/llvm-project?rev=256251=rev Log: Improve error handling for `frame select` command when there are too many arguments. Bug: https://llvm.org/bugs/show_bug.cgi?id=25847 It now gives a more specific

[Lldb-commits] [lldb] r255718 - Propagate socket_error exception from handle_read. Otherwise Ninja crashes.

Author: amccarth Date: Tue Dec 15 17:51:27 2015 New Revision: 255718 URL: http://llvm.org/viewvc/llvm-project?rev=255718=rev Log: Propagate socket_error exception from handle_read. Otherwise Ninja crashes. Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest_channels.py Modified:

Re: [Lldb-commits] [PATCH] D15435: Add tests to inspect a stack and local variables from a mini dump

amccarth updated this revision to Diff 42575. amccarth added a comment. Moved loading of fizzbuzz mini dump to only the tests that needed it. Moved @skipUnlessWindows to the individual tests. (I'm not sure how that worked before.) Improved some comments. http://reviews.llvm.org/D15435

[Lldb-commits] [lldb] r255379 - Add some tests for stack and local variable inspection for mini dumps.

Author: amccarth Date: Fri Dec 11 16:27:57 2015 New Revision: 255379 URL: http://llvm.org/viewvc/llvm-project?rev=255379=rev Log: Add some tests for stack and local variable inspection for mini dumps. Differential Revision: http://reviews.llvm.org/D15435 Added:

Re: [Lldb-commits] [PATCH] D15435: Add tests to inspect a stack and local variables from a mini dump

This revision was automatically updated to reflect the committed changes. Closed by commit rL255379: Add some tests for stack and local variable inspection for mini dumps. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D15435?vs=42575=42585#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D15435: Add tests to inspect a stack and local variables from a mini dump

amccarth added a comment. It's a fair question, but I wonder if it's a bit premature. The tests are still pretty speedy. This way it's easy to change (update/improve) the test and the code in parallel and get immediate results. (There is a checked-in mini dump in this same directory, but that

[Lldb-commits] [PATCH] D15435: Add tests to inspect a stack and local variables from a mini dump

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. More mini dump tests to make sure we can see a stack with several levels and inspect local variables. http://reviews.llvm.org/D15435 Files:

Re: [Lldb-commits] [PATCH] D15359: Fix DoReadMemory for Windows mini dumps.

This revision was automatically updated to reflect the committed changes. Closed by commit rL255083: Fix DoReadMemory for Windows mini dumps. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D15359?vs=42243=42246#toc Repository: rL LLVM

[Lldb-commits] [lldb] r255083 - Fix DoReadMemory for Windows mini dumps.

Author: amccarth Date: Tue Dec 8 18:29:38 2015 New Revision: 255083 URL: http://llvm.org/viewvc/llvm-project?rev=255083=rev Log: Fix DoReadMemory for Windows mini dumps. Differential Revision: http://reviews.llvm.org/D15359 Modified:

Re: [Lldb-commits] [PATCH] D15218: Implement GetMemoryRegionInfo for mini dumps.

amccarth updated this revision to Diff 41884. amccarth added a comment. Address comments. Factored the decoding of the page protection bits to share that logic between the live and mini dump debugging. http://reviews.llvm.org/D15218 Files:

Re: [Lldb-commits] [PATCH] D15218: Implement GetMemoryRegionInfo for mini dumps.

This revision was automatically updated to reflect the committed changes. Closed by commit rL254780: Implement GetMemoryRegionInfo for mini dumps. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D15218?vs=41898=41940#toc Repository: rL LLVM

[Lldb-commits] [lldb] r254780 - Implement GetMemoryRegionInfo for mini dumps.

Author: amccarth Date: Fri Dec 4 16:22:15 2015 New Revision: 254780 URL: http://llvm.org/viewvc/llvm-project?rev=254780=rev Log: Implement GetMemoryRegionInfo for mini dumps. Differential Revision: http://reviews.llvm.org/D15218 Modified:

Re: [Lldb-commits] [PATCH] D15218: Implement GetMemoryRegionInfo for mini dumps.

amccarth updated this revision to Diff 41828. amccarth added a comment. Ran clang-format and removed initialization of a local variable that was no longer used. Note that clang-format re-ordered the include because the change added one include. http://reviews.llvm.org/D15218 Files:

Re: [Lldb-commits] [PATCH] D15092: Fix hang in global static initialization

amccarth added inline comments. Comment at: source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:185 @@ -184,3 +184,3 @@ -static const ConstString FallbackStructName; // Print this as the type name of a struct Element

[Lldb-commits] [PATCH] D15092: Fix hang in global static initialization

amccarth created this revision. amccarth added reviewers: EwanCrawford, zturner. amccarth added a subscriber: lldb-commits. A previous patch introduced a global static ConstString instance. On Windows, this results in a hang because constructing the string pool appears to depend on other

Re: [Lldb-commits] [lldb] r254294 - [RS] Support RenderScript struct allocations

This revision seems to have created a hang on startup on Windows. LLDB now hangs during global static initialization on this line: const ConstString RenderScriptRuntime::Element::FallbackStructName("struct"); Perhaps its an initialization order problem? Adrian. On Mon, Nov 30, 2015 at 2:29

Re: [Lldb-commits] [PATCH] D15092: Fix hang in global static initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rL254338: Fix hang in global static initialization (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D15092?vs=41433=41435#toc Repository: rL LLVM

[Lldb-commits] [lldb] r254338 - Fix hang in global static initialization

Author: amccarth Date: Mon Nov 30 16:18:43 2015 New Revision: 254338 URL: http://llvm.org/viewvc/llvm-project?rev=254338=rev Log: Fix hang in global static initialization Differential Revision: http://reviews.llvm.org/D15092 Modified:

Re: [Lldb-commits] [lldb] r253623 - Make skipIf support the not_in function.

gt; >> This make the test TestVectorTypesFormatting, which is annotated with >> @skipIf(compiler='gcc'), run when using GCC: >> >> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8661/steps/test5/logs/stdio >> >> On Thu, Nov 19, 2015 at 4:

[Lldb-commits] [lldb] r253685 - Revert "FOO"

Author: amccarth Date: Fri Nov 20 12:18:21 2015 New Revision: 253685 URL: http://llvm.org/viewvc/llvm-project?rev=253685=rev Log: Revert "FOO" Accidentally commited before I was done. This reverts commit 2ec2da4ee52780582d5e9c88b2e982a688fbdbe1. Removed:

[Lldb-commits] [lldb] r253683 - Make skipIf support the not_in function (second attempt).

Author: amccarth Date: Fri Nov 20 12:14:24 2015 New Revision: 253683 URL: http://llvm.org/viewvc/llvm-project?rev=253683=rev Log: Make skipIf support the not_in function (second attempt). Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified:

[Lldb-commits] [lldb] r253684 - FOO

Author: amccarth Date: Fri Nov 20 12:15:14 2015 New Revision: 253684 URL: http://llvm.org/viewvc/llvm-project?rev=253684=rev Log: FOO Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_save_core/

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

Greg: Since this adds a new file and I don't have a Mac, can you update the Xcode project? On Fri, Nov 20, 2015 at 3:11 PM, Adrian McCarthy wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL253734: Enable saving of mini

[Lldb-commits] [lldb] r253734 - Enable saving of mini dumps with lldb process save-core.

Author: amccarth Date: Fri Nov 20 17:09:11 2015 New Revision: 253734 URL: http://llvm.org/viewvc/llvm-project?rev=253734=rev Log: Enable saving of mini dumps with lldb process save-core. Also adds SB API to save a core and tests that use it. Differential Revision: http://reviews.llvm.org/D14793

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

This revision was automatically updated to reflect the committed changes. Closed by commit rL253734: Enable saving of mini dumps with lldb process save-core. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D14793?vs=40835=40837#toc Repository: rL LLVM

[Lldb-commits] [lldb] r253623 - Make skipIf support the not_in function.

Author: amccarth Date: Thu Nov 19 18:11:38 2015 New Revision: 253623 URL: http://llvm.org/viewvc/llvm-project?rev=253623=rev Log: Make skipIf support the not_in function. Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified:

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

amccarth marked an inline comment as done. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:159 @@ +158,3 @@ +{ +return SaveMiniDump(process_sp, outfile, error); +} clayborg wrote: > I would rather just have the code from SaveMiniDump inlined

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

amccarth updated this revision to Diff 40716. amccarth marked an inline comment as done. amccarth added a comment. Addresses some of the comments. http://reviews.llvm.org/D14793 Files: include/lldb/API/SBProcess.h include/lldb/API/SBTarget.h

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

amccarth marked 5 inline comments as done. Comment at: include/lldb/API/SBProcess.h:344-346 @@ -343,1 +343,5 @@ +// Save the state of the process in a core file (or mini dump on Windows). +lldb::SBError +SaveCore(const char *file_name); + clayborg

Re: [Lldb-commits] [PATCH] D14591: Implement register context for mini dump debugging

This revision was automatically updated to reflect the committed changes. amccarth marked an inline comment as done. Closed by commit rL252950: Implement RegisterContext for Mini Dumps. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D14591?vs=39978=40082#toc

[Lldb-commits] [lldb] r252950 - Implement RegisterContext for Mini Dumps.

Author: amccarth Date: Thu Nov 12 15:16:15 2015 New Revision: 252950 URL: http://llvm.org/viewvc/llvm-project?rev=252950=rev Log: Implement RegisterContext for Mini Dumps. Differential Revision: http://reviews.llvm.org/D14591 Added: lldb/trunk/source/Plugins/Process/Windows/MiniDump/x64/

Re: [Lldb-commits] [PATCH] D14591: Implement register context for mini dump debugging

amccarth marked 3 inline comments as done. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py:40 @@ +39,3 @@ +thread = self.process.GetThreadAtIndex(0) +# The crash is in main, so there should be one frame on the stack.

[Lldb-commits] [PATCH] D14591: Implement register context for mini dump debugging

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. The old RegisterContextWinMiniDump stub is replaced with x86 and x64 implementations that derive from the common windows register contexts. ProcessWindowsMiniDump grabs the WinAPI

Re: [Lldb-commits] [PATCH] D14136: Refactor Windows process plugin to enable sharing of code between live and post-mortem debugging

amccarth added inline comments. Comment at: source/Plugins/Process/Windows/Common/ProcessWindowsForward.h:20 @@ +19,1 @@ +#endif \ No newline at end of file zturner wrote: > Put a newline here Actually, this file is obsolete, so I'm deleting it instead. It was

[Lldb-commits] [PATCH] D14163: Address another race condition running tests on Windows

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. Another case where sleep-and-retry avoids file access errors on Windows. http://reviews.llvm.org/D14163 Files: packages/Python/lldbsuite/test/lldbtest.py Index:

Re: [Lldb-commits] [PATCH] D14163: Address another race condition running tests on Windows

amccarth added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:1823-1830 @@ -1822,3 +1822,10 @@ -os.rename(src, dst) +try: +os.rename(src, dst) +except: +

Re: [Lldb-commits] [lldb] r251340 - Clang module compilation options need to be per-platform.

FYI: This broke the Windows build (which doesn't have getuid), and the fix wasn't immediately obvious, so I reverted the change. Adrian. On Mon, Oct 26, 2015 at 1:33 PM, Sean Callanan via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: spyffe > Date: Mon Oct 26 15:33:24 2015 > New

[Lldb-commits] [lldb] r250899 - Skip TestMultithreaded on Windows.

Author: amccarth Date: Wed Oct 21 09:42:10 2015 New Revision: 250899 URL: http://llvm.org/viewvc/llvm-project?rev=250899=rev Log: Skip TestMultithreaded on Windows. Differential Revision: http://reviews.llvm.org/D13923 Modified: lldb/trunk/test/api/multithreaded/TestMultithreaded.py

Re: [Lldb-commits] [PATCH] D13923: Skip TestMultithread.py on Windows because it times out (and they'd fail anyway)

This revision was automatically updated to reflect the committed changes. Closed by commit rL250899: Skip TestMultithreaded on Windows. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D13923?vs=37953=38012#toc Repository: rL LLVM http://reviews.llvm.org/D13923

[Lldb-commits] [lldb] r250576 - Skip hanging watchpoint test on Windows (rather than just xfailing).

Author: amccarth Date: Fri Oct 16 18:19:22 2015 New Revision: 250576 URL: http://llvm.org/viewvc/llvm-project?rev=250576=rev Log: Skip hanging watchpoint test on Windows (rather than just xfailing). Modified: lldb/trunk/test/python_api/watchpoint/condition/TestWatchpointConditionAPI.py

[Lldb-commits] [lldb] r250467 - Factor the execution of the test method into a separate function to ensure that any exceptions that are thrown go out of scope and no longer hold references to SB objec

Author: amccarth Date: Thu Oct 15 17:39:55 2015 New Revision: 250467 URL: http://llvm.org/viewvc/llvm-project?rev=250467=rev Log: Factor the execution of the test method into a separate function to ensure that any exceptions that are thrown go out of scope and no longer hold references to SB

Re: [Lldb-commits] [PATCH] D13788: Factor the execution of a test method into its own function to ensure proper cleanup

This revision was automatically updated to reflect the committed changes. amccarth marked an inline comment as done. Closed by commit rL250467: Factor the execution of the test method into a separate function to ensure… (authored by amccarth). Changed prior to commit:

Re: [Lldb-commits] [PATCH] D13788: Factor the execution of a test method into its own function to ensure proper cleanup

amccarth added a comment. Nice catch on the comment. Repository: rL LLVM http://reviews.llvm.org/D13788 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r250189 - Xfail a watchpoint test on Windows, until Windows implements watchpoints.

Author: amccarth Date: Tue Oct 13 12:55:58 2015 New Revision: 250189 URL: http://llvm.org/viewvc/llvm-project?rev=250189=rev Log: Xfail a watchpoint test on Windows, until Windows implements watchpoints. Modified:

[Lldb-commits] [lldb] r250188 - Fix TestTargetAPI.py test for users who use Swig 3.0.5 or greater.

Author: amccarth Date: Tue Oct 13 12:54:15 2015 New Revision: 250188 URL: http://llvm.org/viewvc/llvm-project?rev=250188=rev Log: Fix TestTargetAPI.py test for users who use Swig 3.0.5 or greater. DifferentialRevision: http://reviews.llvm.org/D13679 Modified:

[Lldb-commits] [lldb] r250044 - Switch threading mode for tests on Windows when there are lots of cores.

Author: amccarth Date: Mon Oct 12 09:46:57 2015 New Revision: 250044 URL: http://llvm.org/viewvc/llvm-project?rev=250044=rev Log: Switch threading mode for tests on Windows when there are lots of cores. This prevents a "too many files" error. Differential Revision: http://reviews.llvm.org/D13555

Re: [Lldb-commits] [PATCH] D13679: Fix TestTargetAPI.py test for users who use Swig 3.0.5 or greater.

With Swig 3.0.2, non-string arguments work. I'm not sure why. Even the Swig 1.x documentation says that what we're doing shouldn't work. On Mon, Oct 12, 2015 at 3:49 PM, Zachary Turner wrote: > zturner added a comment. > > Prior to this patch, what was the behavior of

[Lldb-commits] [PATCH] D13679: Fix TestTargetAPI.py test for users who use Swig 3.0.5 or greater.

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. How Swig handles varargs functions changed between 3.0.2 and 3.0.5, which causes one of our tests to fail. This fix adds a Swig directive to the SBError::SetErrorSTringWithFormat

Re: [Lldb-commits] [PATCH] D13679: Fix TestTargetAPI.py test for users who use Swig 3.0.5 or greater.

amccarth added a comment. Adding Greg Clayton for advice on how to proceed. Swig documentation talked about the peril of varargs methods: http://www.swig.org/Doc3.0/Varargs.html#Varargs The fact that it appears to work with 3.0.2 seems to be a bug in 3.0.2. My proposal is in this patch. An

Re: [Lldb-commits] [PATCH] D13555: Cap test threads on Windows to avoid open file limit

amccarth updated this revision to Diff 36993. amccarth added a comment. Using the multiprocessing-pool mode seems more reliable than capping num_threads. I'm doing it only when the number of threads is high because of the loss of Ctrl+C support. http://reviews.llvm.org/D13555 Files:

Re: [Lldb-commits] [PATCH] D13574: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core; other minor fixes.

amccarth added a subscriber: amccarth. amccarth added a comment. There was an lldb-dev thread from February 9, where it seemed to be agreed that lldb code should be more like llvm code, in particular with the spaces between the function names and the opening parens. I've been omitting the spaces

Re: [Lldb-commits] [PATCH] D13574: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core; other minor fixes.

There was an lldb-dev thread from February 9, where it seemed to be agreed that lldb code should be more like llvm code, in particular with the spaces between the function names and the opening parens. I've been omitting the spaces in new code since then. On Fri, Oct 9, 2015 at 10:14 AM, Greg

Re: [Lldb-commits] [PATCH] D13555: Cap test threads on Windows to avoid open file limit

amccarth added a comment. Hold off. I just got a failure even at only 32 subprocesses. http://reviews.llvm.org/D13555 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13312: Fix Windows build due to missing path.

amccarth abandoned this revision. amccarth added a comment. Same fix was already committed to fix the Linux build. http://reviews.llvm.org/D13312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r248909 - Removed an unused member variable. Affects Windows only.

Author: amccarth Date: Wed Sep 30 09:57:21 2015 New Revision: 248909 URL: http://llvm.org/viewvc/llvm-project?rev=248909=rev Log: Removed an unused member variable. Affects Windows only. Modified: lldb/trunk/source/Plugins/Process/Windows/Live/TargetThreadWindows.h Modified:

Re: [Lldb-commits] [PATCH] D12980: Have a clean(er) shutdown when detaching from processes

amccarth accepted this revision. This revision is now accepted and ready to land. Comment at: source/Plugins/Process/Windows/Live/DebuggerThread.cpp:309 @@ -308,1 +308,3 @@ { +if (m_pid_to_detach != 0 &&

[Lldb-commits] [lldb] r247939 - Get the process ID from a minidump.

Author: amccarth Date: Thu Sep 17 15:52:29 2015 New Revision: 247939 URL: http://llvm.org/viewvc/llvm-project?rev=247939=rev Log: Get the process ID from a minidump. Modified: lldb/trunk/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp

[Lldb-commits] [lldb] r247829 - Add first tests for mini-dump debugging.

Author: amccarth Date: Wed Sep 16 13:17:11 2015 New Revision: 247829 URL: http://llvm.org/viewvc/llvm-project?rev=247829=rev Log: Add first tests for mini-dump debugging. Differential Revision: http://reviews.llvm.org/D12888 Added: lldb/trunk/test/functionalities/postmortem/

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

amccarth added a comment. In http://reviews.llvm.org/D12888#247212, @zturner wrote: > In http://reviews.llvm.org/D12888#247195, @amccarth wrote: > > > > Instead of test/functionalities/minidump, I would probably call this > > > test/functionalities/core-file/windows. > > > > > > Hmm... > > > >

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

amccarth updated this revision to Diff 34906. amccarth added a comment. Addressed earlier comments and moved to functionalities\postmortem\minidump http://reviews.llvm.org/D12888 Files: test/functionalities/postmortem/minidump/TestMiniDump.py

Re: [Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

amccarth marked 2 inline comments as done. amccarth added a comment. > Instead of test/functionalities/minidump, I would probably call this > test/functionalities/core-file/windows. Hmm... There is talk of (eventually) debugging minidumps on other platforms. Also some crash capture tools

[Lldb-commits] [PATCH] D12888: Add first tests for mini-dump debugging.

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. This includes a dump file captured using Visual Studio, of the enclosed sample program, which was also build with Visual Studio. The tests just verify that LLDB can access some very

[Lldb-commits] [PATCH] D12641: Work around a race condition in lldbtest.py for Windows.

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. Allows about 10 passing tests to succeed rather than fail due to log file juggling. http://reviews.llvm.org/D12641 Files: test/lldbtest.py Index: test/lldbtest.py

Re: [Lldb-commits] [PATCH] D12641: Work around a race condition in lldbtest.py for Windows.

amccarth updated this revision to Diff 34063. amccarth added a comment. I've put more detail in the comment. http://reviews.llvm.org/D12641 Files: test/lldbtest.py Index: test/lldbtest.py === --- test/lldbtest.py +++

[Lldb-commits] [lldb] r246870 - Sleep-and-retry after a failure to delete a log file, which may be because antimalware is holding the handle to the just-created file.

Author: amccarth Date: Fri Sep 4 15:48:48 2015 New Revision: 246870 URL: http://llvm.org/viewvc/llvm-project?rev=246870=rev Log: Sleep-and-retry after a failure to delete a log file, which may be because antimalware is holding the handle to the just-created file. Differential Revision:

Re: [Lldb-commits] [PATCH] D12641: Work around a race condition in lldbtest.py for Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rL246870: Sleep-and-retry after a failure to delete a log file, which may be because… (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D12641?vs=34063=34071#toc Repository: rL

[Lldb-commits] [lldb] r246558 - Implement DoReadMemory for Windows mini dumps.

Author: amccarth Date: Tue Sep 1 11:59:31 2015 New Revision: 246558 URL: http://llvm.org/viewvc/llvm-project?rev=246558=rev Log: Implement DoReadMemory for Windows mini dumps. Differential Revision: http://reviews.llvm.org/D12507 Modified:

[Lldb-commits] [PATCH] D12507: Implement DoReadMemory for Windows mini dumps

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. Implements DoReadMemory for Windows mini dumps. The dumps can use two slightly different methods for capturing ranges of memory, so I abstracted away the search for a range from the

Re: [Lldb-commits] [PATCH] D12363: Read module list from mini dump

amccarth updated this revision to Diff 33379. amccarth added a comment. Now uses llvm/Support/ConvertUTF.h instead of WinAPI WideCharToMultiByte. http://reviews.llvm.org/D12363 Files: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp

Re: [Lldb-commits] [PATCH] D12363: Read module list from mini dump

amccarth marked an inline comment as done. amccarth added a comment. New patch coming up. http://reviews.llvm.org/D12363 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12126: Read exception records from Windows mini dump

amccarth updated this revision to Diff 32475. amccarth marked an inline comment as done. amccarth added a comment. Addresses some of Zach's comments. http://reviews.llvm.org/D12126 Files: source/Plugins/Process/Windows/ExceptionRecord.h

<    1   2   3