[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

xiaobai added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) hhb wrote: > xiaobai wrote: > > Doesn't this now include the `lldb-private` headers now? Is that

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

xiaobai added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) Doesn't this now include the `lldb-private` headers now? Is that intended? Repository: rL LLVM

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

xiaobai added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3029 Log *log = LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_INFO); - TypeSP type_sp = dwarf_ast->ParseTypeFromDWARF(sc, die, log, type_is_new_ptr); + + TypeSP type_sp;

[Lldb-commits] [PATCH] D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. No objections from me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67991/new/ https://reviews.llvm.org/D67991 ___ lldb-commits

[Lldb-commits] [PATCH] D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

xiaobai added inline comments. Herald added a subscriber: dexonsmith. Comment at: lldb/test/CMakeLists.txt:103 + ${system_debugserver_path} ${LLVM_RUNTIME_OUTPUT_INTDIR} + COMMENT "Copying the system debugserver to LLDB's binaries directory for testing.")

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

This revision was automatically updated to reflect the committed changes. Closed by commit rL371796: [Target] Move InferiorCall to Process (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

xiaobai updated this revision to Diff 220023. xiaobai added a comment. Rename function in question to CallVoidArgVoidPtrReturn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 Files:

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

xiaobai updated this revision to Diff 220018. xiaobai added a comment. Rename InferiorCall to CallNoArgNoReturnFunc make CallNoArgReturnFunc public Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67472/new/ https://reviews.llvm.org/D67472 Files:

[Lldb-commits] [PATCH] D67472: [Target] Move InferiorCall to Process

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, compnerd, labath. Herald added a project: LLDB. InferiorCall is only ever used in Process, and it is not specific to POSIX. By moving it to Process, we can remove all dependencies on plugins from Process. Moving

[Lldb-commits] [PATCH] D67427: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX

This revision was automatically updated to reflect the committed changes. Closed by commit rL371654: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D67427: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, compnerd, davide, clayborg. Herald added a project: LLDB. InferiorCallPOSIX directly grabs a ClangASTContext from the Target it has and does no error checking. I don't think these functions have a reason to know about clang

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

This revision was automatically updated to reflect the committed changes. Closed by commit rL371258: [Core] Remove use of ClangASTContext in DumpDataExtractor (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

xiaobai updated this revision to Diff 219145. xiaobai added a comment. Refactored slightly to be a bit safer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67239/new/ https://reviews.llvm.org/D67239 Files:

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

xiaobai added a comment. Hmm, good question. If you call `GetAPInt` with a `byte_size` of 0, it should assert when trying to read 0 bytes with the `DataExtractor`. In the worst case, it gives you a broken APInt. I think guarded the call to `GetAPInt` to protect against this, but I think that

[Lldb-commits] [PATCH] D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor

xiaobai created this revision. xiaobai added reviewers: clayborg, JDevlieghere, jingham. Herald added a project: LLDB. DumpDataExtractor uses ClangASTContext in order to get the proper llvm fltSemantics for the type it needs so that it can dump floats in a more precise way. However, there's no

[Lldb-commits] [PATCH] D66858: POSIX DYLD: add workaround for android L loader

xiaobai accepted this revision. xiaobai added a comment. Herald added a subscriber: JDevlieghere. LGTM, small typo tho Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:553 + // reported. Attempt to discover it based on the load address of the object +

[Lldb-commits] [PATCH] D66811: [dotest] Remove results port

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66811/new/ https://reviews.llvm.org/D66811 ___

[Lldb-commits] [PATCH] D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline

xiaobai added inline comments. Comment at: lldb/source/Breakpoint/BreakpointInjectedSite.cpp:341 + "\n" + " typedef unsigned intuint32_t;\n" + " typedef unsigned long long uint64_t ;\n" labath wrote: > aprantl

[Lldb-commits] [PATCH] D66628: [Symbol] Decouple clang from DeclVendor

This revision was automatically updated to reflect the committed changes. Closed by commit rL369735: [Symbol] Decouple clang from DeclVendor (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D66628: [Symbol] Decouple clang from DeclVendor

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, jingham, teemperor. Herald added subscribers: kadircet, arphaman, mgorny. Herald added a project: LLDB. This removes DeclVendor's dependency on clang (and ClangASTContext). DeclVendor has no need to know about

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

xiaobai added a comment. I wouldn't mind adding something to reduce boilerplate, but I'm not sure it would actually look too different. A wrapper function or subclass constructor would need to take a ClangASTContext and a clang::QualType so we could avoid calls to `getAsOpaquePtr()` everywhere

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

This revision was automatically updated to reflect the committed changes. Closed by commit rL369424: [ClangExpressionParser] Add ClangDeclVendor (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: lldb/include/lldb/Symbol/DeclVendor.h:27 +eAppleObjCDeclVendor, +eLastClangDeclVendor, + }; JDevlieghere wrote: > What's `eLastClangDeclVendor` and where is it used?

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, jingham, labath. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: LLDB. This introduces a layer between DeclVendor and the currently implemented DeclVendors

[Lldb-commits] [PATCH] D66448: Include "windows" Instead of "Windows"

xiaobai accepted this revision. xiaobai added a comment. Case-sensitive filesystems lol Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66448/new/ https://reviews.llvm.org/D66448 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands

This revision was automatically updated to reflect the committed changes. Closed by commit rL369296: [lldb-vscode] add `launchCommands` to handle launch specific commands (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

xiaobai added a comment. I like the idea of using something from llvm instead of rolling our own. The code changes look relatively simple and straightforward, so that's good. Comment at: lldb/source/Commands/CommandObjectBreakpoint.cpp:685 RegularExpression

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

This revision was automatically updated to reflect the committed changes. Closed by commit rL368741: [Symbol] Decouple clang from CompilerType (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

xiaobai created this revision. xiaobai added reviewers: compnerd, aprantl, JDevlieghere, davide. Herald added a project: LLDB. xiaobai added a reviewer: labath. Ideally CompilerType would have no knowledge of clang or any individual TypeSystem. Decoupling clang is relatively straightforward.

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. I appreciate you adding more error handling. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66093/new/

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

This revision was automatically updated to reflect the committed changes. Closed by commit rL367480: [API] Remove use of ClangASTContext from SBTarget (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai updated this revision to Diff 212483. xiaobai added a comment. Removed argument to GetScratchTypeSystems from SBTarget CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64964/new/ https://reviews.llvm.org/D64964 Files: include/lldb/Target/Target.h source/API/SBTarget.cpp

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai updated this revision to Diff 212482. xiaobai added a comment. Update GetScatchTypeSystems to account for changes to TypeSystem usage CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64964/new/ https://reviews.llvm.org/D64964 Files: include/lldb/Target/Target.h

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

This revision was automatically updated to reflect the committed changes. Closed by commit rL367360: [Symbol] Use llvm::Expected when getting TypeSystems (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65450: Add llvm-style RTTI to ObjectFile hierarchy

xiaobai accepted this revision. xiaobai added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65450/new/ https://reviews.llvm.org/D65450 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

xiaobai added a comment. In D62213#1605521 , @asmith wrote: > I think this change has introduced a dependence on x64. > > I tried building with the 32b Visual Studio compiler and there are a number > of undefined registers in

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai updated this revision to Diff 212232. xiaobai added a comment. Small logic change in SBModule CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65122/new/ https://reviews.llvm.org/D65122 Files: include/lldb/Core/Module.h include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai added inline comments. Comment at: source/API/SBModule.cpp:525 module_sp->GetTypeSystemForLanguage(eLanguageTypeC); - if (type_system) { -CompilerType compiler_type = type_system->GetBuiltinTypeByName(name); + if (auto err =

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai added a comment. In D65122#1604352 , @labath wrote: > I have one remark about the consumeError+LLDB_LOG pattern. As for whether > this is better than status quo or not, I still don't have an opinion on that. > :) Thanks for pointing out

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai updated this revision to Diff 212210. xiaobai added a comment. Fix incorrect error logging pattern CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65122/new/ https://reviews.llvm.org/D65122 Files: include/lldb/Core/Module.h include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai updated this revision to Diff 212031. xiaobai added a comment. Address comments: - Use Expected - Did some formatting - Made error checking more explicit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65122/new/ https://reviews.llvm.org/D65122 Files:

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai added a comment. I'm going to update this diff with what I changed to give y'all a better idea of what has been changed. I shoulda done that to begin with... :P In D65122#1602145 , @labath wrote: > In D65122#1602067

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai added a comment. After going through this and modifying this patch, I can't help but wonder if `llvm::Optional` would be more appropriate. There are plenty of instances where it's not a hard error if you can't get a TypeSystem and the appropriate action is probably just to log and move

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. I think this is fine. Using `.def` files would be okay too, but I like the sanity checks that Jonas introduced in the LLDBPropertyDefEmitter CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage

This revision was automatically updated to reflect the committed changes. Closed by commit rL366950: [Symbol] Fix some botched logic in Variable::GetLanguage (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage

xiaobai updated this revision to Diff 211607. xiaobai added a comment. Implement suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65165/new/ https://reviews.llvm.org/D65165 Files: source/Symbol/Variable.cpp Index: source/Symbol/Variable.cpp

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai marked 4 inline comments as done. xiaobai added inline comments. Comment at: source/Core/ValueObjectRegister.cpp:261 + if (auto *exe_module = target->GetExecutableModulePointer()) { +if (auto type_system_or_err = +

[Lldb-commits] [PATCH] D64767: [lldb][test_suite] Update tests with unexpected pass on Android aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rL366858: [lldb][test_suite] Update tests with unexpected pass on Android aarch64 (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage

xiaobai created this revision. xiaobai added a reviewer: labath. Herald added a reviewer: jdoerfert. I messed up the logic for this. Fixing with some improvements suggested by Pavel. https://reviews.llvm.org/D65165 Files: source/Symbol/Variable.cpp Index: source/Symbol/Variable.cpp

[Lldb-commits] [PATCH] D65155: [lldb] Remove Xcode project legacy

xiaobai added a comment. In D65155#1597710 , @JDevlieghere wrote: > In D65155#1597657 , @lanza wrote: > > > Not directly related, but there's some other legacy cruft I figure are > > valid for removal. e.g. > > >

[Lldb-commits] [PATCH] D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator

This revision was automatically updated to reflect the committed changes. Closed by commit rL366771: [lldb][test_suite] Fix skipIfTargetAndroid decorator (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D64771: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up

This revision was automatically updated to reflect the committed changes. Closed by commit rL366770: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Thanks for restoring them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65123/new/ https://reviews.llvm.org/D65123

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, davide, compnerd. Herald added a subscriber: jdoerfert. This commit achieves the following: - Functions used to return a `TypeSystem *` return an `llvm::Expected` now. This means that the result of a call is always checked,

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

This revision was automatically updated to reflect the committed changes. Closed by commit rL366733: [Symbol] Improve Variable::GetLanguage (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65025: [Symbol] Improve TypeSystemMap mutex safety

xiaobai abandoned this revision. xiaobai added a comment. Actually from the looks of it, I completely misunderstood what's going on here. It looks like `AddToMap` should only be called by things that hold the mutex, meaning that this change isn't actually necessary. I do think that makes this

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64042/new/ https://reviews.llvm.org/D64042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D65025: [Symbol] Improve TypeSystemMap mutex safety

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, davide, labath, jingham. Relying on m_clear_in_progress is dangerous for modifying m_map. It's entirely possible for one thread to invoke TypeSystemMap::Clear(), lock the mutex, and copy the map for finalization while

[Lldb-commits] [PATCH] D64994: [CMake] Align debugserver with lldb-server on Darwin

xiaobai accepted this revision. xiaobai added a comment. Excellent, thanks for taking care of this! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64994/new/ https://reviews.llvm.org/D64994 ___

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai added a comment. In D64964#1592851 , @JDevlieghere wrote: > All uses of this new function drop the error on the ground. Does that mean it > doesn't matter? If it does, should we return an expected instead? Should we > stop on the first error,

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, jingham, clayborg, compnerd. The methods to find types in a Target aren't clang specific and are pretty generalizable to type systems. Additionally, to support some of the use cases in SBTarget, I've added a

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

xiaobai added inline comments. Comment at: lldb/trunk/tools/debugserver/source/CMakeLists.txt:50 - -option(LLDB_NO_DEBUGSERVER "Disable the debugserver target" OFF) -option(LLDB_USE_SYSTEM_DEBUGSERVER "Use the system's debugserver instead of building it from source (Darwin

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai added a comment. Yes, I agree that replacing ClangASTContext uses with TypeSystem would be the right thing to do, and it's what I plan on doing next. There are instances where you really do want a ClangASTContext (e.g. in plugins related to clang expression parsing and objc), and so

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai added a comment. In D64844#1589794 , @jingham wrote: > This seems partly wrong to me. The point is that the Target holds scratch > AST contexts for all the languages it supports. They are the central > repository for the accumulation of

[Lldb-commits] [PATCH] D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64583/new/ https://reviews.llvm.org/D64583 ___

[Lldb-commits] [PATCH] D64823: [CMake] Default LLDB_PATH_TO_LLVM_BUILD to LLVM_DIR

xiaobai added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:45 if(CMAKE_CROSSCOMPILING) set(LLVM_NATIVE_BUILD "${LLDB_PATH_TO_LLVM_BUILD}/NATIVE") if (NOT EXISTS "${LLVM_NATIVE_BUILD}") sgraenitz wrote: > @xiaobai Can this be

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

xiaobai added a comment. I think that this is a good change overall to do but the name `LLDB_USE_SYSTEM_DEBUGSERVER` is kind of a confusing to me. The name itself doesn't really convey to me that the system debugserver is going to be used for just testing. Before this change, that flag

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai updated this revision to Diff 210229. xiaobai added a comment. Remove ClangASTContext header from Target.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64844/new/ https://reviews.llvm.org/D64844 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Target/Target.h

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai created this revision. xiaobai added reviewers: teemperor, shafik, jingham, JDevlieghere, aprantl. Herald added subscribers: arphaman, emaste. Target doesn't really need to know about ClangASTContext more than any other TypeSystem. We can create a method ClangASTContext::GetScratch for

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. This definitely caused me some pain a few months ago. Thanks for adding this! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64812/new/

[Lldb-commits] [PATCH] D64763: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL366148: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D64763: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, compnerd, jingham, clayborg. Herald added subscribers: arphaman, mgorny. Following up to my CPPLanguageRuntime change, I'm moving ObjCLanguageRuntime into a plugin as well. https://reviews.llvm.org/D64763 Files:

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL365951: [LanguageRuntime] Move CPPLanguageRuntime into a plugin (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D64661: [ObjectContainerBSDArchive] Simplify a few things (NFC)

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64661/new/ https://reviews.llvm.org/D64661 ___

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

This revision was automatically updated to reflect the committed changes. Closed by commit rL365939: [Core] Generalize ValueObject::MaybeCalculateCompleteType (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

This revision was automatically updated to reflect the committed changes. Closed by commit rL365853: [Expression] Move IRDynamicChecks to ClangExpressionParser (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai added a comment. In D64591#1581878 , @jingham wrote: > That would be cleaner. > > OTOH, the original reason for these checkers was to help people understand > crashes in their expressions more clearly. Supposedly, modern languages > "don't have

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai added a comment. In D64591#1581820 , @jingham wrote: > Then the IRDynamicCheck part would go with LLVMUserExpression, and the > C-specific checks in Clang... Except IRDynamicChecks has special knowledge of the clang-specific instrumenters. I

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai added a comment. In D64591#1581775 , @jingham wrote: > This is a little unclear to me. LLVMUserExpression is the class that > represents "anything that uses LLVM at its back end." Both the Swift & Clang > user expressions are instances of

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

xiaobai added a comment. In D64599#1581718 , @jingham wrote: > Anyway, if you can make all the generic parts of lldb not depend on the > language specific - but still abstract - part of the plugin, that would be > fine. Then just LanguageRuntime.h

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

xiaobai marked an inline comment as done. xiaobai added a comment. In D64599#1581620 , @labath wrote: > In D64599#1581598 , @jingham wrote: > > > My model for this was that there was a CPPLanguageRuntime.cpp that

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai updated this revision to Diff 209351. xiaobai added a comment. Remove documentation boilerplate CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64591/new/ https://reviews.llvm.org/D64591 Files: include/lldb/Expression/DynamicCheckerFunctions.h

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:55 #include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h" +#include "Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h"

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai added inline comments. Comment at: include/lldb/Expression/DynamicCheckerFunctions.h:19 + +/// \class DynamicCheckerFunctions DynamicCheckerFunctions.h +/// "lldb/Expression/DynamicCheckerFunctions.h" Encapsulates dynamic check JDevlieghere wrote: > Can

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai updated this revision to Diff 209335. xiaobai added a comment. Reflow comment Remove newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64591/new/ https://reviews.llvm.org/D64591 Files: include/lldb/Expression/DynamicCheckerFunctions.h

[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, jingham, compnerd, labath. Herald added a subscriber: mgorny. This seems better suited to be in a plugin. https://reviews.llvm.org/D64599 Files: include/lldb/Target/CPPLanguageRuntime.h

[Lldb-commits] [PATCH] D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator

xiaobai added a comment. Can you add more context to this diff? I can't see the code surrounding the changes. You can get the whole context with something like `git show -U`. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64583/new/

[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

xiaobai created this revision. xiaobai added reviewers: compnerd, clayborg, jingham, JDevlieghere. Herald added a subscriber: mgorny. IRDynamicChecks in its current form is specific to Clang since it deals with the C language family. It is possible that we may want to instrument code generated

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

xiaobai added inline comments. Comment at: source/Target/ObjCLanguageRuntime.cpp:403 +CompilerType +ObjCLanguageRuntime::CalculateCompleteType(CompilerType base_type) { + CompilerType type_to_return; jingham wrote: > xiaobai wrote: > > clayborg wrote: > > > So

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

xiaobai updated this revision to Diff 208841. xiaobai marked an inline comment as done. xiaobai added a comment. Switch to using llvm::Optional for the return type Rename method from CalculateCompleteType to GetRuntimeType CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64159/new/

[Lldb-commits] [PATCH] D64434: [lldb] Quick Fix: IRExecutionUnit check pointer before access it

This revision was automatically updated to reflect the committed changes. Closed by commit rL365567: [lldb] Quick Fix: IRExecutionUnit check pointer before access it (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android

This revision was automatically updated to reflect the committed changes. Closed by commit rL365561: [lldb_test_suite] Fix lldb test suite targeting remote Android (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D64397: [CMake] Remove extra lldb-framework target

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64397/new/ https://reviews.llvm.org/D64397

[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. I like the idea a lot and the implementation looks alright. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64408/new/

[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

xiaobai added a comment. This is awesome, thanks for doing this! I was also thinking about doing something like this at some point as well. :) Comment at: lldb/cmake/modules/AddLLDB.cmake:17 + if( NOT LTG_SOURCE ) +message(FATAL_ERROR "SOURCE source-file required by

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai added a comment. In D64042#1574438 , @jingham wrote: > Why did you make this a function of Variable, rather than SymbolContextScope? After thinking about it more, I realized that the implementation inside of SymbolContextScope would be

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

xiaobai marked 2 inline comments as done. xiaobai added inline comments. Comment at: include/lldb/Target/ObjCLanguageRuntime.h:253 + CompilerType CalculateCompleteType(CompilerType base_type) override; + clayborg wrote: > Is this named correctly? Maybe this

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64042/new/ https://reviews.llvm.org/D64042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType

xiaobai created this revision. xiaobai added reviewers: jingham, clayborg, JDevlieghere. Instead of hardcoding ClangASTContext and ObjCLanguageRuntime, we can generalize this by creating the method CalculateCompleteType in LanguageRuntime and moving the current MaybeCalculateCompleteType

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

xiaobai added a comment. Thanks for doing this! :D Comment at: lldb/docs/resources/build.rst:145 - cmake -G Ninja -DLLDB_TEST_DEBUG_TEST_CRASHES=1 -DPYTHON_HOME=C:\Python35 -DLLDB_TEST_USE_CUSTOM_C_COMPILER=ON

<    5   6   7   8   9   10   11   12   13   14   >