[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

aganea added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool &Debugger::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; clayborg wrote: > aganea wrote: > > Ideally this

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

aganea added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool &Debugger::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; Ideally this should be explicitly created on the

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

aganea added a comment. There's a typo in the title, `s/descirbes/describes/` Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:54 struct FindMembersSize : public TypeVisitorCallbacks { - FindMembersSize(std::vector> &members_info, + FindMembersSize(llvm::Smal

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

aganea added a comment. In that case @werat can you get the caller application to call `llvm::InitLLVM`? That plus the snippet in https://reviews.llvm.org/D119009#3297591 should shield from crashes if the handler isn't installed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

aganea added a comment. Could you please apply clang format just for the changed lines? You can do that usually through `git clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119009/new/ https://reviews.llvm.org/D119009 ___

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

aganea added a comment. Hello @mstorsjo! I've reverted the patch locally, I'm at this commit: F:\aganea\llvm-project>git log commit a3a8a1a15b524d91b5308db68e9d293b34cd88dd (HEAD -> main, origin/main) Using: F:\aganea\llvm-project>cl Microsoft (R) C/C++ Optimizing Compiler Version 19.28

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

aganea added a comment. In D99426#2666141 , @abhina.sreeskantharajan wrote: > In D99426#2665361 , @aganea wrote: > >> I am still concerned by the fact that this patch doesn't fix the issue >> mentionned in https:/

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

aganea added a comment. I am still concerned by the fact that this patch doesn't fix the issue mentionned in https://reviews.llvm.org/D96363#2650460 Was the intention to fix that issue? Will the fix be done in a subsequent patch? Comment at: llvm/lib/Support/Windows/Path.inc:1

[Lldb-commits] [PATCH] D89716: [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG89b72209ad9b: [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89716

[Lldb-commits] [PATCH] D89716: [LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py

aganea created this revision. aganea added reviewers: amccarth, ted, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aganea requested review of this revision. Herald added a subscriber: JDevlieghere. Improve rG79809f58b02419a5d1bfb6c9a59dbd13cd038c77

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea added a comment. I've commited one more fix here: https://reviews.llvm.org/rG97e7fbb343e2 - This didn't occur locally on my machine, but only on another machine. But in essence, the issue was the same, an accentuated Windows-1252 codepage character that was being decoded as UTF-8 by the

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79809f58b024: [LLDB] On Windows, fix tests (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D88975?vs=296809&id=296982#toc

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea marked 2 inline comments as done. aganea added a comment. Thank you all for your time! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88975/new/ https://reviews.llvm.org/D88975 ___ lldb-commits mai

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea added a comment. In D88975#2317494 , @amccarth wrote: > It's interesting that I haven't encountered some of these errors. There are > five _other_ lldb tests that do fail for me. I have a fix in the works for > some of those. Please see my fail

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea updated this revision to Diff 296809. aganea marked an inline comment as done. aganea added a comment. As discussed above: - Remove locale-specific messages. - Skip relevant locale-sensitive TestTargetCommand tests. - Only skip EXPECT calls in Utility/StatusTest. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea added a comment. In D88975#2317566 , @labath wrote: > I really want to avoid having language specific strings in the tests. We all agree on that. I'll update the patch once it passes all tests on my machines. Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea added a comment. In D88975#2317494 , @amccarth wrote: > Maybe dotest.py could change its own Windows locale setting and the processes > it spawns would inherit that. I don't know if that would work, but I don't > see a good alternative. One prob

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea created this revision. aganea added reviewers: amccarth, labath. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aganea requested review of this revision. This patch fixes a few issues seen when running `ninja check-lldb` in a Re

[Lldb-commits] [PATCH] D87765: [llvm][lldb] Add optimal ThreadPool concurrency

aganea added a comment. @dmantipov Do you have commit access (which I can encourage you ask here if you're planning further changes) or should I commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D87765: [llvm][lldb] Add optimal ThreadPool concurrency

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. Side-note: @dmantipov Could you please use `git diff -U9` when creating patches? This allows reviewers to quickly browse through other parts of the file(s) in Phabricator. That would fix t

[Lldb-commits] [PATCH] D85993: [lldb] Set the access property on member function decls

aganea added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85993/new/ https://reviews.llvm.org/D85993 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

This revision was automatically updated to reflect the committed changes. aganea marked 4 inline comments as done. Closed by commit rG76c5f277f25e: Re-land [Debug][CodeView] Emit fully qualified names for globals (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D79447?vs=

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

aganea reopened this revision. aganea added a comment. This revision is now accepted and ready to land. Could you please take another look? Thank you in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79447/new/ https://reviews.llvm.org/D794

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

aganea updated this revision to Diff 263450. aganea added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Reopening because I had to revert. - Fix lldb's variables.test - Fix type lowering, as described here: D79512 - Added asser

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

aganea added inline comments. Comment at: llvm/lib/Support/Unix/Signals.inc:369 - // Send a special return code that drivers can check for, from sysexits.h. if (Sig == SIGPIPE) +if (auto OldOneShotPipeFunction = @vsk Question question: `SIG

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cc0ba4cbdc5: [LLDB] Disable MSVC warning C4190: 'LLDBSwigPythonBreakpointCallbackFunction'… (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D70442: [LLDB] Force message formatting to English

This revision was automatically updated to reflect the committed changes. Closed by commit rGbdad3ec75ab3: [LLDB] On Windows, force error message formatting to English (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70442/new/ ht

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

aganea updated this revision to Diff 231455. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70830/new/ https://reviews.llvm.org/D70830 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp Index: l

[Lldb-commits] [PATCH] D70448: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4dfc5508f92: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70448/

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

aganea created this revision. aganea added reviewers: JDevlieghere, lawrence_danna. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before this patch, when compiling with MSVC 15.9.17 (latest), we would see: F:\llvm-project\lldb\source\Plugins\ScriptInterpreter\Python\Sc

[Lldb-commits] [PATCH] D70448: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

aganea added a comment. This is a trivial change, unless you have any objections, I'll go forward with this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70448/new/ https://reviews.llvm.org/D70448 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D70448: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

aganea updated this revision to Diff 230097. aganea marked an inline comment as done. aganea added a comment. Omit default arguments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70448/new/ https://reviews.llvm.org/D70448 Files: lldb/source/Commands/CommandObjectThread.cpp Index:

[Lldb-commits] [PATCH] D70448: [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope

aganea created this revision. aganea added a reviewer: jingham. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes a warning on MSVC: F:\llvm-project\lldb\source\Commands\CommandObjectThread.cpp(529): warning C4305: 'argument': truncation from 'char' to 'bool' P

[Lldb-commits] [PATCH] D70442: [LLDB] Force message formatting to English

aganea created this revision. aganea added reviewers: asmith, aleksandr.urakov. aganea added a project: LLDB. Herald added a subscriber: lldb-commits. This is a follow-up on D53092 , and fixes the test below on non-English locales (below, on a French locale): [

[Lldb-commits] [PATCH] D62785: Fix compilation following r362280

aganea abandoned this revision. aganea added a comment. Will be fixed by D62772 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62785/new/ https://reviews.llvm.org/D62785 ___ lldb-co

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

aganea added inline comments. Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:29 + llvm::codeview::CPUType cpu_type; + if (arch_type == llvm::Triple::ArchType::aarch64) { +cpu_type = llvm::codeview::CPUType::ARM64; Should

[Lldb-commits] [PATCH] D62785: Fix compilation following r362280

aganea created this revision. aganea added reviewers: TomTan, labath, tstellar. aganea added a project: LLDB. aganea edited reviewers, added: stella.stamenova; removed: tstellar. Repository: rLLDB LLDB https://reviews.llvm.org/D62785 Files: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramTo

[Lldb-commits] [PATCH] D62021: Fix LLDB warnings when compiling with Clang 8.0

This revision was automatically updated to reflect the committed changes. aganea marked an inline comment as done. Closed by commit rL361295: Fix LLDB warnings when compiling with Clang 8.0 (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D62021: Fix LLDB warnings when compiling with Clang 8.0

aganea marked 2 inline comments as done. aganea added inline comments. Comment at: source/Host/windows/ProcessLauncherWindows.cpp:35-37 + reinterpret_cast(const_cast(warg.c_str())), + reinterpret_cast( + const_cast(warg.c_str() + warg.size() + 1)));

[Lldb-commits] [PATCH] D62021: Fix LLDB warnings when compiling with Clang 8.0

aganea created this revision. aganea added reviewers: JDevlieghere, aleksandr.urakov, asmith, mgorny. aganea added a project: LLDB. Herald added subscribers: lldb-commits, abidh, aprantl. Ditto. Please see warnings list: [2660/3259] Building CXX object tools\lldb\source\Host\CMakeFiles\lldbHos

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM. With a few minor comments: Comment at: llvm/include/llvm/DebugInfo/CodeView/TypeDeserializer.h:122 ~FieldListDeserializer() override { -CVType FieldList; -Fi

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

aganea marked an inline comment as done. aganea added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CVRecord.h:29 +/// Carrying the size separately instead of trusting the size stored in the +/// record prefix provides some extra safety and flexibility. templ

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

aganea added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CVRecord.h:29 +/// Carrying the size separately instead of trusting the size stored in the +/// record prefix provides some extra safety and flexibility. template class CVRecord { To