[Lldb-commits] [PATCH] D76593: [lldb-vscode] Convert launch_info and attach_info to local variables

anton.kolesov updated this revision to Diff 252503. anton.kolesov retitled this revision from "[lldb-vscode] Convert g_vsc.launch_info to a local variable" to "[lldb-vscode] Convert launch_info and attach_info to local variables". anton.kolesov edited the summary of this revision. anton.kolesov a

[Lldb-commits] [PATCH] D76593: [lldb-vscode] Convert g_vsc.launch_info to a local variable

anton.kolesov added a comment. In D76593#1936337 , @labath wrote: > Sounds like a good idea. Could you do the same for `attach_info` (it looks > like it should be possible)? Otherwise, one is left wondering about what's > the difference... I have that

[Lldb-commits] [PATCH] D76593: [lldb-vscode] Convert g_vsc.launch_info to a local variable

anton.kolesov created this revision. anton.kolesov added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This field inside of the global variable can be a simple local variable because it is used in only one function: request_launch. Repository

[Lldb-commits] [PATCH] D76351: [lldb-vscode] Don't use SBLaunchInfo in request_attach

anton.kolesov created this revision. anton.kolesov added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If LLDB attaches to an already running target, then structure SBAttachInfo is used instead of SBLaunchInfo. lldb-vscode function request_atta

[Lldb-commits] [PATCH] D75979: [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame

anton.kolesov updated this revision to Diff 249844. anton.kolesov retitled this revision from "[lldb] Implement StackFrame::BehavesLikeZerothFrame" to "[lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame". anton.kolesov edited the summary of this revision. anton.kolesov added a comment

[Lldb-commits] [PATCH] D75979: [lldb] Implement StackFrame::BehavesLikeZerothFrame

anton.kolesov created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Commit [1] added a declaration of function-member StackFrame::BehavesLikeZerothFrame but hasn't added an implementation for the function. Repository: rG LLVM Github Monorepo https://rev

[Lldb-commits] [PATCH] D75975: [lldb] Copy m_behaves_like_zeroth_frame on stack frame update

anton.kolesov created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Field StackFrame::m_behaves_like_zeroth_frame was introduced in commit [1], however that commit hasn't added a copying of the field to UpdatePreviousFrameFromCurrentFrame, therefore the valu

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

anton.kolesov updated this revision to Diff 244160. anton.kolesov added a comment. Updated in attempt to reduce amount of code duplication between request_attach and request_launch. Built and tested with testsuite on Linux/x64, also built and manually tested on Windows/x64 host with a baremetal

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

anton.kolesov updated this revision to Diff 243828. anton.kolesov retitled this revision from "[lldb] Set executable module when adding modules to the Target" to "[lldb-vscode] Ensure that target matches the executable file". anton.kolesov edited the summary of this revision. anton.kolesov added

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

anton.kolesov added a comment. My original patch was changing lldb-vscode - it was creating a new Target object with ELF given to a constructor. That patch, though definitely would need an update - it should delete the original empty target after creating the new one, but it was leaving it aliv

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

anton.kolesov added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/target/set-exec/TestSetExecutable.py:16 +"""Test adding images to the target.""" +self.build() + labath wrote: > anton.kolesov wrote: > > clayborg wrote

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

anton.kolesov added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/target/set-exec/TestSetExecutable.py:16 +"""Test adding images to the target.""" +self.build() + clayborg wrote: > Create a yaml file and put it in the

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

anton.kolesov updated this revision to Diff 240533. anton.kolesov added a comment. Added a testcase. Because target's architecture is not directly exposed through an API, test looks at the target triplet - it is empty for targets created without an exe file. Without the patch, triplet remains un

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

anton.kolesov added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70847/new/ https://reviews.llvm.org/D70847 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D70847: [lldb] Set executable module when adding modules to the Target

anton.kolesov updated this revision to Diff 232512. anton.kolesov retitled this revision from "[lldb-vscode] Ensure that target matches the executable file" to "[lldb] Set executable module when adding modules to the Target". anton.kolesov edited the summary of this revision. anton.kolesov added

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

anton.kolesov added a comment. In D70847#1763797 , @labath wrote: > This needs a test case, though judging by your description it looks like > pretty much every test case on affected platforms (I guess, windows) should > hit this. Can you check if any of

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

anton.kolesov created this revision. anton.kolesov added a project: LLDB. Herald added a subscriber: lldb-commits. Different architectures may use different target processes, so default "gdb-remote" target process created by lldb-vscode may not work for all targets. This commit changes behaviour o

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

anton.kolesov updated this revision to Diff 197117. anton.kolesov added a comment. Allocate path buffer on stack instead of heap. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59015/new/ https://reviews.llvm.org/D59015 Files: lldb/packages/Python/lldbsuite/t

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

anton.kolesov added inline comments. Comment at: lldb/tools/lldb-mi/MICmdCmdData.cpp:419 + // Get a full path to the file. + std::unique_ptr pPathBuffer(new char[PATH_MAX]); + lineEntry.GetFileSpec().GetPath(pPathBuffer.get(), PATH_MAX); clayborg w

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

anton.kolesov added inline comments. Comment at: lldb/tools/lldb-mi/MICmdCmdData.cpp:419 + // Get a full path to the file. + std::unique_ptr pPathBuffer(new char[PATH_MAX]); + lineEntry.GetFileSpec().GetPath(pPathBuffer.get(), PATH_MAX); clayborg w

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

anton.kolesov added inline comments. Comment at: lldb/tools/lldb-mi/MICmdCmdData.cpp:420 + std::unique_ptr pPathBuffer(new char[PATH_MAX]); + lineEntry.GetFileSpec().GetPath(pPathBuffer.get(), PATH_MAX); clayborg wrote: > There is a variant of FileSpe

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

anton.kolesov updated this revision to Diff 194376. anton.kolesov added a comment. Replaced static local variable (as can be found in CMICmnLLDBDebugSessionInfo::GetFrameInfo) with a unique_ptr to the char array (as done in CMICmnLLDBDebuggerHandleEvents::MiHelpGetModuleInfo). Repository: rL

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

anton.kolesov updated this revision to Diff 193863. anton.kolesov added a comment. Added a simple test case. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59015/new/ https://reviews.llvm.org/D59015 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-mi/dat

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

anton.kolesov created this revision. anton.kolesov added a project: LLDB. Herald added subscribers: lldb-commits, abidh, ki.stfu. Simple "file" might not be enough for Eclipse CDT to find the file, therefore it is preferable for -data-disassemble response to include full absolute file path in the