[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

This revision was automatically updated to reflect the committed changes. Closed by commit rG79a8e006dbc4: [lldb] Fix data race in Process (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157648/new/

[Lldb-commits] [PATCH] D158034: [lldb] Fix data race in ThreadList

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb9006324970: [lldb] Fix data race in ThreadList (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D158034?vs=550519=551673#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D158035: [lldb] Protect RNBRemote from a data race

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, bulbazord, jingham. Herald added a subscriber: kristof.beyls. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread

[Lldb-commits] [PATCH] D158034: [lldb] Fix data race in ThreadList

augusto2112 created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ThreadSanitizer reports the following issue: Write of size 8 at

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5d16957207ce: [lldb] Properly protect the Communication class with reader/writer lock (authored by augusto2112).

[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

augusto2112 added a comment. @JDevlieghere do you have any opinions on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157648/new/ https://reviews.llvm.org/D157648 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

This revision was automatically updated to reflect the committed changes. Closed by commit rG22413641e236: [lldb] Fix data race in PipePosix (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

augusto2112 added inline comments. Comment at: lldb/include/lldb/Core/Communication.h:86-89 + lldb_private::Connection *GetConnection() { +std::shared_lock guard(m_connection_mutex); +return m_connection_sp.get(); + } bulbazord wrote: > This isn't

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 updated this revision to Diff 549548. augusto2112 added a comment. Changed to regular mutex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/ https://reviews.llvm.org/D157654 Files: lldb/include/lldb/Host/posix/PipePosix.h

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 added a comment. @JDevlieghere I updated this to two shared mutexes because I'm assuming you can have more than one concurrent read and more than one concurrent write. If this is wrong I can go back to two regular mutexes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 updated this revision to Diff 549539. augusto2112 added a comment. Update to two shared mutexes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/ https://reviews.llvm.org/D157654 Files:

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, bulbazord. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch picks up where https://reviews.llvm.org/D157159

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 updated this revision to Diff 549454. augusto2112 added a comment. Lock earlier in operator= Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/ https://reviews.llvm.org/D157654 Files: lldb/include/lldb/Host/posix/PipePosix.h

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 added inline comments. Comment at: lldb/source/Host/posix/PipePosix.cpp:69 PipeBase::operator=(std::move(pipe_posix)); - m_fds[READ] = pipe_posix.ReleaseReadFileDescriptor(); - m_fds[WRITE] = pipe_posix.ReleaseWriteFileDescriptor(); + std::lock_guard

[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

augusto2112 added a comment. In D157648#4578420 , @JDevlieghere wrote: > Is the reported race specifically about the shared pointer being accessed > concurrently or operations on the `IOHandler`? I believe it's the shared pointer being accessed.

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, bulbazord. Herald added a subscriber: kristof.beyls. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread sanitizer

[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

augusto2112 created this revision. augusto2112 added reviewers: bulbazord, JDevlieghere. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread sanitizer reports a data race in Process.cpp in the

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

augusto2112 added inline comments. Comment at: lldb/source/Host/common/File.cpp:609 num_bytes = bytes_written; - } else if (StreamIsValid()) { + } else if (ValueGuard stream_guard = StreamIsValid()) { bytes_written = ::fwrite(buf, 1, num_bytes, m_stream);

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

augusto2112 accepted this revision. augusto2112 added a comment. I have one nit that I'll leave up to you whether it should be addressed now or not. Comment at: lldb/source/Host/common/File.cpp:545 num_bytes = bytes_read; - } else if (StreamIsValid()) { + } else if

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in ConnectionFileDescriptor

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. On the description you mention `unique_ptr` but I only see `shared_ptr` here. Was that a typo or do you mean that users of this class kept it behind a `unique_ptr`? In any case I

[Lldb-commits] [PATCH] D157153: [lldb] Fix ThreadList::Update not locking the rhs's mutex

This revision was automatically updated to reflect the committed changes. Closed by commit rGd75dc9a8a86c: [lldb] Fix ThreadList::Update not locking the rhss mutex (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157153/new/

[Lldb-commits] [PATCH] D157153: [lldb] Fix ThreadList::Update not locking the rhs's mutex

augusto2112 created this revision. augusto2112 added reviewers: jingham, JDevlieghere. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ThreadList::Update is being caught by thread sanitizer. There's

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

This revision was automatically updated to reflect the committed changes. Closed by commit rG318f600722e3: [lldb] Protect OptionValue accesses from data races (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157041/new/

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 updated this revision to Diff 547318. augusto2112 added a comment. Remove lock from DeepCopy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157041/new/ https://reviews.llvm.org/D157041 Files:

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 updated this revision to Diff 547284. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157041/new/ https://reviews.llvm.org/D157041 Files: lldb/include/lldb/Interpreter/OptionValue.h

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 marked 2 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Interpreter/OptionValue.cpp:49 + std::lock_guard lock(m_mutex); if (GetType() == OptionValue::eTypeBoolean) return static_cast(this); kastiglione

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 added a comment. > Do all of these need to be protected with a mutex? In your description you're > saying TSan is detecting data races. What piece of data are you observing the > data race on? Only SetAsBoolean/GetAsBoolean are being caught when running our test suite at the

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, aprantl, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread sanitizer is catching data races in

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f45a87bf029: [lldb] Print hint if object description is requested but not implemented (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 updated this revision to Diff 546275. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153489/new/ https://reviews.llvm.org/D153489 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 marked an inline comment as done. augusto2112 added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:133-135 + << "note: object description requested, but type doesn't implement " + "a custom object description.

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 added inline comments. Comment at: lldb/include/lldb/Target/Target.h:496 + std::once_flag target_once_flag; // These two functions fill out the Broadcaster interface: kastiglione wrote: > did you mean to use this, or should it be deleted?

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153489/new/ https://reviews.llvm.org/D153489 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

augusto2112 added a comment. Personally I vote for the formatter kind on every line, so we don't need to jump around the logs when reading them, up to you though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154128/new/

[Lldb-commits] [PATCH] D154128: [lldb] Add log indicating which kind of data formatter

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. I've bumped into this problem before, so really like this change. It's a bit sad that you'll only print the kind of data formatter once though, so someone reading the logs might

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 updated this revision to Diff 535561. augusto2112 marked 5 inline comments as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153489/new/ https://reviews.llvm.org/D153489 Files:

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153489/new/ https://reviews.llvm.org/D153489 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 added a comment. Herald added subscribers: Michael137, JDevlieghere. @kastiglione I wonder if we should hint in all 3 command objects (expr, frame var and DWIM) or if we should limit this to DWIM instead (since DWIM is the one aliased to p and po and I don't think `vo` or `expr -O`

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 created this revision. augusto2112 added reviewers: kastiglione, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Lots of users use "po" as their default print command. If the

[Lldb-commits] [PATCH] D152409: [lldb] Never print children if the max depth has been reached

This revision was automatically updated to reflect the committed changes. Closed by commit rGf94c7ffe4640: [lldb] Never print children if the max depth has been reached (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D152409?vs=529673=530994#toc Repository: rG

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1ebfc5de34e: [lldb] Unconditionally increment depth when printing children (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

augusto2112 updated this revision to Diff 529709. augusto2112 marked an inline comment as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/new/ https://reviews.llvm.org/D151950 Files:

[Lldb-commits] [PATCH] D152409: [lldb] Never print children if the max depth has been reached

augusto2112 updated this revision to Diff 529673. augusto2112 added a comment. Remove failure check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152409/new/ https://reviews.llvm.org/D152409 Files:

[Lldb-commits] [PATCH] D152409: [lldb] Never print children if the max depth has been reached

augusto2112 created this revision. augusto2112 added reviewers: aprantl, kastiglione. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When formatting a variable, the max depth would potentially be

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

augusto2112 updated this revision to Diff 529463. augusto2112 added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/new/ https://reviews.llvm.org/D151950 Files: lldb/source/DataFormatters/ValueObjectPrinter.cpp

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

augusto2112 updated this revision to Diff 527670. augusto2112 added a comment. Herald added a subscriber: JDevlieghere. Add radar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/new/ https://reviews.llvm.org/D151950 Files:

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

augusto2112 created this revision. augusto2112 added reviewers: kastiglione, aprantl, DavidSpickett. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `target.max-children-depth` setting and

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fe9718dd5f2: [lldb] Implement GetValueTypeFromAddressType (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150826/new/

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

augusto2112 updated this revision to Diff 523219. augusto2112 added a comment. Add llvm_unreachable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150826/new/ https://reviews.llvm.org/D150826 Files: lldb/include/lldb/Core/Value.h

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

augusto2112 added a comment. In D150826#4351518 , @bulbazord wrote: > Where do you plan on using this? Downstream I assume? Yes, I need this downstream, but seemed general enough to add upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Value::ValueType is a superset of AddressType. Add a function to convert an

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::GetCompileOptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG19d969e340c9: [lldb] Implement SymbolFile::GetCompileOptions (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147748/new/

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::GetCompileOptions

augusto2112 added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:441 + /// associated with that compilation unit. + std::unordered_map GetCompileOptions() { +std::unordered_map args; JDevlieghere wrote: > Any reason you picked

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::ContainsCompileOption

augusto2112 updated this revision to Diff 511815. augusto2112 marked an inline comment as done. augusto2112 added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Changed implementation to GetCompileOptions Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::ContainsCompileOption

augusto2112 added a comment. In D147748#4251543 , @JDevlieghere wrote: > At a higher level I wonder if this is really the best interface. If you ever > need all the compile options, you probably want something like `Args >

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::ContainsCompileOption

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Implement SymbolFile::ContainsCompileOption, which returns true if the

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

augusto2112 updated this revision to Diff 511549. augusto2112 marked 3 inline comments as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147292/new/ https://reviews.llvm.org/D147292 Files:

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

augusto2112 abandoned this revision. augusto2112 added a comment. Abandoning in favor of https://reviews.llvm.org/D147292/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146679/new/ https://reviews.llvm.org/D146679

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

augusto2112 added a comment. In D147292#4238820 , @JDevlieghere wrote: > There seems to be overlap in the code added in this patch and D146679 > . Does one supersede the other or is there > a dependency? If it's the

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jingham, dblaikie. Herald added a reviewer: shafik. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds support

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

augusto2112 added inline comments. Comment at: lldb/include/lldb/Target/Target.h:253 + bool GetEnableTrampolineSupport() const; + JDevlieghere wrote: > What does trampoline "support" mean? Could this be named something more > descriptive? From the

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

augusto2112 updated this revision to Diff 507841. augusto2112 marked 14 inline comments as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146679/new/ https://reviews.llvm.org/D146679 Files:

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jingham, dblaikie. Herald added a reviewer: shafik. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds support

[Lldb-commits] [PATCH] D146265: [lldb] Introduce SymbolFile::ParseAllLanguages

This revision was automatically updated to reflect the committed changes. Closed by commit rGf03cd763384b: [lldb] Introduce SymbolFile::ParseAllLanguages (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D146265?vs=505952=506307#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D146265: [lldb] Introduce SymbolFile::ParseAllLanguages

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, jplehr, sstefan1. Herald added a project: LLDB.

[Lldb-commits] [PATCH] D145612: [lldb] Only replace valobj with persisted one if not null in DWIMPrint

This revision was automatically updated to reflect the committed changes. Closed by commit rG581ac50d58b9: [lldb] Only replace valobj with persisted one if not null in DWIMPrint (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D145612?vs=503503=503518#toc

[Lldb-commits] [PATCH] D145612: [lldb] Only replace valobj with persisted one if not null in DWIMPrint

augusto2112 created this revision. augusto2112 added a reviewer: kastiglione. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145612

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

This revision was automatically updated to reflect the committed changes. Closed by commit rG294ca122956f: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D143772?vs=496567=496643#toc Repository:

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

augusto2112 added a comment. In D143772#4119213 , @JDevlieghere wrote: > Why are only these two tests affected? Should this be something we set > globally for all the tests? The API tests already have support for forwarding > `ASAN_OPTIONS` and lit

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, jingham, aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In situations where only LLDB is ASANified, a false

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG901ba0fcae36: [lldb] Implement SymbolFile::CopyType (authored by

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

augusto2112 updated this revision to Diff 490951. augusto2112 added a comment. Added check for same symbol file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142052/new/ https://reviews.llvm.org/D142052 Files:

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

augusto2112 added a comment. @clayborg we have one instance downstream where we need to keep two types around. One for the original type and one for a slightly modified one (here

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

augusto2112 added a comment. @clayborg the intended usage here is to create a copy of the type in the same symbol file. I could add a sanity check that makes sure we're not creating a copy of something that isn't in the symbol file's type list in debug mode. Would that be enough? Repository:

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

augusto2112 created this revision. augusto2112 added a reviewer: clayborg. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. SymbolFiles should be the only point of creation of Types to ensure that

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. @clayborg I went with your suggestion and made Type's constructor private, and any new Type created is automatically added to the TypeList. I think later on we should make TypeList keep a vector of unique pointers instead of shared ones. Repository: rG LLVM

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 updated this revision to Diff 489137. augusto2112 added a comment. Make Type constructor private Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141318/new/ https://reviews.llvm.org/D141318 Files: lldb/include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. In D141318#4045372 , @clayborg wrote: > Each SymbolFile has its own type list that keeps the shared pointers to all > types. So there should be no need for any of these changes here unless > someone isn't correctly storing

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. In D141318#4037687 , @JDevlieghere wrote: > In D141318#4037640 , @augusto2112 > wrote: > >> In D141318#4037557 , @JDevlieghere >> wrote:

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. In D141318#4037557 , @JDevlieghere wrote: > In D141318#4037541 , @augusto2112 > wrote: > >> I changed the value of the map to a shared pointer, but could change it to a >> weak

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. Herald added a subscriber: JDevlieghere. I changed the value of the map to a shared pointer, but could change it to a weak pointer instead, not sure which is more appropriate in this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 created this revision. augusto2112 added reviewers: labath, clayborg, aprantl. Herald added a reviewer: shafik. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Storing raw pointers in

[Lldb-commits] [PATCH] D141165: [lldb] Fix symbol table use after free

augusto2112 created this revision. augusto2112 added reviewers: labath, jingham, JDevlieghere. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The symbol file stores a raw pointer to the main object

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

This revision was automatically updated to reflect the committed changes. Closed by commit rGf85cc6009aa7: [lldb] Add LTO dependency to lldb test suite (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140051/new/

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

augusto2112 added a comment. @DavidSpickett thanks for the review, I've updated the commit message to be clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140051/new/ https://reviews.llvm.org/D140051

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

augusto2112 added a comment. @DavidSpickett right now if you don't have LTO the test will run but fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140051/new/ https://reviews.llvm.org/D140051 ___

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. Herald added a subscriber: inglorion. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Make the lldb test target depend on

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3b517d57239: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py (authored by augusto2112). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

augusto2112 updated this revision to Diff 471662. augusto2112 added a comment. Added encoding parameter to all "open" calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136798/new/ https://reviews.llvm.org/D136798 Files:

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

augusto2112 created this revision. augusto2112 added reviewers: mib, JDevlieghere, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The python "open" function will use the default encoding

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f2423c6fe97: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 updated this revision to Diff 469032. augusto2112 added a comment. Updated default stack size of the cu containers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136114/new/ https://reviews.llvm.org/D136114 Files:

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 updated this revision to Diff 468750. augusto2112 marked an inline comment as done. augusto2112 added a comment. Add a map from compile unit id to index in vector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136114/new/

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 marked 6 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:644 + if (_unit == extra.get()) + return _compile_unit_infos[i]; } aprantl wrote: > is

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 updated this revision to Diff 468729. augusto2112 added a comment. Herald added subscribers: ormris, steven_wu, hiraditya. Added test, changed DWARFCompileUnit::BuildAddressRangeTable to not stop looking at oso ranges at offset 0. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 updated this revision to Diff 468337. augusto2112 added a comment. Remote extra semi-colon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136114/new/ https://reviews.llvm.org/D136114 Files:

[Lldb-commits] [PATCH] D136114: [lldb] Allow SymbolFileDWARFDebugMap to register multiple compile units

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jasonmolenda, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB.

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

augusto2112 accepted this revision. augusto2112 added a comment. I think this is a good change. One related thing that we could look into fixing is that currently both run-target and no-run-target do the **exact** same thing. Not sure if we could remove one of them since this could break user's

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6c5944d05e8: [lldb] Allow DataFileCache to be constructed with a different policy (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >