[Lldb-commits] [PATCH] D103391: [lldb] Add missing reproducer instrumentation to some SB classes

brucem requested changes to this revision. brucem added a comment. This revision now requires changes to proceed. The change to `SBDebugger::GetProgressFromEvent` needs to be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103391/new/

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

brucem added a comment. It failed because on macOS, the underlying args contains argv0 while on Linux it does not. So my test that checked that `GetNumArguments` is 1 fails on macOS, since there are 2. Ideally, each platform would agree on whether or not the argv0 was included in the args ...

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

brucem reopened this revision. brucem added a comment. This revision is now accepted and ready to land. Not sure why this failed. Is it perhaps a difference where some processes have args including the executable and some do not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103744: [lldb][docs] Remove mention of subversion. NFC.

brucem created this revision. brucem requested review of this revision. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103744 Files: lldb/docs/resources/build.rst Index: lldb/docs/resources/build.rst

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. brucem marked an inline comment as done. Closed by commit rG8d33437d030a: [LLDB/API] Expose args and env from SBProcessInfo. (authored by brucem). Repository: rG

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

brucem marked an inline comment as done. brucem added inline comments. Comment at: lldb/bindings/interface/SBProcessInfo.i:78 + +%feature("docstring", +"Return the specified argument given to the described process." teemperor wrote: > Can you add this

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

brucem updated this revision to Diff 349895. brucem added a comment. Rebase and address feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103675/new/ https://reviews.llvm.org/D103675 Files: lldb/bindings/interface/SBProcessInfo.i

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

brucem created this revision. brucem requested review of this revision. Herald added a project: LLDB. This is another step towards implementing the equivalent of `platform process list` and related functionality. `uint32_t` is used for the argument count and index despite the underlying value

[Lldb-commits] [PATCH] D103375: [lldb/API] Expose triple for SBProcessInfo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG251a5d9d5239: [lldb/API] Expose triple for SBProcessInfo. (authored by brucem). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103391: [lldb] Add missing reproducer instrumentation to some SB classes

brucem added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:165 bool _debugger_specific) { + LLDB_RECORD_STATIC_METHOD( + const char *, SBDebugger, GetProgressFromEvent, This one is already present

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

brucem added a comment. I had requested it and got it a short bit ago. Looks like I landed it successfully. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103381/new/ https://reviews.llvm.org/D103381

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36597e4719e9: [lldb] Fix typos. NFC. (authored by brucem). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

brucem updated this revision to Diff 348714. brucem added a comment. Mark as NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103381/new/ https://reviews.llvm.org/D103381 Files: lldb/docs/design/overview.rst lldb/docs/resources/test.rst

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

brucem updated this revision to Diff 348713. brucem added a comment. Remove incorrect change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103381/new/ https://reviews.llvm.org/D103381 Files: lldb/docs/design/overview.rst

[Lldb-commits] [PATCH] D103381: [lldb] Fix typos.

brucem created this revision. Herald added a reviewer: shafik. brucem requested review of this revision. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103381 Files: lldb/docs/design/overview.rst lldb/docs/resources/test.rst

[Lldb-commits] [PATCH] D103375: [lldb/API] Expose triple for SBProcessInfo.

brucem added inline comments. Comment at: lldb/source/API/SBProcessInfo.cpp:191 + // the string + triple = ConstString(arch.GetTriple().getTriple().c_str()).GetCString(); +} teemperor wrote: > You need to 'instrument' these functions. there is a

[Lldb-commits] [PATCH] D103375: [lldb/API] Expose triple for SBProcessInfo.

brucem created this revision. brucem added a reviewer: lldb-commits. brucem requested review of this revision. Herald added a project: LLDB. This is present when doing a `platform process list` and is tracked by the underlying code. To do something like the process list via the SB API in the

[Lldb-commits] [PATCH] D55376: Generate LLDB website/documentation from rst with Sphinx

brucem added a comment. This sounds great to me. Perhaps it'd be nice if we could use Sphinx instead of epydoc in the future? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55376/new/ https://reviews.llvm.org/D55376

[Lldb-commits] [PATCH] D55361: Move Broadcaster+Listener+Event combo from Core into Utility

brucem added a comment. I recognize that it might be dull, but should you re-sort the various include lists so that the now-in-Utility headers are listed with the other Utility headers? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55361/new/ https://reviews.llvm.org/D55361

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

This revision was automatically updated to reflect the committed changes. Closed by commit rL347637: Add support for the Dylan language to ClangASTContext (authored by brucem, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

brucem added a comment. I can land this today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D52884: Fix typos.

This revision was automatically updated to reflect the committed changes. Closed by commit rL343825: Fix typos. (authored by brucem, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52884 Files:

[Lldb-commits] [PATCH] D52884: Fix typos.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB343825: Fix typos. (authored by brucem, committed by ). Changed prior to commit: https://reviews.llvm.org/D52884?vs=168279=168398#toc Repository: rL LLVM https://reviews.llvm.org/D52884 Files:

[Lldb-commits] [PATCH] D52884: Fix typos.

brucem created this revision. brucem added a reviewer: lldb-commits. Herald added subscribers: ki.stfu, srhines. https://reviews.llvm.org/D52884 Files: include/lldb/Utility/ConstString.h packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py source/Host/common/MainLoop.cpp

[Lldb-commits] [PATCH] D48775: Add new SBTarget::IsDummy method.

brucem requested changes to this revision. brucem added inline comments. This revision now requires changes to proceed. Comment at: include/lldb/API/SBTarget.h:65 + bool IsDummy() const; + Could you add a doc comment here explaining it?

[Lldb-commits] [PATCH] D47420: Remove Linux-specific includes for posix/FileSystem.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL333400: Remove Linux-specific includes for posix/FileSystem.cpp (authored by brucem, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47420

[Lldb-commits] [PATCH] D47421: Typo fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL99: Typo fixes. (authored by brucem, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47421 Files:

[Lldb-commits] [PATCH] D47421: Typo fixes.

brucem updated this revision to Diff 148752. brucem added a comment. Herald added subscribers: kbarton, nemanjai. A couple of additional fixes. https://reviews.llvm.org/D47421 Files: include/lldb/Breakpoint/BreakpointID.h include/lldb/Core/Address.h include/lldb/Core/Broadcaster.h

[Lldb-commits] [PATCH] D47421: Typo fixes.

brucem created this revision. Herald added subscribers: JDevlieghere, ki.stfu. Herald added a reviewer: javed.absar. https://reviews.llvm.org/D47421 Files: include/lldb/Breakpoint/BreakpointID.h include/lldb/Core/Address.h include/lldb/Core/Broadcaster.h

[Lldb-commits] [PATCH] D47420: Remove Linux-specific includes for posix/FileSystem.cpp

brucem created this revision. brucem added a reviewer: clayborg. Herald added a subscriber: krytarowski. This improves the process of cross-compiling from macOS to Linux since these files aren't used / needed at all. https://reviews.llvm.org/D47420 Files: source/Host/posix/FileSystem.cpp

[Lldb-commits] [PATCH] D36948: lldb-argdumper doesn't need lldbCore.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311399: lldb-argdumper doesn't need lldbCore. (authored by brucem). Repository: rL LLVM https://reviews.llvm.org/D36948 Files: lldb/trunk/tools/argdumper/CMakeLists.txt Index:

[Lldb-commits] [PATCH] D36948: lldb-argdumper doesn't need lldbCore.

brucem created this revision. Herald added a subscriber: mgorny. lldb-argdumper only needs lldbUtility to successfully build and link. https://reviews.llvm.org/D36948 Files: tools/argdumper/CMakeLists.txt Index: tools/argdumper/CMakeLists.txt

[Lldb-commits] [PATCH] D31283: Expose hit count via SBBreakpointLocation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308480: Expose hit count via SBBreakpointLocation. (authored by brucem). Repository: rL LLVM https://reviews.llvm.org/D31283 Files: lldb/trunk/include/lldb/API/SBBreakpointLocation.h

[Lldb-commits] [PATCH] D31283: Expose hit count via SBBreakpointLocation.

brucem updated this revision to Diff 107297. brucem added a comment. Update per comments. https://reviews.llvm.org/D31283 Files: include/lldb/API/SBBreakpointLocation.h packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/Makefile

[Lldb-commits] [PATCH] D31283: Expose hit count via SBBreakpointLocation.

brucem added a reviewer: labath. brucem added a comment. Pavel, since Jim was okay with this before apart from it not having a test, want to take a quick look now? Thanks! https://reviews.llvm.org/D31283 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D31283: Expose hit count via SBBreakpointLocation.

brucem updated this revision to Diff 107271. brucem added a comment. Add a test. https://reviews.llvm.org/D31283 Files: include/lldb/API/SBBreakpointLocation.h packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/Makefile

[Lldb-commits] [PATCH] D31282: Fix typos in documentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308426: Fix typos in documentation. (authored by brucem). Repository: rL LLVM https://reviews.llvm.org/D31282 Files: lldb/trunk/scripts/interface/SBBreakpoint.i

[Lldb-commits] [PATCH] D35614: Update API headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308425: Update API headers. (authored by brucem). Repository: rL LLVM https://reviews.llvm.org/D35614 Files: lldb/trunk/include/lldb/API/SBAttachInfo.h lldb/trunk/include/lldb/API/SBBreakpoint.h

[Lldb-commits] [PATCH] D31283: Expose hit count via SBBreakpointLocation.

brucem created this revision. SBBreakpointLocation exposed the ignore count, but didn't expose the hit count. Both values were exposed by SBBreakpoint and SBWatchpoint, so this makes things a bit more consistent. https://reviews.llvm.org/D31283 Files: include/lldb/API/SBBreakpointLocation.h

[Lldb-commits] [PATCH] D31282: Fix typos in documentation.

brucem created this revision. https://reviews.llvm.org/D31282 Files: scripts/interface/SBBreakpoint.i scripts/interface/SBModule.i scripts/interface/SBSymbol.i Index: scripts/interface/SBSymbol.i === ---

[Lldb-commits] [PATCH] D31279: Fix warnings from clang build on macOS.

This revision was automatically updated to reflect the committed changes. Closed by commit rL298585: Fix warnings from clang build on macOS. (authored by brucem). Changed prior to commit: https://reviews.llvm.org/D31279?vs=92764=92776#toc Repository: rL LLVM https://reviews.llvm.org/D31279

[Lldb-commits] [PATCH] D31279: Fix warnings from clang build on macOS.

brucem created this revision. https://reviews.llvm.org/D31279 Files: source/Expression/LLVMUserExpression.cpp source/Host/common/Symbols.cpp source/Host/macosx/Symbols.cpp source/Plugins/Process/Utility/DynamicRegisterInfo.cpp