cs01 wrote:
@labath Is there anything else needed of me? Looks like there are workflows
awaiting approval still.
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
cs01 wrote:
@labath @JDevlieghere thanks again for all the feedback. I believe I have
addressed your comments.
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/cs01 updated https://github.com/llvm/llvm-project/pull/145382
>From 0f906e25b2f8a63272691c070a2394e6eaba2e73 Mon Sep 17 00:00:00 2001
From: Chad Smith
Date: Tue, 29 Jul 2025 10:00:02 -0700
Subject: [PATCH 1/2] refactor android platform
---
.../Plugins/Platform/Android/AdbCli
@@ -8,61 +8,48 @@
#include "AdbClient.h"
-#include "llvm/ADT/STLExtras.h"
-#include "llvm/ADT/SmallVector.h"
-#include "llvm/ADT/StringRef.h"
-#include "llvm/Support/FileUtilities.h"
-
-#include "lldb/Host/ConnectionFileDescriptor.h"
#include "lldb/Host/FileSystem.h"
-#inclu
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cs01 wrote:
Friendly ping @labath
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cs01 wrote:
I think I have everything in order now, it's ready for another pass. Thank you
so much for your time and help on this!
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
https://github.com/cs01 ready_for_review
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cs01 updated https://github.com/llvm/llvm-project/pull/145382
>From 4756820fa10e1c9b98616947780eb4dc83bc98e1 Mon Sep 17 00:00:00 2001
From: Chad Smith
Date: Tue, 29 Jul 2025 10:00:02 -0700
Subject: [PATCH] refactor android platform
---
.../Plugins/Platform/Android/AdbClient.
cs01 wrote:
Hi, yes sorry about that. I did not mean to push the file that state, so I
marked the PR as draft while I get it in order. Generally it's ready for a
review other than the ConnectionFileDescriptor changes if you want to give a
look with that in mind. Btw I see there are workflows w
https://github.com/cs01 updated https://github.com/llvm/llvm-project/pull/145382
Unicorn! ยท GitHub
body {
background-color: #f1f1f1;
margin: 0;
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
}
.container { margin: 50px auto 4
@@ -220,6 +220,12 @@ ConnectionStatus
ConnectionFileDescriptor::Disconnect(Status *error_ptr) {
// Prevents reads and writes during shutdown.
m_shutting_down = true;
+ if (!m_io_sp) {
cs01 wrote:
I will remove and possibly add in a different PR
https:/
cs01 wrote:
Friendly ping @labath and anyone else who has any thoughts
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cs01 wrote:
I added some logs to better understand and debug what's going on. Here are some
results from my testing.
In lldb, turn on logs
```
(lldb) log enable -f /tmp/lldb.log lldb platform
```
then open /tmp/lldb.log:
```
lldb-dap PlatformAndroid::CreateInstance(force=true,
arch={,
cs01 wrote:
It has been a week since the last update was published. Friendly ping to
@labath @jeffreytan81
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/cs01 updated https://github.com/llvm/llvm-project/pull/145382
>From d585051b103acc1973671679bd1fa04b92fb0bf9 Mon Sep 17 00:00:00 2001
From: Chad Smith
Date: Mon, 23 Jun 2025 11:07:00 -0700
Subject: [PATCH 1/2] [lldb] make PlatformAndroid/AdbClient::GetSyncService
threadsafe
cs01 wrote:
After more analysis, I think shared ptr will be too difficult to implement,
since the connection and client manages its lifecycle assuming it's the only
client/thread using it. It will be challenging to ensure it doesn't get
disconnected or freed while other threads are using it. C
cs01 wrote:
Thank you both for the feedback. I started working on changes that add more
mutexes to adbclient methods, use a shared pointer for the sync service, and
has cleaner/less path dependent creation of the syncservice (I agree with your
comments labath). I will push an update either tod
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cs01 created https://github.com/llvm/llvm-project/pull/145382
AdbClient and PlatformAndroid GetSyncService is not threadsafe. This was not an
issue because it was (apparently) not used in a threaded environment. However
when the new setting
```
set target.parallel-module-loa
https://github.com/cs01 converted_to_draft
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cs01 edited https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cs01 wrote:
Thank you! Are there any unit tests that can exercise this?
Or at least repro steps to generate a core with the elf headers in case any one
wants to manually test.
https://github.com/llvm/llvm-project/pull/117070
___
lldb-commits mailing
29 matches
Mail list logo
