[Lldb-commits] [libc] [clang] [lld] [lldb] [clang-tools-extra] [flang] [libcxx] [libcxxabi] [llvm] [flang] Pass Argv0 to getIntriniscDir and getOpenMPHeadersDir (PR #73254)

2023-11-30 Thread Daniel Chen via lldb-commits
DanielCChen wrote: The changes look good to me. I will wait a day to see if other reviewers have any more comments before approving it. https://github.com/llvm/llvm-project/pull/73254 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-11-01 Thread Daniel Chen via lldb-commits
DanielCChen wrote: I think it is still my fault because it is indeed a PR branch that I did revert even though it is on my forked repo. I guess GitHub is doing the right thing to notify everyone affected as the PR could be potentially merged onto upstream branch by accident if it is approved.

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-11-01 Thread Daniel Chen via lldb-commits
DanielCChen wrote: Sorry about the noise. All the reverts are in a private branch on my fork repo. I didn't know it would broadcast to all the people who worked on the reverted commits. My apologies. https://github.com/llvm/llvm-project/pull/67599