[Lldb-commits] [lldb] [lldb] Add "settings modified" command (PR #152338)

2025-08-08 Thread Dave Lee via lldb-commits
kastiglione wrote: @labath do you think it will be more discoverable that way, or more memorable? https://github.com/llvm/llvm-project/pull/152338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread Dave Lee via lldb-commits
@@ -150,6 +151,11 @@ llvm::Expected ValueObjectPrinter::GetDescriptionForDisplay() { if (maybe_str) return maybe_str; + if (maybe_str.errorIsA()) +// Propagate expression errors to expose diagnostics to the user. +// Without this early exit, the summary/value m

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread Dave Lee via lldb-commits
kastiglione wrote: > That's changing this UI to NOT print the value if the `po` expression fails > for some reason. > > Is that your intent? it's my intent when the failure is a _compiler reason_ – which is to make a distinction that this is a more narrow change than "some reason". https://gi

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread Dave Lee via lldb-commits
kastiglione wrote: The ultimate intent is to show errors preventing an expected successful object description. If producing an object description fails, printing an object's address (value) is not what users expect. We can change this to print the error and the value, but I don't expect any us

[Lldb-commits] [lldb] [lldb] Add "settings modified" command (PR #152338)

2025-08-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add "settings modified" command (PR #152338)

2025-08-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] wip: add "settings modified" command (PR #152338)

2025-08-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152338 >From a298abcf82d56a1ccc10b6bc4ac0fd11765ba1a6 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 15:37:30 -0700 Subject: [PATCH] [lldb] Add "settings modified" command --- .../lldb/Interpreter/

[Lldb-commits] [lldb] wip: add "settings modified" command (PR #152338)

2025-08-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/152338 None >From aa9613b6e7a328af6764184e5bbd4a0f33a6d16f Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 15:37:30 -0700 Subject: [PATCH] wip: add "settings modified" command --- .../lldb/Interpre

[Lldb-commits] [lldb] [lldb] Use const ref for looping over frame recognizers (NFC) (PR #152334)

2025-08-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/152334 None >From e7ea7c066193c52700035a87a4ee08950c21da99 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 15:39:17 -0700 Subject: [PATCH] [lldb] Use const ref for looping over frame recognizers (NFC

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152201 >From 90eaf547090690c6250fa36937c0f07b170eb8bb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 13:34:50 -0700 Subject: [PATCH 1/4] [lldb] Preserve original symbol of Mangled function names ---

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152201 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152201 >From 90eaf547090690c6250fa36937c0f07b170eb8bb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 13:34:50 -0700 Subject: [PATCH 1/3] [lldb] Preserve original symbol of Mangled function names ---

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152201 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152201 >From 90eaf547090690c6250fa36937c0f07b170eb8bb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 13:34:50 -0700 Subject: [PATCH 1/2] [lldb] Preserve original symbol of Mangled function names ---

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152201 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/152201 None >From 90eaf547090690c6250fa36937c0f07b170eb8bb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 13:34:50 -0700 Subject: [PATCH] [lldb] Preserve original symbol of Mangled function names -

[Lldb-commits] [lldb] [lldb] Add stop_reason Python property to SBThread (PR #151568)

2025-07-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/151568 >From e6016cf51e315fd894382c0c76ffbd5e3fc3ac04 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 31 Jul 2025 10:53:48 -0700 Subject: [PATCH 1/2] [lldb] Add stop_reason Python property to SBThread --- lldb

[Lldb-commits] [lldb] [lldb] Add stop_reason Python property to SBThread (PR #151568)

2025-07-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/151568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add stop_reason Python property to SBThread (PR #151568)

2025-07-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/151568 None >From e6016cf51e315fd894382c0c76ffbd5e3fc3ac04 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 31 Jul 2025 10:53:48 -0700 Subject: [PATCH] [lldb] Add stop_reason Python property to SBThread --- ll

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/151374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/151374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/151374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/151374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Dave Lee via lldb-commits
@@ -186,8 +182,11 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, expr); } - dump_val_object(*valobj_sp); - return; + bool failed = errorToBool(dump_val_object(*valobj_sp)); kastiglione wro

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/151374 >From d4b65cbf4f45fd92950e1660087b72ca39369b44 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 30 Jul 2025 11:33:28 -0700 Subject: [PATCH 1/2] [lldb] Fallback to expression eval when Dump of variable fai

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Dave Lee via lldb-commits
@@ -186,8 +182,11 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, expr); } - dump_val_object(*valobj_sp); - return; + bool failed = errorToBool(dump_val_object(*valobj_sp)); kastiglione wro

[Lldb-commits] [lldb] [lldb][NFC] Small fixes identified by the clang static analyzer (PR #148773)

2025-07-15 Thread Dave Lee via lldb-commits
@@ -539,6 +540,8 @@ static Status HandleFileAction(ProcessLaunchInfo &launch_info, : "unable to launch"); } + [env_dict release]; + [options release]; kastiglione wrote: I wonder if these objc++ files ca

[Lldb-commits] [lldb] [lldb][NFC] Small fixes identified by the clang static analyzer (PR #148773)

2025-07-15 Thread Dave Lee via lldb-commits
@@ -289,12 +286,8 @@ void LanguageRuntime::InitializeCommands(CommandObject *parent) { if (!parent->IsMultiwordObject()) return; - LanguageRuntimeCreateInstance create_callback; - for (uint32_t idx = 0; - (create_callback = -PluginManager::GetLangu

[Lldb-commits] [lldb] [lldb] Fix AppleObjCDeclVendor for classes which have no methods (PR #145452)

2025-06-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/145452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix AppleObjCDeclVendor for classes which have no methods (PR #145452)

2025-06-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/145452 >From 57857bf2749a2801e9c4fb840a984a483ced6a44 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 23 Jun 2025 20:36:38 -0700 Subject: [PATCH 1/3] [lldb] Fix AppleObjCDeclVendor for classes which have no met

[Lldb-commits] [lldb] [lldb] Fix AppleObjCDeclVendor for classes which have no methods (PR #145452)

2025-06-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/145452 >From 57857bf2749a2801e9c4fb840a984a483ced6a44 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 23 Jun 2025 20:36:38 -0700 Subject: [PATCH 1/2] [lldb] Fix AppleObjCDeclVendor for classes which have no met

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-06-05 Thread Dave Lee via lldb-commits
kastiglione wrote: @jimingham is the updated description for `max-children-count` sufficient? https://github.com/llvm/llvm-project/pull/140938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint and similar (PR #142215)

2025-06-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint and similar (PR #142215)

2025-06-02 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint and similar (PR #142215)

2025-06-02 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-06-02 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/142215 >From b969aeffa2726ef4e0714bde9de72a5292a8d8fa Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 30 May 2025 14:11:19 -0700 Subject: [PATCH 1/4] [lldb] Add Python properties to SBBreakpointr(Location) ---

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-05-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/142215 >From b969aeffa2726ef4e0714bde9de72a5292a8d8fa Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 30 May 2025 14:11:19 -0700 Subject: [PATCH 1/3] [lldb] Add Python properties to SBBreakpointr(Location) ---

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-05-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/142215 >From b969aeffa2726ef4e0714bde9de72a5292a8d8fa Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 30 May 2025 14:11:19 -0700 Subject: [PATCH 1/2] [lldb] Add Python properties to SBBreakpointr(Location) ---

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpointr(Location) (PR #142215)

2025-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpointr(Location) (PR #142215)

2025-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/142215 None >From b969aeffa2726ef4e0714bde9de72a5292a8d8fa Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 30 May 2025 14:11:19 -0700 Subject: [PATCH] [lldb] Add Python properties to SBBreakpointr(Location) --

[Lldb-commits] [lldb] [lldb] Remove some dead code in TypeSystemClang (NFC) (PR #142056)

2025-05-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/142056 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Run TestFrameLanguageCommands.py only on Darwin (PR #141866)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/141866 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Run TestFrameLanguageCommands.py only on Darwin (PR #141866)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/141866 Tests using ObjC do not readily run on Linux. >From be15e28e81e41a6f25c9591ef6fb9b2130482c12 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 28 May 2025 15:08:03 -0700 Subject: [PATCH] [lldb] Run TestFr

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/140938 >From d595bfeac15852ce12d9851198b57de2f7da08cb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 21 May 2025 09:44:16 -0700 Subject: [PATCH 1/3] [lldb] Show more children of top level values This changes p

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread Dave Lee via lldb-commits
kastiglione wrote: See https://github.com/llvm/llvm-project/pull/136766 https://github.com/llvm/llvm-project/pull/141829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/141829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/141829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/141829 None >From f46ad6b01c84dce72cf1547acd2a877f4a8b1dbe Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 28 May 2025 12:24:16 -0700 Subject: [PATCH] [lldb] Fix TestFrameLanguageCommands.py build --- lldb/te

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/140938 >From f07c408bcbc221e69f56459d0cca27a27ed8551c Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 21 May 2025 09:44:16 -0700 Subject: [PATCH 1/3] [lldb] Show more children of top level values This changes p

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-28 Thread Dave Lee via lldb-commits
kastiglione wrote: > If would be really cool if when I'm in a C++ frame and I did: > > `(lldb) help demangle` > > I would get a preface like: > > Chosen from 'language cplusplus demangle' because the current frame's > language is cplusplus. I plan to do this in a follow up. Note that `help dem

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/140938 >From f07c408bcbc221e69f56459d0cca27a27ed8551c Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 21 May 2025 09:44:16 -0700 Subject: [PATCH 1/2] [lldb] Show more children of top level values This changes p

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-05-28 Thread Dave Lee via lldb-commits
kastiglione wrote: I've updated the help description for `max-children-count` to reflect how it is applied. https://github.com/llvm/llvm-project/pull/140938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb] Add templated CompilerType::GetTypeSystem (NFC) (PR #140424)

2025-05-21 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/140424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reduce max-children-count default to readable size (PR #139826)

2025-05-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/139826 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reduce max-children-count default to readable size (PR #139826)

2025-05-19 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/139826 >From 52c587ef84366a0c2a01256f71f1f2404467e3a8 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 8 May 2025 17:24:19 -0700 Subject: [PATCH 1/2] [lldb] Reduce max-children-count default to readable size Cha

[Lldb-commits] [lldb] [lldb] Add templated CompilerType::GetTypeSystem (NFC) (PR #140424)

2025-05-17 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/140424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add templated CompilerType::GetTypeSystem (NFC) (PR #140424)

2025-05-17 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/140424 None >From f00b0d192a921c6cec369d2d674b617a9ca1f706 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 16 May 2025 11:47:08 -0700 Subject: [PATCH] [lldb] Add templated CompilerType::GetTypeSystem (NFC) ---

[Lldb-commits] [lldb] [lldb] Fix ForwardListFrontEnd::CalculateNumChildren (PR #139805)

2025-05-13 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/139805 Fixes the calculation of the number of children for `std::forward_list` to no longer be capped. The calculation was capped by the value of `target.max-children-count`. This resulted in at least the followin

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-01 Thread Dave Lee via lldb-commits
kastiglione wrote: > Similarly, if you're in a frame where we can detect the language, maybe you > step into a frame you don't have debug info or symbols for. @bulbazord note that knowing the language of a frame does not depend on debug info, a symbol alone can be used to identify its languag

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From 776dc6da5c5900adb97bb89a9ed7a60478bf05e1 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 01/10] [lldb] Expose language plugin commands based based on lang

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-01 Thread Dave Lee via lldb-commits
kastiglione wrote: @jimingham I've added 2f91d3f which includes a long help for `language` to describe this behavior. I'll look into making `help` show the output you suggest. https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From 776dc6da5c5900adb97bb89a9ed7a60478bf05e1 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/9] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From 776dc6da5c5900adb97bb89a9ed7a60478bf05e1 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/8] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-01 Thread Dave Lee via lldb-commits
kastiglione wrote: I have not implemented the mentioned idea of using the top frame that has a known language. I think that situation would be rare, and makes this more magic. I think it's better to wait for feedback then to add implement something that users may not need/want. https://github

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sa

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-01 Thread Dave Lee via lldb-commits
kastiglione wrote: I've updated the implementation to not resolve to a language specific command whenever the entered command prefix matches a top level command. In other words, given a python command `abcdef` and a language specific command `abc`, then running `abc` will resolve to the python

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From 94caf0b58ace58ae5159e3819f776ad6b2988329 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/7] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From 94caf0b58ace58ae5159e3819f776ad6b2988329 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/6] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-01 Thread Dave Lee via lldb-commits
@@ -1018,6 +1018,26 @@ CommandInterpreter::VerifyUserMultiwordCmdPath(Args &path, bool leaf_is_command, return cur_as_multi; } +CommandObjectSP CommandInterpreter::GetFrameLanguageCommand() const { + if (auto frame_sp = GetExecutionContext().GetFrameSP()) { +auto frame

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-01 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From 94caf0b58ace58ae5159e3819f776ad6b2988329 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/7] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

2025-04-28 Thread Dave Lee via lldb-commits
kastiglione wrote: @JDevlieghere Does lit run all tests, even those that have duplicate names? If so, it seems like a step back to break lit from doing what it's capable of doing. This code contains the below comment that proposes eliminating the test name uniqueness constraint. If that is th

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

2025-04-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

2025-04-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/137681 >From bbf439758fd2b98389c6df81dd9bede24c59a029 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 28 Apr 2025 10:55:55 -0700 Subject: [PATCH] [lldb] Make duplicate test names a conditional exception When tw

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

2025-04-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/137681 >From bbf439758fd2b98389c6df81dd9bede24c59a029 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 28 Apr 2025 10:55:55 -0700 Subject: [PATCH 1/2] [lldb] Make duplicate test names a conditional exception Whe

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

2025-04-28 Thread Dave Lee via lldb-commits
kastiglione wrote: This came up last week, where a duplicated test name (https://github.com/llvm/llvm-project/pull/137262) prevented me from running my own tests with `lldb-dotest -p `. https://github.com/llvm/llvm-project/pull/137681 ___ lldb-commit

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

2025-04-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/137681 When two or more tests have the same name, dotest will raise an exception. However, when using a test name pattern (`-p`) which does not match the duplicate test names, there seems to be no reason to preven

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-25 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/137262 >From 83d011739ba3a03058474922428c341b9333056f Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 24 Apr 2025 15:53:00 -0700 Subject: [PATCH 1/2] [lldb] Rename reverse-continue/TestReverseContinueNotSupport

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
kastiglione wrote: I'll do that too (for what it's worth that name doesn't matter to the test system). https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
kastiglione wrote: cc @rocallahan (for some reason I can't add you as a reviewer) https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/137262 None >From 83d011739ba3a03058474922428c341b9333056f Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 24 Apr 2025 15:53:00 -0700 Subject: [PATCH] [lldb] Rename reverse-continue/TestReverseContinueNotSuppo

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From daf394bf76b5fd627f77aee6e451e7d706d26916 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/6] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From daf394bf76b5fd627f77aee6e451e7d706d26916 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/5] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [lldb] Fix logic error in AppleObjCTypeEncodingParser (PR #137067)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/137067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
kastiglione wrote: > maybe you step into a frame you don't have debug info or symbols for @bulbazord one potential solution to this is to use the top-most stack frame for which a language is known. https://github.com/llvm/llvm-project/pull/136766 ___

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
kastiglione wrote: > Many of our users are opinionated about how commands should work ("This > breaks my python scripts!" @bulbazord I agree. I don't think this should break anything. https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
kastiglione wrote: > What if a language plugin adds a command that conflicts with a top-level > command? @bulbazord the top-level command will be used. This is a fallback, for when no such top-level command exists. If a language plugin adds a subcommand that conflicts with a top-level command

[Lldb-commits] [lldb] [lldb] Fix logic error in AppleObjCTypeEncodingParser (PR #137067)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From daf394bf76b5fd627f77aee6e451e7d706d26916 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/4] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [lldb] Minor improvements to AddNamesMatchingPartialString (NFC) (PR #136760)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/136760 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix typo in tagged-pointer syntax string (NFC) (PR #137069)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/137069 None >From d4c5962b145e3d8c980159b0adca55d2bad55608 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 23 Apr 2025 14:59:03 -0700 Subject: [PATCH] [lldb] Fix typo in tagged-pointer syntax string (NFC) ---

[Lldb-commits] [lldb] [lldb] Fix typo in tagged-pointer syntax string (NFC) (PR #137069)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/137069 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   3   4   5   6   7   8   >