[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

davezarzycki added a comment. If you want to test more, please let me know and I can test them on my Fedora box. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110962/new/ https://reviews.llvm.org/D110962

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

davezarzycki added a comment. 79bf032fe10546fd1d6e14c5ac8905f25c2b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110962/new/ https://reviews.llvm.org/D110962

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

davezarzycki added a comment. "the buildbot"? There are many. I'd be surprised if this weren't failing on at least one of them. It doesn't seem like subtle terminfo behavior is essential to this test. Can we please trim down the adjustments to only changing the speed? For example: diff

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

davezarzycki added a comment. errno == 22 (EINVAL) The FD in question is 3. Here is the output from `lsof`: HostTests 80108 dave 3u CHR5,2 0t0 231 /dev/ptmx Can we/I please revert this for now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

davezarzycki added a comment. This is failing on my Fedora 34 (x86-64) box. Is this expected? FAIL: lldb-unit :: Host/./HostTests/TerminalTest.SaveRestoreRAII (78548 of 79402) TEST 'lldb-unit :: Host/./HostTests/TerminalTest.SaveRestoreRAII' FAILED

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. In D98179#2689079 , @lebedev.ri wrote: > In D98179#2689075 , @mstorsjo wrote: > >> Something related to the time recording seems to fail intermittently on >> buildbots:

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

davezarzycki added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:69 + + StructuredData::ObjectSP object_sp = GetInterface().CreatePluginObject( + m_launch_info.GetClassName().c_str(), target_sp, mib wrote: >

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

davezarzycki added a comment. In D95713#2647548 , @teemperor wrote: > The tests are failing because Dave's bot is running without enabled Python. > The same is true for the Windows bot. Putting the plugin behind `#ifdef > LLDB_ENABLE_PYTHON` should fix

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

davezarzycki added a comment. I've reverted this. If you need help debugging this, please let me know. Also, as a reminder, please see the attached build log from earlier in the conversation. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

davezarzycki added a comment. An auto-bisecting cron job has identified this change as a regression on Fedora 33 (x86-64). Can we get a quick fix or revert this? Here is the build output: https://znu.io/dd391e1ef762d79f86112dc2480a89c9be066ce1-bisect.txt Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. In D98179#2639554 , @nlopes wrote: > In D98179#2639491 , @davezarzycki > wrote: > >> In D98179#2639476 , @nlopes wrote: >> >>> Why are

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. In D98179#2639476 , @nlopes wrote: > I'm talking about sorting just the summary of failed tests, not the whole > output. We need the whole -vv output, but that can be out of order. > > Why are timeouts important? Our use

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. In D98179#2639483 , @lebedev.ri wrote: > In D98179#2639476 , @nlopes wrote: > >> I'm talking about sorting just the summary of failed tests, not the whole >> output. We need the whole

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. In D98179#2638837 , @nlopes wrote: > In D98179#2638801 , @mehdi_amini > wrote: > >>> Can we revert to the previous behavior please? The current behavior is not >>> user friendly.

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. In D98179#2638882 , @mehdi_amini wrote: >> No, I'm running lit and dumping into a file. sorting is not as easy as >> piping through sort, as I'm running with -vv (required). > > Since tests run in parallel, don't you already

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. Ah yes, of course. I've marked that test as unavailable on Window for now: 61ca706461c5e1edc18526c9ddc3250fe074ed94 In the long run, We'll need to figure out a way for people to commit

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. I've run out of time for today, but for the record, I think we should use slash as the canonical separator for the timing data file. The actual separator doesn't matter because these strings are never used as paths, just as keys into a dictionary. (Therefore any

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. Try: 49d0e115d5df40aa89339f4ace7a8dee378c03bb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98179/new/ https://reviews.llvm.org/D98179

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. Said differently, the Unix side seems to always run the lit tests from a fresh/clean setup, even for incremental builds. If Windows tests lit differently then ya, things will blow up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. That implies a different testing environment. How different is the Windows testing environment compared to Unix? Do you specifically have a custom testing setup? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d297f90649d: [lit] Sort test start times based on prior test timing data (authored by davezarzycki). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki updated this revision to Diff 330907. davezarzycki added a comment. Removed the commented only-failures and fixed a nit before committing. Thanks everybody for the various rounds of feedback. I'm quite happy with how this turned out. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. Might somebody be willing to sign off on this change (this week or next)? I'd like to cherry-pick it to Swift's LLVM branch. Thanks for all the feedback so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki updated this revision to Diff 330200. davezarzycki added a comment. I fixed the call to split as requested. Being unfamiliar with python, I didn't know that it supported keyword arguments / parameter labels. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki updated this revision to Diff 330194. davezarzycki added a comment. I've made all of the requested changes to date. Two notes: 1. One cannot simply omit the first argument to `split()` if the second is provided. As I just learned, python will complain. I switched the first

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki updated this revision to Diff 329277. davezarzycki added a comment. Herald added subscribers: libcxx-commits, lldb-commits, arichardson. Herald added projects: LLDB, libc++. Herald added a reviewer: libc++. I believe I've addressed all of the feedback to date. I've also fixed the

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki updated this revision to Diff 329659. davezarzycki added a comment. I renamed the `file` variable as requested. I also found a workaround to the performance problem I referred to earlier. Now no new parameter is required during test discovery and therefore the diff is both simpler

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki removed 1 blocking reviewer(s): libc++. davezarzycki added a comment. I'm downgrading libcxx as a reviewer to non-blocking because the latest patch no longer requires changes to their project. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki updated this revision to Diff 329613. davezarzycki added a comment. I believe I have addressed all of the feedback to date. For people that care about easily identifying the failures from the previous testing run, that is now encoded via the sign of the test time (please remember

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

davezarzycki added a comment. Hi Jim, this change broke my Fedora 33 Linux (x86) box. Do you think we can get a quick fix or revert this? FAIL: lldb-shell :: Commands/command-stop-hook-output.test (69796 of 70913) TEST 'lldb-shell ::

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

davezarzycki added a comment. And just to be clear, the source directory in my setup is in the home directory. My cron job / "bot" build just builds in /tmp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86497/new/ https://reviews.llvm.org/D86497

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

davezarzycki added a comment. Line 18 fails: `%lldb -x -b --replay %t.repro >> %t.txt 2>&1` error: reproducer replay failed: warning: home directory '/home/dave' not in VFS I tried rebuilding in my home directory as opposed to /tmp and the error went away. Did you try building outside of

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

davezarzycki added a comment. Hello. I have an auto-bisecting multi-stage bot that has identified this change as breaking release (without assertions) testing on Fedora 33 x86-64. Can we get a quick fix or revert this change for now? FAIL: lldb-shell ::

[Lldb-commits] [PATCH] D82259: Deprecate error prone temporary directory APIs

davezarzycki abandoned this revision. davezarzycki added a comment. Now that my core concern is addressed (moving clang's default module cache out of /tmp), I don't have the time to push for this deprecation. Sorry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D82259: Deprecate error prone temporary directory APIs

davezarzycki updated this revision to Diff 272661. davezarzycki added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Moved clang specific changes to: https://reviews.llvm.org/D82362 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

davezarzycki added a comment. Great. See: r371596 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67230/new/ https://reviews.llvm.org/D67230 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

davezarzycki added a comment. This code is trying too hard and failing. Either the result of gethostname() is canonical or it is not. If it is not, then trying to canonicalize it is – for various reasons – a lost cause. For example, a given machine might have multiple network interfaces with

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

davezarzycki added a comment. Can we cherry-pick this into a release branch? Skylake (and newer) CPUs are far from rare these days, especially on cloud hosting providers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59991/new/ https://reviews.llvm.org/D59991

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

davezarzycki accepted this revision. davezarzycki added a comment. I've verified that this fixes my Skylake-SP (Xeon 8168) workstation. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59991/new/ https://reviews.llvm.org/D59991 ___