https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/142193
See #138084 for details.
>From 72e166aa5f1d851cfd0cc972e761536eed14679a Mon Sep 17 00:00:00 2001
From: Dmitry Vassiliev
Date: Fri, 30 May 2025 22:19:28 +0400
Subject: [PATCH] [lldb] Disable TestReverseContinue
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/142192
See #138083 for details.
>From 99e4418063a869e0d9bdec784e62c5ebcb569510 Mon Sep 17 00:00:00 2001
From: Dmitry Vassiliev
Date: Fri, 30 May 2025 20:33:49 +0400
Subject: [PATCH] [lldb] Disable TestConsecutiveBrea
slydiman wrote:
The following buildbots are broken
https://lab.llvm.org/buildbot/#/builders/197/builds/5950
```
ld.lld: error: unable to find library -lobjc
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile.rules:530: a.out] Error 1
```
https://l
slydiman wrote:
https://lab.llvm.org/buildbot/#/builders/197/builds/5542 is broken.
Probably you must use `XFAIL: target-windows` instead of `XFAIL:
system-windows`.
https://github.com/llvm/llvm-project/pull/140588
___
lldb-commits mailing list
lldb-
slydiman wrote:
The following buildbots are broken by this patch too
https://lab.llvm.org/buildbot/#/builders/195/builds/8715
https://lab.llvm.org/buildbot/#/builders/197/builds/5054
Please fix ASAP.
https://github.com/llvm/llvm-project/pull/137904
___
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/138940
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/138940
See #138085 for details.
https://lab.llvm.org/buildbot/#/builders/59/builds/16937
https://lab.llvm.org/buildbot/#/builders/59/builds/17224
Rate limit ยท GitHub
body {
https://github.com/slydiman approved this pull request.
I have tested the failed Host.LaunchProcessDuplicatesHandle test on the setup
similar to
[lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197). It is
fixed now.
https://github.com/llvm/llvm-project/pull/138896
___
https://github.com/slydiman approved this pull request.
Ok, let's see how it flies in the real world.
https://github.com/llvm/llvm-project/pull/137978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/137978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -122,8 +123,14 @@ struct ForkLaunchInfo {
ExitWithError(error_fd, "close");
break;
case FileAction::eFileActionDuplicate:
- if (dup2(action.fd, action.arg) == -1)
-ExitWithError(error_fd, "dup2");
+ if (action.fd != action.arg) {
-
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const
FileSpec &prog,
self_args.AppendArgument(llvm::StringRef("platform"));
self_args.AppendArgument(llvm::StringRef("--child-platform-fd"));
self_args.AppendArgument(llvm::to_string(shared_socket.Ge
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/138263
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/138263
See #138085 for details.
>From b35ad88aa12a000c13a4cc854fd55ba59c2e8535 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 2 May 2025 16:48:21 +0400
Subject: [PATCH] [lldb][test] Disable flaky TestLldbG
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/137978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/137978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const
FileSpec &prog,
self_args.AppendArgument(llvm::StringRef("platform"));
self_args.AppendArgument(llvm::StringRef("--child-platform-fd"));
self_args.AppendArgument(llvm::to_string(shared_socket.Ge
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const
FileSpec &prog,
self_args.AppendArgument(llvm::StringRef("platform"));
self_args.AppendArgument(llvm::StringRef("--child-platform-fd"));
self_args.AppendArgument(llvm::to_string(shared_socket.Ge
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/137978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const
FileSpec &prog,
self_args.AppendArgument(llvm::StringRef("platform"));
self_args.AppendArgument(llvm::StringRef("--child-platform-fd"));
self_args.AppendArgument(llvm::to_string(shared_socket.Ge
slydiman wrote:
https://github.com/llvm/llvm-project/commit/e6f7e3418eb8519d6cf12da8576ad75aac6b307b
broke
[lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197/builds/4542)
again.
Note the special case Windows host and non-Windows target.
Note the buildbot cannot report the pro
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/137415
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Duplicate of #137414.
https://github.com/llvm/llvm-project/pull/137415
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/137415
The buildbot lldb-remote-linux-win is broken after #136466. This patch should
make it green.
>From 53d84b5113c4d7398694a0e0ff7e07f2cc77451b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Sat, 26 Apr 202
slydiman wrote:
Note DomainSocket is not supported on Windows, so removing the following code
broke the Windows build!
```
#if LLDB_ENABLE_POSIX
socket = new DomainSocket(sockfd, /*should_close=*/true);
#else
WithColor::error() << "lldb-platform child: Unix domain sockets are not "
slydiman wrote:
https://lab.llvm.org/buildbot/#/builders/141 is also broken.
https://github.com/llvm/llvm-project/pull/131836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
https://lab.llvm.org/buildbot/#/builders/197/builds/4470 is still broken
```
FAILED:
tools/lldb/source/Plugins/ExpressionParser/Clang/CMakeFiles/lldbPluginExpressionParserClang.dir/ClangModulesDeclVendor.cpp.obj
ccache
C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1441~1.34
slydiman wrote:
The buildbot
[lldb-remote-linux-ubuntu](https://lab.llvm.org/buildbot/#/builders/195/builds/8132)
is broken too
```
FAILED: tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Statistics.cpp.o
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG
-D_GLIBCXX_ASSERTIONS -D
https://github.com/slydiman approved this pull request.
Thanks
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Still failed
https://lab.llvm.org/buildbot/#/builders/195/builds/8109
https://lab.llvm.org/buildbot/#/builders/197/builds/4470
https://github.com/llvm/llvm-project/pull/131836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
slydiman wrote:
> Feel free to ping on this PR if any issues pop up
https://lab.llvm.org/buildbot/#/builders/195/builds/8106
```
14.009 [1092/66/4173] Building CXX object
tools/lldb/source/Core/CMakeFiles/lldbCore.dir/DemangledNameInfo.cpp.o
FAILED: tools/lldb/source/Core/CMakeFiles/lldbCore.di
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/137267
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Ok, thanks.
Then I will close this PR.
https://github.com/llvm/llvm-project/pull/137267
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/137267
None
>From e14614a7ded95fbe9988739ed9d35260f0541e86 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 25 Apr 2025 02:30:03 +0400
Subject: [PATCH] [lldb] Add InstructionARM64 to lldb-server
---
lldb/t
@@ -455,35 +455,29 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
- Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
-
+ Log *log = GetLog(LLDBLog::Platform);
@@ -182,3 +191,22 @@ std::vector
DomainSocket::GetListeningConnectionURI() const {
return {llvm::formatv("unix-connect://{0}", addr.sun_path)};
}
+
+Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close,
+ Status &error) {
+#ifdef _
@@ -455,35 +455,29 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
- Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
slydiman wrote:
There is a p
slydiman wrote:
Don't forget to update the protocol passed to the
GDBRemoteCommunicationServerPlatform constructor.
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
slydiman wrote:
I like it.
I would suggest to move domain/abstract socket checking to a static helper,
something like
```
Socket* DomainSocket::Create(NativeSocket sockfd, bool should_close) {
#ifdef __linux__
// Check if fd represents domain socket or abstract socket.
if (/*abstract*/)
slydiman wrote:
@ashgti Did you test #130169 on Windows?
This patch will fix the building, but I'm not sure that it will work on Windows
considering this:
```
// TODO: On Windows this should be a HANDLE, and wait should use
// WaitForMultipleObjects
typedef int WaitableHandle;
IOObject::Waitab
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/135033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Ping
https://github.com/llvm/llvm-project/pull/135033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman approved this pull request.
LGTM, thanks.
Currently `GDBRemoteCommunication::ListenThread()` to get the bound port is
weird.
https://github.com/llvm/llvm-project/pull/135342
___
lldb-commits mailing list
lldb-commits@lists.
slydiman wrote:
Maybe rename `CPlusPlusLanguage::CPPMethodName` to
`CPlusPlusLanguage::CxxMethodName`?
Any preferences?
https://github.com/llvm/llvm-project/pull/132274
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/132274
>From 40d69ed7386c3f8169b324bd3b7591a46e34ff4d Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 20 Mar 2025 21:50:51 +0400
Subject: [PATCH 1/3] [LLDB] Refactored CPlusPlusLanguage::MethodName to break
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/132274
>From 40d69ed7386c3f8169b324bd3b7591a46e34ff4d Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 20 Mar 2025 21:50:51 +0400
Subject: [PATCH 1/3] [LLDB] Refactored CPlusPlusLanguage::MethodName to break
slydiman wrote:
I'm looking on it.
https://github.com/llvm/llvm-project/pull/132274
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/135033
>From 5e365a86734b33f4ce31eb9199b88a4a772b5342 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 9 Apr 2025 17:06:49 +0400
Subject: [PATCH] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to
br
slydiman wrote:
Note `Language::ForEach()` gives the following list:
```
cplusplus(eLanguageTypeC_plus_plus)
objc(eLanguageTypeObjC)
objcplusplus(eLanguageTypeObjC_plus_plus)
cplusplus(eLanguageTypeC_plus_plus_03)
cplusplus(eLanguageTypeC_plus_plus_11)
cplusplus(eLanguageTypeC_plus_plus_14)
cplus
https://github.com/slydiman ready_for_review
https://github.com/llvm/llvm-project/pull/135033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
It seems the sorting of language plug-ins in CMakeLists.txt is not enough. I
tested #132274 locally and it passed, but failed on the buildbot
[lldb-aarch64-windows](https://lab.llvm.org/buildbot/#/builders/141).
I have updated LookupInfo::LookupInfo() close to the current code
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/135033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman converted_to_draft
https://github.com/llvm/llvm-project/pull/135033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/135033
>From d89b0242152002161b90d29e275a68e0e3f51dfe Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 9 Apr 2025 17:06:49 +0400
Subject: [PATCH] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to
br
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/135033
>From 75c47b9b6ff38150ee7ddd47c9b0be05681bc499 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 9 Apr 2025 17:06:49 +0400
Subject: [PATCH] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to
br
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/135033
The original PR is #132274.
>From 08b6d2b832d3f40ed56f05e7e7da26d6f3f0a8cc Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 9 Apr 2025 17:06:49 +0400
Subject: [PATCH] [LLDB] Reapply refactored CPlusPl
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/132274
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -222,6 +222,21 @@ ObjCLanguage::GetMethodNameVariants(ConstString
method_name) const {
return variant_names;
}
+std::pair
+ObjCLanguage::GetFunctionNameInfo(ConstString name) const {
+ FunctionNameType func_name_type = eFunctionNameTypeNone;
+
+ if (ObjCLanguage::IsPos
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/134383
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/132274
>From 40d69ed7386c3f8169b324bd3b7591a46e34ff4d Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 20 Mar 2025 21:50:51 +0400
Subject: [PATCH 1/2] [LLDB] Refactored CPlusPlusLanguage::MethodName to break
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/134383
>From 590d5b47b9f98a8e5f19945334b2a1c34248f9d8 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 4 Apr 2025 17:49:07 +0400
Subject: [PATCH 1/3] [LLDB][NFC] Remove Debugger dependency in
SystemLifetimeM
slydiman wrote:
@labath
> The only thing which makes that difficult is that the callback is a lambda
> defined in SBDebugger.cpp. However, there's no reason it has to be defined
> there -- the lambda itself doesn't depend on anything, and it could easily be
> moved to SystemInitializerFull.c
slydiman wrote:
> and that's why I am very reluctant to approve #132274
#132274 is most important now because it gives the significant effect.
I have refactored `CPlusPlusLanguage::MethodName` and don't just splite a CU
now. RichManglingContext.cpp uses auto
`Language::FindPlugin(eLanguageTyp
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/132274
>From 40d69ed7386c3f8169b324bd3b7591a46e34ff4d Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 20 Mar 2025 21:50:51 +0400
Subject: [PATCH] [LLDB] Refactored CPlusPlusLanguage::MethodName to break
lld
slydiman wrote:
Disabling asserts locally solved the problem with LLVM_DUMP_METHOD. This patch
works again.
I have refactored CPlusPlusLanguage::MethodName and RichManglingContext.
I got the lldb-server size 6MB. Please review. Thanks
https://github.com/llvm/llvm-project/pull/132274
__
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/132274
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/132274
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/132274
>From a4d62ca1dfaca8eb29ce7d2809c28137d22416b9 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 20 Mar 2025 21:50:51 +0400
Subject: [PATCH 1/2] [LLDB] Refactor Module::LookupInfo constructor and move
slydiman wrote:
I have updated this patch. But it seems we can keep Language.h, ObjCLanguage.*
and Module.cpp untouched, because `a proper way` is useless for our purpose.
`CPlusPlusLanguage::MethodName`, `CPlusPlusLanguage::IsCPPMangledName` and
`CPlusPlusLanguage::ExtractContextAndIdentifier
slydiman wrote:
> It seems like we should address this issue by first fixing the existing
> layering violations, then introducing more layering for `lldb-server` so that
> we bring the granularity to the library level, not the individual object file
> (i.e. source file) level which is too gran
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/134383
>From 590d5b47b9f98a8e5f19945334b2a1c34248f9d8 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 4 Apr 2025 17:49:07 +0400
Subject: [PATCH 1/2] [LLDB][NFC] Remove Debugger dependency in
SystemLifetimeM
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/134383
>From 590d5b47b9f98a8e5f19945334b2a1c34248f9d8 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 4 Apr 2025 17:49:07 +0400
Subject: [PATCH 1/2] [LLDB][NFC] Remove Debugger dependency in
SystemLifetimeM
slydiman wrote:
Note currently I see the following Debugger dependencies in lldb-server:
```
std::__1::__throw_bad_weak_ptr[abi:nn21](): referenced by Section.cpp
lldb_private::Section::GetLoadBaseAddress(lldb_private::Target*) const
lldb_private::Debugger::GetCurrentProgressReport() const:
slydiman wrote:
@labath
> I'm not sure what has changed. This code has been here since 2022, so I
> suspect it's one of those "perfectly reasonable" changes I mentioned earlier.
https://github.com/llvm/llvm-project/commit/d2a7a249c567cb170f22fe6e932896f9298b581d
Changed the definition of LLV
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/134383
>From 590d5b47b9f98a8e5f19945334b2a1c34248f9d8 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 4 Apr 2025 17:49:07 +0400
Subject: [PATCH] [LLDB][NFC] Remove Debugger dependency in
SystemLifetimeManag
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/134383
>From a6ad0039015bdd3d387e8a4f0762961cdf8db50f Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 4 Apr 2025 17:49:07 +0400
Subject: [PATCH] [LLDB][NFC] Remove Debugger dependency in
SystemLifetimeManag
slydiman wrote:
> I'm actually very much opposed to that. lldb-server not need/use a Debugger,
> nor a thread pool nor any IO handling present in that file. I wouldn't want
> to create a Debugger "plugin" for the sake of lldb-server. It should be cut
> off above that.
#134383
https://github.
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/134383
It reduces the memory usage in lldb-server.
Later I will try to remove the rest Debugger dependencies to reduce lldb-server
size.
>From 629601c6c1e974e7981d2e61583c69540bf1cd5c Mon Sep 17 00:00:00 2001
From: D
slydiman wrote:
> I was referring more to the other items on the list. I assumed, it seems
> incorrectly, that Alex's patch would fix the dependency in the mangler. It
> seems like that part still needs to be pluginized, somehow.
Note Module.cpp still uses `CPlusPlusLanguage::MethodName` in
`
slydiman wrote:
> The question here is who is using those files and why. These are all plugins,
> so they shouldn't be pulled in unless they are `Initialized`.
RichManglingContext.cpp is not a plugin and it uses `m_cxx_method_parser = new
CPlusPlusLanguage::MethodName(demangled);`, including c
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/132274
>From a4d62ca1dfaca8eb29ce7d2809c28137d22416b9 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 20 Mar 2025 21:50:51 +0400
Subject: [PATCH] [LLDB] Refactor Module::LookupInfo constructor and move out
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/132274
>From ba94c683a3d652a14a13313653bc70d5430e7b83 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 20 Mar 2025 21:50:51 +0400
Subject: [PATCH] [LLDB] Refactor Module::LookupInfo constructor and move out
slydiman wrote:
`lldb-shell::ProcessMachCoreArch.test` is flake.
But the following tests are broken by this commit (segmentation fault):
1. `lldb-api::TestMiniDump.py`:
```
2 _lldb.cpython-312-x86_64-linux-gnu.so 0x751c11a3cd14
3 libc.so.6 0x751c18845330
4
slydiman wrote:
@bulbazord, Do you have the opportunity to complete the patch
https://github.com/swiftlang/llvm-project/pull/3240 (sort language plug-ins in
cmake or hardcode the sorted list of language plug-ins)? I can try to complete
it, if you don't mind.
https://github.com/llvm/llvm-proje
slydiman wrote:
@labath
> LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu`
[lldb-remote-linux-ubuntu](https://lab.llvm.org/buildbot/#/builders/195/builds/7046)
is broken too.
https://github.com/llvm/llvm-project/pull/133247
___
slydiman wrote:
> I think there's something else happening here.
Ok, it seems the dependency chain is longer:
Module.cpp -> CPlusPlusLanguage::ExtractContextAndIdentifier() ->
CPlusPlusLanguage.cpp ->
BlockPointer.cpp ->
TypeSystemClang.cpp - >
ClangUserExpression.cpp ->
ClangExpressionParser
slydiman wrote:
@labath
The repro above shows that CPlusPlusLanguage::GetHardcodedSummaries() causes to
link TypeSystemClang and other dependencies. But --print-gc-sections and
`llvm-objdump --all-headers --demangle lldb-server` shows that
GetHardcodedSummaries is missing in the final binary
slydiman wrote:
> Okay, and what are those conditions?
I don't know. Probably code fragmentation within CU or number of references
makes the linker to link the entire CU.
> someone's compiler/linker
Note it is mainline clang/lld.
Moving all code used by Module.cpp to a separated module ensur
@@ -38,7 +39,7 @@ enum DWARFProducer {
eProducerOther
};
-class DWARFUnit : public UserID {
+class DWARFUnit : public UserID, public DWARFExpression::Delegate {
slydiman wrote:
Done.
https://github.com/llvm/llvm-project/pull/131645
slydiman wrote:
> Global variables are
> [banned](https://llvm.org/docs/CodingStandards.html#do-not-use-static-constructors)
> by the coding standards, but I wouldn't be surprised if there were still
> some around that cause this.
TypeSystemClang.cpp contains global `char TypeSystemClang::ID;
slydiman wrote:
> I don't see a reason for an function-local static to be a gc root.
I don't know how to check it. lld has parameters `--why-extract=` and
`--print-gc-sections`, but they are useless for this investigation.
Maybe lambdas become gc roots?
Anyway, how will this affect the accept
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/133049
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
> Should this also change the interface of DWAFExpressionList?
Yes, I will prepare the patch. Thanks
https://github.com/llvm/llvm-project/pull/131645
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
slydiman wrote:
Note `-ffunction-sections -fdata-sections` are added in HandleLLVMOptions.cmake
and `-Wl,--gc-sections` is added in AddLLVM.cmake by default. But unused
functions will be kept anyway if they contain linker gc roots.
A lot of functions in CPlusPlusLanguage.cpp contain static va
slydiman wrote:
@bulbazord
> swiftlang#3240
Looks good.
> SwiftLanguageRuntime::MethodName::Parse(). Specifically, as it parses a name,
> there are some codepaths that cause it to think some names are valid swift
> method names.
It seems one solution might be to sort language plugins.
But
slydiman wrote:
> I'm similarly confused about how moving these method definitions into a
> separate CU makes a difference.
Please note Module.cpp uses only few functions which have no dependencies.
After this patch the new CU CPlusPlusLanguageMethod.cpp with only necessary
functions is linke
slydiman wrote:
@labath What do you suggest for a solution? Reducing lldb-server size from 17MB
to 8MB is the significant reason to do something.
https://github.com/llvm/llvm-project/pull/132274
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
@@ -40,6 +35,31 @@ class DWARFUnit;
/// location expression or a location list and interprets it.
class DWARFExpression {
public:
+ class Delegate {
+ public:
+Delegate() = default;
+virtual ~Delegate() = default;
+
+virtual uint16_t GetVersion() const = 0;
+v
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/131645
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -37,7 +36,6 @@
#include "lldb/Target/StackID.h"
#include "lldb/Target/Target.h"
#include "lldb/Target/Thread.h"
-#include "llvm/DebugInfo/DWARF/DWARFDebugLoc.h"
#include "llvm/DebugInfo/DWARF/DWARFExpression.h"
#include "Plugins/SymbolFile/DWARF/DWARFUnit.h"
1 - 100 of 609 matches
Mail list logo
