[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen added a comment. I do not have commit access. Can someone land the change for me? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen marked 3 inline comments as done. erikchen added inline comments. Comment at: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp:6 +// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t +// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck %s +// CHECK:

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen updated this revision to Diff 213962. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 Files: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp Index:

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen marked an inline comment as done. erikchen added inline comments. Comment at: lldb/lit/SymbolFile/DWARF/deterministic-build.cpp:6 +// RUN: ZERO_AR_DATE=1 %clang %t.o -g -o %t +// RUN: %lldb %t -s %S/Inputs/deterministic-build.lldbinit -o exit | FileCheck %s +// CHECK:

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen updated this revision to Diff 213960. erikchen marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 Files: lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen updated this revision to Diff 213758. erikchen added a comment. Added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 Files: lldb/lit/SymbolFile/DWARF/Inputs/deterministic-build.lldbinit

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

erikchen added a comment. Okay, this is ready for another round of review when you have time. Thanks :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65826/new/ https://reviews.llvm.org/D65826 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries to lldb.

erikchen created this revision. erikchen added a reviewer: rnk. Herald added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, abidh, mgrang. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. When ld64 links a binary deterministically using the flag ZERO_AR_DATE,