[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159313/new/ https://reviews.llvm.org/D159313

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159011/new/ https://reviews.llvm.org/D159011 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

fdeazeve added inline comments. Comment at: lldb/include/lldb/Utility/StructuredData.h:436 auto array_sp = std::make_shared(); - collection::const_iterator iter; - for (iter = m_dict.begin(); iter != m_dict.end(); ++iter) { + for (auto iter =

[Lldb-commits] [PATCH] D159150: [lldb][NFCI] Replace bespoke iterator check with std::next

fdeazeve accepted this revision. fdeazeve added a comment. Nice catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159150/new/ https://reviews.llvm.org/D159150 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D152870: [lldb][NFCI] Remove StructuredData::Array::GetItemAtIndexAsString overloads with ConstString

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152870/new/ https://reviews.llvm.org/D152870

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

fdeazeve added a comment. > I decided to make it a global object to guarantee its lifetime independent of > any `PlatformRemoteGDBServer` instance. I don't mind wrapping it in a > concurrent structure to guarantee thread safety though. At that point we would pretty much be re-implementing the

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

fdeazeve added a comment. I am slightly wary of making this a global set without any kind of thread safe mechanism, as I (naively, not really knowing how this class is used) would expect us to be able to instantiate multiple servers and have them be accessed concurrently. As such, it makes

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

fdeazeve added inline comments. Comment at: lldb/source/Core/Mangled.cpp:61 + // Swift's older style of mangling used "_T" as a mangling prefix. This can + // lead to false positives with other symbols that just so happen to start JDevlieghere wrote: >

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158023/new/ https://reviews.llvm.org/D158023 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Good catch :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/new/ https://reviews.llvm.org/D158043

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

fdeazeve added inline comments. Comment at: lldb/include/lldb/Core/Module.h:126 Module( - const FileSpec _spec, const ArchSpec , - const ConstString *object_name = nullptr, + const FileSpec _spec, const ArchSpec , ConstString object_name, lldb::offset_t

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

fdeazeve added a comment. In D158023#4590502 , @bulbazord wrote: > I think the categories you've set are the same ones I would have created. May > I suggest renaming `Extending LLDB` to `Scripting LLDB` or something similar? > I think "Extending" and

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve added a comment. Hi @clayborg, just wanted to make sure this doesn't fall off your radar :) This fixes all outstanding DWARF 5 issues with Debug Maps, so it would be cool if we could get this in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b19d13fde6e: [lldb] Make frame var --regex always search globals (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155334/new/

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

fdeazeve updated this revision to Diff 542122. fdeazeve added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155334/new/ https://reviews.llvm.org/D155334 Files: lldb/include/lldb/Symbol/VariableList.h

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

fdeazeve updated this revision to Diff 541987. fdeazeve added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155334/new/ https://reviews.llvm.org/D155334 Files: lldb/include/lldb/Symbol/VariableList.h

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve updated this revision to Diff 541986. fdeazeve added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155198/new/ https://reviews.llvm.org/D155198 Files: lldb/source/Expression/DWARFExpression.cpp

[Lldb-commits] [PATCH] D155197: [lldb][NFC] Refactor test to enable subsequent reuse

This revision was automatically updated to reflect the committed changes. Closed by commit rG00c60496775b: [lldb][NFC] Refactor test to enable subsequent reuse (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155197/new/

[Lldb-commits] [PATCH] D155332: [lldb][NFC] Factor out CommandObject code filtering results based on scope

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bc97a3ee4f4: [lldb][NFC] Factor out CommandObject code filtering results based on scope (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently frame var --regex sometimes searches globals, sometimes it doesn't. This happens because

[Lldb-commits] [PATCH] D155332: [lldb][NFC] Factor out CommandObject code filtering results based on scope

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We will need this code in a subsequent commit. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155332

[Lldb-commits] [PATCH] D155178: [Support] Move StringExtras.h include from Error.h to Error.cpp (part 6)

fdeazeve added a comment. In D155178#4496936 , @IncludeGuardian wrote: > @MaskRay seems like `ninja` on its own after preparing `lldb` isn't enough to > build tests. I've now built llvm, clang, flang, bolt, lldb, + tests - I'm > hoping that this is it

[Lldb-commits] [PATCH] D155197: [lldb][NFC] Refactor test to enable subsequent reuse

fdeazeve added a comment. See the patch stack for the commit that benefits from this refactor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155197/new/ https://reviews.llvm.org/D155197 ___ lldb-commits

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve updated this revision to Diff 540001. fdeazeve added a comment. Minor comment improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155198/new/ https://reviews.llvm.org/D155198 Files: lldb/source/Expression/DWARFExpression.cpp

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This rewrites DW_OP_addrx inside DWARFExpression as an DW_OP_addr so that we can update addresses that are originally

[Lldb-commits] [PATCH] D155197: [lldb][NFC] Refactor test to enable subsequent reuse

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On a subsequent commit, I intend to update the expression and call the evaluate function more times. This refactors

[Lldb-commits] [PATCH] D153886: [DRAFT][lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve abandoned this revision. fdeazeve added a comment. We're going with the other solution. See discourse thread linked Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153886/new/ https://reviews.llvm.org/D153886

[Lldb-commits] [PATCH] D153891: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve abandoned this revision. fdeazeve added a comment. Now that we have agreement on the discourse thread, I'll close this, polish it, and post again with tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153891/new/

[Lldb-commits] [PATCH] D155100: [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs

This revision was automatically updated to reflect the committed changes. Closed by commit rG85c2e420c87c: [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D155100: [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. This code was introduced in 2fc93eabf7e132abd51d0ea0ad599beb3fa44334. In order to improve readability of

[Lldb-commits] [PATCH] D154843: [lldb] Disable TestNamespaceLookup in DWARF 5 + dSYM setting

This revision was automatically updated to reflect the committed changes. Closed by commit rG6890ad3f41c5: [lldb] Disable TestNamespaceLookup in DWARF 5 + dSYM setting (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154843/new/

[Lldb-commits] [PATCH] D154843: [lldb] Disable TestNamespaceLookup in DWARF 5 + dSYM setting

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The ordering in which functions are presented to the expression evaluator in this test setting triggers a known bug in

[Lldb-commits] [PATCH] D154757: [lldb][NFCI] TestEmulation should take a Stream ref

fdeazeve accepted this revision. fdeazeve added a comment. Thanks for finding those! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154757/new/ https://reviews.llvm.org/D154757 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D154730: [lldb] Consider TAG_imported_declaration in DebugNamesIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rGcec33fc87c0c: [lldb] Consider TAG_imported_declaration in DebugNamesIndex (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154730/new/

[Lldb-commits] [PATCH] D154730: [lldb] Consider TAG_imported_declaration in DebugNamesIndex

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In order to recognize namespace aliases as a namespace, the

[Lldb-commits] [PATCH] D154513: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE

fdeazeve added a comment. > There are some potential improvements we could make to this code Yup, there's a lot I want to change here, but I am taking it slowly in the interest of making each change easier to verify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D154513: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc04b18ad7e4: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

This revision was automatically updated to reflect the committed changes. Closed by commit rG032de3ee0d35: [lldb][DebugNamesDWARF] Also use mangled name when matching regex (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D154610: [lldb][NFC] Remove unused parameter from DebugNames::ProcessEntry

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c3bb6a59027: [lldb][NFC] Remove unused parameter from DebugNames::ProcessEntry (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

fdeazeve added a comment. > Cool, might be worth mentioning that in the commit message. LGMT. Agreed! I'll update it prior to merging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154617/new/ https://reviews.llvm.org/D154617

[Lldb-commits] [PATCH] D154549: [lldb][NFCI] Remove use of Stream * from TypeSystem

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154549/new/ https://reviews.llvm.org/D154549 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

fdeazeve added a comment. In D154617#4478369 , @JDevlieghere wrote: > Is the reason this is necessary because the apple accelerator tables would > emit an entry for both the mangled and demangled name? Not quite. The name inside the accelerator table

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When LLDB queries the debug names index with a regex, we should use the `Mangled`

[Lldb-commits] [PATCH] D154610: [lldb][NFC] Remove unused parameter from DebugNames::ProcessEntry

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154610 Files:

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cea22c0be95: [lldb][NFC] Remove code duplication in InitOSO (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154505/new/

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

fdeazeve updated this revision to Diff 537524. fdeazeve added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154505/new/ https://reviews.llvm.org/D154505 Files:

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Thanks for improving this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154534/new/ https://reviews.llvm.org/D154534

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

fdeazeve added inline comments. Comment at: lldb/source/Utility/StructuredData.cpp:120 +return value->GetObjectForDotSeparatedPath(match.second); + } else if (GetType() == lldb::eStructuredDataTypeArray) { std::pair match = path.split('['); Shouldn't

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Ah you updated the review as I typed the question! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154532/new/ https://reviews.llvm.org/D154532

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

fdeazeve added a comment. In https://reviews.llvm.org/D154532, the string argument comes after the error. Are these interchangeable? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154532/new/ https://reviews.llvm.org/D154532 ___ lldb-commits

[Lldb-commits] [PATCH] D154530: [lldb] Fix incorrect uses of LLDB_LOG_ERROR

fdeazeve accepted this revision. fdeazeve added a comment. Nice catch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154530/new/ https://reviews.llvm.org/D154530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:347-348 + uint32_t sibling_idx = so_symbol->GetSiblingIndex(); + // The sibling index can't be less that or equal to the current index + // "i" + if

[Lldb-commits] [PATCH] D154513: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE

fdeazeve added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3272 +/// Creates a DWARFExpressionList from an DW_AT_location form_value. +static DWARFExpressionList

[Lldb-commits] [PATCH] D154513: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This function does a _lot_ of different things: 1. Parses a DIE, 2. Builds an ExpressionList 3. Figures out lifetime of

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Two identical loops were iterating over different ranges, leading to code duplication. We replace this by a loop over the

[Lldb-commits] [PATCH] D154365: [lldb][nfc] Remove redundant nullptr check

This revision was automatically updated to reflect the committed changes. Closed by commit rGf470ab734c9b: [lldb][nfc] Remove redundant nullptr check (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154365/new/

[Lldb-commits] [PATCH] D154365: [lldb][nfc] Remove redundant nullptr check

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, jplehr, sstefan1. Herald added a project: LLDB. The make_shared function never returns a nullptr, as such the test

[Lldb-commits] [PATCH] D154265: [lldb][NFC] Simplify GetLocation_DW_OP_addr function

This revision was automatically updated to reflect the committed changes. Closed by commit rGf292ca136240: [lldb][NFC] Simplify GetLocation_DW_OP_addr function (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154265/new/

[Lldb-commits] [PATCH] D154268: [lldb] Skip apple accelerator table test in DWARF 5 mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG379b59d1b0f3: [lldb] Skip apple accelerator table test in DWARF 5 mode (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154268/new/

[Lldb-commits] [PATCH] D154268: [lldb] Skip apple accelerator table test in DWARF 5 mode

fdeazeve updated this revision to Diff 536450. fdeazeve added a comment. Herald added a subscriber: JDevlieghere. fix typo in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154268/new/ https://reviews.llvm.org/D154268 Files:

[Lldb-commits] [PATCH] D154268: [lldb] Skip apple accelerator table test in DWARF 5 mode

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D68678 added a test that ensure an Apple accelerator lookup is done efficiently. Since

[Lldb-commits] [PATCH] D154265: [lldb][NFC] Simplify GetLocation_DW_OP_addr function

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A very old commit (9422dd64f870dd33) changed the signature of this function in a number of ways. This patch aims to

[Lldb-commits] [PATCH] D153868: [lldb] Use LLVM's implementation of AppleTables for apple_objc

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e71d14972b4: [lldb] Use LLVMs implementation of AppleTables for apple_objc (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D153867: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe12c701ff040: [lldb] Use LLVMs implementation of AppleTables for apple_debug_types (authored by fdeazeve). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d5c9ad9c3d7: [lldb] Use LLVMs implementation of AppleTables for apple_{names,namespaces} (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D153868: [lldb] Use LLVM's implementation of AppleTables for apple_objc

fdeazeve updated this revision to Diff 535163. fdeazeve added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153868/new/ https://reviews.llvm.org/D153868 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp

[Lldb-commits] [PATCH] D153867: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

fdeazeve updated this revision to Diff 535162. fdeazeve added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153867/new/ https://reviews.llvm.org/D153867 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp

[Lldb-commits] [PATCH] D153867: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:232 + + llvm::StringRef expected_name = context[0].name; + JDevlieghere wrote: > JDevlieghere wrote: > > I assume we always have at least one entry (or that's

[Lldb-commits] [PATCH] D153921: [lldb] Assert index is valid in DWARFDeclContext

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h:58 Entry [](uint32_t idx) { -// "idx" must be valid +assert(idx < m_entries.size() && "invalid index"); return m_entries[idx]; Note the difference

[Lldb-commits] [PATCH] D153921: [lldb] Assert index is valid in DWARFDeclContext

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Thanks for doing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153921/new/ https://reviews.llvm.org/D153921 ___ lldb-commits

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

fdeazeve updated this revision to Diff 535160. fdeazeve added a comment. Fix rebase issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153866/new/ https://reviews.llvm.org/D153866 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

fdeazeve updated this revision to Diff 535155. fdeazeve added a comment. Rebase after addressing the extractor issue in a separate patch: D153913 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153866/new/

[Lldb-commits] [PATCH] D153913: [lldb][NFC] Prevent slicing when converting DataExtractors

This revision was automatically updated to reflect the committed changes. Closed by commit rGab674234c440: [lldb][NFC] Prevent slicing when converting DataExtractors (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153913/new/

[Lldb-commits] [PATCH] D153913: [lldb][NFC] Prevent slicing when converting DataExtractors

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB's implementation of DWARFDataExtractor has a method that returns a

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:26-29 + // We could just pass "debug_str.getAsLLVM()", but that would cause slicing: + // DWARFDataExtractor->DataExtractor + // since AppleAcceleratorTable ctors take

[Lldb-commits] [PATCH] D153891: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This uses rewrites DW_OP_addrx as a DW_OP_addr so that we can update addresses that are originally located in the

[Lldb-commits] [PATCH] D153886: [DRAFT][lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve added a comment. This is here so I can link it in a discourse post. Please don't review seriously yet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153886/new/ https://reviews.llvm.org/D153886

[Lldb-commits] [PATCH] D153886: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

fdeazeve created this revision. Herald added a reviewer: shafik. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This uses a DenseMap to update addresses that are located in the debug_addr section.

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

fdeazeve added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:235 llvm::function_ref callback) { - if (!m_apple_names_up) -return; - - DWARFMappedHash::DIEInfoArray hash_data; -

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

fdeazeve updated this revision to Diff 534951. fdeazeve added a comment. Improve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153866/new/ https://reviews.llvm.org/D153866 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp

[Lldb-commits] [PATCH] D153868: [lldb] Use LLVM's implementation of AppleTables for apple_objc

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This concludes the migration of accelerator tables from LLDB code to LLVM code.

[Lldb-commits] [PATCH] D153867: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This commit is replacing really old LLDB code, and we've found

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. All the new code should match the behavior of the old exactly. Of note, the custom

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

fdeazeve added a comment. I think this may have caused an LLDB test to fail: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56977/execution/node/74/log/ runCmd: platform process launch --stdout

[Lldb-commits] [PATCH] D153711: [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a pointer

fdeazeve accepted this revision. fdeazeve added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153711/new/ https://reviews.llvm.org/D153711 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D153433: [lldb][MachO] Fix section type recognition for new DWARF 5 sections

This revision was automatically updated to reflect the committed changes. Closed by commit rG1704c8d1047d: [lldb][MachO] Fix section type recognition for new DWARF 5 sections (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D153433: [lldb][MachO] Fix section type recognition for new DWARF 5 sections

fdeazeve updated this revision to Diff 533320. fdeazeve added a comment. Add missing dwo sections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153433/new/ https://reviews.llvm.org/D153433 Files:

[Lldb-commits] [PATCH] D153433: [lldb][MachO] Fix section type recognition for new DWARF 5 sections

fdeazeve updated this revision to Diff 533281. fdeazeve added a comment. Add missing debug_cu_index and debug_tu_index sections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153433/new/ https://reviews.llvm.org/D153433 Files:

[Lldb-commits] [PATCH] D153433: [lldb][MachO] Fix section type recognition for new DWARF 5 sections

fdeazeve created this revision. fdeazeve added a reviewer: aprantl. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When LLDB needs to access a debug section, it generally calls

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Nice catch! Also agree with the suggestion of using the STLExtras wrapper Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152846/new/

[Lldb-commits] [PATCH] D152872: Add support for __debug_line_str in Mach-O

fdeazeve accepted this revision. fdeazeve added a comment. Nice and subtle fix! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152872/new/ https://reviews.llvm.org/D152872 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. This is awesome! I believe you said there was no measurable perf diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152476/new/

[Lldb-commits] [PATCH] D152449: [lldb][NFC]Update debug (eh-frame) tests to preserve old behaviour.

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152449/new/ https://reviews.llvm.org/D152449

[Lldb-commits] [PATCH] D152449: [lldb][NFC]Update debug (eh-frame) tests to preserve old behaviour.

fdeazeve added a comment. Thanks for looking into this! I think we should just remove the XFAIL instead, for the reasons you mentioned in the other patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152449/new/ https://reviews.llvm.org/D152449

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

fdeazeve accepted this revision. fdeazeve added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp:129-134 llvm::SmallString<64> name; { llvm::raw_svector_ostream os(name); os <<

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152315/new/ https://reviews.llvm.org/D152315 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D152210: [lldb][NFCI] Remove use of ConstString from OptionValueProperties

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152210/new/ https://reviews.llvm.org/D152210

[Lldb-commits] [PATCH] D152010: [lldb][NFCI] ConstString methods should take StringRefs by value

fdeazeve accepted this revision. fdeazeve added a comment. LGTM, thanks for picking this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152010/new/ https://reviews.llvm.org/D152010 ___ lldb-commits

[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

fdeazeve accepted this revision. fdeazeve added a comment. I'm not exactly familiar with DWOs, but the code motions LGTM! Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:882 + // we have a valid one to set it to. + assert(index_entry); +

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

fdeazeve added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:1001 -bool ObjCLanguage::GetFormatterPrefixSuffix(ValueObject , -ConstString type_hint, -

  1   2   3   >