[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

joerg added a comment. Can't you wrap `iterator_range` and possibly even support Twines like that? That is, don't extend the life time of the iterators, but store it in the range? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110535/new/ https://reviews.llvm.org/D110535

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

joerg added a comment. Why are all the changes from separator character to separator string necessary or desirable? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110535/new/ https://reviews.llvm.org/D110535 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

joerg added a comment. I'm a bit puzzled by the need for this change. The bump allocator already has logic to do power-of-two scaling for the allocation, so I wonder why it doesn't work properly here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D55998: ELF: create "container" sections from PT_LOAD segments

joerg added a comment. I foundamentally don't understand what you are trying to do. You can either look at the executable from a segment perspective or from a section perspective. But trying to mix the views is bound to give bogus results. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D55998: ELF: create "container" sections from PT_LOAD segments

joerg added a comment. In D55998#1340448 , @jankratochvil wrote: > > it is in theory possible to create an elf file where only a part of a > > section would belong to some segment (and another part to a different one). > > ELF standard

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

joerg added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115 _type: \ name = #_type switch (type) { krytarowski wrote: > brunoalr wrote: > >

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

joerg added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115 _type: \ name = #_type switch (type) { labath wrote: > If we go about renaming

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

joerg added a comment. If you want to go this way, rename them consistently and use a different prefix (e.g. AUXV_*) please. https://reviews.llvm.org/D35065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D34322: [lldb] Correctly escape newlines and backslashes in the JSON serializer

joerg added a comment. Not parsers, encoders. Note that the escaping is not correct for control characters other than \n. https://reviews.llvm.org/D34322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D34322: [lldb] Correctly escape newlines and backslashes in the JSON serializer

joerg added a comment. I don't disagree with you, but please see the referenced review for further details. I do not want the amount of adhoc JSON encoders to grow further. The YAML encoder works fine for most of the things, but it is easier to review calls to it than it is to find other

[Lldb-commits] [PATCH] D34322: [lldb] Correctly escape newlines and backslashes in the JSON serializer

joerg added a comment. Please see the discussion in https://reviews.llvm.org/D31992. This patch seems to go in the wrong direction. https://reviews.llvm.org/D34322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

joerg added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:55 const char *const LLDB_NT_OWNER_NETBSD = "NetBSD"; +const char *const LLDB_NT_OWNER_NETBSDCORE = "NetBSD-CORE"; const char *const LLDB_NT_OWNER_OPENBSD = "OpenBSD"; Not

[Lldb-commits] [PATCH] D29256: Do not pass non-POD type variables through variadic function

joerg added a comment. #include #include void f(std::string msg, ...) { va_list ap; va_start(ap, msg); } compiled against libc++ gives: test.cc:6:3: error: cannot pass object of non-POD type 'std::string' (aka 'basic_string') through

[Lldb-commits] [PATCH] D29256: Do not pass non-trivial type variables through variadic function

joerg added a comment. Should be "non-POD type" in the commit message. Repository: rL LLVM https://reviews.llvm.org/D29256 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits