@@ -61,40 +61,37 @@ DAP::DAP()
DAP::~DAP() = default;
void DAP::PopulateExceptionBreakpoints() {
+ exception_breakpoints = {};
if (debugger.SupportsLanguage(lldb::eLanguageTypeC_plus_plus)) {
-exception_breakpoints.emplace_back(
+
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/87550
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/87550
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/93332
AppleObjCTypeEncodingParser::BuildObjCObjectPointerType currently contains an
lldbassert to detect situations where we have a forward declaration without a
definition. According to the accompanying
https://github.com/JDevlieghere approved this pull request.
Normally I'd ask splitting upcross-project PRs, but this one is trivial and
very unlikely to be cause churn :-) LGMT.
https://github.com/llvm/llvm-project/pull/93260
___
lldb-commits
@@ -331,6 +333,7 @@ struct DAP {
// "Content-Length:" field followed by the length, followed by the raw
// JSON bytes.
void SendJSON(const std::string _str);
+ bool bp_initted;
JDevlieghere wrote:
This should be next to `exception_breakpoints`, but I
@@ -335,3 +335,14 @@ TypeSystemMap::GetTypeSystemForLanguage(lldb::LanguageType
language,
}
return GetTypeSystemForLanguage(language);
}
+
+bool TypeSystem::SupportsLanguageStatic(lldb::LanguageType language) {
+ if (language == eLanguageTypeUnknown)
+return false;
+
@@ -87,8 +87,8 @@ llvm::Error Socket::Initialize() {
if (err == 0) {
if (wsaData.wVersion < wVersion) {
WSACleanup();
- return llvm::make_error(
- "WSASock version is not expected.", llvm::inconvertibleErrorCode());
+ return
https://github.com/JDevlieghere commented:
I'm in favor of this. I rarely have a meaningful error code and it makes the
code needlessly verbose.
I was going to ask if we wanted to make an overload of the existing
`createStringError` but without the error code. But then I noticed that it uses
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/93209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/93169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/93006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -44,10 +45,20 @@ bool DWARFDebugInfoEntry::Extract(const DWARFDataExtractor
,
const DWARFUnit *cu,
lldb::offset_t *offset_ptr) {
m_offset = *offset_ptr;
+ auto report_error = [&](const char *fmt, const
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/92953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
No objections in the context of LLDB. We don't use terminfo directly (although
I think editline does, but that isn't affected by this) and if we want the TUI
we depend on curses anyway.
https://github.com/llvm/llvm-project/pull/92865
JDevlieghere wrote:
> Hello all. I am wondering what I can do to advance this patch? I think it is
> required to support process save-core in linux for lldb. I'd love to move
> this before adding static methods in ThreadEfCore.h to produce populated
> prpsinfo and prstatus structs for
Author: Jonas Devlieghere
Date: 2024-05-17T18:43:09-07:00
New Revision: 1e9324a8c734aaa933d2672522cc22d5022c6200
URL:
https://github.com/llvm/llvm-project/commit/1e9324a8c734aaa933d2672522cc22d5022c6200
DIFF:
JDevlieghere wrote:
> @JDevlieghere I know we discussed this in the past and it made sense to me,
> but I'm right now failing to connect the dots. Why couldn't the same
> single-line interface be used to print nested events something like this?
>
> ```
> Evaluating expression > Type Checking
Author: Jonas Devlieghere
Date: 2024-05-17T14:00:24-07:00
New Revision: bdfb04a63d73c31ee75395064762d0d6ccb45819
URL:
https://github.com/llvm/llvm-project/commit/bdfb04a63d73c31ee75395064762d0d6ccb45819
DIFF:
Author: Jonas Devlieghere
Date: 2024-05-17T10:12:51-07:00
New Revision: a4ad05284e97dd188c44252846486cbfb74a884c
URL:
https://github.com/llvm/llvm-project/commit/a4ad05284e97dd188c44252846486cbfb74a884c
DIFF:
Author: Jonas Devlieghere
Date: 2024-05-17T09:58:56-07:00
New Revision: d74bc823beabbb7067a4b4ae2d69a36d874f5132
URL:
https://github.com/llvm/llvm-project/commit/d74bc823beabbb7067a4b4ae2d69a36d874f5132
DIFF:
JDevlieghere wrote:
> @JDevlieghere @adrian-prantl are there plans to change the presentation layer
> to prevent this kind of shadowing in the future? Would be nice if all we
> needed to do was report progress, and not worry about other progress events
> in the debugger being in-flight
No,
JDevlieghere wrote:
> It's a `sed s/== None/is None/g` - what is there to review? 10 separate
> commits/PRs for the same exact `sed` costs more in commit noise (and effort
> on the part of @e-kwsm) than one solid, patient, review here.
In addition to what @ftynse said above, the `sed` might
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/92490
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/92490
Reverts llvm/llvm-project#92470
>From ebb9f82e4c6f9b7c6f627da71ffbfb858f655d1e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 16 May 2024 19:58:44 -0700
Subject: [PATCH] Revert "[lldb] Include
https://github.com/JDevlieghere commented:
This should really be broken up into separate PRs per subproject. One large PR
like this makes reviewing harder and causes unnecessary churn in the case that
this gets reverted.
https://github.com/llvm/llvm-project/pull/91857
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/92470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
The change looks fine. Was this done with by hand or with the help of a script?
If so please put that in the commit message so we can do the same downstream.
https://github.com/llvm/llvm-project/pull/92476
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/92470
>From 3bd3650ad624c1d45b118eb1d5bebc2732371b9d Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 16 May 2024 15:46:36 -0700
Subject: [PATCH 1/2] [lldb] Include SBLanguages in the SWIG bindings
JDevlieghere wrote:
> Actually, this has no dependency tracking. You'll need to add that for this
> to work every time.
It does actually, that's what the `SWIG_HEADERS` glob is used for.
https://github.com/llvm/llvm-project/pull/92470
___
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/92470
None
>From 3bd3650ad624c1d45b118eb1d5bebc2732371b9d Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 16 May 2024 15:46:36 -0700
Subject: [PATCH] [lldb] Include SBLanguages in the SWIG bindings
JDevlieghere wrote:
The stream already knows whether color support is enabled, but it looks like
we're only storing that in the underlying llvm stream, which is commonly used
in combination with `WithColor`. I think we could add a member to check if the
stream has colors enabled. It's already
JDevlieghere wrote:
I don't think Alex is arguing in favor of keeping the old (wrong) behavior, but
the first file looks like this:
```
foundSpec = False
if [...]
foundSpec = True
[...]
if foundSpec is False:
```
It's pretty obvious this is a boolean and should use `if not foundSpec`.
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/92428
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/92428
>From ca9fc570e4b721c36e5a0f9154e3158573bc5483 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 16 May 2024 09:44:57 -0700
Subject: [PATCH] [lldb-dap] Separate user and developer documentation
Author: Jonas Devlieghere
Date: 2024-05-16T09:54:47-07:00
New Revision: bd6c358d01f6ebc3851996e2c29c47b08e992525
URL:
https://github.com/llvm/llvm-project/commit/bd6c358d01f6ebc3851996e2c29c47b08e992525
DIFF:
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/92428
The README.md is what users see when they look for the extension in the
Marketplace [1]. Right now, it's a mix of developer documentation (for us) and
user documentation. This commit moves the developer
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/92320
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/92273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/92285
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/92286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Thanks. LGTM!
https://github.com/llvm/llvm-project/pull/92281
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -177,12 +177,12 @@ def check_stack(self, process, pid, filename):
self.assertEqual(thread.GetStopReasonDataAtIndex(0), 0)
@skipIfLLVMTargetMissing("AArch64")
-def test_aarch64(self):
+def test_aarch64_B(self):
JDevlieghere wrote:
@@ -207,11 +207,11 @@ def check_stack(self, process, pid, filename):
self.assertEqual(thread.GetStopReasonDataAtIndex(0), signal.SIGSEGV)
@skipIfLLVMTargetMissing("AArch64")
-def test_aarch64(self):
+def test_aarch64_C(self):
JDevlieghere
@@ -147,12 +147,12 @@ def check_stack(self, process, pid, filename):
self.check_backtrace(thread, filename, backtrace)
@skipIfLLVMTargetMissing("AArch64")
-def test_aarch64(self):
+def test_aarch64_A(self):
JDevlieghere wrote:
Can we give
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/92268
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
Could this use `os.devnull` to pick the right one based on the platform this is
running on?
```
self.do_test(["log enable -f '{}}' lldb commands".format(os.devnull)])
```
https://github.com/llvm/llvm-project/pull/92273
@@ -107,9 +107,20 @@ def test_process_unload(self):
self, "// Break here", lldb.SBFileSpec("main.cpp")
)
err = lldb.SBError()
-self.process().LoadImage(
-lldb.SBFileSpec(self.getBuildArtifact("libshared.so")), err
-)
+
https://github.com/JDevlieghere requested changes to this pull request.
As per Aiden's suggestion, please split this up into smaller PRs, grouped by
subproject.
https://github.com/llvm/llvm-project/pull/91856
___
lldb-commits mailing list
https://github.com/JDevlieghere commented:
Thanks!
https://github.com/llvm/llvm-project/pull/91688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> I'm pretty sure lldb was sending these events at some point, but that could
> have change since then. I slightly surprised that this wasn't caught before
> as that would mean noone is running these tests remotely.
>
> Jonas, are you running lldb tests in remote
JDevlieghere wrote:
> If this is split out from the other larger PR, should there be `clang/`
> changes in here?
+1, please unstage the `clang` and `openmp` changes.
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing list
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/92124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. TILL about `qSpeedTest`.
https://github.com/llvm/llvm-project/pull/92124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/91029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91653
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -418,9 +418,20 @@ def locate_module_and_debug_symbols(self):
with print_lock:
print('falling back to binary inside "%s"' % dsym)
self.symfile = dsym
-for filename in
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/91631
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91631
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -848,6 +850,13 @@ void Breakpoint::GetDescription(Stream *s,
lldb::DescriptionLevel level,
const size_t num_locations = GetNumLocations();
const size_t num_resolved_locations = GetNumResolvedLocations();
+ // Grey out any disabled breakpoints in the list of
@@ -418,9 +418,22 @@ def locate_module_and_debug_symbols(self):
with print_lock:
print('falling back to binary inside "%s"' % dsym)
self.symfile = dsym
-for filename in
JDevlieghere wrote:
> If this turns out to be necessary, one way to rate-limit them would be to
> have a nesting depth counter. Assuming that these imports happen recursively
> we could create only Progress objects for the top n layers.
Is the code that emits the progress event recursive too?
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/91618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM but let's give Alex and Ismail a chance to take a look too.
https://github.com/llvm/llvm-project/pull/91618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
JDevlieghere wrote:
> My understanding was that the progress increment is designed to be really
> cheap (writing two pointers) and that it's up to presentation layer to decide
> a t what frequency to update the UI.
>
> @JDevlieghere — is that perception correct?
You're correct about the
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> @JDevlieghere , do you know if there's a way to run buildbot on a merge of
> this PR and main branch - just to validate the build/tests work before this
> merge?
Not that I know. When failures are macOS specific I'm happy to apply a PR
locally and run the test suite and
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91146
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91511
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -534,7 +534,8 @@ void BreakpointOptions::GetDescription(Stream *s,
if (m_ignore_count > 0)
s->Printf("ignore: %d ", m_ignore_count);
-s->Printf("%sabled ", m_enabled ? "en" : "dis");
+s->PutCStringColorHighlighted(m_enabled ? "enabled " : "disabled ",
+
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/91390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/91390
Alex pointed out in #91254 that we only need the custom target if we had more
than one target depending on it. This isn't the case upstream, but on our
downstream fork, we have a second dependency.
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/91371
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/91371
On Darwin platforms, the system will generate a crash report in
~/Library/Logs/DiagnosticReports/ when a process crashes.
These reports are much more useful than the "pretty backtraces" printed by LLVM
@@ -731,8 +747,11 @@ class Debugger : public
std::enable_shared_from_this,
lldb::TargetSP m_dummy_target_sp;
Diagnostics::CallbackID m_diagnostics_callback_id;
- lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr;
- void *m_destroy_callback_baton =
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/91254
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Good point. I can't imagine anything needing the SB header that doesn't need
the rest of the framework, but if that's the case we go through a custom
target.
https://github.com/llvm/llvm-project/pull/91254
___
lldb-commits
JDevlieghere wrote:
The change itself looks fine, but can you please add a bit more info to the
commit message, such as the Python version you're seeing this with.
https://github.com/llvm/llvm-project/pull/91146
___
lldb-commits mailing list
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -20,9 +20,19 @@ if(LLDB_ENABLE_LUA)
set(lldb_lua_wrapper ${lua_bindings_dir}/LLDBWrapLua.cpp)
endif()
-lldb_tablegen(../../include/lldb/API/SBLanguages.h -gen-lldb-sbapi-dwarf-enum
- SOURCE ${LLVM_MAIN_INCLUDE_DIR}/llvm/BinaryFormat/Dwarf.def
- TARGET
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/91254
Use add_custom_command instead of add_custom_target to generate SBLanguages.h.
>From 7fa130d2bb2e45f350ca8c3851d32bbec3332f8c Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 6 May 2024 11:48:24
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
Since we're already using `argparse`, can we use the `BooleanOptionalAction` to
make this work automatically with the affirmative option?
https://docs.python.org/3.9/library/argparse.html#action
https://github.com/llvm/llvm-project/pull/91162
@@ -100,6 +111,10 @@ def get_register_context(self) -> str:
def __lldb_init_module(debugger, dict):
if not "SKIP_SCRIPTED_PROCESS_LAUNCH" in os.environ:
+debugger.HandleCommand(
JDevlieghere wrote:
This seems like it would be worth documenting in
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/90998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/90998
Reverts llvm/llvm-project#90921
>From 2beb507e10a6dbe6387bc67143601a66b0168293 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 3 May 2024 12:14:36 -0700
Subject: [PATCH] Revert "[lldb] Unify
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/90921
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/90984
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/90984
>From d1adf630a9981f275f24e4d0c2c613a90ff38290 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 3 May 2024 10:11:40 -0700
Subject: [PATCH 1/2] [lldb] Add TeeLogHandler to log to 2 handlers
Add a
@@ -438,3 +439,15 @@ void RotatingLogHandler::Dump(llvm::raw_ostream )
const {
}
stream.flush();
}
+
+TeeLogHandler::TeeLogHandler(std::shared_ptr first_log_handler,
+ std::shared_ptr second_log_handler)
+:
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/90984
Add a T-style log handler that multiplexes messages to two log handlers. The
goal is to use this in combination with the SystemLogHandler to log messages
both to the user requested file as well as the
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/90657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/90913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/90913
>From 7ed4008b32d6ec7809a9cea0eb4462d1b90f4e52 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 2 May 2024 15:47:46 -0700
Subject: [PATCH] [lldb] Always emit diagnostic events to the system log
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/90917
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/90917
>From 23b16ba8418f03dd11190798ccddf218cbfaf3f1 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 2 May 2024 16:44:18 -0700
Subject: [PATCH 1/2] [lldb] Create a single Severity enum in
@@ -1347,6 +1347,12 @@ enum DebuggerBroadcastBit {
eBroadcastBitProgressCategory = (1 << 3),
};
+enum Severity {
+ eSeverityError,
+ eSeverityWarning,
+ eSeverityInfo,
JDevlieghere wrote:
I considered the latter, but we use `eSeverityRemark` so
1 - 100 of 2993 matches
Mail list logo
