JDevlieghere wrote:
I'm torn: on the one hand this is obviously making things better, on the other,
it undermines what an assertion and has the potential to be used where error
handling is necessary. The idea behind the latter is that if your assertion
fails, you're already in an
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/71128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> Are you asking me to create a SymbolServer class for _this_ change, or do you
> want me to get this diff polished & landed, then create the abstraction
> before adding anything more? (Either is fine: I just can't quite tell what
> you're looking for right now)
I was
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/71151
This commit contains the initial scaffolding to convert the functionality
currently implemented in LocateSymbolFile to a plugin architecture. The plugin
approach allows us to easily add new ways to find
https://github.com/JDevlieghere approved this pull request.
Seems obvious. LGTM!
https://github.com/llvm/llvm-project/pull/71143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/71112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
The nodes on GreenDragon run under a UI session so that might explain why we
don't see that issue there. Is there any harm with using
`packages/Python/lldbsuite/test/make/entitlements.plist` for macOS too? Does
`com.apple.private.security.no-sandbox` cause issues?
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/71081
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/70950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> Yes, that specific kind of refactoring seemed like a good idea, but given
> that this is my first real foray into the LLDB space, I didn't want to bite
> off that much work to start with.
I'd be happy to help with that and I'm sure @clayborg wouldn't mind providing
JDevlieghere wrote:
First off, thank you for working on this. `debuginfod` has been on my radar
since support was added to LLVM and I was curious at which point someone was
going to add support for it to LLDB. I wasn't super familiar with what exactly
it provides, and in case others here
@@ -4892,6 +4894,21 @@ void TargetProperties::SetDebugUtilityExpression(bool
debug) {
SetPropertyAtIndex(idx, debug);
}
+Args TargetProperties::GetDebugInfoDURLs() const {
+ Args urls;
+ m_collection_sp->GetPropertyAtIndexAsArgs(ePropertyDebugInfoDURLs, urls);
+ return
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/70979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1612,6 +1612,22 @@ bool
ProcessGDBRemote::CalculateThreadStopInfo(ThreadGDBRemote *thread) {
return false;
}
+void ProcessGDBRemote::ParseExpeditedRegisters(
+ExpeditedRegisterMap _register_map, ThreadSP thread_sp) {
+ ThreadGDBRemote *gdb_thread =
@@ -762,82 +756,22 @@ uint32_t
GDBRemoteRegisterContext::ConvertRegisterKindToRegisterNumber(
return m_reg_info_sp->ConvertRegisterKindToRegisterNumber(kind, num);
}
-void GDBRemoteRegisterContext::AArch64Reconfigure() {
- assert(m_reg_info_sp);
-
- // Once we start to
@@ -109,6 +110,24 @@ class Architecture : public PluginInterface {
virtual const MemoryTagManager *GetMemoryTagManager() const {
return nullptr;
}
+
+ // This returns true if a write to the named register should cause lldb to
+ // reconfigure its register
@@ -762,82 +756,22 @@ uint32_t
GDBRemoteRegisterContext::ConvertRegisterKindToRegisterNumber(
return m_reg_info_sp->ConvertRegisterKindToRegisterNumber(kind, num);
}
-void GDBRemoteRegisterContext::AArch64Reconfigure() {
- assert(m_reg_info_sp);
-
- // Once we start to
@@ -1612,6 +1612,22 @@ bool
ProcessGDBRemote::CalculateThreadStopInfo(ThreadGDBRemote *thread) {
return false;
}
+void ProcessGDBRemote::ParseExpeditedRegisters(
+ExpeditedRegisterMap _register_map, ThreadSP thread_sp) {
+ ThreadGDBRemote *gdb_thread =
https://github.com/JDevlieghere approved this pull request.
LGTM per my last comment.
https://github.com/llvm/llvm-project/pull/70351
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -614,6 +614,8 @@ class Process : public
std::enable_shared_from_this,
return error;
}
+ virtual void DidLoadCore() {}
JDevlieghere wrote:
Okay, so if semantically this doesn't make sense (which is what I'm hearing)
then I don't why we would reuse
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/70443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -614,6 +614,8 @@ class Process : public
std::enable_shared_from_this,
return error;
}
+ virtual void DidLoadCore() {}
JDevlieghere wrote:
Would it be worth to rename that function to `DidAttachOrLoadCore` (or just
`DidAttachOrLoad`) to make it
https://github.com/JDevlieghere approved this pull request.
Thanks Stefan!
https://github.com/llvm/llvm-project/pull/70793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
+1, if you can verify that Python 3.6 supports the `importlib` approach we
should drop the fallback.
https://github.com/llvm/llvm-project/pull/70443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/JDevlieghere approved this pull request.
LGTM modulo formatting
https://github.com/llvm/llvm-project/pull/70641
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -461,13 +461,11 @@ static void ParseOSVersion(llvm::VersionTuple ,
NSString *Key) {
// Invoke xcrun with the shlib dir.
if (FileSpec fspec = HostInfo::GetShlibDir()) {
if (FileSystem::Instance().Exists(fspec)) {
-std::string contents_dir =
-
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/70512
>From 1c6a604df93b833c3bb9c7d34f4f27415592dbe5 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Thu, 5 Oct 2023 12:39:02 -0700
Subject: [PATCH] [LLVM][DWARF] Add support for monolithic types in
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/70490
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2652,7 +2654,9 @@ void ObjectFileMachO::ParseSymtab(Symtab ) {
std::vector external_sym_trie_entries;
std::set resolver_addresses;
- if (dyld_trie_data.GetByteSize() > 0) {
+ const size_t dyld_trie_data_size = dyld_trie_data.GetByteSize();
+ if (dyld_trie_data_size
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/70490
I have a crash when parsing the dyld trie data and I want to ask the originator
to send me the (possibly corrupted) binary that's causing this. This patch adds
some logging to help pinpoint that file.
@@ -0,0 +1,140 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,146 @@
+//===-- WatchpointResourceList.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -266,33 +268,73 @@ void Watchpoint::Dump(Stream *s) const {
// If prefix is nullptr, we display the watch id and ignore the prefix
// altogether.
-void Watchpoint::DumpSnapshots(Stream *s, const char *prefix) const {
- if (!prefix) {
-s->Printf("\nWatchpoint %u hit:",
@@ -0,0 +1,97 @@
+//===-- WatchpointResource.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -331,6 +373,16 @@ void Watchpoint::DumpWithLevel(Stream *s,
bool Watchpoint::IsEnabled() const { return m_enabled; }
+uint32_t Watchpoint::GetHardwareIndex() const {
+ if (IsEnabled())
+return m_target.GetProcessSP()
+->GetWatchpointResourceList()
+
@@ -0,0 +1,154 @@
+//===-- WatchpointResourceList.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,140 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,155 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,155 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,155 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,146 @@
+//===-- WatchpointResourceList.h *- C++
-*-===//
JDevlieghere wrote:
Do we really need this class? It looks like a pretty trivial wrapper around a
vector and a mutex. How much overlap is there with the
@@ -0,0 +1,155 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,155 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,155 @@
+//===-- WatchpointResource.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,97 @@
+//===-- WatchpointResource.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
Author: Jonas Devlieghere
Date: 2023-10-25T16:03:51-07:00
New Revision: dfa357026be3d9ecacc910abb8d55b8fe2d8d01d
URL:
https://github.com/llvm/llvm-project/commit/dfa357026be3d9ecacc910abb8d55b8fe2d8d01d
DIFF:
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/68052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -32,6 +32,84 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl );
~ScriptedPythonInterface() override = default;
+ template
+ llvm::Expected
+ CreatePluginObject(llvm::StringRef class_name,
+
@@ -56,14 +56,17 @@ ScriptedThread::Create(ScriptedProcess ,
}
ExecutionContext exe_ctx(process);
- StructuredData::GenericSP owned_script_object_sp =
- scripted_thread_interface->CreatePluginObject(
- thread_class_name, exe_ctx,
@@ -32,6 +32,84 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl );
~ScriptedPythonInterface() override = default;
+ template
+ llvm::Expected
+ CreatePluginObject(llvm::StringRef class_name,
+
@@ -19,11 +19,11 @@
namespace lldb_private {
class ScriptedPlatformInterface : virtual public ScriptedInterface {
public:
- StructuredData::GenericSP
+ virtual llvm::Expected
CreatePluginObject(llvm::StringRef class_name, ExecutionContext _ctx,
@@ -32,6 +32,84 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl );
~ScriptedPythonInterface() override = default;
+ template
+ llvm::Expected
+ CreatePluginObject(llvm::StringRef class_name,
+
@@ -769,10 +768,10 @@ bool CommandObjectRaw::Execute(const char *args_string,
handled = InvokeOverrideCallback(argv, result);
}
if (!handled) {
-if (CheckRequirements(result))
- handled = DoExecute(args_string, result);
+if (CheckRequirements(result)) {
+
https://github.com/JDevlieghere approved this pull request.
A few small nits but overall this LGTM.
https://github.com/llvm/llvm-project/pull/69989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -715,7 +715,7 @@ Thread *CommandObject::GetDefaultThread() {
return nullptr;
}
-bool CommandObjectParsed::Execute(const char *args_string,
+void CommandObjectParsed::Execute(const char *args_string,
CommandReturnObject ) {
bool
@@ -429,11 +428,13 @@ llvm::StringRef CommandObjectProxy::GetUnsupportedError()
{
return "command is not implemented";
}
-bool CommandObjectProxy::Execute(const char *args_string,
+void CommandObjectProxy::Execute(const char *args_string,
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/69989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -533,6 +533,12 @@ class Function : public UserID, public SymbolContextScope {
/// The DeclContext, or NULL if none exists.
CompilerDeclContext GetDeclContext();
+ /// Get the CompilerContext for this function, if available.
+ ///
+ /// \return
+ /// The
Author: Jonas Devlieghere
Date: 2023-10-23T15:29:01-07:00
New Revision: 83a6b02c3d79f0ac714690e1baec14efb1c24fe9
URL:
https://github.com/llvm/llvm-project/commit/83a6b02c3d79f0ac714690e1baec14efb1c24fe9
DIFF:
@@ -0,0 +1,120 @@
+//===-- InstrumentationRuntimeASan.cpp
===//
JDevlieghere wrote:
I know it's a bit unwieldy, but should this file be called
`InstrumentationRuntimeASanLibsanitizers`?
https://github.com/JDevlieghere approved this pull request.
LGTM with the filename updated.
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> And if you're not familiar with lldb-server and XML, as I wasn't, it doesn't
> use libXML to generate it. That's why I'm building strings to fit with the
> existing target.xml code.
It's somewhat implied, but is the goal to (continue to) avoid that dependency?
Other
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/69858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM with SWIG all caps.
https://github.com/llvm/llvm-project/pull/69858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -403,13 +403,21 @@ dependencies are required:
* Sphinx (for the website and the Python API reference)
* Graphviz (for the 'dot' tool)
* doxygen (if you wish to build the C++ API reference)
+* Swig (for generating Python bindings)
JDevlieghere wrote:
https://github.com/JDevlieghere approved this pull request.
Nice
https://github.com/llvm/llvm-project/pull/69793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2023-10-19T15:17:36-07:00
New Revision: 969ba9ff1477d9dc350aa1b3f5fd23b6f6af76cd
URL:
https://github.com/llvm/llvm-project/commit/969ba9ff1477d9dc350aa1b3f5fd23b6f6af76cd
DIFF:
Author: Jonas Devlieghere
Date: 2023-10-19T13:13:31-07:00
New Revision: f9632cee30b788df7a6241d7802224d8f633973a
URL:
https://github.com/llvm/llvm-project/commit/f9632cee30b788df7a6241d7802224d8f633973a
DIFF:
Author: Jonas Devlieghere
Date: 2023-10-19T11:14:25-07:00
New Revision: 5bae3a0b0ccf8f4f2bcffc86453197f3cc5a9829
URL:
https://github.com/llvm/llvm-project/commit/5bae3a0b0ccf8f4f2bcffc86453197f3cc5a9829
DIFF:
Author: Jonas Devlieghere
Date: 2023-10-19T10:30:38-07:00
New Revision: bd21efe24c7670bc8d6f5c3bb92f12b0d1983e0b
URL:
https://github.com/llvm/llvm-project/commit/bd21efe24c7670bc8d6f5c3bb92f12b0d1983e0b
DIFF:
https://github.com/JDevlieghere requested changes to this pull request.
I already discussed this offline with Chelsea, but yeah I agree that "discrete"
isn't very informative. Regardless of the name we pick, we should include an
example too to help clarify its meaning. I'd also prefer to use
JDevlieghere wrote:
拾
https://github.com/llvm/llvm-project/pull/69531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/3] [lldb][progress] Add discrete boolean flag to
@@ -388,7 +385,7 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
, uint32_t stop_id);
/// The variable name of \a value or a default placeholder.
const char *GetNonNullVariableName(lldb::SBValue value);
-/// VSCode can't display two variables with the same name,
@@ -0,0 +1,56 @@
+//===-- InstrumentationRuntimeLibsanitizers.h *-
C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
JDevlieghere wrote:
Fix ASCII art
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing
@@ -0,0 +1,31 @@
+//===-- ReportRetriever.h *- C++ -*-===//
JDevlieghere wrote:
Fix ASCII art
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
@@ -1,5 +1,7 @@
+add_subdirectory(Libsanitizers)
JDevlieghere wrote:
Rather than living under the Asan plugin, it seems like his should be living at
the same level. If there's shared code between the two plugins, we should hoist
that up into a separate library
@@ -0,0 +1,56 @@
+//===-- InstrumentationRuntimeLibsanitizers.h *-
C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
JDevlieghere wrote:
> @JDevlieghere , PTAL
> https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/16?u=wallace
I just replied! :D
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
@@ -40,59 +41,59 @@ If you want to make a stand alone plug-in that you can send
to others on UNIX
systems:
```bash
-mkdir -p ~/llvm-org.lldb-vscode-0.1.0/bin
-cp package.json ~/llvm-org.lldb-vscode-0.1.0
-cd ~/llvm-org.lldb-vscode-0.1.0/bin
-cp /path/to/a/built/lldb-vscode .
@@ -18,9 +18,10 @@
# Introduction
JDevlieghere wrote:
I've made `lldb-vscode` a symlink to `lldb-dap`.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
JDevlieghere wrote:
> Actually there was a ninja target for `lldb-dap` but it wasn't built by
> default. Again, existing cmake config so if yours is fine then ignore this.
Yes, I had the same thing happen to me with an incremental build, but
everything looked correct for a clean build.
JDevlieghere wrote:
Okay, to answer my own question: the difference is the typescript vs native
plugin. I had missed that nuance. For the uninitiated, what most of us are
currently using is the native version because it's just a `package.json` +
`lldb-dap` binary, right? I guess I personally
JDevlieghere wrote:
> @JDevlieghere , @clayborg, what do you think of the idea of some of us in the
> LLDB community building a minimal typescript extension for lldb-vscode and
> upload it to the marketplace? Then companies building their custom debugging
> on top of lldb-vscode could just
JDevlieghere wrote:
(Not related to this PR but I put up an
[RFC](https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/)
on Friday to rename it to `lldb-dap`. Putting it up here for extra visibility.)
https://github.com/llvm/llvm-project/pull/69238
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
FWIW I like `:` because that's what the REPL uses and because ` already has a
different meaning in LLDB.
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/JDevlieghere approved this pull request.
Thanks Walter! I'm happy with this
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/JDevlieghere approved this pull request.
Thanks! LGTM.
https://github.com/llvm/llvm-project/pull/68705
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM with some small nits.
https://github.com/llvm/llvm-project/pull/68705
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/68705
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -135,6 +135,12 @@ class TypeSystem : public PluginInterface,
virtual lldb::LanguageType DeclContextGetLanguage(void *opaque_decl_ctx) = 0;
+ // CompilerType functions
JDevlieghere wrote:
I know you're just being consistent with the surrounding code
@@ -586,6 +586,15 @@ lldb::TemplateArgumentKind
SBType::GetTemplateArgumentKind(uint32_t idx) {
return eTemplateArgumentKindNull;
}
+SBType SBType::FindDirectNestedType(const char *name) {
+ LLDB_INSTRUMENT_VA(this, name);
+
+ if (!IsValid())
+return SBType();
+
@@ -720,6 +720,14 @@ SBType supports the eq/ne operator. For example,::
"
) lldb::SBType::GetTypeFlags;
+%feature("docstring",
+"Searches for a directly nested type that has provided name.
JDevlieghere wrote:
`s/has provided name/has the provided
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/68940
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/68970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
901 - 1000 of 3145 matches
Mail list logo
