[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-29 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht approved this pull request. LGTM, but heads up for @mysterymath if this causes issues w/ Fuchsia's build https://github.com/llvm/llvm-project/pull/93712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb][DAP] Fix test failure from #73393 (PR #89692)

2024-04-22 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht commented: LGTM https://github.com/llvm/llvm-project/pull/89692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Remove unused pexpect/ptyprocess (PR #89609)

2024-04-22 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/89609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [lldb][test] Remove LLDB_TEST_USE_VENDOR_PACKAGES (PR #89260)

2024-04-18 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/89260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [lldb][test] Remove LLDB_TEST_USE_VENDOR_PACKAGES (PR #89260)

2024-04-18 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/89260 The `LLDB_TEST_USE_VENDOR_PACKAGES` has defaulted to `Off` for a while. Either installing `pexpect` or skipping those tests with `-DLLDB_TEST_USER_ARGS=--skip-category=pexpect` seems to be enough that we can

[Lldb-commits] [lldb] [lldb] Don't crash when attempting to parse breakpoint id `N.` as `N.*` (PR #87263)

2024-04-01 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/87263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't crash when attempting to parse breakpoint id `N.` as `N.*` (PR #87263)

2024-04-01 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/87263 We check if the next character after `N.` is `*` before we check its length. Using `split` on the string is cleaner and less error prone than using indices with `find` and `substr`. Note: this does not make

[Lldb-commits] [lldb] [lldb] Remove cmake check for pexpect with LLDB_TEST_USE_VENDOR_PACKAGES (PR #86962)

2024-03-28 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/86962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove cmake check for pexpect with LLDB_TEST_USE_VENDOR_PACKAGES (PR #86962)

2024-03-28 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/86962 The commit 8bed754c2f965c8cbbb050be6f650b78f7fd78a6 was intended to support the use case where users want to run all the LLDB tests in an environment where pexpect is not installed. Those users can build with

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-13 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/84860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-12 Thread Jordan Rupprecht via lldb-commits
@@ -914,6 +914,25 @@ def checkForkVForkSupport(): configuration.skip_categories.append("fork") +def checkPexpectSupport(): +from lldbsuite.test import lldbplatformutil + +platform = lldbplatformutil.getPlatform() + +# llvm.org/pr22274: need a pexpect

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-12 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/84860 >From b5e04eb49c89c8c654305c6ba5db5e2f237bccec Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Mon, 11 Mar 2024 11:23:59 -0700 Subject: [PATCH 1/5] [lldb][test] Add `pexpect` category for tests that

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-12 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/84860 >From b5e04eb49c89c8c654305c6ba5db5e2f237bccec Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Mon, 11 Mar 2024 11:23:59 -0700 Subject: [PATCH 1/4] [lldb][test] Add `pexpect` category for tests that

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-12 Thread Jordan Rupprecht via lldb-commits
@@ -914,6 +914,25 @@ def checkForkVForkSupport(): configuration.skip_categories.append("fork") +def checkPexpectSupport(): +from lldbsuite.test import lldbplatformutil + +platform = lldbplatformutil.getPlatform() + +# llvm.org/pr22274: need a pexpect

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-12 Thread Jordan Rupprecht via lldb-commits
@@ -914,6 +914,25 @@ def checkForkVForkSupport(): configuration.skip_categories.append("fork") +def checkPexpectSupport(): +from lldbsuite.test import lldbplatformutil + +platform = lldbplatformutil.getPlatform() + +# llvm.org/pr22274: need a pexpect

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-12 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/84860 >From b5e04eb49c89c8c654305c6ba5db5e2f237bccec Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Mon, 11 Mar 2024 11:23:59 -0700 Subject: [PATCH 1/3] [lldb][test] Add `pexpect` category for tests that

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-11 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/84860 >From b5e04eb49c89c8c654305c6ba5db5e2f237bccec Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Mon, 11 Mar 2024 11:23:59 -0700 Subject: [PATCH 1/2] [lldb][test] Add `pexpect` category for tests that

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-11 Thread Jordan Rupprecht via lldb-commits
@@ -914,6 +914,25 @@ def checkForkVForkSupport(): configuration.skip_categories.append("fork") +def checkPexpectSupport(): +from lldbsuite.test import lldbplatformutil + +platform = lldbplatformutil.getPlatform() + +# llvm.org/pr22274: need a pexpect

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-11 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/84860 Instead of directly annotating pexpect-based tests with `@skipIfWindows`, we can tag them with a new `pexpect` category. We still automatically skip windows behavior by adding `pexpect` to the skip category

[Lldb-commits] [lldb] [lldb][test] Enforce `pexpect` system availability by default (PR #84270)

2024-03-07 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: @mysterymath do you run the API test suites with that custom python, i.e. `ninja check-lldb-api`? If so, would you be able to add bundle `pexpect` for your tests even if it's not in what you ship? The goal is to be able to delete

[Lldb-commits] [lldb] [lldb][test] Enforce `pexpect` system availability by default (PR #84270)

2024-03-07 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/84270 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Enforce `pexpect` system availability by default (PR #84270)

2024-03-06 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: btw, it would be nice if LLDB buildbots were clean before landing this. https://green.lab.llvm.org/green/view/LLDB/ is currently giving me ERR_CONNECTION_REFUSED. The others are failing but I'm hoping ec72909b62ce568ed27c6ad0581e50c0fdd70df4 restores that.

[Lldb-commits] [lldb] ec72909 - [lldb][test] iwyu for vfork test

2024-03-06 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2024-03-06T18:41:18-08:00 New Revision: ec72909b62ce568ed27c6ad0581e50c0fdd70df4 URL: https://github.com/llvm/llvm-project/commit/ec72909b62ce568ed27c6ad0581e50c0fdd70df4 DIFF:

[Lldb-commits] [lldb] [lldb][test] Enforce `pexpect` system availability by default (PR #84270)

2024-03-06 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/84270 This switches the default of `LLDB_TEST_USE_VENDOR_PACKAGES` from `ON` to `OFF` in preparation for eventually deleting it. All known LLDB buildbots have this package installed, so flipping the default will

[Lldb-commits] [lldb] [lldb] Log to system log instead of stderr from Host::SystemLog (PR #83366)

2024-03-04 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht approved this pull request. https://github.com/llvm/llvm-project/pull/83366 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Log to system log instead of stderr from Host::SystemLog (PR #83366)

2024-03-04 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > @rupprecht @oontvoo How do you feel about the current approach? The other > alternative is to make this function a NOOP on all platforms but Darwin > (where I want to actively use it). It's not currently load bearing (except > the log, which is opt-in). This approach LGTM.

[Lldb-commits] [lldb] 503075e - [lldb][test][NFC] Narrow scope of `import pexpect`

2024-03-04 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2024-03-04T11:21:47-08:00 New Revision: 503075e4d4a9c1b3754b21ee9ec41f176e54fd83 URL: https://github.com/llvm/llvm-project/commit/503075e4d4a9c1b3754b21ee9ec41f176e54fd83 DIFF:

[Lldb-commits] [lldb] [lldb][test][NFC] Add option to exclude third_party packages (PR #83191)

2024-03-04 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > FYI @labath as the x86 bot owner. I checked w/ them that [lldb-x86_64-debian](https://lab.llvm.org/buildbot/#/builders/68) has python3-pexpect (specifically 4.8) installed. > > It should perhaps unset the variable first, I'll see if I can implement > > that. > >

[Lldb-commits] [lldb] [lldb] Log to system log instead of stderr from Host::SystemLog (PR #83366)

2024-02-28 Thread Jordan Rupprecht via lldb-commits
@@ -89,8 +89,17 @@ using namespace lldb; using namespace lldb_private; #if !defined(__APPLE__) +#if !defined(_WIN32) +#include +void Host::SystemLog(llvm::StringRef message) { + openlog("lldb", LOG_CONS | LOG_PID | LOG_NDELAY, LOG_USER); + syslog(LOG_INFO, "%s",

[Lldb-commits] [lldb] [lldb] Log to system log instead of stderr from Host::SystemLog (PR #83366)

2024-02-28 Thread Jordan Rupprecht via lldb-commits
@@ -89,8 +89,17 @@ using namespace lldb; using namespace lldb_private; #if !defined(__APPLE__) +#if !defined(_WIN32) +#include +void Host::SystemLog(llvm::StringRef message) { + openlog("lldb", LOG_CONS | LOG_PID | LOG_NDELAY, LOG_USER); + syslog(LOG_INFO, "%s",

[Lldb-commits] [lldb] [lldb][test][NFC] Add option to exclude third_party packages (PR #83191)

2024-02-28 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/83191 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][NFC] Add option to exclude third_party packages (PR #83191)

2024-02-28 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht edited https://github.com/llvm/llvm-project/pull/83191 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Deduplicate watchpoints starting at the same address on SetDataBreakpointsRequest. (PR #83192)

2024-02-28 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht approved this pull request. https://github.com/llvm/llvm-project/pull/83192 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][NFC] Add option to exclude third_party packages (PR #83191)

2024-02-28 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht edited https://github.com/llvm/llvm-project/pull/83191 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Exclude third_party packages by default (PR #83191)

2024-02-28 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/83191 >From d21ac756226a364603acd0180f9a06c23600acb1 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Tue, 27 Feb 2024 13:25:12 -0800 Subject: [PATCH 1/2] [lldb][test] Exclude third_party packages by default

[Lldb-commits] [lldb] [lldb][test] Exclude third_party packages by default (PR #83191)

2024-02-28 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > Though maybe you intend this to break builds, that way obscure builders that > we don't know about will still hear about this? > Yes, but I agree with your suggestion to land this with a default of `ON`, which makes this change NFC. I can then switch it to `OFF` once known

[Lldb-commits] [lldb] [lldb][test] Exclude third_party packages by default (PR #83191)

2024-02-27 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/83191 The goal here is to remove the third_party/Python/module tree, which LLDB tests only use to `import pexpect`. This package is available on `pip`, and I believe should not be hard to obtain. However, in case

[Lldb-commits] [lldb] [lldb][dap] Avoid concurrent `HandleCommand` calls (PR #83162)

2024-02-27 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/83162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][dap] Avoid concurrent `HandleCommand` calls (PR #83162)

2024-02-27 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/83162 The `EventThreadFunction` can end up calling `HandleCommand` concurrently with the main request processing thread. The underlying API does not appear to be thread safe, so add a narrowly scoped mutex lock to

[Lldb-commits] [lldb] [lldb][test] Remove vendored packages `unittest2` and `progress` (PR #82670)

2024-02-26 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/82670 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove vendored packages `unittest2` and `progress` (PR #82670)

2024-02-22 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > 拾 > > Please wait a little bit for others to look. Thanks for taking care of this! Yep, no problem! I'll give it a few days, and assume no comments == submit. Next up: I'd like to remove `pexpect` (available on pip) and completely remove the lldb/third_party/ tree.

[Lldb-commits] [lldb] [lldb][docs] Remove/update docs pointing to unittest2 (PR #82672)

2024-02-22 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/82672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Remove/update docs pointing to unittest2 (PR #82672)

2024-02-22 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/82672 None >From 9b971b403448a6e7ff374558c5d963b7c5636ea1 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Thu, 22 Feb 2024 10:24:22 -0800 Subject: [PATCH] [lldb][docs] Remove/update docs pointing to unittest2

[Lldb-commits] [lldb] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initialize in the unit tests (PR #82096)

2024-02-21 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > This change has caused a failing test on Linux: > https://lab.llvm.org/buildbot/#/builders/68/builds/69157 > Fixed w/ 675791335285fa86434dc46e5c92f543e0e79d19 https://github.com/llvm/llvm-project/pull/82096 ___ lldb-commits

[Lldb-commits] [lldb] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initialize in the unit tests (PR #82096)

2024-02-21 Thread Jordan Rupprecht via lldb-commits
@@ -9,43 +9,27 @@ #include "gtest/gtest.h" #include "Plugins/ScriptInterpreter/Python/SWIGPythonBridge.h" -#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.h" -#include "Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h" #include

[Lldb-commits] [lldb] 6757913 - [lldb][test] Fix PythonDataObjectsTest

2024-02-21 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2024-02-21T22:59:03-08:00 New Revision: 675791335285fa86434dc46e5c92f543e0e79d19 URL: https://github.com/llvm/llvm-project/commit/675791335285fa86434dc46e5c92f543e0e79d19 DIFF:

[Lldb-commits] [lldb] [lldb][test] Modernize assertEqual(value, bool) (PR #82526)

2024-02-21 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/82526 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Modernize asserts (PR #82503)

2024-02-21 Thread Jordan Rupprecht via lldb-commits
@@ -456,8 +457,9 @@ def queues_with_libBacktraceRecording(self): "doing_the_work_2", "queue 2's pending item #0 should be doing_the_work_2", ) -self.assertTrue( -queue_performer_2.GetPendingItemAtIndex().IsValid() ==

[Lldb-commits] [lldb] [lldb][test] Modernize assertEqual(value, bool) (PR #82526)

2024-02-21 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/82526 Any time we see the pattern `assertEqual(value, bool)`, we can replace that with `assert(value)`. Likewise for `assertNotEqual`. Technically this relaxes the test a bit, as we may want to make sure `value` is

[Lldb-commits] [lldb] [lldb][test] Modernize asserts (PR #82503)

2024-02-21 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/82503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Modernize asserts (PR #82503)

2024-02-21 Thread Jordan Rupprecht via lldb-commits
@@ -456,8 +457,9 @@ def queues_with_libBacktraceRecording(self): "doing_the_work_2", "queue 2's pending item #0 should be doing_the_work_2", ) -self.assertTrue( -queue_performer_2.GetPendingItemAtIndex().IsValid() ==

[Lldb-commits] [lldb] [lldb] Replace assertEquals with assertEqual (NFC) (PR #82073)

2024-02-20 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: Thanks! Nice cleanup. https://github.com/llvm/llvm-project/pull/82073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-15 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: Skipped the test in 65c25a4c40865a0e460c0fecb1b33f7cf7455573 Tear down behavior was patched for LLDB back in b1490b6172c48cf802b24bd738c90eeb019436fe. I'm guessing that explains why we weren't noticing those errors -- they get logged as cleanup_errors, not as errors. (Maybe

[Lldb-commits] [lldb] 65c25a4 - [lldb][test] Skip TestDAP_commands.py test due to flakiness

2024-02-15 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2024-02-15T11:51:44-08:00 New Revision: 65c25a4c40865a0e460c0fecb1b33f7cf7455573 URL: https://github.com/llvm/llvm-project/commit/65c25a4c40865a0e460c0fecb1b33f7cf7455573 DIFF:

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-15 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: I believe the old unittest framework may have been ignoring failures that happen during teardown. I have started looking at https://github.com/llvm/llvm-project/issues/81686 a bit, but +1 to suppressing this temporarily -- I should be able to land that in a bit.

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-14 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/81703 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-14 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > Yeah given GreenDragon has been red for 20h, I'd like to get this merged > sooner rather than later. @DavidSpickett what's the benefit of waiting for > the arm bots to come back up? Broadly speaking, if a buildbot is down, it interferes with bisection if something

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-14 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: The arm bots still haven't picked up the change :( Green Dragon is back online, and TestRequireHWBreakpoints.py is failing:

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-13 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/81703 Switching to modern `unittest` in 5b386158aacac4b41126983a5379d36ed413d0ea needs xfail annotations to be known prior to test running. In contrast, skipping can happen at any time, even during test execution.

[Lldb-commits] [lldb] [lldb][test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-02-13 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: I got one buildbot email: https://lab.llvm.org/buildbot/#/builders/68/builds/68776 Looks like lldb-dap crashes occasionally, and so the `disconnect` event doesn't get the response it was expecting. (The buildbot does not enable the dap request/response logging, but I have it

[Lldb-commits] [lldb] [lldb][test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-02-13 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/79945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-02-13 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/79945 >From ff9ef2f1dba9b2227916c16ebf7c11810e67a1dd Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Mon, 29 Jan 2024 19:07:36 -0800 Subject: [PATCH 1/6] Blanket unittest2 -> unittest replacement (excluding

[Lldb-commits] [lldb] [lldb][test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-01-30 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > I ran this on Arm and AArch64 Linux. One test > `lldb/test/API/functionalities/breakpoint/hardware_breakpoints/require_hw_breakpoints/TestRequireHWBreakpoints.py` > was xfailed on AArch64 is now not. Before: > > ``` > PASS: LLDB

[Lldb-commits] [lldb] [test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-01-29 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/79945 This removes the dependency LLDB API tests have on lldb/third_party/Python/module/unittest2, and instead uses the standard one provided by Python. This does not actually remove the vendored dep yet, nor

[Lldb-commits] [llvm] [clang-tools-extra] [clang] [libc] [mlir] [lldb] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2024-01-19 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/73067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [lldb] [llvm] [clang] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2024-01-19 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/73067 >From 22bfc5878f1f96b3138a03eea4dc856948185c89 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Tue, 21 Nov 2023 17:28:30 -0800 Subject: [PATCH 1/2] [lldb][test] Apply @expectedFailureAll/@skipIf early

[Lldb-commits] [lldb] [LLDB] Fix write permission error in TestGlobalModuleCache.py (PR #76171)

2023-12-21 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: IIUC, the issue is that even though we are working in the build directory, which is writeable, we are copying a file from the source tree, which may be readonly, and those readonly permission bits persist when they're copied to the build directory.

[Lldb-commits] [clang-tools-extra] [lldb] [llvm] [clang] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2023-12-05 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > Is this a performance optimization or a function al change? Neither. This should only affect tests, and the set of tests we skip/mark as xfail should not change, we just generally know about it earlier in the test setup. https://github.com/llvm/llvm-project/pull/73067

[Lldb-commits] [clang] [clang-tools-extra] [llvm] [lldb] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2023-12-05 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: ping :) https://github.com/llvm/llvm-project/pull/73067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [clang-tools-extra] [clang] [lldb] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2023-11-28 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/73067 >From 22bfc5878f1f96b3138a03eea4dc856948185c89 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Tue, 21 Nov 2023 17:28:30 -0800 Subject: [PATCH 1/2] [lldb][test] Apply @expectedFailureAll/@skipIf early

[Lldb-commits] [lldb] [lldb][test] Remove `reason` from `unittest2.expectedFailure` usage (PR #73028)

2023-11-28 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/73028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove `reason` from `unittest2.expectedFailure` usage (PR #73028)

2023-11-27 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/73028 >From a0805cfc2b2b1c84d58c0551ccf1acfaf2326a4a Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Tue, 21 Nov 2023 11:38:43 -0800 Subject: [PATCH 1/3] [lldb][test] Remove `reason` from

[Lldb-commits] [lldb] [lldb][test] Remove `reason` from `unittest2.expectedFailure` usage (PR #73028)

2023-11-27 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > I suppose we don't really lose anything by moving away from `expectedFailure` > from decorators? > Someone filed a FR ages ago for the standard unittest to take a reason for xfail: https://bugs.python.org/issue12681 tl;dr good idea but that ship has sailed. So, this PR

[Lldb-commits] [lldb] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2023-11-27 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > * This is still early enough that the standard `unittest` framework will > recognize the test as xfail/skip by the time the test actually runs. I did a little bit more research, turns out this is not a difference between unittest and unittest2, but rather just something we

[Lldb-commits] [lldb] [lldb][test] Remove `reason` from `unittest2.expectedFailure` usage (PR #73028)

2023-11-21 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/73028 >From a0805cfc2b2b1c84d58c0551ccf1acfaf2326a4a Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Tue, 21 Nov 2023 11:38:43 -0800 Subject: [PATCH 1/2] [lldb][test] Remove `reason` from

[Lldb-commits] [lldb] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2023-11-21 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/73067 >From 22bfc5878f1f96b3138a03eea4dc856948185c89 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Tue, 21 Nov 2023 17:28:30 -0800 Subject: [PATCH 1/2] [lldb][test] Apply @expectedFailureAll/@skipIf early

[Lldb-commits] [lldb] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2023-11-21 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/73067 The @expectedFailureAll and @skipIf decorators will mark the test case as xfail/skip if _all_ conditions passed in match, including debug_info. * If debug_info is not one of the matching conditions, we can

[Lldb-commits] [lldb] [lldb][test] Remove `reason` from `unittest2.expectedFailure` usage (PR #73028)

2023-11-21 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: This cleanup isn't strictly required to proceed w/ unittest2->unittest; we already have a wrapper in decorators.py that we could update, from: ```py def expectedFailure(func): return unittest2.expectedFailure(func) ``` To: ```py def expectedFailure(func): if

[Lldb-commits] [lldb] [lldb][test] Remove `reason` from `unittest2.expectedFailure` usage (PR #73028)

2023-11-21 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/73028 None >From a0805cfc2b2b1c84d58c0551ccf1acfaf2326a4a Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Tue, 21 Nov 2023 11:38:43 -0800 Subject: [PATCH] [lldb][test] Remove `reason` from

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

2023-11-15 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/72416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

2023-11-15 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > Beautiful, thank you for working on this. After this change, what's left to > get us using the python-provided `unittest`? The giant lambda inside `_decorateTest` has one remaining `self` reference, which is `self.getDebugInfo()` -- i.e. the debug info specific variant

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

2023-11-15 Thread Jordan Rupprecht via lldb-commits
@@ -184,3 +187,144 @@ def hasChattyStderr(test_case): ): return True # The dynamic linker on the device will complain about unknown DT entries return False + + +def builder_module(): +return get_builder(sys.platform) + + +def getArchitecture(): +

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

2023-11-15 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/72416 >From b3178bb93c0d414857732b08228987894df762d4 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Wed, 15 Nov 2023 08:58:17 -0800 Subject: [PATCH 1/2] [lldb][test] Move most `self` references out of

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

2023-11-15 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht edited https://github.com/llvm/llvm-project/pull/72416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

2023-11-15 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/72416 None >From b3178bb93c0d414857732b08228987894df762d4 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Wed, 15 Nov 2023 08:58:17 -0800 Subject: [PATCH] [lldb][test] Move most `self` references out of

[Lldb-commits] [lldb] Detect against invalid variant index for LibStdC++ std::variant data formatters (PR #69253)

2023-10-17 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: This seems to cause `TestTemplatePackArgs.py` to fail, e.g. https://lab.llvm.org/buildbot/#/builders/68/builds/61819 ```shell File "/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/test/API/lang/cpp/class-template-parameter-pack/TestTemplatePackArgs.py", line 42, in

[Lldb-commits] [lldb] 6db44e5 - [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.

2023-03-02 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2023-03-02T13:51:30-08:00 New Revision: 6db44e52ce474bbeb66042073a6e3c6c586f78a2 URL: https://github.com/llvm/llvm-project/commit/6db44e52ce474bbeb66042073a6e3c6c586f78a2 DIFF:

[Lldb-commits] [lldb] dd9b31e - [test] Remove unused `unittest2` import from concurrent_base.py

2023-01-26 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2023-01-26T18:23:23-08:00 New Revision: dd9b31e2c2a271c9e6059dde6a406aea5ed8b663 URL: https://github.com/llvm/llvm-project/commit/dd9b31e2c2a271c9e6059dde6a406aea5ed8b663 DIFF:

[Lldb-commits] [lldb] d5c0b1f - [test] Remove unused `unittest2` import

2023-01-26 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2023-01-26T18:02:16-08:00 New Revision: d5c0b1f73b0502158d9b3afa0ba7b22b69f0823e URL: https://github.com/llvm/llvm-project/commit/d5c0b1f73b0502158d9b3afa0ba7b22b69f0823e DIFF:

[Lldb-commits] [lldb] dc682ed - [test][lldb-vscode] Fix unclean shutdown in test_terminate_commands

2023-01-26 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2023-01-26T14:29:48-08:00 New Revision: dc682ed590f73f7b7417ecf66d18b303ab957c62 URL: https://github.com/llvm/llvm-project/commit/dc682ed590f73f7b7417ecf66d18b303ab957c62 DIFF:

[Lldb-commits] [lldb] 5ed6d99 - [lldb] Remove legacy six module for py2->py3

2023-01-24 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2023-01-24T19:46:26-08:00 New Revision: 5ed6d99a8311e54762df3d40dfb1d12578aaa4f5 URL: https://github.com/llvm/llvm-project/commit/5ed6d99a8311e54762df3d40dfb1d12578aaa4f5 DIFF:

[Lldb-commits] [lldb] 3afe296 - [test][lldb-vscode] Relax assertion to allow multiple compile units returned.

2022-12-22 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2022-12-22T05:19:29-08:00 New Revision: 3afe296c81b93473c1e5008514d6225a2200ad19 URL: https://github.com/llvm/llvm-project/commit/3afe296c81b93473c1e5008514d6225a2200ad19 DIFF:

[Lldb-commits] [lldb] f9d8090 - Improve error handling for invalid breakpoint `-t` and `-x` options.

2022-12-08 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2022-12-08T17:53:54-08:00 New Revision: f9d8090a90a1f1f9ddf6aebb82e7fc4c1dbcf030 URL: https://github.com/llvm/llvm-project/commit/f9d8090a90a1f1f9ddf6aebb82e7fc4c1dbcf030 DIFF:

[Lldb-commits] [lldb] 28b869d - [NFC] Fix leak handling breakpoint names.

2022-12-08 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2022-12-08T17:14:38-08:00 New Revision: 28b869d8724207bd7fd8b80f57f6c02abe4bc607 URL: https://github.com/llvm/llvm-project/commit/28b869d8724207bd7fd8b80f57f6c02abe4bc607 DIFF:

[Lldb-commits] [lldb] 23f145d - [NFC] Fix leak in command options configuration.

2022-12-08 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2022-12-08T16:37:43-08:00 New Revision: 23f145daa50c3f51a7fb8c8d68c55e5f4a8027c2 URL: https://github.com/llvm/llvm-project/commit/23f145daa50c3f51a7fb8c8d68c55e5f4a8027c2 DIFF:

[Lldb-commits] [lldb] 3c51ea3 - [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION` enabled.

2022-11-30 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2022-11-30T13:20:13-08:00 New Revision: 3c51ea3619e488db19cd26840ed46d58cfc7062f URL: https://github.com/llvm/llvm-project/commit/3c51ea3619e488db19cd26840ed46d58cfc7062f DIFF:

[Lldb-commits] [lldb] 7d26f9e - [test] Allow libc++ namespaces besides `__1`

2022-11-29 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2022-11-29T04:34:40-08:00 New Revision: 7d26f9e1329f981ed43eb31f66891702de2f6470 URL: https://github.com/llvm/llvm-project/commit/7d26f9e1329f981ed43eb31f66891702de2f6470 DIFF:

[Lldb-commits] [lldb] 3c10e9c - [test] Implement layout for unstable std::string garbage formatter tests.

2022-11-29 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2022-11-29T04:22:30-08:00 New Revision: 3c10e9c77332ad0472d8641a62b8faf76deef0bf URL: https://github.com/llvm/llvm-project/commit/3c10e9c77332ad0472d8641a62b8faf76deef0bf DIFF:

[Lldb-commits] [lldb] cd02e78 - [NFC] Make headers self-contained.

2022-11-29 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2022-11-29T04:14:55-08:00 New Revision: cd02e78cd5cdfa079f2a82f34fea25bee1ae02da URL: https://github.com/llvm/llvm-project/commit/cd02e78cd5cdfa079f2a82f34fea25bee1ae02da DIFF:

[Lldb-commits] [lldb] 71b2ff7 - [test] Fix TestSourceManager when the source file is readonly.

2022-11-21 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2022-11-21T11:56:02-08:00 New Revision: 71b2ff79043aea637335b28299e978b678fd83bd URL: https://github.com/llvm/llvm-project/commit/71b2ff79043aea637335b28299e978b678fd83bd DIFF:

  1   2   >