[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-09-03 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 555625. kkcode0 marked an inline comment as done. kkcode0 added a comment. use ptracewrapper Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files:

[Lldb-commits] [PATCH] D158251: [lldb] Propagate destination type's byte order to memory writer

2023-09-03 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 555624. kkcode0 added a comment. use ptracewrapper Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158251/new/ https://reviews.llvm.org/D158251 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-09-02 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:186-193 - -if (!SetRendezvousBreakpoint()) { - // If we cannot establish rendezvous breakpoint right now we'll try again - // at entry point. -

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-09-02 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:114-117 + tp = LLDB_INVALID_ADDRESS; + Status error; + return error; +} labath wrote: > Is this necessary, given that the function is already stubbed

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-09-02 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 92. kkcode0 marked an inline comment as done. kkcode0 added a comment. spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files:

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-09-02 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 91. kkcode0 marked 3 inline comments as done. kkcode0 added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files:

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-09-02 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 75. kkcode0 added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-09-02 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 74. kkcode0 marked an inline comment as done. kkcode0 added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files:

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-09-02 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 73. kkcode0 added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-09-02 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 72. kkcode0 added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h

[Lldb-commits] [PATCH] D158251: [lldb] Propagate destination type's byte order to memory writer

2023-08-18 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 551398. kkcode0 added a comment. typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158251/new/ https://reviews.llvm.org/D158251 Files: lldb/include/lldb/Symbol/CompilerType.h

[Lldb-commits] [PATCH] D158251: [lldb] Propagate destination type's byte order to memory writer

2023-08-18 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 551397. kkcode0 added a comment. Herald added a subscriber: JDevlieghere. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158251/new/ https://reviews.llvm.org/D158251 Files:

[Lldb-commits] [PATCH] D158251: [lldb] Propagate destination type's byte order to memory writer

2023-08-18 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 created this revision. Herald added a project: All. kkcode0 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When a compiler attaches endianess to type, debugger should honor that when writing to variables of that variable.

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-02-15 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-02-10 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 496655. kkcode0 added a comment. added comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-02-10 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 496654. kkcode0 added a comment. added comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Target/RegisterContext.h Index:

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-02-10 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 496392. kkcode0 added a comment. enabled the tls test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h

[Lldb-commits] [PATCH] D143698: Cleanedup and added comments

2023-02-10 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 496360. kkcode0 added a comment. rebased with main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h

[Lldb-commits] [PATCH] D143698: Cleanedup and added comments

2023-02-09 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 496347. kkcode0 added a comment. mark some vars used Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h

[Lldb-commits] [PATCH] D143698: Cleanedup and added comments

2023-02-09 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 updated this revision to Diff 496321. kkcode0 added a comment. Herald added a subscriber: Michael137. rebase all changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files:

[Lldb-commits] [PATCH] D143698: Cleanedup and added comments

2023-02-09 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 created this revision. Herald added a project: All. kkcode0 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143698 Files: