[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

lawrence_danna marked an inline comment as done. lawrence_danna added a comment. fixed whitespace and commited Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114973/new/ https://reviews.llvm.org/D114973

[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

This revision was automatically updated to reflect the committed changes. Closed by commit rG27ca9458012c: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D114973?vs=391384=391541#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. @clayborg Does this fix it for you? https://reviews.llvm.org/D114973 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 ___

[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jingham, JDevlieghere. lawrence_danna requested review of this revision. Herald added a project: LLDB. Some pythons are configured to set platlib somewhere outside of their sys.prefix. It's important that we at least

[Lldb-commits] [PATCH] D114106: [lldb] remove usage of distutils, fix python path on debian/ubuntu

This revision was automatically updated to reflect the committed changes. Closed by commit rG63270710f13a: [lldb] remove usage of distutils, fix python path on debian/ubuntu (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D114106: [lldb] remove usage of distutils, fix python path on debian/ubuntu

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jingham, JDevlieghere. Herald added a subscriber: mgorny. lawrence_danna requested review of this revision. Herald added a project: LLDB. distutils is deprecated and will be removed, so we shouldn't be using it. We

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. In D113650#3136407 , @aprantl wrote: > This seems to have broken the green dragon incremental bot: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38387/ looks like its fixed now. Repository: rG LLVM

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. In D113650#3136407 , @aprantl wrote: > This seems to have broken the green dragon incremental bot: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38387/ Crosscompiling LLDB with Python requires manually

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGae389b2450bd: [lldb] use EXT_SUFFIX for python extension (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112972/new/

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c2cf3a314d9: [lldb] fix -print-script-interpreter-info on windows (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

lawrence_danna updated this revision to Diff 386996. lawrence_danna added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112972/new/ https://reviews.llvm.org/D112972 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386995. lawrence_danna added a comment. cmake fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

lawrence_danna updated this revision to Diff 386970. lawrence_danna added a comment. rebased, and include win32 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112972/new/ https://reviews.llvm.org/D112972 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386968. lawrence_danna added a comment. revert change that disabled the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. In D113650#3128674 , @stella.stamenova wrote: > Can you please disable the test on Windows or back your change out until > there's a fix? There are already other failures that are getting missed > because the bot is

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386967. lawrence_danna added a comment. cleanup cmake usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386878. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. fix cmake error message condition for cross-compile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. OK this should work in all configs I think, as long as sys.executable ultimately points at something under sys.prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386599. lawrence_danna added a comment. Herald added a subscriber: mgorny. maybe this approach is better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:432 + elif os.name == 'posix': + exename = "python" + str(sys.version_info[0]) + info['executable'] = os.path.join(sys.prefix, 'bin', exename)

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:413 +static const char GetInterpreterInfoScript[] = R"( +import os stella.stamenova wrote: > Does `sys.executable` not work for some

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna added a comment. In D112973#3122496 , @stella.stamenova wrote: > Windows buildbot is broken: > > https://lab.llvm.org/buildbot/#/builders/83/builds/11865 eek, sorry. fix is here: https://reviews.llvm.org/D113650 Repository: rG LLVM

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. lawrence_danna requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Apparently "{sys.prefix}/bin/python3" isn't where you find the python

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbef51eb43c2: [lldb] make it easier to find LLDBs python (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 386198. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 Files:

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBHostOS.h:23 + const char *GetScriptInterpreterInfo(); + JDevlieghere wrote: > Is still still relevant? nope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 386170. lawrence_danna added a comment. changed internal apis to use StructuredData instead of char* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 Files:

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 385712. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 385711. lawrence_danna added a comment. updated according to reviewer feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 Files:

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

lawrence_danna added a comment. @stella.stamenova fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/ https://reviews.llvm.org/D113047 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

lawrence_danna added a comment. In D113047#3106732 , @stella.stamenova wrote: > The Windows buildbot is still broken after this change: > > https://lab.llvm.org/buildbot/#/builders/83/builds/11630 sorry again :/ I will fix. It's takaing me a

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna added a comment. @JDevlieghere That approach would work great for my purposes, i'll update like that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f01f78593d6: [lldb] update TestEchoCommands (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna added a comment. In D112988#3103992 , @stella.stamenova wrote: > It looks like some of the tests need to be updated after this change (at > least on Windows, the Windows LLDB bot is broken now): > >

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham, stella.stamenova. lawrence_danna requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Followup to https://reviews.llvm.org/D112988

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2a6c08bbc38: [lldb] fix --source-quietly (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112988/new/

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna added a comment. In D112988#3103574 , @jingham wrote: > Ha! It was apparently so easy to add the test that it wasn't noticeable (at > least by me!). > > This isn't directly relevant to your patch, since this wasn't behavior you >

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna marked an inline comment as done. lawrence_danna added a comment. In D112988#3103463 , @jingham wrote: > There was one typo I pointed out, and it would be good to add a test. I'm > sure this worked at some point, but wasn't tested so it

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna updated this revision to Diff 384155. lawrence_danna added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112988/new/ https://reviews.llvm.org/D112988 Files: lldb/docs/man/lldb.rst

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. Herald added subscribers: dang, pengfei. lawrence_danna requested review of this revision. Herald added a project: LLDB. Jim says: lldb has a -Q or --source-quietly option, which supposedly

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 383978. lawrence_danna added a comment. change lldb-python into a script instead of a feature of Driver.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna added a comment. In D112973#3101602 , @JDevlieghere wrote: > FWIW `crashlog.py` has a good example of how to import LLDB. It's complicated > slightly by us having to honor the `LLDB_DEFAULT_PYTHON_VERSION`, but > otherwise it's pretty

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. Herald added subscribers: dang, mgorny. lawrence_danna requested review of this revision. Herald added a project: LLDB. It is surprisingly difficult to write a simple python script that can

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. Herald added a subscriber: mgorny. lawrence_danna requested review of this revision. Herald added a project: LLDB. LLDB doesn't use only the python stable ABI, which means loading it into an

[Lldb-commits] [PATCH] D111965: [lldb] improve the help strings for gdb-remote and kdp-remote

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ac5a6641fa4: [lldb] improve the help strings for gdb-remote and kdp-remote (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D111965: [lldb] improve the help strings for gdb-remote and kdp-remote

lawrence_danna updated this revision to Diff 380257. lawrence_danna added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111965/new/ https://reviews.llvm.org/D111965 Files: lldb/source/Interpreter/CommandInterpreter.cpp

[Lldb-commits] [PATCH] D111965: [lldb] improve the help strings for gdb-remote and kdp-remote

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere. lawrence_danna requested review of this revision. Herald added a project: LLDB. The help string can be more helpful by explaining these are aliases for 'process connect' Repository: rG LLVM

[Lldb-commits] [PATCH] D111910: Fix Xcode project for debugserver

This revision was automatically updated to reflect the committed changes. Closed by commit rG4594f8116543: Fix Xcode project for debugserver (authored by Lawrence D\Anna lawrence_da...@apple.com, committed by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D111910: Fix Xcode project for debugserver

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere. lawrence_danna requested review of this revision. Herald added a project: LLDB. It seems StringConvert.cpp was moved, and the Xcode project file wasn't updated. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D87051: scan-build-py: fix multiprocessing error

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c642828612d: scan-build-py: fix multiprocessing error (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87051/new/

[Lldb-commits] [PATCH] D87051: scan-build-py: fix multiprocessing error

lawrence_danna created this revision. lawrence_danna added reviewers: ldionne, chandlerc, jasonmolenda, JDevlieghere. Herald added subscribers: cfe-commits, dexonsmith, whisperity. Herald added a project: clang. lawrence_danna requested review of this revision. Recent versions of python3's

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

lawrence_danna accepted this revision. lawrence_danna added a comment. This revision is now accepted and ready to land. Looks fine to me, assuming that the tests pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86381/new/

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:500 + } +}; + lawrence_danna wrote: > aadsm wrote: > > labath wrote: > > > Could you also `= delete` the copy operations to make sure nothing funny > > > happens with

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:500 + } +}; + aadsm wrote: > labath wrote: > > Could you also `= delete` the copy operations to make sure nothing funny > > happens with those. > The `= delete` is

[Lldb-commits] [PATCH] D78603: remove unused function LLDBSwigPython_GetIndexOfChildWithName

lawrence_danna abandoned this revision. lawrence_danna added a comment. despite there being no references to this function, it is not actually unused. This change causes `TestFormattersSBAPI.py` to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

This revision was automatically updated to reflect the committed changes. Closed by commit rG52712d3ff7a2: Re-land get rid of PythonInteger::GetInteger() (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D78462?vs=259916=262908#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna added a comment. @omjavaid ok to re-land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 259916. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 259700. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna added a comment. @omjavaid sorry I didn't catch that on pre-submit testing. `PyLong_AsLongLong` and friends do not automatically convert on python2 like they do on python3. It's fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 259659. lawrence_danna added a comment. fix python2 projblems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D78603: remove unused function LLDBSwigPython_GetIndexOfChildWithName

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jasonmolenda, JDevlieghere. Herald added subscribers: lldb-commits, arphaman. Herald added a project: LLDB. Remove LLDBSwigPython_GetIndexOfChildWithName and associated functions. They are not used. Repository: rG

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

This revision was automatically updated to reflect the committed changes. Closed by commit rG737521217295: get rid of PythonInteger::GetInteger() (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D78462?vs=259131=259134#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 259131. lawrence_danna marked 4 inline comments as done. lawrence_danna added a comment. wrap long line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files:

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:585-597 +llvm::Expected result = pfunc.Call(PythonString(child_name)); -if (!result.IsAllocated()) -return UINT32_MAX; +long long retval =

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 258831. lawrence_danna added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:3153-3159 + long long py_return = unwrapOrSetPythonException( + As(implementor.CallMethod(callee_name))); // if it fails, print the error but

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 258810. lawrence_danna marked 4 inline comments as done. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files:

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jasonmolenda, JDevlieghere, vadimcn. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. One small step in my long running quest to improve python exception handling in LLDB. Replace GetInteger()

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8de17bca658: Fix illegal early call to PyBuffer_Release in swig typemaps (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna updated this revision to Diff 255772. lawrence_danna added a comment. fix initializer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna marked an inline comment as done. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna updated this revision to Diff 255464. lawrence_danna added a comment. delete operator= too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna updated this revision to Diff 255447. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 Files: lldb/bindings/python/python-typemaps.swig Index:

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added a comment. In D77480#1963315 , @labath wrote: > Thanks for getting back to this. Is there any reasonable way of testing this > (e.g. an existing python class with temporary buffer storage), or would we > have to implement our own

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added a comment. Those errors don't look like they could possibly be related to these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added a comment. thanks @vadimcn for pointing this out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jasonmolenda, JDevlieghere, vadimcn. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lawrence_danna added a comment. thanks @vadimcn for pointing this out. The buffer protocol does not allow us

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/trunk/scripts/Python/python-typemaps.swig:481 + PyBuffer_Release(); + $1 = ($1_ltype) buf; + $2 = ($2_ltype) (size/sizeof($*1_type)); labath wrote: >

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

This revision was automatically updated to reflect the committed changes. Closed by commit rGadbf64ccc9e1: [LLDB][Python] remove ArgInfo::count (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69742/new/

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. In D69742#1732608 , @labath wrote: > At this point, should we just delete the ArgInfo struct altogether, and > replace it with a plain `unsigned`? Sounds like a good idea

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:764 } #if PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >= 3 JDevlieghere wrote: > Should we

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

lawrence_danna created this revision. lawrence_danna added reviewers: labath, mgorny, JDevlieghere. Herald added a project: LLDB. This patch updates the last user of ArgInfo::count and deletes it. I also delete `GetNumInitArguments()` and `GetInitArgInfo()`. Classess are callables and

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

This revision was automatically updated to reflect the committed changes. Closed by commit rG3071ebf7b383: [LLDB][PythonFile] fix dangerous borrow semantics on python2 (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

lawrence_danna abandoned this revision. lawrence_danna added a comment. thanks for the feedback, I'll come back with a "Dense" version of this at some point Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69230/new/ https://reviews.llvm.org/D69230

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

lawrence_danna added a comment. @labath looks like you were right, just not flushing seems to work fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69532/new/ https://reviews.llvm.org/D69532 ___

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

lawrence_danna updated this revision to Diff 227009. lawrence_danna added a comment. fix the test too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69532/new/ https://reviews.llvm.org/D69532 Files:

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

lawrence_danna updated this revision to Diff 227007. lawrence_danna added a comment. just don't even flush Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69532/new/ https://reviews.llvm.org/D69532 Files:

[Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

This revision was automatically updated to reflect the committed changes. Closed by commit rGa69bbe02a235: [LLDB][breakpoints] ArgInfo::count - ArgInfo::max_positional_args (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

lawrence_danna marked 4 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:76-79 +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wreturn-type-c-linkage" + +extern

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

lawrence_danna added a comment. In D69532#1724806 , @labath wrote: > So, if I understand correctly. The problem here is the final call to > `fflush`, which can end up referencing a closed FILE*. Can we just not call > `fflush` then? Hrm, maybe. I'll

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a93a12a8dd9: [LLDB][Python] fix another fflush issue on NetBSD (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

lawrence_danna created this revision. lawrence_danna added reviewers: labath, mgorny. Herald added a project: LLDB. It is, I think, inherently unsafe to hand a borrowed native file object to a python program on python 2. This is because the python file object must be created with a FILE*, not

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226747. lawrence_danna added a comment. revert to previous version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Files:

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna added a comment. In D69488#1724178 , @mgorny wrote: > I have confirmed that your previous revision fixed the problem in question. > The newer one would probably require full test suite run which I can't do > right now. As I said, I would

[Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

lawrence_danna updated this revision to Diff 226737. lawrence_danna added a comment. improved error handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69468/new/ https://reviews.llvm.org/D69468 Files:

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna added a comment. In D69488#1723481 , @labath wrote: > I am not thrilled by all of that duping going around. Having multiple FILE > objects means that you have multiple independent file caches too. That can > cause different kinds of

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna added a comment. There, I think that fixes the issue with borrow semantics and the NetBSD issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488

  1   2   3   4   5   >