[Lldb-commits] [PATCH] D74917: [lldb/cmake] Enable more verbose find_package output.

2020-02-21 Thread Matt Davis via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG07d2cdae1163: [lldb/cmake] Enable more verbose find_package output. (authored by mattd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74917/new/

[Lldb-commits] [PATCH] D74917: [lldb/cmake] Enable more verbose find_package output.

2020-02-20 Thread Matt Davis via Phabricator via lldb-commits
mattd updated this revision to Diff 245771. mattd retitled this revision from "[lldb/cmake] Fail configuration if a required swig dependency is not met." to "[lldb/cmake] Enable more verbose find_package output.". mattd edited the summary of this revision. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74917: [lldb/cmake] Fail configuration if a required swig dependency is not met.

2020-02-20 Thread Matt Davis via Phabricator via lldb-commits
mattd added a comment. In D74917#1885621 , @JDevlieghere wrote: > In D74917#1885615 , @mattd wrote: > > > In D74917#1885590 , @JDevlieghere > > wrote: > > > > > It should

[Lldb-commits] [PATCH] D74917: [lldb/cmake] Fail configuration if a required swig dependency is not met.

2020-02-20 Thread Matt Davis via Phabricator via lldb-commits
mattd updated this revision to Diff 245763. mattd retitled this revision from "[lldb/bindings] Fail configuration when a required dependency is not met." to "[lldb/cmake] Fail configuration if a required swig dependency is not met.". CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74917: [lldb/bindings] Fail configuration when a required dependency is not met.

2020-02-20 Thread Matt Davis via Phabricator via lldb-commits
mattd added a comment. In D74917#1885590 , @JDevlieghere wrote: > It should never be possible for `LLDB_ENABLE_PYTHON` to be true but > `SWIG_FOUND` to be false. The modules `FindPythonInterpAndLibs.cmake` and > `FindLuaAndSwig.cmake` should fail early

[Lldb-commits] [PATCH] D74917: [lldb/bindings] Fail configuration when a required dependency is not met.

2020-02-20 Thread Matt Davis via Phabricator via lldb-commits
mattd created this revision. mattd added reviewers: aadsm, hhb. mattd added a project: LLDB. Herald added a subscriber: mgorny. If the SWIG dependency is required {LLDB_ENABLE_PYTHON, LLDB_ENABLE_LUA} and SWIG is not available, fail the configuration step. Terminate the configure early rather