[Lldb-commits] [PATCH] D137338: Fix dupe word typos

Meinersbur added a comment. Changes in `/polly/` look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

Meinersbur added a comment. Semi-OT: `polly\lib\External` has 3 more third-party libraries. Two of them have been heavily modified in-tree, the third has just a custom CMakeLists.txt. Should these eventually also be moved? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D129131: Remove uses of llvm_shutdown

Meinersbur added inline comments. Comment at: polly/lib/External/isl/interface/extract_interface.cc:590 delete Clang; - llvm::llvm_shutdown(); This file is imported from the upstream project

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Meinersbur added a comment. In D99484#2724435 , @Ericson2314 wrote: > I effectively replaced `${CMAKE_INSTALL_PREFIX}/lib` with > `${CMAKE_INSTALL_LIBDIR}`, which evaluates (by default) merely to `lib`. The > fix was `${CMAKE_INSTALL_FULL_LIBDIR}` which

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Meinersbur added a comment. In D99484#2724055 , @Ericson2314 wrote: > Fix bug makeing polly path full, and rebase fixing conflicts What was the problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Meinersbur added a comment. In D99484#2668225 , @Ericson2314 wrote: > Additionally, I have cleaned up the `polly` code so that I need not change it > so much, and it should still work with absolute or relative paths quite > flexibly. Looks fine to me.

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Meinersbur added inline comments. Comment at: polly/cmake/CMakeLists.txt:82-96 +set(POLLY_INSTALL_PREFIX "") set(POLLY_CONFIG_LLVM_CMAKE_DIR "${LLVM_BINARY_DIR}/${LLVM_INSTALL_PACKAGE_DIR}") -set(POLLY_CONFIG_CMAKE_DIR "${POLLY_INSTALL_PREFIX}/${POLLY_INSTALL_PACKAGE_DIR}")

[Lldb-commits] [PATCH] D84780: Setting the /bigobj option globally for Windows debug build. https://bugs.llvm.org/show_bug.cgi?id=46733

Meinersbur added a comment. Hasn't this already been done in 80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84780/new/

[Lldb-commits] [PATCH] D84038: On Windows build, making the /bigobj flag global , instead of passing it per file.

This revision was automatically updated to reflect the committed changes. Closed by commit rG80bd6ae13ea2: On Windows build, making the /bigobj flag global , instead of passing it per… (authored by zahiraam, committed by Meinersbur). Herald added projects: clang, LLDB. Herald added subscribers: