[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b63ca1379a8: [Mips] Use appropriate private label prefix based on Mips ABI (authored by mbrkusanin). Changed prior to commit: https://reviews.llvm.org/D66795?vs=224603=226112#toc Repository: rG

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 224603. mbrkusanin added a comment. - Rebase - Ping @echristo @craig.topper @tstellar @dylanmckay @petecoup If there are no objections then I'll split this into llvm, clang and lldb patches and commit them next week. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 221931. mbrkusanin added reviewers: echristo, craig.topper, uweigand, tstellar, dylanmckay, petecoup. mbrkusanin added a comment. - rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 Files:

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin added a comment. @echristo @craig.topper @uweigand @tstellar @dylanmckay @petecoup Do you have any comments on the current patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 ___

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin added a comment. Any comment on whether we should split this into two patches? One that adds `MCTargetOptions` to `MCAsmInfo` and another one that just fixes prefixes for Mips. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 222832. mbrkusanin added a comment. - rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 Files: clang/lib/Parse/ParseStmtAsm.cpp clang/tools/driver/cc1as_main.cpp

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 220830. mbrkusanin added a comment. - `MipsMCAsmInfo()` now always reads ABI from `MipsABIInfo` instead of `Triple`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 Files:

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 220675. mbrkusanin added a comment. Herald added subscribers: lldb-commits, cfe-commits, seiya, lenary, rupprecht, jrtc27, hiraditya. Herald added projects: clang, LLDB. - MCTargetOptions is now always passed to MCAsmInfo (or rather createMCAsmInfo). In

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin added a comment. In D66795#1650305 , @atanasyan wrote: > But take a look at `LLVMCreateDisasmCPUFeatures` function from > `Disassembler.cpp`. If we cannot retrieve `MCTargetOptions` right in this > function, we will have to change "LLVM-C"