[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

petpav01 closed this revision. petpav01 added a comment. Landed as r315444 . Closing manually because I forgot to include "Differential Revision: ..." in the commit message. https://reviews.llvm.org/D38394 ___

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

petpav01 added a comment. Thanks, will commit shortly. https://reviews.llvm.org/D38394 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

petpav01 updated this revision to Diff 118375. petpav01 added a comment. Updated patch contains the following changes: - Remove comments for `DataExtractor::GetMaxU32()` and `GetMaxU64()` from `DataExtractor.cpp` and keep only the Doxygen ones in the header file. - Restore assertion for

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

petpav01 added inline comments. Comment at: source/Utility/DataExtractor.cpp:566 size_t byte_size) const { - switch (byte_size) { - case 1: -return GetU8(offset_ptr); -break; - case 2: -return GetU16(offset_ptr); -break; -

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

petpav01 added a comment. Thank you for the initial review. Comment at: source/Core/DumpDataExtractor.cpp:275-281 + // Reject invalid item_byte_size. + if (item_byte_size > 8) { +s->Printf("error: unsupported byte size (%" PRIu64 ") for char format", +

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

petpav01 created this revision. Herald added subscribers: kristof.beyls, aemerson. - Prevent dumping of characters in `DumpDataExtractor()` with `item_byte_size` bigger than 8 bytes. This case is not supported by the code and results in a crash because the code calls

[Lldb-commits] [PATCH] D35298: [MainLoop] Fix possible use of an invalid iterator

petpav01 created this revision. Store file descriptors from `loop.m_read_fds` (if `FORCE_PSELECT` is defined) and signals from `loop.m_signals` that need to be processed in `MainLoop::RunImpl::ProcessEvents()` into a separate vector and then iterate over this container to invoke the callbacks.