[Lldb-commits] [lldb] r307773 - Fixing Android builder

2017-07-12 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Wed Jul 12 04:54:17 2017 New Revision: 307773 URL: http://llvm.org/viewvc/llvm-project?rev=307773&view=rev Log: Fixing Android builder Modified: lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp Modified: lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp URL

[Lldb-commits] [lldb] r307768 - Adding Support for Error Strings in Remote Packets

2017-07-12 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Wed Jul 12 04:15:34 2017 New Revision: 307768 URL: http://llvm.org/viewvc/llvm-project?rev=307768&view=rev Log: Adding Support for Error Strings in Remote Packets Summary: This patch adds support for sending strings along with error codes in the reply packets. The implemen

[Lldb-commits] [lldb] r307030 - Fixing warnings for unused variables and copy ellision

2017-07-03 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Mon Jul 3 08:07:36 2017 New Revision: 307030 URL: http://llvm.org/viewvc/llvm-project?rev=307030&view=rev Log: Fixing warnings for unused variables and copy ellision Summary: The std::move was preventing copy ellision when compiled with clang, the patch fixes the warning

[Lldb-commits] [lldb] r306520 - Linux unit tests should only run on

2017-06-28 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Wed Jun 28 02:01:17 2017 New Revision: 306520 URL: http://llvm.org/viewvc/llvm-project?rev=306520&view=rev Log: Linux unit tests should only run on Linux based systems. Modified: lldb/trunk/unittests/Process/CMakeLists.txt Modified: lldb/trunk/unittests/Process/CMakeL

[Lldb-commits] [lldb] r306516 - Implementation of Intel(R) Processor Trace support for Linux

2017-06-28 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Wed Jun 28 00:58:31 2017 New Revision: 306516 URL: http://llvm.org/viewvc/llvm-project?rev=306516&view=rev Log: Implementation of Intel(R) Processor Trace support for Linux Summary: This patch implements support for Intel(R) Processor Trace in lldb server. The changes have

[Lldb-commits] [lldb] r303991 - Fixing Memory Leak

2017-05-26 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Fri May 26 09:26:14 2017 New Revision: 303991 URL: http://llvm.org/viewvc/llvm-project?rev=303991&view=rev Log: Fixing Memory Leak Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp Modified: lldb/trunk/source/Plugins/Process

[Lldb-commits] [lldb] r303972 - Implementation of remote packets for Trace data.

2017-05-26 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Fri May 26 06:46:27 2017 New Revision: 303972 URL: http://llvm.org/viewvc/llvm-project?rev=303972&view=rev Log: Implementation of remote packets for Trace data. Summary: The changes consist of new packets for trace manipulation and trace collection. The new packets are als

[Lldb-commits] [lldb] r301389 - Initial implementation of SB APIs for Tracing support.

2017-04-26 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Wed Apr 26 03:48:50 2017 New Revision: 301389 URL: http://llvm.org/viewvc/llvm-project?rev=301389&view=rev Log: Initial implementation of SB APIs for Tracing support. Summary: This patch introduces new SB APIs for tracing support inside LLDB. The idea is to gather trace da

[Lldb-commits] [lldb] r285885 - Test for YMMRegisters.

2016-11-03 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Thu Nov 3 03:35:55 2016 New Revision: 285885 URL: http://llvm.org/viewvc/llvm-project?rev=285885&view=rev Log: Test for YMMRegisters. Summary: This patch contains test for reading YMM Registers. The test basically contains an inferior that loads the ymm registers with a b

[Lldb-commits] [lldb] r274750 - Fix for PrintStackTraces

2016-07-07 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Thu Jul 7 08:00:29 2016 New Revision: 274750 URL: http://llvm.org/viewvc/llvm-project?rev=274750&view=rev Log: Fix for PrintStackTraces Summary: The issue arises due to the wrong unwinder used for the first stack frame, where the default unwinder returns erroneous frame w

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-07-06 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 62831. ravitheja added a comment. Removing other files. http://reviews.llvm.org/D21221 Files: packages/Python/lldbsuite/test/functionalities/unwind/ehframe/ packages/Python/lldbsuite/test/functionalities/unwind/ehframe/Makefile packages/Python/lldb

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-27 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 61936. ravitheja added a comment. Renaming testcase http://reviews.llvm.org/D21221 Files: packages/Python/lldbsuite/test/functionalities/unwind/ehframe/ packages/Python/lldbsuite/test/functionalities/unwind/ehframe/Makefile packages/Python/lldbsuit

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-23 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 61668. ravitheja added a comment. Adding testcase http://reviews.llvm.org/D21221 Files: packages/Python/lldbsuite/test/functionalities/unwind/nonabi/ packages/Python/lldbsuite/test/functionalities/unwind/nonabi/Makefile packages/Python/lldbsuite/te

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-15 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. @jasonmolenda The approach suggested seems promising, I look forward to it, if u want I can test it at my end ? once I see it. http://reviews.llvm.org/D21221 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-14 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. @labath In order to reproduce this situation without the help of standard library, I would have to write handwritten assembly and the CFI directives for that, is that fine ? http://reviews.llvm.org/D21221 ___ lldb-commit

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-14 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. so regarding this particular situation I want to give little more insight -> It starts out from here 0x40143a <+346>: movabsq $0x403e32, %rdi ; imm = 0x403E32 0x401444 <+356>: movb $0x0, %al 0x401446 <+358>: callq 0x400d30 ; symbol s

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-14 Thread Ravitheja Addepally via lldb-commits
ravitheja added inline comments. Comment at: source/Plugins/Process/Utility/RegisterContextLLDB.cpp:1602 @@ -1610,3 +1601,3 @@ // isn't going to do any better. -if (m_full_unwind_plan_sp->GetSourcedFromCompiler() == eLazyBoolYes) -return false; +//if (m_full_u

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-13 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 60539. ravitheja added a comment. Checks for nullptr http://reviews.llvm.org/D21221 Files: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h source/Plugins/Process/Uti

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-13 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 60533. ravitheja added a comment. Making EH Frame CFI the full unwinder when artificial symbols are found. http://reviews.llvm.org/D21221 Files: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp source/Plugins/DynamicLoader/POSIX-DYLD

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-13 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Well its not possible for the assembly unwinder to do the correct thing in this situation , as the function is entered through a stub function (which has push instruction) and then a jump. The point of this patch is to catch when to use the CFI or the assembly unwinde

Re: [Lldb-commits] [PATCH] D20091: Rewriting TestMultithreaded.py to solve flakyness on Linux

2016-05-11 Thread Ravitheja Addepally via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL269168: Rewriting TestMultithreaded.py to solve flakyness on Linux (authored by ravitheja). Changed prior to commit: http://reviews.llvm.org/D20091?vs=56671&id=56870#toc Repository: rL LLVM http://r

[Lldb-commits] [lldb] r269168 - Rewriting TestMultithreaded.py to solve flakyness on Linux

2016-05-11 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Wed May 11 04:54:41 2016 New Revision: 269168 URL: http://llvm.org/viewvc/llvm-project?rev=269168&view=rev Log: Rewriting TestMultithreaded.py to solve flakyness on Linux Summary: test_listener_event_process_state checks for Threads and Frames in the multithreaded_queue. T

Re: [Lldb-commits] [PATCH] D20091: Rewriting TestMultithreaded.py to solve flakyness on Linux

2016-05-11 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. @labath, Well the other tests in TestMultithreaded.py are not flaky and I see the only difference as an extra push operation, so I thought the push operation could be potential bottleneck. http://reviews.llvm.org/D20091

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-28 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Hello @ldrumm, I did investigate the issue and my finding is that incorrect values are being passed to the SetDataWithReadMemoryFallback function. Now I suspect the ElfSectionHeader is wrongly parsed in your case and the size and offsets obtained are wrong. To talk

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-25 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Hello, Ok I will take a look. http://reviews.llvm.org/D16107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r258122 - Fix for Bug 25338

2016-01-19 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Tue Jan 19 06:55:21 2016 New Revision: 258122 URL: http://llvm.org/viewvc/llvm-project?rev=258122&view=rev Log: Fix for Bug 25338 Summary: The issue arises because LLDB is not able to read the vdso library correctly. The fix adds memory allocation callbacks to allocate suf

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-19 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 45238. ravitheja added a comment. correcting previous revision. http://reviews.llvm.org/D16107 Files: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py packages/Python/lldbsuite/test/functionalities/unwind/noreturn

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-18 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 45185. ravitheja added a comment. Changes according to http://reviews.llvm.org/D16151 http://reviews.llvm.org/D16107 Files: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py packages/Python/lldbsuite/test/functiona

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-13 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Yes the vdso is fine, last year I did discuss this and we here decided that at the moment we can only offer this solution. http://reviews.llvm.org/D16107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://li

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-13 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Hi Oleyksiy, actually the problem is not with the Elf Format but its a problem with the ObjectFileElf itself which cannot handle reading from arbitrary offsets in the Elf. Now the ideal solution would be to fix that but as we had discussed last year we agreed to alloc

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-13 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Hi Tamas, a modified algorithm may work in this case for now, but this issue may still reoccur for some other Elf Format . http://reviews.llvm.org/D16107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://li

[Lldb-commits] [lldb] r257465 - Fix for TestNoreturnUnwind.py on i386

2016-01-12 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Tue Jan 12 04:08:41 2016 New Revision: 257465 URL: http://llvm.org/viewvc/llvm-project?rev=257465&view=rev Log: Fix for TestNoreturnUnwind.py on i386 Summary: The testcase TestNoreturnUnwind.py was failing because the unwind from the vdso library was not successful for cla

Re: [Lldb-commits] [PATCH] D15046: Fix for TestNoreturnUnwind.py on i386

2016-01-11 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Hello, Any updates on this differential ? http://reviews.llvm.org/D15046 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15046: Fix for TestNoreturnUnwind.py on i386

2015-12-02 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. The reason assembly unwind did not work is because if the ebp register is set to 0 at that time, so the CFA is not available. In the case of clang the frame pointer is not set by any function, which is why the formula does not work. (lldb) image show-unwind -n __kerne

Re: [Lldb-commits] [PATCH] D15046: Fix for TestNoreturnUnwind.py on i386

2015-12-01 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Hi Jason, Ok let me explain the scenario here, the application i.e the test function tries to abort which eventually ends up in a function present in the vdso, on the way the call flow goes through some functions in libc. Now the backtrace is done from inside of th

Re: [Lldb-commits] [PATCH] D14118: Changes for Bug 17384

2015-11-03 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Hello, I tried making an instance on GCE but it asks for a credit card information which I unfortunately don’t have. Can you provide me maybe access through some other way ? btw I checked the logs u sent me and the vdso is being loaded but the unwinding till m

[Lldb-commits] [lldb] r251917 - Changes for Bug 25251

2015-11-03 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Tue Nov 3 08:24:24 2015 New Revision: 251917 URL: http://llvm.org/viewvc/llvm-project?rev=251917&view=rev Log: Changes for Bug 25251 Summary: The solution to bug 24074,rL249673 needed to parse the function information from the Dwarf in order to set the SymbolContext. For

Re: [Lldb-commits] [PATCH] D14118: Changes for Bug 17384

2015-10-29 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Hi, This link for the traces needs a password, could u maybe provide me the login details or upload these somewhere else ? Also could u provide me the value of the AuxVectors during this test ? BR, A Ravi Theja http://reviews.llvm.org/D14118 _

[Lldb-commits] [lldb] r251505 - Changes for Bug 17384

2015-10-28 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Wed Oct 28 04:47:29 2015 New Revision: 251505 URL: http://llvm.org/viewvc/llvm-project?rev=251505&view=rev Log: Changes for Bug 17384 Summary: Virtual dynamic shared objects, or vdso files were not loaded for Linux OS.In Bug 17384 the call stack could not be unwinded fro

Re: [Lldb-commits] [PATCH] D14118: Changes for Bug 17384

2015-10-28 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 38637. ravitheja added a comment. Updates for previous comments. http://reviews.llvm.org/D14118 Files: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h test/functiona

[Lldb-commits] [lldb] r249673 - Testcase and fix for bug 24074

2015-10-08 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Thu Oct 8 04:45:41 2015 New Revision: 249673 URL: http://llvm.org/viewvc/llvm-project?rev=249673&view=rev Log: Testcase and fix for bug 24074 Summary: In bug 24074, the type information is not shown correctly. This commit includes the following - -> Changes for displaying

[Lldb-commits] [lldb] r248366 - Testcase and fix for bug 24074

2015-09-23 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Wed Sep 23 02:19:02 2015 New Revision: 248366 URL: http://llvm.org/viewvc/llvm-project?rev=248366&view=rev Log: Testcase and fix for bug 24074 Summary: In bug 24074, the type information is not shown correctly. This commit includes the following - -> Changes for displayin

[Lldb-commits] [lldb] r244886 - Removing redundant check from r244875

2015-08-13 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Thu Aug 13 06:53:23 2015 New Revision: 244886 URL: http://llvm.org/viewvc/llvm-project?rev=244886&view=rev Log: Removing redundant check from r244875 Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp Modified: lldb/trunk/source/

[Lldb-commits] [lldb] r244875 - Set orig_eax to -1 for Linux x86 platforms

2015-08-13 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Thu Aug 13 04:05:11 2015 New Revision: 244875 URL: http://llvm.org/viewvc/llvm-project?rev=244875&view=rev Log: Set orig_eax to -1 for Linux x86 platforms Summary: For Linux x86 based environments the orig_eax/orig_rax register should be set to -1 to prevent the instructio