[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. With this patch, it looks like the test added in this patch fails for lldb-arm-ubuntu: https://lab.llvm.org/buildbot/#/builders/17/builds/10498 Everything passes on these buildbots: lldb-aarch64-ubuntu, lldb-x64-windows-ninja, lldb-x86_64-debian. The test logic

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03df97101287: [lldb] Add support for debugging via the dynamic

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. @teemperor: I believe I have addressed your comments. If there is any other concern, I can address it post-commit. Thank you everyone for the review and help with the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa updated this revision to Diff 371644. rdhindsa marked 6 inline comments as done. rdhindsa added a comment. Thanks Pavel for investigating and figuring out that the upstream failing test had libxml support disabled. I was able to reproduce the failure locally by adding

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa updated this revision to Diff 371425. rdhindsa marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108061/new/ https://reviews.llvm.org/D108061 Files:

[Lldb-commits] [PATCH] D109249: [lldb] Add Getdescription function for SBInstruction.

rdhindsa updated this revision to Diff 370660. rdhindsa marked an inline comment as done. rdhindsa added a comment. Added LLDB_REGISTER_METHOD for GetDescription. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109249/new/

[Lldb-commits] [PATCH] D109249: [lldb] Add Getdescription function for SBInstruction.

rdhindsa created this revision. rdhindsa added reviewers: labath, clayborg. rdhindsa requested review of this revision. Herald added a project: LLDB. Add another Getdescription function for SBInstruction. When trying to print the instruction, existing GetDescription function doesn't have access

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. Thank you for suggestion to try! After adding the assertions in memory region info trick, 3 testcases from only one test failed because of assertion : lldb/test/API/functionalities/load_unload/TestLoadUnload.py test_lldb_process_load_and_unload_commands

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. Thank you for giving it a try! It passes for me for both Release and RelWithDebInfo along with asserts enabled in each case. I can give it a try by recommitting and checking the status, this patch is in `Needs Review` status presently. Hence, requesting for a review.

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. For me, this test passes every time. I have tried multiple times with instructions from failing bot, but haven't been able to reproduce the failure locally yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108061/new/

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa marked 2 inline comments as done and an inline comment as not done. rdhindsa added a comment. This patch caused a test failure when it was submitted two days ago, so I reverted it that day. However, I have not been able to reproduce the failure locally even using the cmake config from

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa updated this revision to Diff 368988. rdhindsa marked 6 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108061/new/ https://reviews.llvm.org/D108061 Files:

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cbdc07ec015: [lldb] Add support for debugging via the dynamic linker. (authored by rdhindsa). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. Thank you for the review and suggestion to check memory region. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108061/new/ https://reviews.llvm.org/D108061 ___ lldb-commits

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa updated this revision to Diff 367715. rdhindsa added a comment. Updated to extract executable file name using GetMemoryRegionInfo since ld.so returns empty file name for executable file name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9c5613e856c: Update logic to close inherited file descriptors. (authored by rdhindsa). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. Looking further as to why executable symbols are not loaded, it looks like when we read the link_map in lldb, AddSOEntries() is called for all the entries in link_map read from ld.so. The first entry's name(which corresponds to executable) is empty, which seems to be

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

rdhindsa updated this revision to Diff 367311. rdhindsa added a comment. Updated comments as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732 Files:

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. I checked the status with both gdb and lldb using test case added here. It looks like breakpoint on main doesn't get hit even for gdb when called through ld.so. However, breakpoint on shared library functions is supported by gdb. With this patch, we are now able to

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

rdhindsa updated this revision to Diff 367286. rdhindsa marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732 Files: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

rdhindsa updated this revision to Diff 367067. rdhindsa added a comment. Herald added a project: LLDB. Updated it to use llvm's filesystem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732 Files:

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa marked an inline comment as done. rdhindsa added a comment. Updated the test to check for the respective function name from the shared library in the frames. I didn't add run_to_source_breakpoint since we can't set a breakpoint on main initially before running the program. Hence it

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa updated this revision to Diff 367047. rdhindsa marked an inline comment as done. rdhindsa added a comment. Updated the test to check for the respective function name from the shared library in the frames. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa updated this revision to Diff 366692. rdhindsa added a comment. Reverted code changes from ObjectFileELF as suggested and added directly to DYLDRendezvous.cpp. Is there a better place to place the test, or is it okay to keep under ObjectFile. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa created this revision. rdhindsa added reviewers: labath, clayborg. Herald added a subscriber: emaste. rdhindsa requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: LLDB. Add support for shared library load when executable called through ld.

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

rdhindsa added a comment. fork is being called in LaunchProcess function in this file(ProcessLauncherPosixFork.cpp) itself. Thank you for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

rdhindsa added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

rdhindsa updated this revision to Diff 358429. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732 Files: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp Index: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp

[Lldb-commits] [PATCH] D96370: Pass enviroment variables to python scripts.

rdhindsa updated this revision to Diff 322510. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96370/new/ https://reviews.llvm.org/D96370 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

[Lldb-commits] [PATCH] D96370: Pass enviroment variables to python scripts.

rdhindsa created this revision. rdhindsa added a reviewer: labath. rdhindsa requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It enables environment variables set for lldb targets to be passed to python scripts. This allows the user to put