[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

compnerd wrote: > Also, it's a bit funny to have .bat files without CRLF endings given that > they run on Windows. I'm not sure about the funny bit - but certainly dangerous. I've had cmd misinterpret batch files with LF vs CRLF. https://github.com/llvm/llvm-project/pull/86318

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

compnerd wrote: > changes to `clang/test/CXX/lex/lex.literal/lex.string/p4.cpp` should be > reverted (it's a CRLF related test) This is the type of problems that I am concerned about. We certainly have some tests which are line-ending sensitive, and each test should be audited before we make

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

compnerd wrote: > @compnerd I just realised I didn't respond to your concern. Apologies. > > > I think that the concern that I have is that do we have sufficient testing > > for supporting line-ending dependent behaviour in the compiler? > > For the first part: I don't know that it matters,

[Lldb-commits] [clang] [lldb] Revert "NFC: Make clang resource headers an interface library (#88317)" (PR #89266)

https://github.com/compnerd approved this pull request. Approving it in case it needs to be merged, but I think that we should try to determine how it is breaking. This change feels like it should be correct and is a pretty good cleanup, so I would prefer that fix forward rather than revert.

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

compnerd wrote: Philosophically, I agree with this change. Enshrining the information about the line endings into the SCM tool makes sense. I think that the concern that I have is that do we have sufficient testing for supporting line-ending dependent behaviour in the compiler? Additionally,

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/84362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

@@ -168,8 +168,8 @@ class ConstString { // Implicitly convert \class ConstString instances to \class StringRef. operator llvm::StringRef() const { return GetStringRef(); } - // Implicitly convert \class ConstString instances to \class std::string_view. - operator

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

@@ -168,8 +168,8 @@ class ConstString { // Implicitly convert \class ConstString instances to \class StringRef. operator llvm::StringRef() const { return GetStringRef(); } - // Implicitly convert \class ConstString instances to \class std::string_view. - operator

[Lldb-commits] [lldb] [LLDB] Define _BSD_SOURCE globally, to get optreset available in mingw's getopt.h (PR #76137)

@@ -44,6 +44,10 @@ endif() if (WIN32) add_definitions(-D_ENABLE_EXTENDED_ALIGNED_STORAGE) + if (NOT MSVC) compnerd wrote: clang-cl should be detected as MSVC. The define should be generally safe, but it is nice to be more precise and add it when needed.

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/74731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() { return Status(); } + +const char *TargetThreadWindows::GetName() { + Log *log = GetLog(LLDBLog::Thread); + HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll"); + if (hModule) { +auto GetThreadDescription = +

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() { return Status(); } + +const char *TargetThreadWindows::GetName() { + Log *log = GetLog(LLDBLog::Thread); + HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll"); + if (hModule) { +auto GetThreadDescription = +

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() { return Status(); } + +const char *TargetThreadWindows::GetName() { + Log *log = GetLog(LLDBLog::Thread); + HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll"); + if (hModule) { +auto GetThreadDescription =

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() { return Status(); } + +const char *TargetThreadWindows::GetName() { + Log *log = GetLog(LLDBLog::Thread); + HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll"); + if (hModule) { +auto GetThreadDescription = +

[Lldb-commits] [lldb] [lldb] Fix missing comsumeError() with LLDB_LOG in ObjectFileCOFF/PECOFF (PR #70793)

https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/70793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cd21c0d - Revert "Revert "Host: generalise `GetXcodeSDKPath`""

Author: Saleem Abdulrasool Date: 2023-05-29T10:16:41-07:00 New Revision: cd21c0d30c0803b24e1dcf71d2f04cb46e539905 URL: https://github.com/llvm/llvm-project/commit/cd21c0d30c0803b24e1dcf71d2f04cb46e539905 DIFF:

[Lldb-commits] [lldb] 5014830 - ObjectFile: introduce a COFF object file plugin

Author: Saleem Abdulrasool Date: 2023-05-07T12:40:44-07:00 New Revision: 5014830ede78e55e2c638948ca00cea045eac9ce URL: https://github.com/llvm/llvm-project/commit/5014830ede78e55e2c638948ca00cea045eac9ce DIFF:

[Lldb-commits] [lldb] 039fc57 - ObjectFile: remove extraneous shadowed variable (NFCI)

Author: Saleem Abdulrasool Date: 2023-05-05T10:55:29-07:00 New Revision: 039fc57191980847afb6e674cac8bcbb6c1efa13 URL: https://github.com/llvm/llvm-project/commit/039fc57191980847afb6e674cac8bcbb6c1efa13 DIFF:

[Lldb-commits] [lldb] 6bca093 - SymbolFile: invert condition, remove unnecessary `else` (NFC)

Author: Saleem Abdulrasool Date: 2023-05-05T07:31:19-07:00 New Revision: 6bca093976ef40f36a396b11a61a44dc0f4dcd13 URL: https://github.com/llvm/llvm-project/commit/6bca093976ef40f36a396b11a61a44dc0f4dcd13 DIFF:

[Lldb-commits] [lldb] ade3c6a - Host: generalise `GetXcodeSDKPath`

Author: Saleem Abdulrasool Date: 2023-04-28T09:30:59-07:00 New Revision: ade3c6a6a88ed3a9b06c076406f196da9d3cc1b9 URL: https://github.com/llvm/llvm-project/commit/ade3c6a6a88ed3a9b06c076406f196da9d3cc1b9 DIFF:

[Lldb-commits] [lldb] d87cd45 - PECOFF: consume errors properly

Author: Saleem Abdulrasool Date: 2023-04-17T07:53:54-07:00 New Revision: d87cd45e4d855b57aed76dbd72c270ed152542ff URL: https://github.com/llvm/llvm-project/commit/d87cd45e4d855b57aed76dbd72c270ed152542ff DIFF:

[Lldb-commits] [lldb] 16b7cf2 - SymbolFile: ensure that we have a value before invoking `getBitWidth`

Author: Saleem Abdulrasool Date: 2023-03-22T14:14:13-04:00 New Revision: 16b7cf245ec0ff5428daee4f71af62e1938bfc73 URL: https://github.com/llvm/llvm-project/commit/16b7cf245ec0ff5428daee4f71af62e1938bfc73 DIFF:

[Lldb-commits] [lldb] 2696d82 - Windows: correct iteration of additional search paths

Author: Saleem Abdulrasool Date: 2022-04-16T18:01:02-07:00 New Revision: 2696d82fa0c323d92d8794f0a34ea9619888fae9 URL: https://github.com/llvm/llvm-project/commit/2696d82fa0c323d92d8794f0a34ea9619888fae9 DIFF:

[Lldb-commits] [lldb] c604207 - lldb/ObjectFile, Disassembler: read some state from the executable

Author: Saleem Abdulrasool Date: 2022-03-10T21:42:06Z New Revision: c6042076081025bc8060637b05fbeb24dbb82538 URL: https://github.com/llvm/llvm-project/commit/c6042076081025bc8060637b05fbeb24dbb82538 DIFF: https://github.com/llvm/llvm-project/commit/c6042076081025bc8060637b05fbeb24dbb82538.diff

[Lldb-commits] [lldb] f52b5a8 - lldb/ObjectFile: reflow a comment (NFC)

Author: Saleem Abdulrasool Date: 2022-03-09T18:47:31Z New Revision: f52b5a852a4b4d48b9c049e68569cfdb184f11ab URL: https://github.com/llvm/llvm-project/commit/f52b5a852a4b4d48b9c049e68569cfdb184f11ab DIFF: https://github.com/llvm/llvm-project/commit/f52b5a852a4b4d48b9c049e68569cfdb184f11ab.diff

[Lldb-commits] [lldb] b5491dd - ObjectFile: add a case for `EM_RISCV`

Author: Saleem Abdulrasool Date: 2022-03-04T21:54:20Z New Revision: b5491dd30792c1ad31bfc8e2f9d1809a79205234 URL: https://github.com/llvm/llvm-project/commit/b5491dd30792c1ad31bfc8e2f9d1809a79205234 DIFF: https://github.com/llvm/llvm-project/commit/b5491dd30792c1ad31bfc8e2f9d1809a79205234.diff

[Lldb-commits] [lldb] 906e60b - lldb: silence a warning on the Windows error path (NFCI)

Author: Saleem Abdulrasool Date: 2021-12-08T09:01:10-08:00 New Revision: 906e60b9f923464cba0f71a9205846550752162f URL: https://github.com/llvm/llvm-project/commit/906e60b9f923464cba0f71a9205846550752162f DIFF:

[Lldb-commits] [lldb] f1585a4 - Windows: support `DoLoadImage`

Author: Saleem Abdulrasool Date: 2021-12-04T11:11:47-08:00 New Revision: f1585a4b47cc9c08c9a4c10058597f4b7468c227 URL: https://github.com/llvm/llvm-project/commit/f1585a4b47cc9c08c9a4c10058597f4b7468c227 DIFF:

[Lldb-commits] [lldb] 6488bd1 - test: add a lit configuration for Windows subdirectory

Author: Saleem Abdulrasool Date: 2021-11-28T18:27:47-08:00 New Revision: 6488bd1d51715501632778e3c9a1d4eedfac2998 URL: https://github.com/llvm/llvm-project/commit/6488bd1d51715501632778e3c9a1d4eedfac2998 DIFF:

[Lldb-commits] [lldb] 92d42b3 - Utility: ignore OS version on non-Darwin targets in `ArchSpec`

Author: Saleem Abdulrasool Date: 2020-09-23T18:21:34-07:00 New Revision: 92d42b32a9b7a085fd200a56022724a77cf12a2d URL: https://github.com/llvm/llvm-project/commit/92d42b32a9b7a085fd200a56022724a77cf12a2d DIFF:

[Lldb-commits] [lldb] 7c8fa95 - lldb: use the newer `find_package` if available

Author: Saleem Abdulrasool Date: 2020-04-29T03:54:33Z New Revision: 7c8fa95395e719f9a2c211ee0f574ac9ef88a19d URL: https://github.com/llvm/llvm-project/commit/7c8fa95395e719f9a2c211ee0f574ac9ef88a19d DIFF: https://github.com/llvm/llvm-project/commit/7c8fa95395e719f9a2c211ee0f574ac9ef88a19d.diff

[Lldb-commits] [lldb] 3775be2 - Target: correct the return value for `GetImageAddrFromToken`

Author: Saleem Abdulrasool Date: 2020-04-06T17:37:57-07:00 New Revision: 3775be2d8e17aaeae62ab83ded005867f4bf70ac URL: https://github.com/llvm/llvm-project/commit/3775be2d8e17aaeae62ab83ded005867f4bf70ac DIFF:

[Lldb-commits] [lldb] abb0075 - build: reduce CMake handling for zlib

Author: Saleem Abdulrasool Date: 2020-01-02T11:19:12-08:00 New Revision: abb00753069554c538f3d850897373d093389945 URL: https://github.com/llvm/llvm-project/commit/abb00753069554c538f3d850897373d093389945 DIFF:

[Lldb-commits] [lldb] fb170fd - tests: XFAIL/UNSUPPORTED tests on Windows

Author: Saleem Abdulrasool Date: 2020-01-01T14:22:49-08:00 New Revision: fb170fd652bf2fcc4c2cd54aaf384591d8df266b URL: https://github.com/llvm/llvm-project/commit/fb170fd652bf2fcc4c2cd54aaf384591d8df266b DIFF:

[Lldb-commits] [lldb] 64c6bb3 - test: ensure that we dead-strip in the linker

Author: Saleem Abdulrasool Date: 2019-12-24T10:19:22-08:00 New Revision: 64c6bb37832c2139a91801fece96de8898151079 URL: https://github.com/llvm/llvm-project/commit/64c6bb37832c2139a91801fece96de8898151079 DIFF:

[Lldb-commits] [lldb] 4b0563f - test: correct flags for Windows

Author: Saleem Abdulrasool Date: 2019-12-23T20:21:26-08:00 New Revision: 4b0563f89f939f2160002298d5491a8fc8ee1137 URL: https://github.com/llvm/llvm-project/commit/4b0563f89f939f2160002298d5491a8fc8ee1137 DIFF:

[Lldb-commits] [lldb] b449d19 - build: use `find_package(Python3)` rather than `PYTHON_HOME`

Author: Saleem Abdulrasool Date: 2019-12-22T20:47:25-08:00 New Revision: b449d19e55888ab9554b04184c6d9716389820fd URL: https://github.com/llvm/llvm-project/commit/b449d19e55888ab9554b04184c6d9716389820fd DIFF:

[Lldb-commits] [lldb] 2046d72 - build: improve python checks for Windows

Author: Saleem Abdulrasool Date: 2019-12-22T13:57:46-08:00 New Revision: 2046d72e91670114625c87e122db6e013ba089d5 URL: https://github.com/llvm/llvm-project/commit/2046d72e91670114625c87e122db6e013ba089d5 DIFF:

[Lldb-commits] [lldb] 5e029c4 - DebugServer: be more lenient about the target triple

Author: Saleem Abdulrasool Date: 2019-10-30T12:08:29-07:00 New Revision: 5e029c4cfd7b8db269b6db475ecd420311fbd7d1 URL: https://github.com/llvm/llvm-project/commit/5e029c4cfd7b8db269b6db475ecd420311fbd7d1 DIFF:

[Lldb-commits] [lldb] e56ba37 - build: make standalone builds work again

Author: Saleem Abdulrasool Date: 2019-10-29T08:24:10-07:00 New Revision: e56ba3743bcc344c51be9d919c32ec8f88ddef44 URL: https://github.com/llvm/llvm-project/commit/e56ba3743bcc344c51be9d919c32ec8f88ddef44 DIFF:

[Lldb-commits] [lldb] 55eec2b - build: workaround stale caches (NFC)

Author: Saleem Abdulrasool Date: 2019-10-29T08:20:58-07:00 New Revision: 55eec2ba96bd9c19ccb5d4d13cb8c88d4abcebc6 URL: https://github.com/llvm/llvm-project/commit/55eec2ba96bd9c19ccb5d4d13cb8c88d4abcebc6 DIFF:

[Lldb-commits] [lldb] r372788 - Host: use the platform identifiers from LLVM (NFC)

Author: compnerd Date: Tue Sep 24 15:55:44 2019 New Revision: 372788 URL: http://llvm.org/viewvc/llvm-project?rev=372788=rev Log: Host: use the platform identifiers from LLVM (NFC) Use symbolic constants for the platform identifiers rather than replicating them locally. Modified:

[Lldb-commits] [lldb] r369788 - Windows: explicitly cast constants to `DWORD`

Author: compnerd Date: Fri Aug 23 10:58:53 2019 New Revision: 369788 URL: http://llvm.org/viewvc/llvm-project?rev=369788=rev Log: Windows: explicitly cast constants to `DWORD` STATUS_SINGLE_STEP and STATUS_BREAKPOINT are defined as 0x8-- which is negative and thus can't be implicitly

[Lldb-commits] [lldb] r369307 - Windows: Include "windows" Instead of "Windows"

Author: compnerd Date: Mon Aug 19 15:45:01 2019 New Revision: 369307 URL: http://llvm.org/viewvc/llvm-project?rev=369307=rev Log: Windows: Include "windows" Instead of "Windows" The actual include directory is lldb/Host/windows not lldb/Host/Windows which breaks on case sensitive file systems

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

On Wed, Jul 31, 2019 at 11:29 AM Greg Clayton via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > > > On Jul 31, 2019, at 10:57 AM, Raphael Isemann > wrote: > > > > It seems that patch is lacking a test (which doesn't seem too hard to > provide). > > I am not the original author of this

[Lldb-commits] [lldb] r366639 - build: allow the user to specify `llvm-tblgen`

Author: compnerd Date: Sat Jul 20 10:59:08 2019 New Revision: 366639 URL: http://llvm.org/viewvc/llvm-project?rev=366639=rev Log: build: allow the user to specify `llvm-tblgen` This follows the same pattern as Clang and permits the user to specify the tablegen to use via `-DLLVM_TABLEGEN=`.

[Lldb-commits] [lldb] r365282 - Process: generalise Windows thread setup

Author: compnerd Date: Sun Jul 7 10:58:11 2019 New Revision: 365282 URL: http://llvm.org/viewvc/llvm-project?rev=365282=rev Log: Process: generalise Windows thread setup The Windows build currently cannot support debugging foreign targets or debugging Windows ARM NT and Windows ARM64 targets.

[Lldb-commits] [lldb] r365155 - Plugins: permit building on Windows ARM64

Author: compnerd Date: Thu Jul 4 12:26:49 2019 New Revision: 365155 URL: http://llvm.org/viewvc/llvm-project?rev=365155=rev Log: Plugins: permit building on Windows ARM64 Rather than relying on `sizeof(void *)` to determine the architecture, use the `CMAKE_SYSTEM_PROCESSOR` variable. This

[Lldb-commits] [lldb] r362961 - ABI: reflow the table text (NFC)

Author: compnerd Date: Mon Jun 10 09:32:33 2019 New Revision: 362961 URL: http://llvm.org/viewvc/llvm-project?rev=362961=rev Log: ABI: reflow the table text (NFC) Reflow the text for the table to make the table legible. This is purely cosmetic, but makes understanding the contents of the table

[Lldb-commits] [lldb] r361915 - build: only search for the needed python type

Author: compnerd Date: Tue May 28 19:26:29 2019 New Revision: 361915 URL: http://llvm.org/viewvc/llvm-project?rev=361915=rev Log: build: only search for the needed python type Windows has different types of runtime libraries which are ABI incompatible with one another. This requires that the

[Lldb-commits] [lldb] r361443 - Expression: correct relocation model for Windows

Author: compnerd Date: Wed May 22 16:23:39 2019 New Revision: 361443 URL: http://llvm.org/viewvc/llvm-project?rev=361443=rev Log: Expression: correct relocation model for Windows The Windows Code Generation model cannot generation code with the PIC relocation model - all code is implicitly

[Lldb-commits] [lldb] r361210 - lldb-server: LLGS: support 32-bit on 64-bit hosts

Author: compnerd Date: Mon May 20 18:25:48 2019 New Revision: 361210 URL: http://llvm.org/viewvc/llvm-project?rev=361210=rev Log: lldb-server: LLGS: support 32-bit on 64-bit hosts Enable the ARM emulation support on AArch64 which can execute ARM32 code. Similarly, handle MIPS 32 on 64.

[Lldb-commits] [lldb] r360745 - Revert "build: use the correct variable"

Author: compnerd Date: Tue May 14 20:57:07 2019 New Revision: 360745 URL: http://llvm.org/viewvc/llvm-project?rev=360745=rev Log: Revert "build: use the correct variable" This reverts commit b5a8abd57f23e2f621d5ceb0f64f1bb8f9579c3f. This should not be needed as the lldb-server tool will add

[Lldb-commits] [lldb] r360695 - build: use the correct variable

Author: compnerd Date: Tue May 14 10:24:45 2019 New Revision: 360695 URL: http://llvm.org/viewvc/llvm-project?rev=360695=rev Log: build: use the correct variable Adjust the variable that controls whether the unit tests use `lldb-server`. This should repair the default build on Windows.

[Lldb-commits] [lldb] r360693 - lldb-server: rename `llgs::terminate` (NFC)

Author: compnerd Date: Tue May 14 10:07:36 2019 New Revision: 360693 URL: http://llvm.org/viewvc/llvm-project?rev=360693=rev Log: lldb-server: rename `llgs::terminate` (NFC) `terminate` overlaps with a C function on Windows: ``` D:\a\1\s\lldb\tools\lldb-server\lldb-server.cpp(45,13): warning:

[Lldb-commits] [lldb] r360067 - Initialization: move InstructionEmulation to full initialization

Author: compnerd Date: Mon May 6 12:38:24 2019 New Revision: 360067 URL: http://llvm.org/viewvc/llvm-project?rev=360067=rev Log: Initialization: move InstructionEmulation to full initialization The debug server does not need to use the instruction emulation. This helps reduce the size of the

[Lldb-commits] [lldb] r359944 - ExpressionParser: only force link MCJIT when needed

Author: compnerd Date: Fri May 3 16:19:27 2019 New Revision: 359944 URL: http://llvm.org/viewvc/llvm-project?rev=359944=rev Log: ExpressionParser: only force link MCJIT when needed This was added to support FreeBSD. The inclusion of this header increases the size of `lldb-server` due to MCJIT

[Lldb-commits] [lldb] r359832 - Initialization: move InstructionEmulation to full initialization

Author: compnerd Date: Thu May 2 14:49:29 2019 New Revision: 359832 URL: http://llvm.org/viewvc/llvm-project?rev=359832=rev Log: Initialization: move InstructionEmulation to full initialization The debug server does not need to use the instruction emulation. This helps reduce the size of the

[Lldb-commits] [lldb] r359817 - Initialization: correct macro usage

Author: compnerd Date: Thu May 2 12:25:18 2019 New Revision: 359817 URL: http://llvm.org/viewvc/llvm-project?rev=359817=rev Log: Initialization: correct macro usage `_MSC_VER` indiciates that you are building with MSVC, not that you are building for Windows. Use `_WIN32` (which identifies

[Lldb-commits] [lldb] r359816 - gdb-remote: fix the build on Windows

Author: compnerd Date: Thu May 2 12:09:58 2019 New Revision: 359816 URL: http://llvm.org/viewvc/llvm-project?rev=359816=rev Log: gdb-remote: fix the build on Windows Windows does not have a definition for `mode_t`. Include the appropriate header. Modified:

[Lldb-commits] [lldb] r359811 - gdb-remote: reduce some inclusion of Target/Process.h

Author: compnerd Date: Thu May 2 11:15:03 2019 New Revision: 359811 URL: http://llvm.org/viewvc/llvm-project?rev=359811=rev Log: gdb-remote: reduce some inclusion of Target/Process.h Reduce the inclusion of Target/Process.h to help isolate why Process is being preserved during the build of

[Lldb-commits] [lldb] r359810 - Initialization: remove ObjectContainer from Common

Author: compnerd Date: Thu May 2 11:11:44 2019 New Revision: 359810 URL: http://llvm.org/viewvc/llvm-project?rev=359810=rev Log: Initialization: remove ObjectContainer from Common This restructures the initialization path to move the ObjectContainer initialization into the *full* initialization

[Lldb-commits] [lldb] r359738 - lldb-server: remove link against lldbInterpreter

Author: compnerd Date: Wed May 1 16:06:45 2019 New Revision: 359738 URL: http://llvm.org/viewvc/llvm-project?rev=359738=rev Log: lldb-server: remove link against lldbInterpreter This dependency is unused. Remove the extraneous link. Modified: lldb/trunk/tools/lldb-server/CMakeLists.txt

[Lldb-commits] [lldb] r348556 - Host: remove Yield on Windows

Author: compnerd Date: Thu Dec 6 16:31:34 2018 New Revision: 348556 URL: http://llvm.org/viewvc/llvm-project?rev=348556=rev Log: Host: remove Yield on Windows Windows provides a Yield function-like macro that allows a thread to yield the CPU. However, this conflicts with `Yield` in swift.

[Lldb-commits] [lldb] r348332 - gdb-remote: use elaborated type specifier for `Module`

Author: compnerd Date: Tue Dec 4 20:04:14 2018 New Revision: 348332 URL: http://llvm.org/viewvc/llvm-project?rev=348332=rev Log: gdb-remote: use elaborated type specifier for `Module` When building with MSVC, the type `Module` is ambiguous due to both the lldb_private and llvm namespaces being

[Lldb-commits] [lldb] r345569 - Utility: fix cross-compilation from Linux to Windows

Author: compnerd Date: Mon Oct 29 23:29:28 2018 New Revision: 345569 URL: http://llvm.org/viewvc/llvm-project?rev=345569=rev Log: Utility: fix cross-compilation from Linux to Windows Only attempt to link against Backtrace if it is found. Without this, trying to cross-compile to Windows would

[Lldb-commits] [lldb] r333863 - Python: adjust the include directories

Author: compnerd Date: Sun Jun 3 19:08:12 2018 New Revision: 333863 URL: http://llvm.org/viewvc/llvm-project?rev=333863=rev Log: Python: adjust the include directories Restructure the include search order to adjust for libedit. This ensures that the variables are not unused if they are not

[Lldb-commits] [lldb] r323363 - www: update lldb architecture doc

Author: compnerd Date: Wed Jan 24 11:00:08 2018 New Revision: 323363 URL: http://llvm.org/viewvc/llvm-project?rev=323363=rev Log: www: update lldb architecture doc ArchSpec was moved from Core to Utility, so I modified the docs to reflect that. Patch by Alex Langford ! Modified:

[Lldb-commits] [lldb] r312841 - Plugins: fix resolution ambiguity in PDB plugin

Author: compnerd Date: Fri Sep 8 17:13:49 2017 New Revision: 312841 URL: http://llvm.org/viewvc/llvm-project?rev=312841=rev Log: Plugins: fix resolution ambiguity in PDB plugin A clang change caused the inclusion of `llvm::Type` and `lldb_private::Type` to be pulled into the global namespace

[Lldb-commits] [lldb] r311582 - test: fix missed test

Author: compnerd Date: Wed Aug 23 11:05:19 2017 New Revision: 311582 URL: http://llvm.org/viewvc/llvm-project?rev=311582=rev Log: test: fix missed test I had built without python bindings and did not find this in the grep output. Adjust the test output for the printing format update. Modified:

Re: [Lldb-commits] [lldb] r311579 - Process: fix FXSAVE on x86

This would be nice to merge to 5.0 IMO. It fixes reading the x87 FPU state. What do you think Greg? On Wed, Aug 23, 2017 at 10:24 AM Saleem Abdulrasool via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Wed Aug 23 10:23:12 2017 > New Revision:

[Lldb-commits] [lldb] r311579 - Process: fix FXSAVE on x86

Author: compnerd Date: Wed Aug 23 10:23:12 2017 New Revision: 311579 URL: http://llvm.org/viewvc/llvm-project?rev=311579=rev Log: Process: fix FXSAVE on x86 The FXSAVE member `ftw` (FPU Tag Word) was given the wrong size (8-bit) instead of the correct width (16-bit) as per the x87 Programmer's

[Lldb-commits] [lldb] r311577 - ObjC: fix some -Wpedantic warnings by removing '; '

Author: compnerd Date: Wed Aug 23 10:00:14 2017 New Revision: 311577 URL: http://llvm.org/viewvc/llvm-project?rev=311577=rev Log: ObjC: fix some -Wpedantic warnings by removing ';' Remove some stray ';' that were in the source code. NFC. Modified:

[Lldb-commits] [lldb] r308489 - silence a couple of -Wqual-cast warning from GCC (NFC)

Author: compnerd Date: Wed Jul 19 08:46:21 2017 New Revision: 308489 URL: http://llvm.org/viewvc/llvm-project?rev=308489=rev Log: silence a couple of -Wqual-cast warning from GCC (NFC) Cast to `const uint8_t *` instead of `uint8_t *` to avoid the warning from GCC.

Re: [Lldb-commits] LLGS for Free/NetBSD (was: Re: [PATCH] D25756: FreeBSD ARM support for software single step.)

On Mon, Oct 24, 2016 at 11:38 AM, Ed Maste via lldb-commits < lldb-commits@lists.llvm.org> wrote: > On 24 October 2016 at 06:26, Pavel Labath wrote: > > > > It's not my place to tell you how to work, but I'd recommend a > > different approach to this. If you base your work on

[Lldb-commits] [lldb] r278774 - Symbol: add missing item in covered switch

Author: compnerd Date: Mon Aug 15 23:12:36 2016 New Revision: 278774 URL: http://llvm.org/viewvc/llvm-project?rev=278774=rev Log: Symbol: add missing item in covered switch RenderScript was missing from the covered switch. Add it to avoid a warning of the missing entry. NFC. Modified:

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

compnerd closed this revision. compnerd added a comment. SVN r277011 https://reviews.llvm.org/D20436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r277013 - Host: correct use of std::condition_variable::wait_for

Author: compnerd Date: Thu Jul 28 13:16:07 2016 New Revision: 277013 URL: http://llvm.org/viewvc/llvm-project?rev=277013=rev Log: Host: correct use of std::condition_variable::wait_for std::condition::wait_for takes a std::unique_lock. The previous commit accidentally left a reference to

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

compnerd added a subscriber: sas. compnerd added a comment. @emaste I think so. I was hoping that @zturner or @sas would be able to get a windows run. However, Linux and FreeBSD should give us some assurance that this is good. How about I go ahead and commit this tomorrow?

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

compnerd added a comment. Tested against Linux-x86_64, tests state seems unchanged across the patch. @zturner you want to run another round on Windows before I merge this? https://reviews.llvm.org/D20436 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

compnerd added a comment. Ugh, yeah, I had forgotten about this. Ill try to get to this tonight/tomorrow. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:354-355 @@ -358,5 +353,4 @@ { -// Calculate absolute timeout value -TimeValue timeout =

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

compnerd added a comment. *hadn't Repository: rL LLVM https://reviews.llvm.org/D20436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

compnerd added inline comments. Comment at: docs/Proposals/GitHub.rst:167 @@ +166,3 @@ +with the limited number of developers whose job will be to mainly merge +thousands of patches a day. + rengolin wrote: > compnerd wrote: > > I don't fully understand how this

[Lldb-commits] [lldb] r270377 - SymbolFile: remove an unused variable

Author: compnerd Date: Sun May 22 15:16:53 2016 New Revision: 270377 URL: http://llvm.org/viewvc/llvm-project?rev=270377=rev Log: SymbolFile: remove an unused variable Address a -Wunused-but-set-variable warning from gcc. NFC. Modified:

Re: [Lldb-commits] [PATCH] D20351: second pass over removal of Mutex and Condition

compnerd marked 2 inline comments as done. Comment at: source/Interpreter/CommandObject.cpp:339 @@ -338,3 +338,3 @@ m_exe_ctx.Clear(); -m_api_locker.Unlock(); +m_api_locker.unlock(); } zturner wrote: > ``` > if (m_api_locker) >

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

compnerd added a comment. Ah, I just ran git-clang-format, and that found a few additional things. Incorporated that; Ill commit this tonight and hopefully have the second pass done soon. http://reviews.llvm.org/D20278 ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

compnerd added a comment. I ran it on Darwin while I was working on this. Ill run it on Linux once before I commit the first pass. http://reviews.llvm.org/D20278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

compnerd added a comment. Zach is correct, this doesn't *remove* the Mutex and Condition types, merely starts reducing the easier uses of it. My thinking is to do this piecemeal, slowly reducing the local usage until the real uses remain in the cases where we need to actually change the

[Lldb-commits] [lldb] r268757 - debugserver: fix some -Wpessimizing-move warnings

Author: compnerd Date: Fri May 6 12:33:04 2016 New Revision: 268757 URL: http://llvm.org/viewvc/llvm-project?rev=268757=rev Log: debugserver: fix some -Wpessimizing-move warnings Remove the unnecessary use of std::move to permit the compiler to perform NVRO instead. Fixes more warnings from

[Lldb-commits] [lldb] r268758 - debugserver: fix a couple of -Wmissing-field-initializers warnings

Author: compnerd Date: Fri May 6 12:33:09 2016 New Revision: 268758 URL: http://llvm.org/viewvc/llvm-project?rev=268758=rev Log: debugserver: fix a couple of -Wmissing-field-initializers warnings Explicitly provide an initializer for the std::vector in the constructed type. Addresses

[Lldb-commits] [lldb] r268759 - debugserver; fix -Wunused-local-typedef, -Wunused-variable warnings

Author: compnerd Date: Fri May 6 12:33:13 2016 New Revision: 268759 URL: http://llvm.org/viewvc/llvm-project?rev=268759=rev Log: debugserver; fix -Wunused-local-typedef, -Wunused-variable warnings Remove the typedef and local structure which was unused. Fixes last of the new clang warnings in

[Lldb-commits] [lldb] r268756 - debugserver: fix a few -Wcovered-swift-default warnings

Author: compnerd Date: Fri May 6 12:33:01 2016 New Revision: 268756 URL: http://llvm.org/viewvc/llvm-project?rev=268756=rev Log: debugserver: fix a few -Wcovered-swift-default warnings Remove a couple of `default` cases from switches which are covered. This is beneficial since it would allow

[Lldb-commits] [lldb] r268755 - debugserver: fix some -Wformat-pedantic warnings

Author: compnerd Date: Fri May 6 12:32:58 2016 New Revision: 268755 URL: http://llvm.org/viewvc/llvm-project?rev=268755=rev Log: debugserver: fix some -Wformat-pedantic warnings Perform explicit casts for the log message to address some `-Wformat-pedantic` warnings from clang. NFC. Modified:

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

compnerd added a comment. The few lines above are for the x86, x86_64 targets, which traditionally use the pc vendor as a legacy label. http://reviews.llvm.org/D19604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r267291 - ObjectFile: parse EABI Attributes

Author: compnerd Date: Sat Apr 23 11:00:15 2016 New Revision: 267291 URL: http://llvm.org/viewvc/llvm-project?rev=267291=rev Log: ObjectFile: parse EABI Attributes This adds basic parsing of the EABI attributes section. This section contains additional information about the target for which the

[Lldb-commits] [lldb] r267247 - Source: fix another -Wunused-variable warning

Author: compnerd Date: Fri Apr 22 18:08:34 2016 New Revision: 267247 URL: http://llvm.org/viewvc/llvm-project?rev=267247=rev Log: Source: fix another -Wunused-variable warning Conditionalise a variable definition which may be unused in certain compilations due to the preprocessor. Protect the

[Lldb-commits] [PATCH] D19446: ObjectFile: parse EABI Attributes

compnerd created this revision. compnerd added a reviewer: clayborg. compnerd added a subscriber: lldb-commits. compnerd set the repository for this revision to rL LLVM. This adds basic parsing of the EABI attributes section. This section contains additional information about the target for

[Lldb-commits] [lldb] r267000 - Host: fix some -Wformat-pedantic warnings

Author: compnerd Date: Thu Apr 21 11:55:58 2016 New Revision: 267000 URL: http://llvm.org/viewvc/llvm-project?rev=267000=rev Log: Host: fix some -Wformat-pedantic warnings Add explicit casts for function pointer to void * for %p conversion. NFC. Modified:

[Lldb-commits] [lldb] r267001 - API: fix a -Wunused-variable warning

Author: compnerd Date: Thu Apr 21 11:56:02 2016 New Revision: 267001 URL: http://llvm.org/viewvc/llvm-project?rev=267001=rev Log: API: fix a -Wunused-variable warning expr_log is only conditionally used via preprocessing. Ensure that we guard the definition accordingly. NFC. Modified:

[Lldb-commits] [lldb] r266042 - Process: fix the build with certain kernel versions

Author: compnerd Date: Tue Apr 12 00:40:51 2016 New Revision: 266042 URL: http://llvm.org/viewvc/llvm-project?rev=266042=rev Log: Process: fix the build with certain kernel versions The structure definitions are not provided, but we perform a sizeof operation of them which causes a build

  1   2   >