[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

2023-01-11 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon added a comment. @ayermolo This has broken some buildbots - please can you take a look? https://lab.llvm.org/buildbot/#/builders/245/builds/3279 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 __

[Lldb-commits] [PATCH] D121168: Cleanup includes: LLVMTarget

2022-03-10 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon added a comment. @serge-sans-paille Any luck with tracking down https://lab.llvm.org/buildbot/#/builders/67/builds/6136 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121168/new/ https://reviews.llvm.org/D121168 _

[Lldb-commits] [PATCH] D121168: Cleanup includes: LLVMTarget

2022-03-08 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon added a comment. Please add a reference to https://discourse.llvm.org/t/include-what-you-use-include-cleanup/5831 in the summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121168/new/ https://reviews.llvm.org/D121168

[Lldb-commits] [PATCH] D119092: Cleanup LLVMDebugInfoCodeView headers

2022-02-06 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon added inline comments. Herald added a subscriber: JDevlieghere. Comment at: llvm/include/llvm/DebugInfo/CodeView/CVTypeVisitor.h:12 +#include "llvm/ADT/ArrayRef.h" #include "llvm/DebugInfo/CodeView/CVRecord.h" Forward declare ArrayRef<> ? Repository:

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

2022-02-01 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon added a comment. mlir-windows buildbot looks to be green now - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

2022-01-29 Thread Simon Pilgrim via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG058c5dfc78cd: Raise the minimum Visual Studio version to VS2019 (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D114639?v

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

2022-01-29 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon added a comment. @stella.stamenova It looks like the mlir-windows buildbot is still using VS2017: CMake Error at cmake/modules/CheckCompilerVersion.cmake:39 (message): Host Visual Studio version must be at least 19.20, your version is 19.16.27045.0. Are you able to make the fix

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

2022-01-28 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon updated this revision to Diff 404076. RKSimon added a comment. fix cut+paste typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Users

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

2022-01-28 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon updated this revision to Diff 403924. RKSimon added a comment. update lldb cmake command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/doc

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

2022-01-27 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon updated this revision to Diff 403574. RKSimon added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. update lldb docs as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

2020-08-18 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon added a comment. @haampie @JDevlieghere This is failing on several buildbots please can you take a look : http://lab.llvm.org:8011/builders/clang-x86_64-debian-new-pass-manager-fast/builds/13553 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D44354: [lldb] Unbreak lldb builds due to r327219

2018-03-10 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon added a comment. (post) LGTM Repository: rL LLVM https://reviews.llvm.org/D44354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits