Re: [Lldb-commits] TestFormattersBoolRefPtr.py on OSX

I attached the log for the failure (come from the build bot). About the double reporting, I seen it on one of the build bot, but we have some case when 2 different test have the same name what can explain the issue (e.g. TestFormattersBoolRefPtr) Tamas On Wed, Sep 9, 2015 at 6:54 PM Zachary

[Lldb-commits] [lldb] r247022 - Fix assertion failure caused by a bug in 128bit register handling in RegisterValue

Author: tberghammer Date: Tue Sep 8 11:22:23 2015 New Revision: 247022 URL: http://llvm.org/viewvc/llvm-project?rev=247022=rev Log: Fix assertion failure caused by a bug in 128bit register handling in RegisterValue Modified: lldb/trunk/include/lldb/Core/RegisterValue.h

[Lldb-commits] [PATCH] D12699: Change the looping stack detection code

tberghammer created this revision. tberghammer added a reviewer: jasonmolenda. tberghammer added a subscriber: lldb-commits. Change the looping stack detection code In some special case (e.g. signal handlers, hand written assembly) it is valid to have 2 stack frame with the same CFA value. This

[Lldb-commits] [lldb] r246958 - Use eAddressClassCode for address lookup for opcodes for stack frames

Author: tberghammer Date: Mon Sep 7 04:58:09 2015 New Revision: 246958 URL: http://llvm.org/viewvc/llvm-project?rev=246958=rev Log: Use eAddressClassCode for address lookup for opcodes for stack frames It is required because of the following edge case on arm: bxNon-tail call in a no return

Re: [Lldb-commits] [PATCH] D12636: Fix the handling of FPR offsets in Linux arm/aarch64 register contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rL246959: Fix the handling of FPR offsets in Linux arm/aarch64 register contexts (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D12636?vs=34034=34138#toc Repository: rL

Re: [Lldb-commits] [PATCH] D12636: Fix the handling of FPR offsets in Linux arm/aarch64 register contexts

tberghammer added a comment. I prefer to keep it this way because there is no canonical register layout we can rely on so putting them just next to each other would be just an arbitrary layout what might break in the future. If we want the offsets to make sense, then on arm/aarch64 the best

[Lldb-commits] [lldb] r246959 - Fix the handling of FPR offsets in Linux arm/aarch64 register contexts

Author: tberghammer Date: Mon Sep 7 05:11:23 2015 New Revision: 246959 URL: http://llvm.org/viewvc/llvm-project?rev=246959=rev Log: Fix the handling of FPR offsets in Linux arm/aarch64 register contexts Differential revision: http://reviews.llvm.org/D12636 Modified:

[Lldb-commits] [lldb] r246972 - XFAIL single_step_only_steps_one_instruction related tests on arm/aarch64

Author: tberghammer Date: Mon Sep 7 11:01:26 2015 New Revision: 246972 URL: http://llvm.org/viewvc/llvm-project?rev=246972=rev Log: XFAIL single_step_only_steps_one_instruction related tests on arm/aarch64 Modified: lldb/trunk/test/tools/lldb-server/TestGdbRemoteSingleStep.py

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

tberghammer added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:34-44 @@ +33,13 @@ + +DIERef::DIERef(const DWARFFormValue& form_value) : +cu_offset(DW_INVALID_OFFSET), +die_offset(DW_INVALID_OFFSET) +{ +if (form_value.IsValid()) +{ +

Re: [Lldb-commits] [PATCH] D12601: Fix TestLoadUnload.test_load_unload for android API > 21

This revision was automatically updated to reflect the committed changes. Closed by commit rL246852: Fix TestLoadUnload.test_load_unload for android API > 21 (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D12601?vs=33949=34025#toc Repository: rL LLVM

Re: [Lldb-commits] [Diffusion] rL246639: Fix tab completion for command arguments containing spaces

Sorry for the breakage. It should be fixed by r246791 On Fri, Sep 4, 2015 at 1:34 AM Dawn Perchik wrote: > dawn added a subscriber: dawn. > dawn added a comment. > > We're seeing 2 new failures on OSX since this commit: > > >

[Lldb-commits] [PATCH] D12636: Fix the handling of FPR offsets in Linux arm/aarch64 register contexts

tberghammer created this revision. tberghammer added reviewers: labath, chaoren, omjavaid. tberghammer added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer, rengolin, aemerson. Fix the handling of FPR offsets in Linux arm/aarch64 register contexts This should fix

Re: [Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

tberghammer updated this revision to Diff 34038. tberghammer added a comment. Updated the change based on the comments. I don't fully agree with restricting the user from setting breakpoint in non-code locations because if LLDB classified a section incorrectly (e.g. haven't found the SO file

Re: [Lldb-commits] [PATCH] D12584: Fix TestCompletion.py failure on Darwin after r246639

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. I don't understand why it is necessary on OSX but I am fine with this change if it fixes the issue (at the moment I am struggling with building lldb on OSX so I can't test it). One

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

tberghammer added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:316-328 @@ +315,15 @@ + +const char* dwo_name = cu_die.GetAttributeValueAsString(m_dwarf2Data, +this, +

Re: [Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

tberghammer retitled this revision from "Introduce new address class eAddressClassDataIntermixedCode" to "Use eAddressClassCode for address lookup for opcodes". tberghammer updated the summary for this revision. tberghammer updated this revision to Diff 33937. tberghammer added a comment.

[Lldb-commits] [PATCH] D12556: Introduce new address class eAddressClassDataIntermixedCode

tberghammer created this revision. tberghammer added a reviewer: clayborg. tberghammer added a subscriber: lldb-commits. Herald added a subscriber: aemerson. Introduce new address class eAddressClassDataIntermixedCode It is used for marking data what is intermixed into the code section on

[Lldb-commits] [lldb] r246639 - Fix tab completion for command arguments containing spaces

Author: tberghammer Date: Wed Sep 2 05:35:27 2015 New Revision: 246639 URL: http://llvm.org/viewvc/llvm-project?rev=246639=rev Log: Fix tab completion for command arguments containing spaces If a command argument contains a space then it have to be escaped with backslash signs so the argument

[Lldb-commits] [PATCH] D12553: Fix arm disassambler with specifying armv8.1a architecture

tberghammer created this revision. tberghammer added reviewers: labath, dsrbecky. tberghammer added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Fix arm disassambler with specifying armv8.1a architecture If no architecture is defined for the disassambler command then

[Lldb-commits] [lldb] r246648 - Fix arm disassambler with specifying armv8.1a architecture

Author: tberghammer Date: Wed Sep 2 08:24:50 2015 New Revision: 246648 URL: http://llvm.org/viewvc/llvm-project?rev=246648=rev Log: Fix arm disassambler with specifying armv8.1a architecture If no architecture is defined for the disassambler command then it uses the architecture of the target.

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

tberghammer accepted this revision. tberghammer added a comment. LGTM Repository: rL LLVM http://reviews.llvm.org/D12356 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

tberghammer added a comment. I don't know too much about mips so I haven't checked if the emulation is actually correct but the general concept looks good to me. I added a few comments inline but they are mostly suggestions what you might want to consider. Comment at:

[Lldb-commits] [PATCH] D12374: Code cleanup in preparation of adding split dwarf support

tberghammer created this revision. tberghammer added a reviewer: clayborg. tberghammer added a subscriber: lldb-commits. Code cleanup in preparation of adding split dwarf support * Remove some unused code * Remove usage of DWARFDebugInfoEntry::Attributes where usage isn't reasonable * Cleanup

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

tberghammer added a subscriber: tberghammer. tberghammer added a comment. You added 10 new function to the emulator where the first 8 functions and the last 2 functions are almost identical. I know that the rest of the MIPS64 instruction emulator is having the same issue but I would like to see

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

tberghammer added a comment. Sorry, first I manage to submit my comments without finishing them. In http://reviews.llvm.org/D12291#232191, @clayborg wrote: I also question why Symbo In http://reviews.llvm.org/D12291#231523, @tberghammer wrote: In the current version of the patch the

[Lldb-commits] [lldb] r245928 - Fix source manager regression caused by r245905

Author: tberghammer Date: Tue Aug 25 05:27:38 2015 New Revision: 245928 URL: http://llvm.org/viewvc/llvm-project?rev=245928view=rev Log: Fix source manager regression caused by r245905 Modified: lldb/trunk/source/Symbol/SymbolFile.cpp Modified: lldb/trunk/source/Symbol/SymbolFile.cpp URL:

Re: [Lldb-commits] [PATCH] D12239: Fix buffer overflow for fixed_form_sizes

This revision was automatically updated to reflect the committed changes. Closed by commit rL245930: Fix buffer overflow for fixed_form_sizes (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D12239?vs=32946id=33060#toc Repository: rL LLVM

[Lldb-commits] [lldb] r245931 - Add support for DW_FORM_GNU_[addr, str]_index

Author: tberghammer Date: Tue Aug 25 06:45:58 2015 New Revision: 245931 URL: http://llvm.org/viewvc/llvm-project?rev=245931view=rev Log: Add support for DW_FORM_GNU_[addr,str]_index These are 2 new value currently in experimental status used when split debug info is enabled. Differential

[Lldb-commits] [lldb] r245932 - Handle DW_OP_GNU_addr_index in DWARF expressions

Author: tberghammer Date: Tue Aug 25 06:46:06 2015 New Revision: 245932 URL: http://llvm.org/viewvc/llvm-project?rev=245932view=rev Log: Handle DW_OP_GNU_addr_index in DWARF expressions Differential revision: http://reviews.llvm.org/D12290 Modified:

Re: [Lldb-commits] [PATCH] D12238: Add support for DW_FORM_GNU_[addr, str]_index

tberghammer added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:729 @@ -727,3 +728,3 @@ if (attributes.ExtractFormValueAtIndex(m_dwarf2Data, i, form_value)) -name = form_value.AsCString(debug_str);

Re: [Lldb-commits] [PATCH] D12280: Make TestCreateDuringInstructionStep linux-specific

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good with 2 minor comments - After the renames the test path don't say that the test is thread related. I think you should add it back to somewhere (e.g. to the test name) -

[Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

tberghammer created this revision. tberghammer added reviewers: labath, clayborg. tberghammer added a subscriber: lldb-commits. Add split dwarf support to SymbolFileDWARF * Create new dwo symbol file class * Add handling for .dwo sections * Propagate queries from SymbolFileDWARF to the dwo

[Lldb-commits] [lldb] r245834 - Add absolute load address support for the DynamicLoader plugins

Author: tberghammer Date: Mon Aug 24 05:21:55 2015 New Revision: 245834 URL: http://llvm.org/viewvc/llvm-project?rev=245834view=rev Log: Add absolute load address support for the DynamicLoader plugins The POSIX linker generally reports the load bias for the loaded libraries but in some case it

Re: [Lldb-commits] [PATCH] D12239: Fix buffer overflow for fixed_form_sizes

tberghammer updated this revision to Diff 32946. tberghammer added a comment. Address review comments http://reviews.llvm.org/D12239 Files: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp

Re: [Lldb-commits] [PATCH] D12239: Fix buffer overflow for fixed_form_sizes

tberghammer added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h:165 @@ -164,3 +164,3 @@ const DWARFCompileUnit* cu, -const uint8_t *fixed_form_sizes, +DWARFFormValue::FixedFormSizes

[Lldb-commits] [lldb] r245695 - Fix type of dw_form_t in dwarf.h

Author: tberghammer Date: Fri Aug 21 07:14:47 2015 New Revision: 245695 URL: http://llvm.org/viewvc/llvm-project?rev=245695view=rev Log: Fix type of dw_form_t in dwarf.h Modified: lldb/trunk/include/lldb/Core/dwarf.h Modified: lldb/trunk/include/lldb/Core/dwarf.h URL:

Re: [Lldb-commits] [PATCH] D12237: [NativeProcessLinux] Pass around threads by reference

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good (I assume when you dropped const from the argument it was intentional) http://reviews.llvm.org/D12237 ___ lldb-commits

[Lldb-commits] [PATCH] D12233: Add absolute load address support for the DynamicLoader plugins

tberghammer created this revision. tberghammer added reviewers: sas, clayborg. tberghammer added a subscriber: lldb-commits. Add absolute load address support for the DynamicLoader plugins The POSIX linker generally reports the load bias for the loaded libraries but in some case it is useful to

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

tberghammer added a comment. Fixed by http://reviews.llvm.org/rL245546 Repository: rL LLVM http://reviews.llvm.org/D11947 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12218: Implement handling of `library:` keys in thread stop replies.

tberghammer resigned from this revision. tberghammer removed a reviewer: tberghammer. tberghammer added a comment. I leave this review to the others as I have no idea about how library loading works on Windows. (On Linux/Android we use a breakpoint on a special symbol exposed by the linker)

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

This revision was automatically updated to reflect the committed changes. Closed by commit rL245546: Improve instruction emulation based stack unwinding (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D11947?vs=32395id=32670#toc Repository: rL LLVM

[Lldb-commits] [lldb] r245546 - Improve instruction emulation based stack unwinding

Author: tberghammer Date: Thu Aug 20 04:09:01 2015 New Revision: 245546 URL: http://llvm.org/viewvc/llvm-project?rev=245546view=rev Log: Improve instruction emulation based stack unwinding On ARM there is no difference petween a pop and a load instruction so a register can be loaded multiple

Re: [Lldb-commits] [PATCH] D12025: Make UriParser to support [$HOSTNAME] notation.

tberghammer added inline comments. Comment at: source/Utility/UriParser.cpp:13 @@ -12,4 +12,3 @@ // C Includes -#include stdlib.h -#include stdio.h +#include string.h I think you wanted to include string, not string.h Comment at:

Re: [Lldb-commits] [PATCH] D12187: [NativeProcessLinux] Reduce the number of casts

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good. One inconsistency what might worth a change is that you usually pass NPL as a shared_ptr (or a reference to a shared_ptr) but you created a few function where it isn't

Re: [Lldb-commits] [PATCH] D12204: Understand absolute base addresses in ProcessGDBRemote::GetLoadedModuleList.

tberghammer added a comment. Yes, mine is effecting the ObjectFile plugins and the DynamicLoader plugins. I will try to upload it tomorrow http://reviews.llvm.org/D12204 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12025: Make UriParser to support [$HOSTNAME] notation.

tberghammer added inline comments. Comment at: source/Utility/UriParser.cpp:13 @@ -12,4 +12,3 @@ // C Includes -#include stdlib.h -#include stdio.h +#include string.h labath wrote: ovyalov wrote: tberghammer wrote: I think you wanted to include string,

Re: [Lldb-commits] [PATCH] D12104: [NativeProcessLinux] Fix a bug in instruction-stepping over thread creation

tberghammer added inline comments. Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1049-1051 @@ -1047,5 +1048,5 @@ -NativeThreadProtocolSP new_thread_sp = GetThreadByID(tid); +NativeThreadLinuxSP new_thread_sp =

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

tberghammer updated this revision to Diff 32395. tberghammer added a comment. Fix incorrect assert http://reviews.llvm.org/D11947 Files: source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

Re: [Lldb-commits] [PATCH] D12025: Make LLDB URLs to support hex encoding for special symbols

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. I see your point. I am still not too happy with this approach but I don't have any better idea to solve it. I am fine with committing it in in this format and we can improve it

[Lldb-commits] [lldb] r244877 - Fix Linux build after r244875

Author: tberghammer Date: Thu Aug 13 04:19:27 2015 New Revision: 244877 URL: http://llvm.org/viewvc/llvm-project?rev=244877view=rev Log: Fix Linux build after r244875 Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp Modified:

Re: [Lldb-commits] [PATCH] D11899: Fix AArch64 watchpoint handlers in NativeRegisterContextLinux_arm64

tberghammer added a comment. Generally looks good to me. I am happy to push the 2 cleanup change to a separate CL but please check that the read/write flag calculation is correct. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:514-519 @@ -507,8

Re: [Lldb-commits] [PATCH] D11384: Improve check for ASAN callbacks

tberghammer added a comment. Friendly ping http://reviews.llvm.org/D11384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2   3   4   5   6