[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

thieta added a comment. In D151460#4372763 , @mib wrote: > Can you add this commit hash to the `.git-blame-ignore-revs` file so it > doesn't show up in the git history Yeah that should be done. But has to be done after arc land anyway. CHANGES SINCE

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

thieta accepted this revision. thieta added a comment. This revision is now accepted and ready to land. Thanks for doing this! Going to assume you ran the tests and it worked :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151460/new/ https://reviews.llvm.org/D151460

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

thieta added a comment. I think this is ready to land @Mordante or is there anything else missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

thieta accepted this revision as: thieta. thieta added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, JDevlieghere. I think this is fine as we have discussed before. But I really dislike the code duplication for the check. We could put it in a include() I

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:57 + +* GCC >= 7.1 +* Clang >= 5.0 xbolva00 wrote: > Do we have bots which uses last supported compiler versions? GCC 7.1, Clang > 5.0 and MSVC 16.7. > > It is bad to promise something and

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. Hi - I tried to incorporate all the feedback here and added a post to discourse suggesting tweaks to the developer policy - please have a look and review it: https://discourse.llvm.org/t/rfc-updates-to-developer-policy-around-c-standards-bump/64383 Repository: rG

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. I think a week or two of moratorium would be good for sure. I think we can table this discussion for now and I will write a RFC post in discourse when I have time and we can discuss the details there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3709742 , @aaron.ballman wrote: > One thing I think would be a definite improvement is to have done an RFC on > Discourse for these changes so that downstreams have a chance to weigh in on > the impact. The patch was

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) glandium wrote: > thieta wrote: > >

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) glandium wrote: > You didn't update

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706424 , @aaron.ballman wrote: > +1, thank you for thinking about how we can improve this process in the > future! Given that C++17 adoption across compilers has been far better than > C++20, I suspect the next time

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706336 , @aaron.ballman wrote: > That's the only reason this hasn't been reverted already. Landing sweeping > changes on a weekend is a good way to reduce the pain, but we really need to > be sure someone watches

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706263 , @aaron.ballman wrote: > > Something odd is going on here and we might want to consider a revert of this > patch until we resolve it. When I do a git pull and cmake files change, > Visual Studio's

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706199 , @cor3ntin wrote: > Trying to read the logs,, notably > `C:\PROGRA~2\MIB055~1\2019\PROFES~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\cl.exe > `, it would seem that this particular bot is running a version

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705579 , @Jake-Egan wrote: > There is a failure on the AIX bot also: > ... > https://lab.llvm.org/buildbot/#/builders/214/builds/2707/steps/5/logs/stdio Filed an issue here:

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705474 , @dyung wrote: > We are seeing an additional failure on an internal linux bot due to the > change to using C++17 by default when using GNU ld: > ... > Switching between BFD ld and gold still fails (although

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705236 , @royjacobson wrote: > This affects people on their work branches as well, and it's not obvious that > it's a configuration error and not a broken master. > > The CMake approach sounds cleaner to me, but I

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705131 , @royjacobson wrote: > This seems to have been more disruptive than expected, since an existing > CMakeCache.txt can make LLVM compile in previous C++14 configuration. This > seems to make some of the bots

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1356504e63a: [LLVM] Update C++ standard to 17 (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 450364. thieta added a comment. Fixed spelling error and added links to C++ standard libraries Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files:

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. All right! Last call - I am going fix the spelling error and merge this tomorrow EU time unless someone objects. Thanks for all reviews so far! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. @nikic @thakis I fixed this issue in https://reviews.llvm.org/D131063 and it can be built with CXX_STANDARD=17 and OSX_DEPLOYMENT_TARGET=10.11. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3690274 , @nikic wrote: > Given > https://github.com/llvm/llvm-project/blob/2bb7c54621f31a957302a4deb3d25b752acb07bd/llvm/include/llvm/Support/RWMutex.h#L22-L27, > it seems like this is supposed to be supported. This

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3689157 , @thakis wrote: > Is it expected and intentional that this increases the mac deployment target > to 10.12? I wasn't aware of that - but I think it's expected since the check in RWMutex checks for the C++

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3686723 , @h-vetinari wrote: > I don't think the standard library can be called a vendor-specific extension, > and so I think this still could/should be made clearer (even though the > status links below would show

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3686718 , @thieta wrote: > In D130689#3684399 , @h-vetinari > wrote: > >> It may be worth calling out that this is about C++17 core language and not >> the standard library?

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684399 , @h-vetinari wrote: > It may be worth calling out that this is about C++17 core language and not > the standard library? > > libstdcxx only finished C++17 support in GCC 12, and libcxx is still missing >

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3686397 , @thakis wrote: > It'd be nice if this was landed opt-in behind some cmake variable at first, > so that folks could try it out on their bots and see how well things work. You can already test this with

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 448262. thieta added a comment. Fixed unintended indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files: bolt/runtime/CMakeLists.txt

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684334 , @ChuanqiXu wrote: > So it is free that developers want to use some C++17 features in a small > amount of code, right? As soon as this land C++ 17 should be free to use everywhere yeah! Repository: rG

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684360 , @barannikov88 wrote: > There are a few places (primarily in ADT and Support) that check __cplusplus > > 201402. Do they need to be cleaned up? Sounds good - but maybe that can be addressed in a separate

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 448261. thieta added a comment. Address some old comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files: bolt/runtime/CMakeLists.txt clang/CMakeLists.txt

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684330 , @mehdi_amini wrote: > What does it mean exactly? We can't use **anything** C++17 without writing it > in the coding standards? > I'm not sure it'll be manageable: how do you see this playing out? Probably

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta created this revision. thieta added reviewers: mehdi_amini, jyknight, jhenderson, hans, tstellar, cor3ntin, MaskRay. Herald added subscribers: ayermolo, StephenFan, mgorny. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added a

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

thieta added a comment. FYI: I helped @PatriosTheGreat to commit this after he asked for help in discord. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

This revision was automatically updated to reflect the committed changes. Closed by commit rGa33983729df6: Pass plugin_name in SBProcess::SaveCore (authored by PatriosTheGreat, committed by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION