[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

2023-01-17 Thread Vassil Vassilev via Phabricator via lldb-commits
v.g.vassilev added a comment. In D131858#4058807 , @erichkeane wrote: > In D131858#4054348 , @v.g.vassilev > wrote: > >> In D131858#4052031 , @erichkeane >> wrote: >> >

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

2023-01-14 Thread Vassil Vassilev via Phabricator via lldb-commits
v.g.vassilev added a comment. In D131858#4052031 , @erichkeane wrote: > In D131858#4052026 , @v.g.vassilev > wrote: > >> Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and >> @erichkea

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

2023-01-13 Thread Vassil Vassilev via Phabricator via lldb-commits
v.g.vassilev added a comment. Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and @erichkeane for the efforts saving @mizvekov work over the summer. I believe he has sporadic access to internet and soon he will be back to normal. Great example of team work here!! Repo

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

2023-01-12 Thread Vassil Vassilev via Phabricator via lldb-commits
v.g.vassilev added a comment. In D131858#4047785 , @erichkeane wrote: > @mizvekov : I'm looking at the revert of this since no work seems to have > been done to fix @steven_wu 's problem. Unfortunately, it seems that > reverting this requires revertin

[Lldb-commits] [PATCH] D91524: Make iteration over the DeclContext::lookup_result safe.

2021-03-17 Thread Vassil Vassilev via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cb7e7ca0c86: Make iteration over the DeclContext::lookup_result safe. (authored by v.g.vassilev). Herald added projects: clang, LLDB. Herald added s

[Lldb-commits] [PATCH] D91524: Make iteration over the DeclContext::lookup_result safe.

2021-03-17 Thread Vassil Vassilev via Phabricator via lldb-commits
v.g.vassilev added a comment. Herald added a subscriber: JDevlieghere. argh... I only now see the pre-merge suggestions -- almost all of them seem not super essential -- let me know if I should address them in a subsequent commit... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

2019-11-28 Thread Vassil Vassilev via Phabricator via lldb-commits
v.g.vassilev added a comment. https://reviews.llvm.org/D41416 could be relevant. I am not an expert but I think when reading the DWARF you could only register 'lazy' specializations which will be imported only when really required. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69309/ne