[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. https://llvm-compile-time-tracker.com/compare.php?from=1a17739d3aa78599c32f6106e05dcfa7f3f9e823=9c1adc5fcca177d6628bdb22c72e7546c7b691aa=instructions:u looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. Do you intend to (optionnaly) provide XXH3 as described in https://github.com/Cyan4973/xxHash ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142862/new/ https://reviews.llvm.org/D142862

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. Can you take a shot against https://llvm-compile-time-tracker.com/ so that we get an hint of the practical speedup? Looks like xxhash.h is missing from the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

serge-sans-paille added a comment. LGTM Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:652 auto data = + llvm::MutableArrayRef(static_cast(buf), bytes_read); random nit: This could be rewritten as ``` llvm::MutableArrayRef

[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07bb29d8ffc3: [OptTable] Precompute OptTable prefixes union table through tablegen (authored by serge-sans-paille). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added a comment. In D140800#4043723 , @nikic wrote: > Just to check, this isn't going to cause some warning spew about all those > OptTable implementations being non-final? nope. Why

[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

serge-sans-paille updated this revision to Diff 488344. serge-sans-paille added a comment. Nits + rebase on main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140800/new/ https://reviews.llvm.org/D140800 Files: clang/lib/Driver/DriverOptions.cpp

[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

serge-sans-paille added a comment. @nikic : gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140800/new/ https://reviews.llvm.org/D140800 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D141298: Move from llvm::makeArrayRef to ArrayRef deduction guides - last part

serge-sans-paille added a comment. Herald added subscribers: Michael137, JDevlieghere. Once that patch lands, I'll mark `makeArrayRef` as deprecated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141298/new/ https://reviews.llvm.org/D141298

[Lldb-commits] [PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3677ee65d192: Move from llvm::makeArrayRef to ArrayRef deduction

[Lldb-commits] [PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

serge-sans-paille updated this revision to Diff 486172. serge-sans-paille added a comment. Split the original patch in pieces: first just introduce the deduction guide. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140896/new/ https://reviews.llvm.org/D140896 Files:

[Lldb-commits] [PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

serge-sans-paille updated this revision to Diff 486049. serge-sans-paille added a comment. + keep deprecated version, flagged appropriately CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140896/new/ https://reviews.llvm.org/D140896 Files: bolt/tools/bat-dump/bat-dump.cpp

[Lldb-commits] [PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

serge-sans-paille created this revision. Herald added subscribers: libc-commits, hanchung, kadircet, Moerafaat, kmitropoulou, zero9178, Enna1, bzcheeseman, kosarev, mattd, gchakrabarti, ThomasRaoux, pmatos, asb, ayermolo, awarzynski, arjunp, sdasgup3, asavonic, carlosgalvezp, Groverkss,

[Lldb-commits] [PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge-sans-paille updated this revision to Diff 485931. serge-sans-paille added a comment. (rebased on main. Note that this patch is applied on top of https://reviews.llvm.org/D140699) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140800/new/ https://reviews.llvm.org/D140800 Files:

[Lldb-commits] [PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge-sans-paille added a comment. In D140800#4021282 , @thakis wrote: > I'm guessing on non-empty files this is a negligible win even in clang. As showcased by

[Lldb-commits] [PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge-sans-paille updated this revision to Diff 485929. serge-sans-paille added a comment. Added to versions of OptTable, one that uses a precomputed Table, generated by TableGen, and one that relies on the old, generic approach. Both are tested using the same test bench. Updated benchmark:

[Lldb-commits] [PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge-sans-paille added a comment. In D140800#4021228 , @thakis wrote: > Could we make this an optional opt-in maybe? I imagine for the majority of > the tools, this has no measurable effect, but it currently makes the Opt > library harder to use for

[Lldb-commits] [PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge-sans-paille created this revision. serge-sans-paille added a reviewer: nikic. Herald added subscribers: pmatos, asb, jhenderson, ormris, mstorsjo, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: alexander-shaposhnikov.

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille marked 4 inline comments as done. serge-sans-paille added a comment. New version passes `ninja check` with clang, clang-tools-extra and lld. Comment at: clang/lib/StaticAnalyzer/Core/CallDescription.cpp:39

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille updated this revision to Diff 482825. serge-sans-paille added a comment. Make `Prefixes` an array of StringRef too CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139881/new/ https://reviews.llvm.org/D139881 Files: clang-tools-extra/clangd/CompileCommands.cpp

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:470 const char *const *Prefixes[DriverID::LastOption] = {nullptr}; -#define PREFIX(NAME, VALUE) static const char *const NAME[] = VALUE; +#define PREFIX(NAME, VALUE) static

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille created this revision. serge-sans-paille added a reviewer: nikic. Herald added subscribers: steakhal, pmatos, asb, jhenderson, abrachet, ormris, martong, phosek, kadircet, arphaman, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: JDevlieghere. Herald

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

serge-sans-paille added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath,

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

serge-sans-paille updated this revision to Diff 472945. serge-sans-paille added a comment. + Release Note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137337/new/ https://reviews.llvm.org/D137337 Files: bolt/CMakeLists.txt

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, tstellar, mgorny, sylvestre.ledru. Herald added subscribers: libc-commits, libcxx-commits, Moerafaat, zero9178, Enna1, bzcheeseman, kosarev, ayermolo, sdasgup3, wenzhicui, wrengr, cota, StephenFan, teijeong,

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

serge-sans-paille added a comment. The consensus in the discourse thread you mention is not super strong, but I tend to agree with that patch. +1 for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860

[Lldb-commits] [PATCH] D134877: [lldb] Get rid of __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS

This revision was automatically updated to reflect the committed changes. Closed by commit rG81fc5f7909a4: [lldb] Get rid of __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D134877: [lldb] Get rid of __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS

serge-sans-paille updated this revision to Diff 463999. serge-sans-paille retitled this revision from "[lldb] Fixes for swig-4.1.0 macro definition correction" to "[lldb] Get rid of __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS". serge-sans-paille edited the summary of this revision.

[Lldb-commits] [PATCH] D134877: [lldb] Fixes for swig-4.1.0 macro definition correction

serge-sans-paille added a comment. In D134877#3823855 , @labath wrote: > Looking at https://bugzilla.redhat.com/show_bug.cgi?id=2128646, I'd say that > the real bug is that we're defining this macro in two places. How about we > leave these definitions

[Lldb-commits] [PATCH] D134877: [lldb] Fixes for swig-4.1.0 macro definition correction

serge-sans-paille created this revision. serge-sans-paille added reviewers: clayborg, jingham. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For swig-4.1.0 change: #2193 -DFOO on the SWIG

[Lldb-commits] [PATCH] D129261: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

This revision was automatically updated to reflect the committed changes. Closed by commit rGb042d15d2e39: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test (authored by jchecahi, committed by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D129261: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

serge-sans-paille added a comment. I checked the test base and didn't find any similar test either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129261/new/ https://reviews.llvm.org/D129261 ___

[Lldb-commits] [PATCH] D129261: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

serge-sans-paille added a reviewer: JDevlieghere. serge-sans-paille added inline comments. Comment at: lldb/test/Shell/Expr/TestStringLiteralExpr.test:1 +# RUN: echo %t +# RUN: echo %s This line and the one below looks like debug code and should be removed

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rGf416e57339bd: [lldb] Fix ppc64 detection in lldb (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D124760?vs=427119=427225#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille reopened this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. @labath does that version look good? I only changed the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124760/new/ https://reviews.llvm.org/D124760

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille updated this revision to Diff 427119. serge-sans-paille added a comment. Change the rest case to something that doesn't require me to implement ppc64be corefile support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124760/new/ https://reviews.llvm.org/D124760

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille added a comment. In D124760#3488289 , @DavidSpickett wrote: > I reverted this due to an assert: > https://lab.llvm.org/buildbot/#/builders/96/builds/22715/steps/6/logs/stdio > (set cmake `LLVM_ENABLE_ASSERTIONS` to `ON`) > > I

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rGf114f0094868: [lldb] Fix ppc64 detection in lldb (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124760/new/

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille updated this revision to Diff 426620. serge-sans-paille added a comment. Fix nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124760/new/ https://reviews.llvm.org/D124760 Files: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, jasonmolenda, labath. Herald added subscribers: StephenFan, shchenz, kbarton, nemanjai, emaste. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: LLDB.

[Lldb-commits] [PATCH] D121168: Cleanup includes: LLVMTarget

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c4410dfcaaf: Cleanup includes: LLVMTarget (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121168/new/

[Lldb-commits] [PATCH] D121168: Cleanup includes: LLVMTarget

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, RKSimon, lenary. Herald added subscribers: kerbowa, Jim, atanasyan, jrtc27, hiraditya, nhaehnle, jvesely, sdardis, dylanmckay. Herald added a project: All. serge-sans-paille requested review of this revision.

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

serge-sans-paille added a comment. @thakis should be fixed by 57c6012213b50804ed78530b89bae30c0ee4fe82 , the new failure (seems) unrelated to this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb4c8608115c: Cleanup llvm/DebugInfo/PDB headers (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

serge-sans-paille added a comment. In D120195#943 , @MaskRay wrote: > It'd be good to test `-DLLVM_ENABLE_MODULES=on` build. Sure, I'll add that to my local test setup. > Some files get pure new headers. That's expected. It happens a lot when some

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

serge-sans-paille added a comment. In D120195#942 , @MaskRay wrote: > before: 1065515095 > after: 1065629059 > > An increase? Ooopsie, a typo :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, MaskRay, lenary. Herald added a subscriber: hiraditya. serge-sans-paille requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. accumulated

[Lldb-commits] [PATCH] D119723: Cleanup LLVMDWARFDebugInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG290e48234282: Cleanup LLVMDWARFDebugInfo (authored by serge-sans-paille). Changed prior to commit:

[Lldb-commits] [PATCH] D119723: Cleanup LLVMDWARFDebugInfo

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, MaskRay, mehdi_amini, lenary. Herald added subscribers: ayermolo, cmtice, rupprecht, arphaman, hiraditya. Herald added a reviewer: jhenderson. Herald added a reviewer: rafauler. Herald added a reviewer: Amir.

[Lldb-commits] [PATCH] D119092: Cleanup LLVMDebugInfoCodeView headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81cde474e2c5: Cleanup LLVMDebugInfoCodeView headers (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D119092: Cleanup LLVMDebugInfoCodeView headers

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, lenary, MaskRay, mehdi_amini. Herald added subscribers: arphaman, hiraditya. serge-sans-paille requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits,

[Lldb-commits] [PATCH] D104856: [NFC] Remove unreferenced function ResolveIPV4HostName

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7b1fa6f5ebe: [NFC] remove unreferenced function ResolveIPV4HostName (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D104856: [NFC] Remove unreferenced function ResolveIPV4HostName

serge-sans-paille added a comment. What a simpler patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104856/new/ https://reviews.llvm.org/D104856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D104856: [NFC] Remove unreferenced function ResolveIPV4HostName

serge-sans-paille updated this revision to Diff 354443. serge-sans-paille retitled this revision from "[lldb] replace gethostbyname call by getaddrinfo" to "[NFC] Remove unreferenced function ResolveIPV4HostName". serge-sans-paille edited the summary of this revision. serge-sans-paille added a

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

serge-sans-paille created this revision. serge-sans-paille requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. According to the manpage The gethostbyname*() and gethostbyaddr*() functions are obsolete. Applications should use

[Lldb-commits] [PATCH] D83857: Harmonize python shebang

This revision was automatically updated to reflect the committed changes. Closed by commit rG515bc8c1554f: Harmonize Python shebang (authored by serge-sans-paille). Herald added projects: clang, Sanitizers, LLDB, libc++, OpenMP, libc-project. Herald added subscribers: libc-commits,

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

serge-sans-paille added a comment. Possible followup: shouldn't all the other `Get*` be flagged as `const` too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83580/new/ https://reviews.llvm.org/D83580

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Looks obviously good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83580/new/ https://reviews.llvm.org/D83580

[Lldb-commits] [PATCH] D69846: [lldb] [Python] Build readline override module only on Linux

serge-sans-paille added a comment. Thanks for the fix o/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69846/new/ https://reviews.llvm.org/D69846 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

serge-sans-paille added a comment. In D69793#1733672 , @labath wrote: > > 1. use PyMem_RawMalloc instead of PyMem_Malloc, as expected by > > PyOS_Readline (prevents to segfault upon exit of interactive session) > > It looks like this is failing on

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

This revision was automatically updated to reflect the committed changes. Closed by commit rG9357b5d08497: Revert and patch [Python] Remove readline module (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D69793?vs=227823=227834#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

serge-sans-paille updated this revision to Diff 227821. serge-sans-paille marked 4 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69793/new/ https://reviews.llvm.org/D69793 Files:

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.h:13-15 +#ifndef LLDB_DISABLE_LIBEDIT +extern "C" PyMODINIT_FUNC initlldb_readline(void); +#endif

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

serge-sans-paille updated this revision to Diff 227695. serge-sans-paille edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69793/new/ https://reviews.llvm.org/D69793 Files:

[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

serge-sans-paille created this revision. serge-sans-paille added reviewers: labath, JDevlieghere. serge-sans-paille added a project: LLDB. Herald added subscribers: lldb-commits, mgorny. Fix https://bugs.llvm.org/show_bug.cgi?id=43830 while avoiding polluting the global Python namespace. This

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

serge-sans-paille added inline comments. Comment at: llvm/include/llvm/ADT/Optional.h:216 + OptionalStorage =(T const ) { +assert(Info::is_valid(y)); +value = y; Slight note (borrowed from [this

[Lldb-commits] [PATCH] D69230: RFC: specialized Optional for T that can represent its own invalid state

serge-sans-paille added a comment. (keeping the ball rolling) lYou want to exploit the presence of a sentinel in the domain of values of a given type. Maybe make that explicit through the method naming instead of using the `isValid` theme. Some bibliography on the subject:

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

serge-sans-paille added a comment. @davezarzycki I tend to agree with you. We can just remove 35:44 and just keep the hostname. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67230/new/ https://reviews.llvm.org/D67230

[Lldb-commits] [PATCH] D67230: Remove call to obsolete gethostbyname, using getaddrinfo

serge-sans-paille created this revision. serge-sans-paille added a reviewer: k8stone. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. >From the man page: > The gethostbyname*() and gethostbyaddr*() functions are obsolete. > Applications should use getaddrinfo(3) and

[Lldb-commits] [PATCH] D57830: Add functionality to trace a function within lldb

serge-sans-paille added a comment. LGTM with respect to Python 2/3 compat, can't tell for the functionality though. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57830/new/ https://reviews.llvm.org/D57830 ___

[Lldb-commits] [PATCH] D59591: Python 2/3 compat: unichr vs chr

serge-sans-paille closed this revision. serge-sans-paille added a comment. Closed by https://reviews.llvm.org/rL356904 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59591/new/ https://reviews.llvm.org/D59591 ___

[Lldb-commits] [PATCH] D59580: Use compatible print statements for Python2/3

serge-sans-paille added a comment. @davide : is that ok if I add you to a few other python compat related reviews? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59580/new/ https://reviews.llvm.org/D59580 ___

[Lldb-commits] [PATCH] D59580: Use compatible print statements for Python2/3

serge-sans-paille added a comment. validates fine on my side with py3 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59580/new/ https://reviews.llvm.org/D59580 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D59580: Use compatible print statements for Python2/3

serge-sans-paille added a comment. I didn't run the `check-lldb` target though, I'm doing that right now. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59580/new/ https://reviews.llvm.org/D59580 ___ lldb-commits

[Lldb-commits] [PATCH] D59580: Use compatible print statements for Python2/3

serge-sans-paille added a comment. @davide I first applied 2to3 systematically, then manually edited the diff so that it remains backward compatible with python2. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59580/new/ https://reviews.llvm.org/D59580

[Lldb-commits] [PATCH] D59591: Python 2/3 compat: unichr vs chr

serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D59591 Files: lldb/examples/summaries/cocoa/CFString.py Index:

[Lldb-commits] [PATCH] D59589: Python 2/3 compat: str vs basestring

serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added subscribers: lldb-commits, jdoerfert, arphaman. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D59589 Files: lldb/examples/summaries/cocoa/CFArray.py

[Lldb-commits] [PATCH] D59590: Python 2/3 compat: queue vs Queue

serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D59590 Files: lldb/utils/lui/lui.py lldb/utils/lui/sandbox.py

[Lldb-commits] [PATCH] D59588: Python 2/3 compat: iteritems vs items

serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D59588 Files: lldb/examples/python/pytracer.py Index:

[Lldb-commits] [PATCH] D59586: Python 2/3 compat: tkinter

serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D59586 Files: lldb/examples/python/lldbtk.py Index:

[Lldb-commits] [PATCH] D59587: Use explicit loop instead of map for Python 2/3 compat

serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. The output of map is not used, so using a list comprehension or an explicit call to list looks awkward. Repository:

[Lldb-commits] [PATCH] D59585: python 2/3 compat: int vs long

serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D59585 Files: lldb/examples/python/jump.py Index:

[Lldb-commits] [PATCH] D59584: python 2/3 compat: commands vs subprocess

serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D59584 Files: lldb/examples/python/delta.py

[Lldb-commits] [PATCH] D59582: Python 2/3 compat: StringIO

serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D59582 Files: lldb/examples/customization/bin-utils/binutils.py

[Lldb-commits] [PATCH] D59581: Python 2/3 compat: urllib

serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added subscribers: llvm-commits, lldb-commits, jdoerfert. Herald added projects: LLDB, LLVM. Repository: rLLDB LLDB https://reviews.llvm.org/D59581 Files: lld/utils/benchmark.py Index:

[Lldb-commits] [PATCH] D59583: python2/3 compat: exceptions

serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D59583 Files: lldb/examples/python/crashlog.py Index:

[Lldb-commits] [PATCH] D59579: Use list comprehension instead of map/filter to prepare Python2/3 compat

serge-sans-paille created this revision. serge-sans-paille added a reviewer: michaelplatings. Herald added subscribers: lldb-commits, jdoerfert. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D59579 Files: lldb/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

serge-sans-paille added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py:533 +self.assertEqual(2, len(modules)) +self.verify_module(modules[0], "/tmp/a", None) +

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

serge-sans-paille abandoned this revision. serge-sans-paille added a comment. @sgraenitz It's fixed! I'm dropping this patch then, thanks for investigating o/ Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58193/new/ https://reviews.llvm.org/D58193

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

serge-sans-paille added a comment. @sgraenitz : it's possible that r352382 fixes my issue. I'll double check that first! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58193/new/ https://reviews.llvm.org/D58193

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

serge-sans-paille added a comment. @sgraenitz I currently have this patch applied to LLVM 8rc1 source tree for fedora, because it wasn't working automagically otherwise. Reading the discussion, I don't think I missed some configuration stuff, or what did I miss when configuring the build of

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

serge-sans-paille created this revision. serge-sans-paille added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a reviewer: alexshap. Herald added a project: LLDB. When building lldb in standalone mode, the llvm-nm, llvm-objdump etc target are not available, so

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

serge-sans-paille added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:415 # Add zero-fill to the right/end (MSB side) of the value. -retval += "00" * (byte_size - len(retval) / 2) +retval