[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

2017-08-29 Thread vignesh balu via Phabricator via lldb-commits
vbalu updated this revision to Diff 113067. vbalu marked 2 inline comments as done. vbalu added a comment. done changes as ssuggested https://reviews.llvm.org/D32522 Files: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py Index: packages/Python/lldbsuite/

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

2017-08-28 Thread vignesh balu via Phabricator via lldb-commits
vbalu requested changes to this revision. vbalu added a comment. This revision now requires changes to proceed. if (::sysctl(mib, 4, pathname, &len, NULL, 0) == 0) "len" is not declared. Please change to "pathname_len". https://reviews.llvm.org/D32271 __

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

2017-05-28 Thread vignesh balu via Phabricator via lldb-commits
vbalu updated this revision to Diff 100579. vbalu added a comment. Modified as suggested. sorry for the delay, i caught up in other work. Please let me know if something goes wrong. https://reviews.llvm.org/D32522 Files: packages/Python/lldbsuite/test/functionalities/process_attach/TestProc

[Lldb-commits] [PATCH] D32732: "target variable" not showing all global variable if we print any global variable before execution starts

2017-05-16 Thread vignesh balu via Phabricator via lldb-commits
vbalu added a comment. In https://reviews.llvm.org/D32732#753348, @jingham wrote: > That looks like the right way to do it. What was your thinking behind > returning null rather than the partial list of variables already parsed if > can_create is false? That doesn't seem like what somebody wh

[Lldb-commits] [PATCH] D32732: "target variable" not showing all global variable if we print any global variable before execution starts

2017-05-12 Thread vignesh balu via Phabricator via lldb-commits
vbalu updated this revision to Diff 98762. vbalu added a comment. Modified as per suggested. I used the flag option "flagsParsedVariables" to monitor if global variable are completely parsed or not. Looks like it never used. For a compile unit global variable will be parsed only through the meth

[Lldb-commits] [PATCH] D32732: "target variable" not showing all global variable if we print any global variable before execution starts

2017-05-03 Thread vignesh balu via Phabricator via lldb-commits
vbalu added a comment. i am confused as I dont see it is similar way when i don't print global variable before strting inferior. For the c file "lldbsuite/test/functionalities/target_command/globals.c" i see "target variable" behaves differently as below. **Without printing global variable be

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

2017-05-03 Thread vignesh balu via Phabricator via lldb-commits
vbalu updated this revision to Diff 97575. vbalu marked an inline comment as done. vbalu added a comment. modified exe path computation Repository: rL LLVM https://reviews.llvm.org/D32522 Files: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py Index: p

[Lldb-commits] [PATCH] D32732: "target variable" not showing all global variable if we print any global variable before execution starts

2017-05-03 Thread vignesh balu via Phabricator via lldb-commits
vbalu updated this revision to Diff 97569. vbalu added a comment. Herald added a subscriber: srhines. Added the test case. Repository: rL LLVM https://reviews.llvm.org/D32732 Files: packages/Python/lldbsuite/test/functionalities/target_command/TestTargetCommand.py packages/Python/lldbsu

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

2017-05-02 Thread vignesh balu via Phabricator via lldb-commits
vbalu updated this revision to Diff 97550. vbalu added a comment. Corrected the code. Now this test will fail without https://reviews.llvm.org/D32271 patch. https://reviews.llvm.org/D32522 Files: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py Index: pa

[Lldb-commits] [PATCH] D32732: "target variable" not showing all global variable if we print any global variable before execution starts

2017-05-01 Thread vignesh balu via Phabricator via lldb-commits
vbalu created this revision. "target variable" at main not printing all the global variables if we have print ant global variable before starting execution. Instead it show only variables that we printed before starting execution. It wont work on three scenarios. case 1: (lldb) print my_global

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

2017-04-27 Thread vignesh balu via Phabricator via lldb-commits
vbalu updated this revision to Diff 96878. vbalu added a comment. Removed the changes from test frame work. https://reviews.llvm.org/D32522 Files: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py Index: packages/Python/lldbsuite/test/functionalities/proce

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

2017-04-26 Thread vignesh balu via Phabricator via lldb-commits
vbalu created this revision. Adding test case to test the scenario in https://reviews.llvm.org/D3 Repository: rL LLVM https://reviews.llvm.org/D32522 Files: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py packages/Python/lldbsuite/test/lldbtest.py In

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

2017-04-23 Thread vignesh balu via Phabricator via lldb-commits
vbalu accepted this revision. vbalu added a comment. This revision is now accepted and ready to land. Fine. This will work. Thanks for the update. https://reviews.llvm.org/D32271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists