Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

tfiala added a comment. Dawn, the output supported by the command shouldn't have been changed. I'll have a peek at what may have caused that to happen. All this change was trying to do was stop the need to call dosep and roll that behavior into dotest. Zachary, I'm in the process of add

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

dawn added a comment. I really liked that dosep.py -s and dotest.py would report the run of each test case: Collected 6 tests 1: test_double_type_from_block_with_dsym (TestFloatTypes.FloatTypesTestCase) Test that double-type variables are displayed correctly from a block. ... ok 2:

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

I guess the thing to do in that case would be to fix it. I know priorities and all, but I don't want to hold back progress supporting an external workflow. In any case, Todd says that the output shouldn't have changed, so it may still be that you can continue doing this (for now). But at some

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

dawn added a subscriber: lldb-commits. Users: tfiala (Author) http://reviews.llvm.org/rL246794 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

Please try: ./dotest.py --output-on-success -v --executable $INSTALLDIR/bin/lldb I think you'll find that is identical output to what used to be this: ./dosep.py -s --options "-v --executable $INSTALLDIR/bin/lldb" If you find differently, please let me know. I couldn't maintain the '-s'

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

Yeah I'm actually hoping that once we move over to a test event stream that can be formatted with a customizable formatter, we can pretty much start deprecating the other output streams aside from the pure test run stdout/stderr. On Fri, Sep 4, 2015 at 12:45 PM, Zachary Turner

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

I agree with Zachary that we shouldn't mess around with options piecemeal, but let Todd get done with this first round of fixes then go take a hatchet to the options that dotest has, hopefully removing all the ones that nobody needs and rationalizing the others. Jim > On Sep 4, 2015, at 1:31

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

tfiala added a comment. I'm glad that worked for you, Dawn! Users: tfiala (Author) dawn (Auditor) http://reviews.llvm.org/rL246794 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

> Now there is no equivelent to "dosep.py -s", and: >./dotest.py -v --executable $INSTALLDIR/bin/lldb All of dosep's args moved over to dotest. I think if you wanted dosep.py -s behavior, you only need to use --output-on-success (long form of what used to be -s in dosep I believe). The

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

On Fri, Sep 4, 2015 at 12:40 PM Todd Fiala wrote: > > Now there is no equivelent to "dosep.py -s", and: > >./dotest.py -v --executable $INSTALLDIR/bin/lldb > > All of dosep's args moved over to dotest. I think if you wanted dosep.py > -s behavior, you only need to use

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

On Fri, Sep 04, 2015 at 12:44:36PM -0700, Todd Fiala wrote: > Please try: > > ./dotest.py --output-on-success -v --executable $INSTALLDIR/bin/lldb Yes, this appears to work. With this, I'm now back up to my old totals :) lldb_failures=0 lldb_errors=0 lldb_passes=1146

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

On Fri, Sep 04, 2015 at 12:40:12PM -0700, Todd Fiala wrote: > > Now there is no equivelent to "dosep.py -s", and: > >./dotest.py -v --executable $INSTALLDIR/bin/lldb > > All of dosep's args moved over to dotest. I think if you wanted dosep.py > -s behavior, you only need to use

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

dawn accepted this commit. dawn added a comment. Apparently now you must use: ./dotest.py --output-on-success -v --executable $INSTALLDIR/bin/lldb to see the same detailed output as you used to see with: ./dosep.py -s --options "-v --executable $INSTALLDIR/bin/lldb" or: ./dotest.py -v

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

dawn added a subscriber: dawn. dawn raised a concern with this commit. dawn added a comment. I'm very unhappy with this change. Before I could count up all the test failures using: ./dotest.py -v --executable $INSTALLDIR/bin/lldb 2>&1 | tee $INSTALLDIR/lldb_test_out.log || true

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

To be honest I think grepping the output is the wrong way to go about counting the tests. If there's a regression in that you no longer have access to a piece of information that you need, then we should fix it by printing the value you need. Log scraping is kind of a horrible thing to do,