[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

MaskRay added a comment. The remaining failures are on Linux x86-64 in a `-DLLVM_USE_SANITIZER=Leaks` build (`Address` should achieve the same effect because on many targets asan enables LeakSanitizer) Failed Tests (45): lldb-shell :: Reproducer/Functionalities/TestDataFormatter.test

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2cd6d07691a: [lldb] Fix demangler leaks in the DWARF AST parser (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

JDevlieghere added a comment. In D100800#271 , @teemperor wrote: > LGTM. I still kinda like the unique_ptr deleter but let's not block bot-fixes > with refactoring requests. I'll open a review for the unique_ptr as a follow > up. > > In

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1249 attrs.is_inline); +free(buf); MaskRay wrote: > teemperor wrote: > > `std::free` ? > `std::` for C library functions is uncommon. >

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. I still kinda like the unique_ptr deleter but let's not block bot-fixes with refactoring requests. I'll open a review for the unique_ptr as a follow up. In D100800#2699984

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

MaskRay added a comment. In D100800#2699940 , @teemperor wrote: > Thanks for fixing this, I guess we really need a leak sanitizer/valgrind bot > for LLDB... > > I just have some minor comments but otherwise this LGTM. Agree.. The 45+ `check-lldb`

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

MaskRay added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1229 if (!function_decl) { +char *buf = nullptr; llvm::StringRef name = attrs.name.GetStringRef(); teemperor wrote: > `name_buf` ?

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

MaskRay updated this revision to Diff 338664. MaskRay marked an inline comment as done. MaskRay added a comment. buf -> name_buf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100800/new/ https://reviews.llvm.org/D100800 Files:

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

teemperor added a comment. Thanks for fixing this, I guess we really need a leak sanitizer/valgrind bot for LLDB... I just have some minor comments but otherwise this LGTM. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1229 if

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

MaskRay created this revision. MaskRay added reviewers: labath, rupprecht. Herald added a reviewer: shafik. MaskRay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes 6 check-lldb-shell failures in a `-DLLVM_USE_SANITIZER=Leaks`