[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1435f6b00be7: [lldb] Move and clean-up the Declaration class (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

teemperor accepted this revision. teemperor added a comment. In D101556#2727603 , @mib wrote: > In D101556#2726434 , @teemperor > wrote: > >> IIRC they were #ifdef's out because of memory concerns. Did you have

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

mib updated this revision to Diff 341758. mib marked 2 inline comments as done. mib added a comment. Addressed @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101556/new/ https://reviews.llvm.org/D101556 Files:

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/include/lldb/Core/Declaration.h:161 + /// \b false otherwise. + bool operator!() const { return !operator bool(); } +

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

mib updated this revision to Diff 341727. mib added a comment. Addressed @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101556/new/ https://reviews.llvm.org/D101556 Files: lldb/include/lldb/Core/Declaration.h

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

mib added a comment. In D101556#2726434 , @teemperor wrote: > IIRC they were #ifdef's out because of memory concerns. Did you have a chance > to benchmark this quickly (e.g., trying to attach to a debug Clang and see > how much it increases memory) > >

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/Declaration.h:129 + + bool IsValid() const { +return m_file && (m_line != 0 || m_line != LLDB_INVALID_LINE_NUMBER); Let's also add an operator bool that just calls `IsValid()` under the

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

teemperor added a comment. IIRC they were #ifdef's out because of memory concerns. Did you have a chance to benchmark this quickly (e.g., trying to attach to a debug Clang and see how much it increases memory) Otherwise this LGTM. FWIW, we also need this for the SourceLocation in Clang Decls

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

mib created this revision. mib added reviewers: teemperor, JDevlieghere. mib added a project: LLDB. Herald added a subscriber: mgorny. Herald added a reviewer: shafik. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch moves the `Declaration` class from the