[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

brucem added a comment. It failed because on macOS, the underlying args contains argv0 while on Linux it does not. So my test that checked that `GetNumArguments` is 1 fails on macOS, since there are 2. Ideally, each platform would agree on whether or not the argv0 was included in the args ...

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

teemperor added a comment. In D103675#2800653 , @brucem wrote: > Not sure why this failed. Is it perhaps a difference where some processes > have args including the executable and some do not? Do you have the bot failures around for that? (Or, the

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

brucem reopened this revision. brucem added a comment. This revision is now accepted and ready to land. Not sure why this failed. Is it perhaps a difference where some processes have args including the executable and some do not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. brucem marked an inline comment as done. Closed by commit rG8d33437d030a: [LLDB/API] Expose args and env from SBProcessInfo. (authored by brucem). Repository: rG

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

brucem marked an inline comment as done. brucem added inline comments. Comment at: lldb/bindings/interface/SBProcessInfo.i:78 + +%feature("docstring", +"Return the specified argument given to the described process." teemperor wrote: > Can you add this

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

brucem updated this revision to Diff 349895. brucem added a comment. Rebase and address feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103675/new/ https://reviews.llvm.org/D103675 Files: lldb/bindings/interface/SBProcessInfo.i

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

teemperor added inline comments. Comment at: lldb/bindings/interface/SBProcessInfo.i:78 + +%feature("docstring", +"Return the specified argument given to the described process." Can you add this line here? ``` %feature("autodoc", "GetArgumentAtIndex(int

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

mib accepted this revision as: mib. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103675/new/ https://reviews.llvm.org/D103675

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

brucem created this revision. brucem requested review of this revision. Herald added a project: LLDB. This is another step towards implementing the equivalent of `platform process list` and related functionality. `uint32_t` is used for the argument count and index despite the underlying value