[Lldb-commits] [PATCH] D104091: [NFC][lldb] Fix leak in test

2021-06-11 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added inline comments. Comment at: lldb/unittests/Host/HostInfoTest.cpp:64 + +TEST(HostInfoTest2, InitTwice) { + llvm::VersionTuple Version; `HostInfoTestInitialization` maybe? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D104091: [NFC][lldb] Fix leak in test

2021-06-11 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think we should instead implement the `Terminate` function that the plugin system provides to tear down our state. I made a patch in D104093