[Lldb-commits] [PATCH] D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct

2021-06-11 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG632cbcac7906: [lldb] Move once_flags in HostInfoLinux so the internal state struct (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct

2021-06-11 Thread Vitaly Buka via Phabricator via lldb-commits
vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. I see comment on the D104091 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104093/new/ https://reviews.llvm.org/D104093

[Lldb-commits] [PATCH] D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct

2021-06-11 Thread Vitaly Buka via Phabricator via lldb-commits
vitalybuka added inline comments. Comment at: lldb/source/Host/linux/HostInfoLinux.cpp:41 g_fields = new HostInfoLinuxFields(); } this still does not solve memory leak if HostInfoLinux::Initialize called twice CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct

2021-06-11 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added reviewers: vitalybuka, LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. The HostInfoLinuxFields struct is supposed to be set up/torn down on Initialize/Terminate and