[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

2021-06-29 Thread Med Ismail Bennani via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe1874dd2dd9: [lldb/Interpreter] Add setting to set session transcript save directory (authored by mib). Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

2021-06-28 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. In D105030#2844708 , @vsk wrote: > I love the save-session feature. Just checking, has it already been > release-noted on llvm.org (and for that matter Xcode)? Glad you like it @vsk ! I don't think it was on the release note (at lea

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

2021-06-28 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 354950. mib marked 3 inline comments as done. mib added a comment. Rephrase setting description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105030/new/ https://reviews.llvm.org/D105030 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

2021-06-28 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added a comment. I love the save-session feature. Just checking, has it already been release-noted on llvm.org (and for that matter Xcode)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105030/new/ https://reviews.llvm.org/D105030 ___

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

2021-06-28 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Interpreter/InterpreterProperties.td:18 +DefaultStringValue<"">, +Desc<"A path where LLDB will save the session's transcripts

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

2021-06-28 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 354916. mib added a comment. Address @JDevlieghere comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105030/new/ https://reviews.llvm.org/D105030 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h l

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

2021-06-28 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added inline comments. Comment at: lldb/source/Interpreter/InterpreterProperties.td:18 +DefaultStringValue<"">, +Desc<"A path where LLDB will save the session's transcripts.">; def StopCmdSourceOnError: Property<"stop-command-source-on-error", "Boolean">,

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

2021-06-28 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/InterpreterProperties.td:18 +DefaultStringValue<"">, +Desc<"A path where LLDB will save the session's transcripts.">; def StopCmdSourceOnError: Property<"stop-command-source-on-error", "Boolean">,

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

2021-06-28 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added reviewers: teemperor, JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new interpreter setting `interpreter.save-session-directory` so the user can specify a directo