This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5ea091a8174b: [lldb][AArch64] Add memory tag writing to lldb
(authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
DavidSpickett updated this revision to Diff 358977.
DavidSpickett added a comment.
Rebase, update use of SendPacketAndWaitForResponse.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105181/new/
https://reviews.llvm.org/D105181
Files:
lldb/include
DavidSpickett updated this revision to Diff 358541.
DavidSpickett added a comment.
Rebase onto the earlier refactoring patch.
Now GetMemoryTagManager just deals with the manager,
no range handling. So this patch just adds WriteMemoryTags.
"memory tag write" will use MakeTaggedRange from
the memo
DavidSpickett added inline comments.
Comment at: lldb/source/Target/Process.cpp:6108
+range_callback) {
Architecture *arch = GetTarget().GetArchitecturePlugin();
const MemoryTagManager *tag_manager =
DavidSpickett wrote:
> omjavaid wrote:
> > The po
DavidSpickett added inline comments.
Comment at: lldb/source/Target/Process.cpp:6108
+range_callback) {
Architecture *arch = GetTarget().GetArchitecturePlugin();
const MemoryTagManager *tag_manager =
omjavaid wrote:
> The point I was trying to estab
omjavaid added inline comments.
Comment at: lldb/include/lldb/Target/MemoryTagManager.h:35
+ // alignment/expansion over again.
+ struct TagManagerWithRange {
+const MemoryTagManager *manager;
DavidSpickett wrote:
> omjavaid wrote:
> > I was wondering if yo
DavidSpickett added inline comments.
Comment at: lldb/include/lldb/Target/MemoryTagManager.h:35
+ // alignment/expansion over again.
+ struct TagManagerWithRange {
+const MemoryTagManager *manager;
omjavaid wrote:
> I was wondering if you can explain reason
omjavaid added inline comments.
Comment at: lldb/include/lldb/Target/MemoryTagManager.h:35
+ // alignment/expansion over again.
+ struct TagManagerWithRange {
+const MemoryTagManager *manager;
I was wondering if you can explain reason for hosting this struc
DavidSpickett created this revision.
Herald added subscribers: danielkiss, kristof.beyls.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This adds memory tag writing to Process and the
GDB remote code. Supporting work for the
