This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8e6b31c3952b: [LLDB] Move Trace-specific classes into
separate library (authored by bulbazord).
Changed prior to commit:
https://reviews.llvm.org/
bulbazord updated this revision to Diff 360542.
bulbazord added a comment.
Updating
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105649/new/
https://reviews.llvm.org/D105649
Files:
lldb/include/lldb/Target/ThreadPostMortemTrace.h
lldb/include
clayborg accepted this revision.
clayborg added a comment.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105649/new/
https://reviews.llvm.org/D105649
___
lldb-commits mailing list
lldb-commits@list
wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: JDevlieghere.
this looks good to me. Let's wait for Greg's opinion as well
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.
bulbazord created this revision.
bulbazord added reviewers: wallace, clayborg.
Herald added a subscriber: mgorny.
bulbazord requested review of this revision.
Herald added a project: LLDB.
These two classes, TraceSessionFileParser and ThreadPostMortemTrace,
seem to be useful primarily for tracing.