[Lldb-commits] [PATCH] D108257: Add type to the output for FieldDecl when logging in ClangASTSource::layoutRecordType

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a4a498a884a: [LLDB] Add type to the output for FieldDecl when logging in ClangASTSource… (authored by shafik). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D108257: Add type to the output for FieldDecl when logging in ClangASTSource::layoutRecordType

shafik updated this revision to Diff 368935. shafik added a comment. Applying formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108257/new/ https://reviews.llvm.org/D108257 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp Index:

[Lldb-commits] [PATCH] D108257: Add type to the output for FieldDecl when logging in ClangASTSource::layoutRecordType

shafik added a comment. In D108257#2950994 , @aprantl wrote: > If getType() doesn't trigger type completion then this LGTM! AFAICT the call to `getType` end up in `ValueDecl`: QualType getType() const { return DeclType; } and this is just returning

[Lldb-commits] [PATCH] D108257: Add type to the output for FieldDecl when logging in ClangASTSource::layoutRecordType

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. If getType() doesn't trigger type completion then this LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108257/new/ https://reviews.llvm.org/D108257

[Lldb-commits] [PATCH] D108257: Add type to the output for FieldDecl when logging in ClangASTSource::layoutRecordType

shafik created this revision. shafik added reviewers: teemperor, aprantl. shafik requested review of this revision. I was debugging a problem and noticed that it would have been helpful to have the type of each `FieldDecl` when looking at the output from `ClangASTSource::layoutRecordType`