This revision was automatically updated to reflect the committed changes.
Closed by commit rGf659bf00b4c0: [lldb] [test] Add synchronization fix
Subprocess test flakiness (authored by mgorny).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
cool, thanks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109495/new/
https://reviews.llvm.org/D109495
___
lldb-commits mailing list
mgorny added a comment.
With this version, I haven't been able to reproduce a test failure in 350
iterations, so I guess it's good now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109495/new/
https://reviews.llvm.org/D109495
___
mgorny updated this revision to Diff 371571.
mgorny added a comment.
Force sync earlier for `fork()` and `clone()` (since we don't have to wait for
exec there). Avoid depending on ordering between child output and LLDB exit.
Stress-testing it now.
CHANGES SINCE LAST ACTION
mgorny updated this revision to Diff 371554.
mgorny added a comment.
Remove unnecessary `child_done` pipe, as pointed out by @labath.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109495/new/
https://reviews.llvm.org/D109495
Files:
lldb/test/Shell/Subprocess/Inputs/fork.cpp
mgorny created this revision.
mgorny added reviewers: labath, emaste, krytarowski.
mgorny requested review of this revision.
Add synchronization routines to ensure that Subprocess tests output
in a predictable order, and all test strings are output before the tests
terminate.
