[Lldb-commits] [PATCH] D109785: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings

2021-09-16 Thread Alex Langford via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa65f6aafe2d3: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings (authored by bulbazord). Changed prior to commit:

[Lldb-commits] [PATCH] D109785: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings

2021-09-15 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h:130 - // Given a mangled function name, calculates some alternative manglings since - // the compiler mangling may not line up with the symbol we are expecting - static

[Lldb-commits] [PATCH] D109785: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings

2021-09-15 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h:130 - // Given a mangled function name, calculates some alternative manglings since - //

[Lldb-commits] [PATCH] D109785: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings

2021-09-14 Thread Alex Langford via Phabricator via lldb-commits
bulbazord created this revision. bulbazord added reviewers: clayborg, teemperor, jingham, JDevlieghere, labath. bulbazord requested review of this revision. Herald added a project: LLDB. I have 2 goals with this change: 1. Disambiguate between CPlusPlus::FindAlternateFunctionManglings and