[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

2021-09-21 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. In D110013#3013733 , @aprantl wrote: > Without having dug into this deeper, do you think not specifying the arch > could cause any problems with universal binaries? I guess not, because we > still have the UUID, and the

[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

2021-09-21 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added a comment. In D110013#3013733 , @aprantl wrote: > Without having dug into this deeper, do you think not specifying the arch > could cause any problems with universal binaries? I guess not, because we > still have the UUID, and the UUID is per

[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

2021-09-21 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. Without having dug into this deeper, do you think not specifying the arch could cause any problems with universal binaries? I guess not, because we still have the UUID, and the UUID is per arch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

2021-09-20 Thread Vedant Kumar via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe31b2d7d7be9: [lldb][crashlog] Avoid specifying arch for image when a UUID is present (authored by vsk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

2021-09-18 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yeah, on macOS we'll always have a UUID so this is a good change. The only time an arch is really important is if we don't have a UUID and we have a universal binary (aka fat

[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

2021-09-17 Thread Vedant Kumar via Phabricator via lldb-commits
vsk created this revision. vsk added reviewers: jasonmolenda, jingham, JDevlieghere. Herald added subscribers: pengfei, kristof.beyls. vsk requested review of this revision. Herald added a project: LLDB. When adding an image to a target for crashlog purposes, avoid specifying the architecture of