[Lldb-commits] [PATCH] D112325: [lldb] Pass the target triple to the compiler when determining the DWARF version

2021-10-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f12cf7ebaaf: [lldb] Pass the target triple when determining the DWARF version (authored by JDevlieghere). Herald added a project: LLDB. Changed

[Lldb-commits] [PATCH] D112325: [lldb] Pass the target triple to the compiler when determining the DWARF version

2021-10-22 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added a comment. Thanks! Lgtm as well, but with the same nits as Raphael. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112325/new/ https://reviews.llvm.org/D112325 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D112325: [lldb] Pass the target triple to the compiler when determining the DWARF version

2021-10-22 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Some nits but otherwise LGTM Comment at: lldb/packages/Python/lldbsuite/test/builders/builder.py:26 +"""Returns the triple for the given architecture or an

[Lldb-commits] [PATCH] D112325: [lldb] Pass the target triple to the compiler when determining the DWARF version

2021-10-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, vsk. JDevlieghere requested review of this revision. When targeting iOS, the default dwarf version is 2 and not 4. Currently, the test suite does not pick up on that because it invokes the test compiler without